Author: compnerd
Date: Tue May 3 23:22:29 2016
New Revision: 268477
URL: http://llvm.org/viewvc/llvm-project?rev=268477&view=rev
Log:
libc++abi: fix visibility of personalities
The personality routines need to be exposed to the users as the functions
reference the personality routine to handle e
ahatanak added reviewers: manmanren, doug.gregor, rjmccall.
ahatanak updated this revision to Diff 56092.
ahatanak added a comment.
Rebase and add reviewers.
http://reviews.llvm.org/D18815
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaObjCXX/block-cleanup.mm
Index: test/SemaObjCXX/block-cleanup
ahatanak updated this revision to Diff 56090.
ahatanak added a comment.
Apply John's patch with a few modifications.
I had to special case __block variables and remove the line creating a load
from a reference to fix the failing regression tests.
http://reviews.llvm.org/D19536
Files:
lib/Co
etienneb added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1578
@@ +1577,3 @@
+/// \endcode
+AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) {
+ return Node.getLength() == N;
aaron.ballman wrote:
> Perhaps we can adjust the `hasSize()
Author: rnk
Date: Tue May 3 21:58:24 2016
New Revision: 268473
URL: http://llvm.org/viewvc/llvm-project?rev=268473&view=rev
Log:
[X86] Add -malign-double support
The -malign-double flag causes i64 and f64 types to have alignment 8
instead of 4. On x86-64, the behavior of -malign-double is enable
Author: benlangmuir
Date: Tue May 3 19:53:13 2016
New Revision: 268471
URL: http://llvm.org/viewvc/llvm-project?rev=268471&view=rev
Log:
Fix CodeCompletion & TypoCorrection when combining a PCH with Modules
This commit fixes the IdentifierIterator to actually include identifiers
from a PCH or pr
probinson updated this revision to Diff 56079.
probinson marked an inline comment as done.
probinson added a comment.
Correct the attribute condition, and refine the Objective-C test.
http://reviews.llvm.org/D19754
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Cod
probinson marked 2 inline comments as done.
Comment at: include/clang/Basic/Attr.td:86-88
@@ -85,1 +85,5 @@
+def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam &&
+ S->getKind() != Decl::ParmVar &&
+ S->ge
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268461: [clang-tidy] MoveConstructorInitCheck - Add
parameter name to check message. (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D19849?vs=55975&id=56076#toc
Repository:
rL LL
Author: flx
Date: Tue May 3 18:07:44 2016
New Revision: 268461
URL: http://llvm.org/viewvc/llvm-project?rev=268461&view=rev
Log:
[clang-tidy] MoveConstructorInitCheck - Add parameter name to check message.
Reviewers: alexfh
Subscribers: aaron.ballman, cfe-commits
Differential Revision: http://
Author: dblaikie
Date: Tue May 3 18:06:40 2016
New Revision: 268460
URL: http://llvm.org/viewvc/llvm-project?rev=268460&view=rev
Log:
[modules][debuginfo] Only include imported modules when targeting LLDB
These constructs are only applicable to a debugger capable of loading a
Clang AST, so omit
Author: ericwf
Date: Tue May 3 17:50:33 2016
New Revision: 268459
URL: http://llvm.org/viewvc/llvm-project?rev=268459&view=rev
Log:
Update version numbers in docs
Modified:
libcxx/trunk/docs/conf.py
Modified: libcxx/trunk/docs/conf.py
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/d
Author: ericwf
Date: Tue May 3 17:32:08 2016
New Revision: 268456
URL: http://llvm.org/viewvc/llvm-project?rev=268456&view=rev
Log:
Add documentation for new experimental library
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
libcxx/trunk/docs/UsingLibcxx.rst
Modified: libcxx/trunk/docs
koriakin created this revision.
koriakin added reviewers: uweigand, rjmccall.
koriakin added a subscriber: cfe-commits.
koriakin set the repository for this revision to rL LLVM.
koriakin added a dependency: D19889: [SystemZ] Implement backchain attribute..
This option, like the corresponding gcc o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268453: [scan-build] fix dead store warnings emitted on
clang code base (authored by dblaikie).
Changed prior to commit:
http://reviews.llvm.org/D19831?vs=56059&id=56071#toc
Repository:
rL LLVM
http
Author: dblaikie
Date: Tue May 3 17:14:14 2016
New Revision: 268453
URL: http://llvm.org/viewvc/llvm-project?rev=268453&view=rev
Log:
[scan-build] fix dead store warnings emitted on clang code base
This fixes dead store warnings of the type "dead assignment" reported
by CLang Static Analyzer on
Author: ericwf
Date: Tue May 3 16:58:07 2016
New Revision: 268451
URL: http://llvm.org/viewvc/llvm-project?rev=268451&view=rev
Log:
Make check-libcxx dependant on libc++experimental if present.
Modified:
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/trunk/test/CMakeLists.txt
URL:
http:
apelete added a comment.
In http://reviews.llvm.org/D19831#420410, @dblaikie wrote:
> Thanks - do you need someone (me) to commit this, or do you have commit
> access?
I would appreciate if you could commit this for me since I don't have commit
access.
Thanks.
http://reviews.llvm.org/D19831
Author: ericwf
Date: Tue May 3 16:30:18 2016
New Revision: 268443
URL: http://llvm.org/viewvc/llvm-project?rev=268443&view=rev
Log:
Create new library 'libc++experimental.a' for packaging TS symbols.
Summary:
Out-of-line symbols for headers are not ABI or API stable
and cannot live in the 'lib
EricWF added a comment.
In http://reviews.llvm.org/D19856#420366, @mclow.lists wrote:
> Q: Should the .a file get installed into /lib when you do a make install?
>
> That will make it easier to link against.
For now the install rule is off by default.
`-DLIBCXX_INSTALL_EXPERIMENTAL_LIBRARY=ON
On Tue, May 3, 2016 at 12:51 PM, Dmitry Polukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> DmitryPolukhin added a comment.
>
> Richard, could you please share your counterexample so I could test it on
> my patch and GCC?
>
Sure:
struct __attribute__((abi_tag("X"))) Foo {};
void
Thanks - do you need someone (me) to commit this, or do you have commit
access?
On Tue, May 3, 2016 at 1:32 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete updated this revision to Diff 56059.
> apelete added a comment.
>
> [scan-build] fix dead store warnings
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
Please do add tests before committing. Otherwise ok.
Thanks.
-eric
Comment at: lib/Basic/Targets.cpp:1239
@@ -1227,1 +1238,3 @@
+ if (defs & ArchDefinePwr9)
+Builder.defineMacr
apelete updated this revision to Diff 56059.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- Move 'Record' and 'Parent' variables into if() {} scope where they are
actually used.
http://reviews.llvm.org/D19831
Files:
t
rjmccall added a comment.
In http://reviews.llvm.org/D19678#420358, @hfinkel wrote:
> In http://reviews.llvm.org/D19678#419445, @rjmccall wrote:
>
> > This discussion of the command line interface makes me think that we should
> > be taking Richard's suggestion one step further. Why is Clang's
Author: dlkreitz
Date: Tue May 3 15:20:59 2016
New Revision: 268432
URL: http://llvm.org/viewvc/llvm-project?rev=268432&view=rev
Log:
Add address space 258 (X86 SS segment) to clang documentation.
The change reflects llvm r268431.
Patch by Michael Lemay (michael.le...@intel.com)
Differential Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268432: Add address space 258 (X86 SS segment) to clang
documentation. (authored by dlkreitz).
Changed prior to commit:
http://reviews.llvm.org/D19458?vs=54877&id=56056#toc
Repository:
rL LLVM
http:
mclow.lists added a comment.
Q: Should the .a file get installed into /lib when you do a make install?
That will make it easier to link against.
http://reviews.llvm.org/D19856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268430: [clang-tidy] Speedup misc-static-assert. (authored
by sbenza).
Changed prior to commit:
http://reviews.llvm.org/D19877?vs=56028&id=56053#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1987
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
I like this approach. LGTM.
http://reviews.llvm.org/D19856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: sbenza
Date: Tue May 3 15:11:09 2016
New Revision: 268430
URL: http://llvm.org/viewvc/llvm-project?rev=268430&view=rev
Log:
[clang-tidy] Speedup misc-static-assert.
Summary:
Speedup the misc-static-assert check by not use `stmt()` as the toplevel
matcher.
The framework runs a filter on
hfinkel added a comment.
In http://reviews.llvm.org/D19678#419445, @rjmccall wrote:
> This discussion of the command line interface makes me think that we should
> be taking Richard's suggestion one step further. Why is Clang's involvement
> here more than just handing down specific requests f
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
This revision is now accepted and ready to land.
Comment at: tools/c-index-test/c-index-test.c:1435-1436
@@ -1434,3 +1434,4 @@
/* recurse to get the first parent record that is not anonymous. */
-CXCurs
DmitryPolukhin added a comment.
Richard, could you please share your counterexample so I could test it on my
patch and GCC?
As for separate pass, it was my first reaction on the original patch from
Stefan but soon I realized that I'll have to copy parts of magnler to some
simplified mangler bu
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
Split these onto two lines?
Comment at: include/clang/AST
Author: tnorthover
Date: Tue May 3 14:24:47 2016
New Revision: 268423
URL: http://llvm.org/viewvc/llvm-project?rev=268423&view=rev
Log:
AArch64: fixup comment after change
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vie
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.h:34-35
@@ -33,3 +33,4 @@
IncludeFixerActionFactory(
- XrefsDB &Xrefs, std::vector &Replacements,
+ XrefsDBManager &XrefsDBMgr,
+ std::vector &Replacements,
bool MinimizeIncludePaths = tr
Author: tnorthover
Date: Tue May 3 14:22:41 2016
New Revision: 268422
URL: http://llvm.org/viewvc/llvm-project?rev=268422&view=rev
Log:
AArch64: simplify illegal vector check. NFC.
Use a utility function to check whether the number of elements is a power of 2
and drop the redundant upper limit (
klimek added inline comments.
Comment at: include-fixer/IncludeFixer.h:34-35
@@ -33,3 +33,4 @@
IncludeFixerActionFactory(
- XrefsDB &Xrefs, std::vector &Replacements,
+ XrefsDBManager &XrefsDBMgr,
+ std::vector &Replacements,
bool MinimizeIncludePaths = tr
apelete added a comment.
In http://reviews.llvm.org/D19831#420115, @dblaikie wrote:
> Looks good to me - go ahead & commit whenever you're ready.
If this last revision is good for you, please go ahead and commit this for me
(I don't have commit access).
Thanks.
http://reviews.llvm.org/D1983
apelete updated this revision to Diff 56042.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- Initialize 'CXCursor Parent' variable to avoid passing 'Record' variable as
an un-initialized argument thereafter.
http://review
apelete added inline comments.
Comment at: tools/c-index-test/c-index-test.c:1440
@@ -1440,3 +1439,3 @@
Record = Parent;
Parent = clang_getCursorSemanticParent(Record);
RecordIsAnonymous = clang_Cursor_isAnonymous(Record);
This line now
hans abandoned this revision.
hans added a comment.
In http://reviews.llvm.org/D19881#420250, @thakis wrote:
> So ninja knows how to filter out the source line that cl.exe prints
> unconditionally, without a way to disable that. If you add a bare newline,
> ninja won't filter that out and this
Author: rnk
Date: Tue May 3 13:48:50 2016
New Revision: 268419
URL: http://llvm.org/viewvc/llvm-project?rev=268419&view=rev
Log:
Fix use of LLVM IR names in lit test
Modified:
cfe/trunk/test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp
Modified: cfe/trunk/test/CodeGenCXX/microsoft-abi-v
thakis added a comment.
In http://reviews.llvm.org/D19881#420245, @hans wrote:
> In http://reviews.llvm.org/D19881#420244, @thakis wrote:
>
> > I agree with Brad that it'd be nice if we didn't have to add this :-)
> >
> > What's the workaround for current cmake releases?
>
>
> Passing -DCMAKE_CL_
thakis added a comment.
(Also, this "only" affects .rc compilations, not regular source compilations --
those don't go through cmcldeps)
http://reviews.llvm.org/D19881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: rnk
Date: Tue May 3 13:44:29 2016
New Revision: 268418
URL: http://llvm.org/viewvc/llvm-project?rev=268418&view=rev
Log:
[MS] Pass CalleeDecl to adjustThisArgumentForVirtualFunctionCall
If we are devirtualizing, then we want to compute the 'this' adjustment
of the devirtualized target, n
hans added a comment.
In http://reviews.llvm.org/D19881#420244, @thakis wrote:
> I agree with Brad that it'd be nice if we didn't have to add this :-)
>
> What's the workaround for current cmake releases?
Passing -DCMAKE_CL_SHOWINCLUDES_PREFIX="Note: including file: " is the
work-around I used
thakis added a comment.
I agree with Brad that it'd be nice if we didn't have to add this :-)
What's the workaround for current cmake releases?
http://reviews.llvm.org/D19881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Hi Michael
I was seeing issues with the CHECK lines referencing explicit value numbers.
i.e., %1, %2, etc.
In r268416 I changed these to use a regex. I hope this was ok. Please let me
know if you have an alternative you would prefer.
Thanks,
Pete
> On May 3, 2016, at 7:12 AM, Michael Zucker
Author: pete
Date: Tue May 3 13:32:01 2016
New Revision: 268416
URL: http://llvm.org/viewvc/llvm-project?rev=268416&view=rev
Log:
Change test to use regex instead of explicit value numbers. NFC.
We were seeing an internal failure when running this test. I can't
see a good reason for the differ
brad.king added a comment.
I do not think MSVC starts off with an empty line with -showIncludes
specifically. It is just that MSVC unconditionally prints the name of the
source file first. This means that any showIncludes output is naturally
preceded by a newline because at least one other li
hans added inline comments.
Comment at: lib/Frontend/HeaderIncludeGen.cpp:106
@@ +105,3 @@
+// it to be there.
+*OutputFile << '\n';
+ }
thakis wrote:
> Doesn't do that for me:
>
> C:\src\ninja>cl /c test.cc /nologo /showIncludes
> test.cc
> Note: includ
thakis added inline comments.
Comment at: lib/Frontend/HeaderIncludeGen.cpp:106
@@ +105,3 @@
+// it to be there.
+*OutputFile << '\n';
+ }
Doesn't do that for me:
C:\src\ninja>cl /c test.cc /nologo /showIncludes
test.cc
Note: including file: c:\src\ninja
hans created this revision.
hans added reviewers: thakis, brad.king.
hans added a subscriber: cfe-commits.
MSVC prints a blank line there, and it turns out CMake (at least currently
released versions) expects it to be there.
http://reviews.llvm.org/D19881
Files:
lib/Frontend/HeaderIncludeGen.
aaron.ballman added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
@@ +101,3 @@
+ static clang::CastKind getCastKind(llvm::StringRef AttrKind) {
+return llvm::StringSwitch(AttrKind)
+ .Case("CK_Dependent", CK_Dependent)
This might
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Speedup the misc-static-assert check by not use `stmt()` as the toplevel
matcher.
The framework runs a filter on the matchers before trying them on each node and
uses the toplevel type for this.
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for noticing that!
http://reviews.llvm.org/D19877
_
sbenza added a comment.
> > So even if the above solution is working, we still need to call it that way
> > (as a string):
>
> > clang-query> match castExpr(hasCastKind("CK_Dependent"))
>
>
> Correct, that's expected behavior for clang-query (though I would love if
> someday we could
ioeric added inline comments.
Comment at: include-fixer/InMemoryXrefsDB.cpp:24-26
@@ +23,5 @@
+for (const auto &Header : Entry.second) {
+ SymbolInfo Info;
+ Info.Name = Names.back();
+ Info.FilePath = Header;
+ for (auto IdentiferContext = Names.rbegin() +
ioeric updated this revision to Diff 56026.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addressed reviewer comment.
http://reviews.llvm.org/D19869
Files:
include-fixer/CMakeLists.txt
include-fixer/InMemoryXrefsDB.cpp
include-fixer/InMemoryXrefsDB.h
include-fixer/I
etienneb updated this revision to Diff 56025.
etienneb added a comment.
fix doc
http://reviews.llvm.org/D19876
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittest
etienneb created this revision.
etienneb added reviewers: alexfh, sbenza, aaron.ballman, klimek.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This patch is adding support for a matcher to check string literal length.
This matcher is used in clang-tidy checkers and
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D19684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Looks good to me - go ahead & commit whenever you're ready.
On Mon, May 2, 2016 at 11:40 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete updated this revision to Diff 55952.
> apelete added a comment.
>
> [scan-build] fix dead store warnings emitted on clang co
etienneb updated this revision to Diff 56023.
etienneb added a comment.
nit
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/
etienneb updated this revision to Diff 56022.
etienneb added a comment.
add dynamic parsing
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unitte
etienneb added a comment.
> though I would love if someday we could expose actual enumerations somehow
> instead of string literals
I would like too. Ditto for "equals" which is missing :)
http://reviews.llvm.org/D19871
___
cfe-commits mailing li
aaron.ballman added a comment.
In http://reviews.llvm.org/D19871#420095, @etienneb wrote:
> > I agree that when possible, matchers should be available via the dynamic
> > matchers API. It doesn't seem overly complicated to add this support here.
> > As far as I understand, we just need to regis
etienneb added a comment.
> I agree that when possible, matchers should be available via the dynamic
> matchers API. It doesn't seem overly complicated to add this support here. As
> far as I understand, we just need to register the matcher in
> lib/ASTMatchers/Dynamic/Registry.cpp and add su
Author: cbieneman
Date: Tue May 3 11:54:20 2016
New Revision: 268401
URL: http://llvm.org/viewvc/llvm-project?rev=268401&view=rev
Log:
[CMake] Fix a copy-paste error
Based on post commit feedback from Eric Fiselier.
Modified:
libcxx/trunk/include/CMakeLists.txt
Modified: libcxx/trunk/inclu
2016-04-26 0:55 GMT+06:00 Richard Smith :
> rsmith added inline comments.
>
>
> Comment at: lib/Sema/SemaDecl.cpp:8611-8612
> @@ -8609,3 +8610,4 @@
> } else {
> - // This needs to happen first so that 'inline' propagates.
> - NewFD->setPreviousDeclaration(cast(OldDe
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:173-182
@@ -165,1 +172,12 @@
+void FindAllSymbols::addPragmaHeader(FileID ID, llvm::StringRef FilePath) {
+ PragmaHeaderMap[ID] = FilePath;
+}
+
+llvm::Optional FindAllSymbols::getPragma
sepavloff updated this revision to Diff 56015.
sepavloff added a comment.
Updated patch.
http://reviews.llvm.org/D16989
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
test/SemaCXX/PR25848.cpp
test/SemaCXX/friend2.cpp
Index: test/SemaCXX/friend2.cpp
=
Hello,
the attached patch introduces the `convergent` attribute.
It is meant to be lowered into the LLVM `convergent` attribute, to restrict
optimizations of attributed functions — e.g. you can attach convergent to
OpenCL’s barrier, and thus prevent a call site being moved to another position
courbet added inline comments.
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+ const ArrayRef overridden_methods(
+ const CXXMethodDecl *Method) const;
aaron.ballman
zaks.anna added a comment.
Thanks for fixing!
Devin, what do you think about the BugType wording?
Comment at:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:229
@@ -228,3 +228,3 @@
BT_stackleak.reset(
-new BuiltinBug(this, "Stack address s
aaron.ballman added inline comments.
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+ const ArrayRef overridden_methods(
+ const CXXMethodDecl *Method) const;
courbet
courbet added inline comments.
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+ const ArrayRef overridden_methods(
+ const CXXMethodDecl *Method) const;
aaron.ballman
alexfh added a comment.
In http://reviews.llvm.org/D19871#419947, @aaron.ballman wrote:
> Is this required for some purpose?
>
> I'm not keen on adding new AST matchers that we cannot expose via the dynamic
> API, so I would prefer to solve that problem if we want to add this matcher.
I agree
rnk added a comment.
I think Richard has a counterexample that shows that the "NullOut" approach to
computing abi_tag sets isn't the right way to go. I wasn't able to craft it
myself, but I figured I should send along the feedback that maybe a separate,
up-front pass over the return type with a
etienneb added a comment.
> It's good to have that context in a review for functionality that isn't part
> of the proposed patch. :-) Looking at the other patch, I would prefer to keep
> this matcher narrowed to just clang-tidy unless you can also solve how to
> expose it via the dynamic regist
twoh added a comment.
Ping. Can someone please commit this patch for me? Thanks!
http://reviews.llvm.org/D19062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza added a comment.
In http://reviews.llvm.org/D19871#419985, @aaron.ballman wrote:
> In http://reviews.llvm.org/D19871#419954, @etienneb wrote:
>
> > In http://reviews.llvm.org/D19871#419947, @aaron.ballman wrote:
> >
> > > Is this required for some purpose?
> >
> >
> > It's used in clang-ti
aaron.ballman added inline comments.
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+ const ArrayRef overridden_methods(
+ const CXXMethodDecl *Method) const;
This is
klimek added inline comments.
Comment at: include-fixer/InMemoryXrefsDB.cpp:18
@@ +17,3 @@
+InMemoryXrefsDB::InMemoryXrefsDB(
+std::map> LookupTable) {
+ for (const auto &Entry : LookupTable) {
I'd make that a const ref.
Comment at: include-
aaron.ballman added a comment.
In http://reviews.llvm.org/D19871#419954, @etienneb wrote:
> In http://reviews.llvm.org/D19871#419947, @aaron.ballman wrote:
>
> > Is this required for some purpose?
>
>
> It's used in clang-tidy checkers.
>
> see http://reviews.llvm.org/D19841
It's good to have
courbet updated this revision to Diff 56006.
courbet marked an inline comment as done.
courbet added a comment.
implement overridden_methods_begin()/end() in terms of overridden_methods().
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
courbet added inline comments.
Comment at: clang-tidy/google/GoogleTidyModule.cpp:40
@@ -38,1 +39,3 @@
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
+CheckFactories.registerCheck(
+"google-default-arguments");
hokein wro
etienneb added a comment.
In http://reviews.llvm.org/D19871#419947, @aaron.ballman wrote:
> Is this required for some purpose?
It's used in clang-tidy checkers.
see http://reviews.llvm.org/D19841
> I'm not keen on adding new AST matchers that we cannot expose via the dynamic
> API, so
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
Is this required for some purpose?
I'm not keen on adding new AST matchers that we cannot expose via the dynamic
API, so I would prefer to solve that problem if we want
courbet updated this revision to Diff 56000.
courbet marked 4 inline comments as done.
courbet added a comment.
Cosmetics + change error message.
http://reviews.llvm.org/D19534
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/DefaultArgumentsCheck.cpp
clang-tidy/google/DefaultArg
etienneb created this revision.
etienneb added reviewers: alexfh, sbenza, klimek.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This AST matcher will match a given CastExpr kind.
It's an narrowing matcher on CastExpr.
http://reviews.llvm.org/D19871
Files:
include
mcrosier added a comment.
In http://reviews.llvm.org/D19827#419870, @mamai wrote:
> I think the blog comment is right. The pragma should make the loop unroll
> even in /Os. I think it is essential to allow the user to optimize some
> specific loops even if he generally wants to optimize for siz
flx added a comment.
In http://reviews.llvm.org/D19865#419830, @alexfh wrote:
> Is it a workaround to avoid breaking the code by incorrect fixes?
Yes. We can't simply change the type of DeclStmt when we only look one of the
VarDecls and how it is initialized.
Repository:
rL LLVM
http://re
curdeius added a subscriber: curdeius.
curdeius added a comment.
I'm really interested in the manner this check works when a typedef has
multiple declarations in it (same example as in the comment):
typedef int m_int, *m_int_p, &m_int_r, m_int_arr[10], (&m_int_fun)(int, int);
I tried to imple
Author: mzuckerm
Date: Tue May 3 09:26:52 2016
New Revision: 268387
URL: http://llvm.org/viewvc/llvm-project?rev=268387&view=rev
Log:
[clang][AVX512][BuiltIn] Adding intrinsics for cast{pd|ps|si}128_{pd|ps|si}512
and castsi256_si512 instruction set
Differential Revision: http://reviews.llvm.org
yaxunl added a comment.
Hi Alexey,
Any comments on this patch?
Thanks.
http://reviews.llvm.org/D19484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mzuckerm
Date: Tue May 3 09:12:23 2016
New Revision: 268385
URL: http://llvm.org/viewvc/llvm-project?rev=268385&view=rev
Log:
[Clang][avx512][Builtin] Adding intrinsics for cvtw2mask{128|256|512}
instruction set
Differential Revision: http://reviews.llvm.org/D19766
Modified:
cfe/tr
mamai added a subscriber: tyler.nowicki.
mamai added a comment.
I think the blog comment is right. The pragma should make the loop unroll even
in /Os. I think it is essential to allow the user to optimize some specific
loops even if he generally wants to optimize for size the rest of the code. I
1 - 100 of 134 matches
Mail list logo
