ABataev accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+assert(
+(!D || D->isCanonicalDecl()) &&
sfantao wrote:
> Ok, using canonical decl
djasper added inline comments.
Comment at: cfe/trunk/lib/Format/AffectedRangeManager.h:59
@@ +58,3 @@
+ const AnnotatedLine *PreviousLine);
+ SourceManager &SourceMgr;
+ const SmallVector Ranges;
And an empty line between functions and da
pxli168 accepted this revision.
pxli168 added a comment.
LGTM.
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hopefully fixed by r267513.
On Mon, Apr 25, 2016 at 6:46 PM, Kostya Serebryany wrote:
> +rnk
>
> On Mon, Apr 25, 2016 at 5:09 PM, Jacques Pienaar via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: jpienaar
>> Date: Mon Apr 25 19:09:29 2016
>> New Revision: 267496
>>
>> URL: http
Author: kcc
Date: Mon Apr 25 20:53:49 2016
New Revision: 267513
URL: http://llvm.org/viewvc/llvm-project?rev=267513&view=rev
Log:
trying to fix the windows build broken by r267496
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.
+rnk
On Mon, Apr 25, 2016 at 5:09 PM, Jacques Pienaar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jpienaar
> Date: Mon Apr 25 19:09:29 2016
> New Revision: 267496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=267496&view=rev
> Log:
> [lanai] Update handling of structs in arg
Author: compnerd
Date: Mon Apr 25 20:11:29 2016
New Revision: 267509
URL: http://llvm.org/viewvc/llvm-project?rev=267509&view=rev
Log:
unwind: remove last instance of -Wexpansion-to-defined
This unifies the definition of _LIBUNWIND_BUILD_SJLJ_APIS. It also further
generalises the definition to a
dyung updated this revision to Diff 54956.
dyung added a comment.
Updated diff to fix up the comments based on Paul's feedback. Also tightened up
one of the #if blocks to not include something that did not require C11.
http://reviews.llvm.org/D19003
Files:
include/clang/Frontend/CompilerInvo
Author: chapuni
Date: Mon Apr 25 19:45:00 2016
New Revision: 267503
URL: http://llvm.org/viewvc/llvm-project?rev=267503&view=rev
Log:
CGOpenMPRuntime.h: Prune '\param IfCond' in r267395. [-Wdocumentation]
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
Modified: cfe/trunk/lib/CodeGen/CGOpe
My bad :)
Attempt to fix committed as r267501.
On Mon, Apr 25, 2016 at 5:31 PM, Nico Weber wrote:
> Looks like this broke
> http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/13793/steps/docs-clang-html/logs/stdio
>
>
> /home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/
Author: gbiv
Date: Mon Apr 25 19:31:29 2016
New Revision: 267501
URL: http://llvm.org/viewvc/llvm-project?rev=267501&view=rev
Log:
[Docs] Fix indentation error introduced by r267447.
Modified:
cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.r
On Mon, Apr 25, 2016 at 1:52 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Mon Apr 25 15:52:40 2016
> New Revision: 267464
>
> URL: http://llvm.org/viewvc/llvm-project?rev=267464&view=rev
> Log:
> Module Debugging: Fix the condition for determining
Looks like this broke
http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/13793/steps/docs-clang-html/logs/stdio
/home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UndefinedBehaviorSanitizer.rst:96:
WARNING: Bullet list ends without a blank line; unexpected unindent.
Author: jpienaar
Date: Mon Apr 25 19:09:29 2016
New Revision: 267496
URL: http://llvm.org/viewvc/llvm-project?rev=267496&view=rev
Log:
[lanai] Update handling of structs in arguments to be passed in registers.
Previously aggregate types were passed byval, change the ABI to pass these in
register
sfantao marked an inline comment as done.
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+assert(
+(!D || D->isCanonicalDecl()) &&
Ok, using canonical declarations now.
http://reviews.llvm.org/D19382
sfantao updated this revision to Diff 54941.
sfantao added a comment.
- Use canonical declarations associated with mappable expressions.
http://reviews.llvm.org/D19382
Files:
include/clang/AST/OpenMPClause.h
lib/AST/OpenMPClause.cpp
lib/Sema/SemaOpenMP.cpp
lib/Serialization/ASTReaderStm
thakis closed this revision.
thakis added a comment.
Landed the new flag and its tests in r267474, thanks! (Didn't land the test
updates needed after http://reviews.llvm.org/D19417 yet, since that's not in
yet.)
http://reviews.llvm.org/D19425
___
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
The checker was noisy when running over llvm code base.
This patch is impriving the way string-compare functions are matched.
1) By default, do not report !strcmp(...) unless it's activate
Author: nico
Date: Mon Apr 25 16:15:49 2016
New Revision: 267474
URL: http://llvm.org/viewvc/llvm-project?rev=267474&view=rev
Log:
driver: Add a `--rsp-quoting` flag to pick response file quoting.
Currently, clang-cl always uses Windows style for unquoting, and clang always
uses POSIX style for u
Author: adrian
Date: Mon Apr 25 15:52:40 2016
New Revision: 267464
URL: http://llvm.org/viewvc/llvm-project?rev=267464&view=rev
Log:
Module Debugging: Fix the condition for determining whether a template
instantiation is in a module.
This patch fixes the condition for determining whether the debu
mlemay-intel updated this revision to Diff 54877.
mlemay-intel added a comment.
Update heading.
http://reviews.llvm.org/D19458
Files:
docs/LanguageExtensions.rst
Index: docs/LanguageExtensions.rst
===
--- docs/LanguageExtensions
On Mon, Apr 25, 2016 at 1:04 PM, Reid Kleckner wrote:
> On Fri, Apr 22, 2016 at 1:58 PM, Richard Smith
> wrote:
>>
>> This seems like a fragile thing to rely on. What about template
>> instantiation performed at end of TU? (I /think/ that case is currently
>> fine because all the kinds of templa
majnemer accepted this revision.
majnemer added a comment.
LGTM
http://reviews.llvm.org/D19459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Apr 22, 2016 at 1:58 PM, Richard Smith
wrote:
>
> This seems like a fragile thing to rely on. What about template
> instantiation performed at end of TU? (I /think/ that case is currently
> fine because all the kinds of template we instantiate ultimately do result
> in a call to HandleTopL
rnk added inline comments.
Comment at: tools/driver/driver.cpp:350
@@ +349,3 @@
+ for (const char *F : argv) {
+if (strcmp(F, "--rsp-quoting=posix") == 0)
+ RSPQuoting = POSIX;
thakis wrote:
> rnk wrote:
> > Should we call it "posix" or "gnu"? The refere
rsmith closed this revision.
rsmith added a comment.
Committed as r267454.
http://reviews.llvm.org/D17451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Mon Apr 25 14:30:37 2016
New Revision: 267454
URL: http://llvm.org/viewvc/llvm-project?rev=267454&view=rev
Log:
Implement support for conditional between xvalues of reference-compatible
types. Patch by Erik Pilkington!
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
cfe/
Author: rsmith
Date: Mon Apr 25 14:28:08 2016
New Revision: 267453
URL: http://llvm.org/viewvc/llvm-project?rev=267453&view=rev
Log:
Refactor traversal of bases in deduction of template parameters from base
classes of an argument to use CXXRecordDecl::forallBases. Fix forallBases to
only visit eac
rsmith closed this revision.
rsmith added a comment.
Committed as r267444.
I refactored it to use `CXXRecordDecl::forallBases` instead of a hand-rolled
traversal of the base classes in r267453.
http://reviews.llvm.org/D18868
___
cfe-commits mailin
etienneb added a comment.
thx Reid. added the appropriate reviewer.
http://reviews.llvm.org/D19459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gbiv
Date: Mon Apr 25 14:21:45 2016
New Revision: 267447
URL: http://llvm.org/viewvc/llvm-project?rev=267447&view=rev
Log:
[Docs] Clarify what the object-size sanitizer does.
Currently, the UBSan docs make it sound like the object-size sanitizer
will only detect out-of-bounds reads/writes
yaxunl marked 12 inline comments as done.
yaxunl added a comment.
Changed file name to opencl-c.h and updated comments.
Addressed Anastasia's early comments.
I am thinking we may need several more patches to address remaining issues to
keep the changes manageable.
Comment at:
Anastasia added a comment.
LGTM, just wondering other languages will compile to SPIR too?
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
Thanks!
Comment at: tools/driver/driver.cpp:350
@@ +349,3 @@
+ for (const char *F : argv) {
+if (strcmp(F, "--rsp-quoting=posix") == 0)
+ RSPQuoting = POSIX;
rnk wrote:
> Should we call it "posix" or "gnu"? The reference impleme
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
This test doesn't fail without your fix.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:155
@@ -155,1 +154,3 @@
+.bind("Initializer")),
+
Author: rsmith
Date: Mon Apr 25 14:09:05 2016
New Revision: 267444
URL: http://llvm.org/viewvc/llvm-project?rev=267444&view=rev
Log:
When deducing template parameters from base classes of an argument type, don't
preserve any deduced types from a failed deduction to a subsequent attempt at
deductio
EricWF abandoned this revision.
EricWF added a comment.
I've been working on this a bunch and will repost it with the new changes later
next week.
http://reviews.llvm.org/D11397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:8611-8612
@@ -8609,3 +8610,4 @@
} else {
- // This needs to happen first so that 'inline' propagates.
- NewFD->setPreviousDeclaration(cast(OldDecl));
+ if (NewFD->isOutOfLine() &&
+ NewFD-
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good
Comment at: tools/driver/driver.cpp:350
@@ +349,3 @@
+ for (const char *F : argv) {
+if (strcmp(F, "--rsp-quoting=posix") == 0)
+ RSPQuoting = POSIX;
--
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5768
@@ +5767,3 @@
+def ext_ms_downcast_from_inaccessible_base : ExtWarn<
+ "cast %select{private|protected}2 base class
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
FYI David Majnemer is a good reviewer for InstCombine.
http://reviews.llvm.org/D19459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
2016-04-21 2:57 GMT+06:00 Richard Smith :
> rsmith added a comment.
>
> Sorry, I don't think this approach can work. Consider:
>
> template struct X {
> template friend void f(T);
> template friend void f(U);
> };
>
> These two friend declarations declare different friend function temp
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Yeah, this LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D19443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: mzuckerm
Date: Mon Apr 25 11:42:29 2016
New Revision: 267425
URL: http://llvm.org/viewvc/llvm-project?rev=267425&view=rev
Log:
[Clang][Builtin][AVX512]Adding k-register logic intrinsics KAND, KANDN, KOR,
KORTEST, KXNOR, KXOR, KUNPACK instruction set.
Differential Revision: http://reviews
rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.
We definitely should not rely on typo correction or other error recovery
mechanisms to do this for us. Otherwise we can end up accepting ill-formed
programs like this one:
struct MyStru
chh marked 2 inline comments as done.
chh added a comment.
I used "svn mv" to move the file and "svn diff --show-copies-as-adds" to
generate the diff.
If I didn't use "--show-copies-as-adds", the new file was not included/shown by
phabricator at all.
Please let me know if there is better way to
hokein added inline comments.
Comment at: test/clang-tidy/modernize-make-shared.cpp:81
@@ +80,3 @@
+
+ std::shared_ptr R(new int());
+
Prazek wrote:
> hokein wrote:
> > Why can't this case convert to `std::shared_ptr R =
> > std::make_shared(new int())`?
> You
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader.
yaxunl added subscribers: cfe-commits, pxli168, tstellarAMD.
Add supported OpenCL extensions to target info. It serves as default values to
save the users of the burden setting each supported extensions and optional
core fea
hokein added a comment.
@michael_miller
You fixing is not completed. The crash still happens, the test case see
https://llvm.org/bugs/show_bug.cgi?id=27419.
Could you please take a look on it? Thanks very much.
Repository:
rL LLVM
http://reviews.llvm.org/D19270
_
mlemay-intel added a comment.
In http://reviews.llvm.org/D19458#410042, @mkuper wrote:
> LGTM with a small nit - can you change the heading from "Memory references
> off the GS segment" to something more general?
Good idea! Thanks for noticing that inconsistency.
http://reviews.llvm.org/D194
ioeric added a comment.
@Daniel, sorry that I forgot to have you look at the final version before
submitting it...
Repository:
rL LLVM
http://reviews.llvm.org/D18551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ioeric updated this revision to Diff 54855.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Addressed comments.
http://reviews.llvm.org/D18551
Files:
include/clang/Format/Format.h
lib/Format/AffectedRangeManager.cpp
lib/Format/AffectedRangeManager.h
lib/Format/CMakeLi
@Daniel, sorry that I forgot to have you look at the final version before
submitting it...
On Mon, Apr 25, 2016 at 5:15 PM Eric Liu wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL267416: Added Fixer implementation and fix() interface
> in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267416: Added Fixer implementation and fix() interface in
clang-format for removing… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D18551?vs=54855&id=54857#toc
Repository:
rL
Author: ioeric
Date: Mon Apr 25 10:09:22 2016
New Revision: 267416
URL: http://llvm.org/viewvc/llvm-project?rev=267416&view=rev
Log:
Added Fixer implementation and fix() interface in clang-format for removing
redundant code.
Summary:
After applying replacements, redundant code like extra commas
Author: dergachev
Date: Mon Apr 25 09:44:25 2016
New Revision: 267413
URL: http://llvm.org/viewvc/llvm-project?rev=267413&view=rev
Log:
[analyzer] Let TK_PreserveContents span across the whole base region.
If an address of a field is passed through a const pointer,
the whole structure's base regi
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
We'll probably want Daniel to also take another look over it, as it's a pretty
substantial change that will haunt us for a while, but I think this now pretty
m
Author: mzuckerm
Date: Mon Apr 25 09:48:23 2016
New Revision: 267414
URL: http://llvm.org/viewvc/llvm-project?rev=267414&view=rev
Log:
[Clang][Builtin][AVX512]Adding intrinsics for vfpclass{sd|ss} vfpclass{pd|ps}
instruction set
Differential Revision: http://reviews.llvm.org/D19476
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267413: [analyzer] Let TK_PreserveContents span across the
whole base region. (authored by dergachev).
Changed prior to commit:
http://reviews.llvm.org/D19057?vs=53551&id=54852#toc
Repository:
rL LLV
alexfh added a comment.
A few nits.
Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:90
@@ +89,3 @@
+ // It's OK to fold an int into:
+ // - an int of the same size and signedness.
+ // - a bigger int, regardless of signedness.
No, I don't have a better na
I can't access the cpp file- tried cloning the respository - but got
an error - perhaps you can email it to me as a text file?
Faisal Vali
On Mon, Apr 25, 2016 at 8:29 AM, Gonzalo BG wrote:
> Dear Richard Smith and Faisal Vali,
>
> this patch broke my code. I've filled a bug report here:
> http
ioeric updated this revision to Diff 54848.
ioeric added a comment.
- Merged VirtualEnvironment into Environment.
http://reviews.llvm.org/D18551
Files:
include/clang/Format/Format.h
lib/Format/AffectedRangeManager.cpp
lib/Format/AffectedRangeManager.h
lib/Format/CMakeLists.txt
lib/For
yaxunl added a comment.
LGTM
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
Thanks for catching this.
http://reviews.llvm.org/D19460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Dear Richard Smith and Faisal Vali,
this patch broke my code. I've filled a bug report here:
https://llvm.org/bugs/show_bug.cgi?id=27507
I tried to reduce the testcase with delta but over the weekend it only
managed to reduce it from 500k LOC to 300k LOC, sorry for that.
If there is anything I c
Author: mzuckerm
Date: Mon Apr 25 08:01:40 2016
New Revision: 267398
URL: http://llvm.org/viewvc/llvm-project?rev=267398&view=rev
Log:
[Clang][AVX512][BUILTIN] Adding intrinsics for VSCATTERPF{1|0}{DPS|QPS|DPD|QPD}
instruction set
Differential Revision: http://reviews.llvm.org/D19313
Modified:
Prazek added a subscriber: Prazek.
Comment at: docs/clang-tidy/checks/misc-fold-init-type.rst:16-17
@@ +15,4 @@
+
+.. code:: c++
+ auto a = {0.5f, 0.5f, 0.5f, 0.5f};
+ return std::accumulate(std::begin(a), std::end(a), 0);
Doesn't .. code node need new line?
h
Author: abataev
Date: Mon Apr 25 07:22:29 2016
New Revision: 267395
URL: http://llvm.org/viewvc/llvm-project?rev=267395&view=rev
Log:
[OPENMP 4.5] Codegen for 'taskloop' directive.
The taskloop construct specifies that the iterations of one or more associated
loops will be executed in parallel u
ioeric updated this revision to Diff 54837.
ioeric added a comment.
- Refactored - added Environment class.
http://reviews.llvm.org/D18551
Files:
include/clang/Format/Format.h
lib/Format/AffectedRangeManager.cpp
lib/Format/AffectedRangeManager.h
lib/Format/CMakeLists.txt
lib/Format/Fo
ABataev added inline comments.
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+if (Cache.count(D))
+ continue;
I think you'd better to count and to store canonical decls rather than the
decls themselves. It will r
courbet updated this revision to Diff 54833.
courbet marked 3 inline comments as done.
courbet added a comment.
Refactoring matchers & cosmetics.
http://reviews.llvm.org/D18442
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/FoldInitTypeCheck.cpp
clang-tidy/misc/FoldInitTypeCheck.h
courbet added inline comments.
Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:89
@@ +88,3 @@
+
+/// Returns true if ValueType is allowed to fold into InitType, i.e. if:
+/// static_cast(ValueType{some_value})
alexfh wrote:
> Is "fold" a commonly used term in
avt77 created this revision.
avt77 added a reviewer: rnk.
avt77 added a subscriber: cfe-commits.
This is the first patch to fix clang-cl incompatibility prohibited to compile
the header file. The patch covers the following case:
class CCommandBarCtrlBase {
public:
typedef int CMsgHookMap;
};
vmiklos added a comment.
Hi,
Can I help anything to get this reviewed, please?
Thanks,
Miklos
http://reviews.llvm.org/D18957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet updated this revision to Diff 54830.
courbet marked an inline comment as done.
courbet added a comment.
overridden_methods return ArrayRef instead of TinyPtrVector*
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang
sheredom created this revision.
sheredom added reviewers: Anastasia, yaxunl, pxli168.
sheredom added a subscriber: cfe-commits.
Remove an assert mandating that OpenCL must be used with the SPIR target. We
need to be able to use the SPIR target with non-OpenCL inputs, which worked
perfectly well
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rnk.
DmitryPolukhin added a subscriber: cfe-commits.
MSVC doesn't report even warning for cast from private base class to derived.
http://reviews.llvm.org/D19477
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D18957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
78 matches
Mail list logo
