etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This checker finds redundant expression on both side of a binary operator.
The current implementation provide a function to check whether expression
are the equivalent. This implementation
Author: silvas
Date: Fri Apr 22 21:13:48 2016
New Revision: 267263
URL: http://llvm.org/viewvc/llvm-project?rev=267263&view=rev
Log:
[profile] Fix another use of the driver.
Follow-on to r267262.
Modified:
cfe/trunk/test/Profile/cxx-indirect-call.cpp
Modified: cfe/trunk/test/Profile/cxx-ind
Author: silvas
Date: Fri Apr 22 21:11:16 2016
New Revision: 267262
URL: http://llvm.org/viewvc/llvm-project?rev=267262&view=rev
Log:
[profile] Use cc1 in these tests instead of the driver.
I ran into this when seeing what tests would break if we make a
driver-level decision about whether FEPGO or
chh updated this revision to Diff 54758.
chh added a comment.
Also move Checkers.td to clang/include/.../Checkers.
http://reviews.llvm.org/D19393
Files:
include/clang/CMakeLists.txt
include/clang/StaticAnalyzer/Checkers/CMakeLists.txt
include/clang/StaticAnalyzer/Checkers/Checkers.td
li
mprobst added a comment.
Friendly ping.
http://reviews.llvm.org/D19204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Fri Apr 22 19:00:08 2016
New Revision: 267254
URL: http://llvm.org/viewvc/llvm-project?rev=267254&view=rev
Log:
[clang-tidy] Fix misc-macro-repeated-side-effects false positive with
stringified arguments
Added:
clang-tools-extra/trunk/test/clang-tidy/misc-macro-repeated-
rsmith added a comment.
I think this is a reasonable direction. I'd like to see some kind of %list form
added to our diagnostics system, but I don't mind whether that happens before
or after this change.
(I'd also prefer to use singular forms in the various subject names, but that
seems to cre
weimingz added a comment.
Ping ?
http://reviews.llvm.org/D17741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl created this revision.
aprantl added a reviewer: doug.gregor.
aprantl added a subscriber: cfe-commits.
aprantl set the repository for this revision to rL LLVM.
This patch fixes the condition for determining whether the debug info for a
template instantiation will exist in an imported clan
Author: rtrieu
Date: Fri Apr 22 17:14:32 2016
New Revision: 267234
URL: http://llvm.org/viewvc/llvm-project?rev=267234&view=rev
Log:
Revert the bool portion of r267054
Remove the floating point to bool conversion warnings. Some of these
conversions will be caught by -Wliteral-conversion and -Wfl
teemperor marked 4 inline comments as done.
teemperor added a comment.
No, didn't saw the thread so far. I assume the comments in there are still
valid, so I'll update this patch.
Thanks for the feedback so far!
http://reviews.llvm.org/D19312
___
c
Author: eugenezelenko
Date: Fri Apr 22 16:33:33 2016
New Revision: 267228
URL: http://llvm.org/viewvc/llvm-project?rev=267228&view=rev
Log:
[Clang-tidy] Fix Clang warning in misc/StringConstructorCheck.h.
Using LLVM_ENABLE_WARNINGS=ON is good idea.
Modified:
clang-tools-extra/trunk/clang-tid
Author: xur
Date: Fri Apr 22 16:19:05 2016
New Revision: 267224
URL: http://llvm.org/viewvc/llvm-project?rev=267224&view=rev
Log:
PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name
Write out the PGOFuncName meta data if PGOFuncName is different from function's
raw nam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267224: PGO] PGOFuncName meta data if PGOFuncName is
different from function's raw name (authored by xur).
Changed prior to commit:
http://reviews.llvm.org/D18624?vs=54717&id=54725#toc
Repository:
rL
xur added a comment.
tested with povray with full path names in the command line and it works fine.
http://reviews.llvm.org/D18624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Apr 22, 2016 at 10:50 AM, David Blaikie wrote:
>
>
> On Thu, Apr 21, 2016 at 2:04 PM, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Thu Apr 21 16:04:55 2016
>> New Revision: 267054
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=26705
Nico,
With this warning, I was attempting to catch different cases of floating to
bool conversion:
bool x = 5.0; // Wrong type
void test(bool, float);
test(5.0, true); // Switched arguments.
I did not see anything like your example come up. See as there are many
edge cases in with floati
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D18624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
On Fri, Apr 22, 2016 at 12:59 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Apr 22, 2016 at 12:29 PM, Richard Smith
> wrote:
>
>> On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: rnk
>>> Date:
aaron.ballman added a comment.
Ping
http://reviews.llvm.org/D18768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Ping.
http://reviews.llvm.org/D19244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xur updated this revision to Diff 54717.
xur added a comment.
Handling the path-stripped prefix in PGOFuncName.
This new patch depends on http://reviews.llvm.org/D19433
http://reviews.llvm.org/D18624
Files:
CodeGenPGO.cpp
Index: CodeGenPGO.cpp
===
bryanpkc created this revision.
bryanpkc added reviewers: rjmccall, kbarton.
bryanpkc added a subscriber: cfe-commits.
bryanpkc added a dependency: D19414: [SystemZ] Support Swift Calling Convention.
Port rL265324 to SystemZ to allow using the 'swiftcall' attribute on that
architecture.
Depends
rjmccall added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:763
@@ -762,8 +762,3 @@
Includers.push_back(std::make_pair(FindFile, FindFile->getDir()));
- File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
-
rjmccall added inline comments.
Comment at: lib/Sema/SemaExceptionSpec.cpp:260
@@ -261,1 +259,3 @@
+ (First->getLocation().isInvalid() ||
+ Context.getSourceManager().isInSystemHeader(First->getLocation( {
New->setType(Context.getFunctionType(
dschuff added a subscriber: rengolin.
dschuff added a comment.
any comments from @t.p.northover or perhaps @rengolin ?
(This does have a potential new cost on ARM, as it requires one thunk (which is
just a tail call) per static initializer on ARM and WebAssembly)
http://reviews.llvm.org/D19275
On Fri, Apr 22, 2016 at 12:29 PM, Richard Smith
wrote:
> On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Fri Apr 22 13:46:33 2016
>> New Revision: 267186
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=267186&view
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D18540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Fri Apr 22 13:46:33 2016
> New Revision: 267186
>
> URL: http://llvm.org/viewvc/llvm-project?rev=267186&view=rev
> Log:
> Fix a bug involving deferred decl emission and PCH
>
rsmith added a subscriber: rsmith.
Comment at: lib/Sema/SemaExceptionSpec.cpp:260
@@ -261,1 +259,3 @@
+ (First->getLocation().isInvalid() ||
+ Context.getSourceManager().isInSystemHeader(First->getLocation( {
New->setType(Context.getFunctionType(
--
apelete added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:763
@@ -762,8 +762,3 @@
Includers.push_back(std::make_pair(FindFile, FindFile->getDir()));
- File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
-
Author: rnk
Date: Fri Apr 22 13:46:33 2016
New Revision: 267186
URL: http://llvm.org/viewvc/llvm-project?rev=267186&view=rev
Log:
Fix a bug involving deferred decl emission and PCH
For various reasons, involving dllexport and class linkage compuations,
we have to wait until after the semicolon af
thakis created this revision.
thakis added a reviewer: rnk.
thakis added a subscriber: cfe-commits.
Currently, clang-cl always uses Windows style for unquoting, and clang always
uses POSIX style for unquoting.
In general, response file quoting should match the shell the response file is
used in
rjmccall added inline comments.
Comment at: lib/Sema/SemaExceptionSpec.cpp:260
@@ -261,1 +259,3 @@
+ (First->getLocation().isInvalid() ||
+ Context.getSourceManager().isInSystemHeader(First->getLocation( {
New->setType(Context.getFunctionType(
rjmccall added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:763
@@ -762,8 +762,3 @@
Includers.push_back(std::make_pair(FindFile, FindFile->getDir()));
- File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false,
-
bader added a comment.
In http://reviews.llvm.org/D18369#409011, @yaxunl wrote:
> In http://reviews.llvm.org/D18369#408773, @bader wrote:
>
> > BTW, there is a comment on GitHub that opencl.h might be a bad name for
> > that header, since Khronos group provides the header with the same name,
>
On Thu, Apr 21, 2016 at 2:04 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Thu Apr 21 16:04:55 2016
> New Revision: 267054
>
> URL: http://llvm.org/viewvc/llvm-project?rev=267054&view=rev
> Log:
> Split interesting warnings off from -Wfloat-convers
Author: compnerd
Date: Fri Apr 22 12:11:05 2016
New Revision: 267169
URL: http://llvm.org/viewvc/llvm-project?rev=267169&view=rev
Log:
unwind: unify some more macros
The macros were defined identically across both cases. Unify the definitions to
have a single definition for _LIBUWNIND_{HIDDEN,EX
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: include/clang/AST/OpenMPClause.h:2789-2797
@@ +2788,11 @@
+// \brief Expression associated with the component.
+Expr *AssociatedExpression;
+// \brief Declaration associated with the declaration.
sfantao updated this revision to Diff 54672.
sfantao marked 15 inline comments as done.
sfantao added a comment.
- Address review comments. Fix bug in the evaluation of the unique declarations.
http://reviews.llvm.org/D19382
Files:
include/clang/AST/OpenMPClause.h
lib/AST/OpenMPClause.cpp
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Please fix formatting, btw.
Repository:
rL LLVM
http://reviews.llvm.org/D19201
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists, theraven, jroelofs.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This patch builds on D19412.
The motivation here is to allow toolchain vendors to build a version of
`libcxx` with all
rmaprath updated this revision to Diff 54658.
rmaprath added a comment.
Added bit more context to the diff.
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_base
include/__os_support
include/mutex
include/thread
src/algorithm.cpp
src/condition_variable.cpp
sbaranga added a comment.
A gentle ping?
Cheers,
Silviu
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath created this revision.
rmaprath added reviewers: EricWF, theraven, mclow.lists, jroelofs.
rmaprath added subscribers: espositofulvio, cfe-commits.
This is mostly D11781 with the final review comments addressed:
- Merged all the headers into a single `__os_support` header
- Moved all inter
rmaprath added a comment.
In http://reviews.llvm.org/D14293#350570, @rengolin wrote:
> Sorry, this fell out of my radar. I'm ok with the changes. Ping me when you
> commit so I can monitor the bot for a while.
Sorry, I missed your message this time around :)
I'll double-check the patch and co
Author: kparzysz
Date: Fri Apr 22 09:58:46 2016
New Revision: 267159
URL: http://llvm.org/viewvc/llvm-project?rev=267159&view=rev
Log:
[Hexagon] Add definitions for circular and bit-reverse loads/stores
Modified:
cfe/trunk/include/clang/Basic/BuiltinsHexagon.def
cfe/trunk/test/CodeGen/bui
yaxunl added a comment.
In http://reviews.llvm.org/D18369#408773, @bader wrote:
> BTW, there is a comment on GitHub that opencl.h might be a bad name for that
> header, since Khronos group provides the header with the same name, but it
> defines host API. So if some developer is using clang to
hokein added a comment.
In http://reviews.llvm.org/D19406#408893, @omtcyf0 wrote:
> @hokein
>
> Great, thanks!
>
> I'd be very grateful if you could land it!
Sure. Done.
Repository:
rL LLVM
http://reviews.llvm.org/D19406
___
cfe-commits mailin
twoh added a comment.
Ping. @joerg, could you please take a look?
http://reviews.llvm.org/D19062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Fri Apr 22 09:43:39 2016
New Revision: 267155
URL: http://llvm.org/viewvc/llvm-project?rev=267155&view=rev
Log:
[clang-tidy] fix link in Release Notes
Summary: This is intended to fix https://llvm.org/bugs/show_bug.cgi?id=27426
Patch by Kirill Bobyrev!
Reviewers: alexfh, Le
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267155: [clang-tidy] fix link in Release Notes (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D19406?vs=54620&id=54649#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19406
Hi Richard,
1.) Are these new warnings in -Wconversion? If not, they probably should
be, right?
2.) It looks like -Wfloat-bool-constant-conversion is on by default and
warns on things like
if (kHotspotRadius)
if kHotspotRadius is a float. Do you have data that suggests that this is a
common b
baloghadamsoftware marked 9 inline comments as done.
baloghadamsoftware added a comment.
http://reviews.llvm.org/D19357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
baloghadamsoftware updated this revision to Diff 54642.
baloghadamsoftware added a comment.
Updated according to the comments.
http://reviews.llvm.org/D19357
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/A
zoran.jovanovic updated this revision to Diff 54640.
zoran.jovanovic added a comment.
New patch version rebased to r256194.
Any comments to this work?
http://reviews.llvm.org/D12200
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
l
omtcyf0 added a comment.
@hokein
Great, thanks!
I'd be very grateful if you could land it!
http://reviews.llvm.org/D19406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mzuckerm
Date: Fri Apr 22 05:56:24 2016
New Revision: 267135
URL: http://llvm.org/viewvc/llvm-project?rev=267135&view=rev
Log:
[clang][AVX512][Builtin] adding intrinsics for vf{n}madd{ss|sd} and
vf{n}sub{ss|sd} instruction set
Differential Revision: http://reviews.llvm.org/D19320
Modif
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1544
@@ -1508,2 +1543,3 @@
deriveLocalStyle(AnnotatedLines);
-computeAffectedLines(AnnotatedLines.begin(), AnnotatedLines.end());
+AffectedRangeMgr.computeAffectedLines(AnnotatedLines.begin(),
+
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D19406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: mzuckerm
Date: Fri Apr 22 05:06:10 2016
New Revision: 267129
URL: http://llvm.org/viewvc/llvm-project?rev=267129&view=rev
Log:
[Clang][AVX512][BUILTIN] Adding scalar intrinsics for rsqrt14 ,rcp14, getexp
and getmant instruction set
Differential Revision: http://reviews.llvm.org/D19326
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, LegalizeAdulthood, hokein.
omtcyf0 added a subscriber: cfe-commits.
This is intended to fix https://llvm.org/bugs/show_bug.cgi?id=27426
http://reviews.llvm.org/D19406
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
PING.
On Thu, Apr 21, 2016 at 11:48 AM Eric Liu wrote:
> ioeric updated this revision to Diff 54476.
> ioeric added a comment.
>
> - Added comments for endsWithInternal().
>
>
> http://reviews.llvm.org/D18551
>
> Files:
> include/clang/Format/Format.h
> lib/Format/AffectedRangeManager.cpp
>
ioeric added a subscriber: ioeric.
ioeric added a comment.
PING.
http://reviews.llvm.org/D18551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added inline comments.
Comment at: lib/Headers/opencl.h:2
@@ +1,3 @@
+//
+// SPIR Tools
+//
This comment should be updated.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-c
Author: abataev
Date: Fri Apr 22 04:05:03 2016
New Revision: 267125
URL: http://llvm.org/viewvc/llvm-project?rev=267125&view=rev
Log:
[OPENMP] Fix for PR27463: Privatizing struct fields with array type
causes code generation failure.
The codegen part of firstprivate clause for member decls used t
bader added a comment.
BTW, there is a comment on GitHub that opencl.h might be a bad name for that
header, since Khronos group provides the header with the same name, but it
defines host API. So if some developer is using clang to compile OpenCL
application it might accidentally include opencl
bader added inline comments.
Comment at: lib/Headers/opencl.h:4870
@@ +4869,3 @@
+
+#ifdef cl_khr_fp64
+char __const_func __attribute__((overloadable)) convert_char(double);
Sam, could you confirm that this macro id implicitly defined for OpenCL
versions 1.2+?
DmitryPolukhin added a comment.
Weekly friendly ping, PTAL!
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Fri Apr 22 02:39:05 2016
New Revision: 267119
URL: http://llvm.org/viewvc/llvm-project?rev=267119&view=rev
Log:
Add missing include of
Modified:
libcxx/trunk/test/std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.pconst/eval.pass.cpp
libcxx/trunk/test/std/
Author: akirtzidis
Date: Fri Apr 22 02:21:16 2016
New Revision: 267118
URL: http://llvm.org/viewvc/llvm-project?rev=267118&view=rev
Log:
[index] Add SymbolSubKinds for ObjC IB annotations.
Modified:
cfe/trunk/include/clang/Index/IndexSymbol.h
cfe/trunk/lib/Index/IndexSymbol.cpp
cfe/tr
Author: akirtzidis
Date: Fri Apr 22 02:21:10 2016
New Revision: 267117
URL: http://llvm.org/viewvc/llvm-project?rev=267117&view=rev
Log:
[index] Add a SymbolSubKind for an ObjC unit test.
Added:
cfe/trunk/test/Index/Core/index-subkinds.m
Modified:
cfe/trunk/include/clang/Index/IndexSymbol
Author: akirtzidis
Date: Fri Apr 22 02:21:04 2016
New Revision: 267116
URL: http://llvm.org/viewvc/llvm-project?rev=267116&view=rev
Log:
[index] Change SymbolCXXTemplateKind to a 'SymbolSubKinds' bitset.
This provides a more general and flexible way to annotate special symbols.
Modified:
cfe
74 matches
Mail list logo
