Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

twoh updated this revision to Diff 53369. twoh added a comment. Fix attribute annotation from 'const' to 'pure'. Add support for 'pure' attribute to builtin function database related code. Test case (test/Sema/libbuiltins-ctype.c) added. Line 116 of test/FixIt/typo.m is removed because it is no

Re: [PATCH] D18947: Emit the module hash by default with -flto=thin.

joker.eph closed this revision. joker.eph added a comment. r265977 http://reviews.llvm.org/D18947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

doug.gregor added a comment. I think it's completely reasonable to implement support for VLAs as a GNU C++ extension. We did go through a phase where we tried to avoid implementing VLAs in C++ because we considered them to be a poor feature in C++. However, their use was wide-spread enough that

[clang-tools-extra] r266044 - [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its

Author: mgehre Date: Tue Apr 12 00:45:13 2016 New Revision: 266044 URL: http://llvm.org/viewvc/llvm-project?rev=266044&view=rev Log: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its Summary: The Fix-Its for the added test cases were before: -void F11(cons

Re: [PATCH] D18993: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its

This revision was automatically updated to reflect the committed changes. Closed by commit rL266044: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid… (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D18993?vs=53322&id=53368#toc Repository: rL L

Re: [PATCH] D18991: [ASTMatchers]: fix crash in hasReturnValue

This revision was automatically updated to reflect the committed changes. Closed by commit rL266043: [ASTMatchers]: fix crash in hasReturnValue (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D18991?vs=53311&id=53367#toc Repository: rL LLVM http://reviews.llvm.org/D18

r266043 - [ASTMatchers]: fix crash in hasReturnValue

Author: mgehre Date: Tue Apr 12 00:43:18 2016 New Revision: 266043 URL: http://llvm.org/viewvc/llvm-project?rev=266043&view=rev Log: [ASTMatchers]: fix crash in hasReturnValue Summary: The crash was reproduced by the included test case. It was initially found through a crash of clang-tidy's misc-

r266041 - [OPENMP 4.0] Support for 'uniform' clause in 'declare simd' directive.

Author: abataev Date: Tue Apr 12 00:28:34 2016 New Revision: 266041 URL: http://llvm.org/viewvc/llvm-project?rev=266041&view=rev Log: [OPENMP 4.0] Support for 'uniform' clause in 'declare simd' directive. OpenMP 4.0 defines clause 'uniform' in 'declare simd' directive: 'uniform' '(' ')' The unif

[PATCH] D19006: [libcxx] Remove the "reduced-arity-initialization" extension from the uses-allocator constructors

EricWF created this revision. EricWF added a subscriber: cfe-commits. http://reviews.llvm.org/D19006 Files: include/tuple test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_UTypes.pass.cpp Index: test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_UTypes.pass.cpp =

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno updated this revision to Diff 53363. bruno added a comment. Hi Richard & Ben, Thanks for the review! I've attached a new patch and changed the approach: made findUsableModuleForHeader receive a FileName instead of FileEntry. Answering the questions below: FileManager::getFile returns th

Re: [PATCH] D18657: Propagate missing empty exception spec from function declared in system header

rjmccall added a comment. IIRC, isInSystemHeader isn't a terribly cheap check. Please extract this into a function that only needs to be called if the other checks succeed. You should also be able to just ask about the first declaration. There are contrived situations where isInSystemHeader c

r266039 - Basic: fix profiling with GNU EABI

Author: compnerd Date: Mon Apr 11 22:05:03 2016 New Revision: 266039 URL: http://llvm.org/viewvc/llvm-project?rev=266039&view=rev Log: Basic: fix profiling with GNU EABI The GNU profiling support indicates that the interface is `_mcount` rather than `mcount`. Conditionalise the behaviour accordi

[patch] clang-cl: Remove -isystem, add -imsvc, expose -nostdlibinc

Hi, r260990 exposed -isystem in clang-cl. -isystem adds a directory to the front of the system include search path. The idea was to use this to point to a hermetic msvc install, but as it turns out this doesn't work: -isystem then adds the hermetic headers in front of clang's builtin headers, and

[PATCH] D19003: Set C99 as default C Standard for PS4 target

dyung created this revision. dyung added reviewers: rsmith, ygao. dyung added a subscriber: cfe-commits. On the PS4, the default C standard is C99 which differs from the current default of C11. This patch makes the default C99 when targeting the PS4. This change includes the changes previously p

r266031 - [analyzer] Fix assertion in ReturnVisitor for body-farm synthesized getters

Author: dcoughlin Date: Mon Apr 11 19:53:26 2016 New Revision: 266031 URL: http://llvm.org/viewvc/llvm-project?rev=266031&view=rev Log: [analyzer] Fix assertion in ReturnVisitor for body-farm synthesized getters Don't emit a path note marking the return site if the return statement does not have a

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

rjmccall added a comment. Seems okay to me. Normally we wouldn't want to remove an attribute from the DeclSpec because it can apply to multiple declarators, but that's not possible with a block-literal declarator, so it's fine. Richard should sign off, though. http://reviews.llvm.org/D18567

[PATCH] D18998: [CodeGen] Explicitly widen non-power-of-2 vector HFA base types.

ab created this revision. ab added reviewers: rjmccall, uweigand, t.p.northover. ab added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Currently, for the ppc64--gnu and aarch64 ABIs, we recognize: ``` typedef __attribute__((__ext_vector_type__(3))) float v3f32; typedef __attri

[PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno created this revision. bruno added a reviewer: doug.gregor. bruno added subscribers: manmanren, dexonsmith, cfe-commits. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list when type args and protocols are mixed in the same list. This happens when the

Re: [PATCH] D18879: Lit C++11 Compatibility Patch #6

tigerleapgorge closed this revision. tigerleapgorge added a comment. Patch committed @r265982. http://reviews.llvm.org/D18879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

alexfh added inline comments. Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:28 @@ +27,3 @@ + // - actually deleted + // - not in template instantiation. + const auto isBadlyDefaulted = For decls there is `isInstantiated()`, which is defined as

Re: r265934 - [clang-format] Walk backwards from end() instead of forwards from rend().

> > > Was/is the 2 correct then? (if it was next(rbegin, 2) that'd be > equivalent > > to prev(end, 3), yes?) > > I think it is from looking at the test case, looping in martin to see > whether I'm right :) At that point in the code, we have [..., PrePrev = '@', Prev = 'SomeToken'] and CurrentTok

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rjmccall added a comment. In the cases where we can emit nonnull, I agree that we should be able to safely use dereferenceable for the non-virtual data size of of the type. I'm not too concerned about people calling methods on entirely the wrong type, especially to the relatively small degree

r266005 - Allow simultaneous safestack and stackprotector attributes.

Author: eugenis Date: Mon Apr 11 17:27:55 2016 New Revision: 266005 URL: http://llvm.org/viewvc/llvm-project?rev=266005&view=rev Log: Allow simultaneous safestack and stackprotector attributes. This is the clang part of http://reviews.llvm.org/D18846. SafeStack instrumentation pass adds stack pro

Re: r265934 - [clang-format] Walk backwards from end() instead of forwards from rend().

On Mon, Apr 11, 2016 at 11:15 PM, Martin Probst wrote: >> > Was/is the 2 correct then? (if it was next(rbegin, 2) that'd be >> > equivalent >> > to prev(end, 3), yes?) >> >> I think it is from looking at the test case, looping in martin to see >> whether I'm right :) > > > At that point in the cod

Re: [PATCH] D18993: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its

alexfh accepted this revision. alexfh added a comment. LG. Thank you! http://reviews.llvm.org/D18993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

mgehre added inline comments. Comment at: test/clang-tidy/readability-redundant-inline.cpp:6 @@ +5,3 @@ +// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: 'inline' is redundant because method body is defined inside class [readability-redundant-inline] +// CHECK-FIXES: {{^}} int f1()

Re: [PATCH] D18993: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its

fowles accepted this revision. fowles added a comment. This revision is now accepted and ready to land. Thanks for doing this! I tried a bunch of variants and just couldn't figure it out. http://reviews.llvm.org/D18993 ___ cfe-commits mailing list

Re: [PATCH] D17180: Fix failing python bindings test

jbcoe abandoned this revision. jbcoe added a comment. Fixed in http://reviews.llvm.org/D17278 Repository: rL LLVM http://reviews.llvm.org/D17180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D18993: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its

mgehre created this revision. mgehre added reviewers: fowles, hokein, sbenza, alexfh. mgehre added a subscriber: cfe-commits. The Fix-Its for the added test cases were before: -void F11(const unsigned int /*version*/); +void F11(unsigned int int /*version*/); -void F12(const bool b = true); +void

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

gberry added a subscriber: gberry. gberry added a comment. Not to hijack this review, but would it not make sense to do something similar with the 'this' pointer and the 'dereferenceable' attribute? Granted, figuring out the size to use is trickier, but I believe this would enable LICM e.g. to

Re: [PATCH] D18991: [ASTMatchers]: fix crash in hasReturnValue

alexfh added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5018 @@ -5017,1 +5017,3 @@ InnerMatcher) { + if (!Node.getRetValue()) +return false; nit: might be a bit clearer, if you reverse the condition: if (const auto

Re: [PATCH] D18991: [ASTMatchers]: fix crash in hasReturnValue

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. This should also fix http://llvm.org/PR27298 http://reviews.llvm.org/D18991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

rsmith added a subscriber: rsmith. Comment at: test/clang-tidy/readability-redundant-inline.cpp:5 @@ +4,3 @@ + inline int f1() { +// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: 'inline' is redundant because method body is defined inside class [readability-redundant-inline] +// CHE

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

rsmith added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaType.cpp:2158-2159 @@ -2157,3 +2157,4 @@ if (!getLangOpts().C99) { -if (T->isVariableArrayType()) { +if (T->isVariableArrayType() && +!(getLangOpts().CPlusPlus && getLangOpts().GNUMode)) {

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

mgehre updated this revision to Diff 53317. mgehre added a comment. Removed debug output http://reviews.llvm.org/D18914 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantInlineCheck.cpp clang-tidy/readability/Re

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

jbcoe updated this revision to Diff 53316. jbcoe added a comment. This revision is now accepted and ready to land. Remove `isDeleted` as it needs to be added for non-member functions. I will add `isDeleted` as an isolated follow up patch. http://reviews.llvm.org/D15469 Files: bindings/python

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

rsmith added a comment. Can you find who's poisoning the `FileManager`'s idea of the name of the file with a full path to the VFS overlay and fix that? Comment at: lib/Lex/HeaderSearch.cpp:1163 @@ +1162,3 @@ +SmallString<256> RootName = StringRef(Root->getName()); +path

r265994 - libclang: fix two memory leaks (PR26292)

Author: hans Date: Mon Apr 11 15:53:59 2016 New Revision: 265994 URL: http://llvm.org/viewvc/llvm-project?rev=265994&view=rev Log: libclang: fix two memory leaks (PR26292) Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http://llvm.org/viewvc

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

mgehre updated this revision to Diff 53315. mgehre added a comment. Update for review comments; simplified lexing, added proposed test case http://reviews.llvm.org/D18914 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/R

r265991 - Adjust tests to have consistent integer sizes.

Author: rtrieu Date: Mon Apr 11 15:37:04 2016 New Revision: 265991 URL: http://llvm.org/viewvc/llvm-project?rev=265991&view=rev Log: Adjust tests to have consistent integer sizes. Add a triple to the run lines so that integers will the same sizes across runs. Also add a compile time check to ensu

Re: [PATCH] RHEL: Look in more places to find g++ headers and runtime

New patch attached. -Michael Rafael Espíndola wrote: LGTM with a comment saying why it is needed. Cheers, Rafael On 22 March 2016 at 23:02, Michael Lampe via cfe-commits wrote: Some distros with ten years of support ship an old gcc but later offer more recent versions for installation in p

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

twoh added a comment. @joerg My bad. They surely read from globals. I'll fix the diff. Thanks for the catch! http://reviews.llvm.org/D18970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D18991: [ASTMatchers]: fix crash in hasReturnValue

mgehre created this revision. mgehre added reviewers: klimek, alexfh. mgehre added a subscriber: cfe-commits. Herald added a subscriber: klimek. The crash was reproduced by the included test case. It was initially found through a crash of clang-tidy's misc-misplaced-widening-cast check. http://re

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

rjmccall added a comment. It requires careful IRGen support which at one point did not exist. When I implemented VLAs of __strong/__weak references for ARC, I deliberately tried to make sure that the infrastructure would also work for the C++ cases, but I didn't have time to go actually test a

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

benlangmuir added a comment. This doesn't appear to be a safe change. We can't assume that `RootName` wouldn't ever be legitimately found somewhere in a path (even without a VFS) and changing the path prefix could give a completely different location. I would also be concerned about the perfo

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

rsmith added a comment. @vbyakovl The description of this patch is very misleading. What I believe this does is to allow VLAs with non-trivially-destructed element types. Can you fix the description (and make sure the fixed version ends up in the commit message if this is approved)? @rjmccall D

r265982 - Lit C++11 Compatibility Patch #6

Author: lcharles Date: Mon Apr 11 14:30:25 2016 New Revision: 265982 URL: http://llvm.org/viewvc/llvm-project?rev=265982&view=rev Log: Lit C++11 Compatibility Patch #6 Updated the expected diagnostics of 17 OpenMP tests. The changes to each test are identical. Modified: cfe/trunk/test/OpenMP

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

joerg added a subscriber: joerg. joerg added a comment. ctype.h functions are only pure, not const? http://reviews.llvm.org/D18970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

t.p.northover added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -target-feature +vfp4

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

rengolin added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -target-feature +vfp4 -fsyn

r265977 - Emit the module hash by default with -flto=thin.

Author: mehdi_amini Date: Mon Apr 11 13:45:20 2016 New Revision: 265977 URL: http://llvm.org/viewvc/llvm-project?rev=265977&view=rev Log: Emit the module hash by default with -flto=thin. Reviewers: tejohnson Subscribers: joker.eph, cfe-commits Differential Revision: http://reviews.llvm.org/D189

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5570 @@ -5565,3 +5569,3 @@ // and qualified friend declarations. - // NB: MSVC converts such a declaration to dllexport. + // NB: MSVC converts such a declaration to dllexport that's why we do it also. bool I

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

pilki added a comment. I hope I answered all comments (sorry if I missed some, I'm not yet used to this UI). I have an open question about isInTemplateInstantiation, and added a test (since I missed templated function) Comment at: clang-tidy/readability/DeletedDefaultCheck.c

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

pilki updated this revision to Diff 53289. pilki marked 5 inline comments as done. http://reviews.llvm.org/D18961 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/DeletedDefaultCheck.cpp clang-tidy/readability/DeletedDefaultCheck.h clang-tidy/readability/Readability

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli updated this revision to Diff 53283. carlo.bertolli added a comment. [OPENMP] Remove template for intervening statement and only allow CompoundStmt. Repository: rL LLVM http://reviews.llvm.org/D18474 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/teams_codegen.cpp Ind

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Alexey Thanks for the review. I addressed your comment in a new version of the revision. Samuel already reviewed the patch, as you can see in the message exchange. I am very happy to apply any design change you can

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

t.p.northover added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -target-feature +vfp4

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D18961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

ioeric updated this revision to Diff 53274. ioeric added a comment. - removed unused fields in AnnotatedLine. http://reviews.llvm.org/D18551 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/CMakeLists.txt unittests/Format/CleanupTest.cpp unittests/Format/For

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

I don't feel sufficiently strongly to insist - clang-tidy's mostly outside my wheelhouse anyway. As for how to go about it - my rough approach would be to write a small test case that calls an implicitly-deleted-but-explicitly-defaulted move op, run it, check the diagnostic text, find that in Diag

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

rnk added a comment. Richard, do you think we should be handling this by rewriting the AST-level attribute in Sema or by changing our interpretation of things in CodeGen? We're already creating a bunch of implicit attributes to implement class-level import/export. Comment at:

r265964 - [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512, psllv{16si|8di}, psra{d|q}512, psrav{16si|8di}, pternlog{d|q}{128|256|512} ) builtin to clang

Author: mzuckerm Date: Mon Apr 11 12:04:21 2016 New Revision: 265964 URL: http://llvm.org/viewvc/llvm-project?rev=265964&view=rev Log: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang Differential Re

r265963 - Update getting started docs

Author: rnk Date: Mon Apr 11 12:02:34 2016 New Revision: 265963 URL: http://llvm.org/viewvc/llvm-project?rev=265963&view=rev Log: Update getting started docs compiler-rt is optional. We often get email from users with compiler-rt build errors who don't actually need compiler-rt. Marking it option

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

ioeric updated this revision to Diff 53268. ioeric marked 16 inline comments as done. ioeric added a comment. - Addressed comments. http://reviews.llvm.org/D18551 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/TokenAnnotator.h unittests/Format/CMakeLists.txt uni

Re: r265934 - [clang-format] Walk backwards from end() instead of forwards from rend().

On Mon, Apr 11, 2016 at 6:48 PM, David Blaikie wrote: > > > On Mon, Apr 11, 2016 at 5:19 AM, Benjamin Kramer via cfe-commits > wrote: >> >> Author: d0k >> Date: Mon Apr 11 07:19:19 2016 >> New Revision: 265934 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=265934&view=rev >> Log: >> [clang-fo

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno added a comment. Ping! http://reviews.llvm.org/D18849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

alexfh added a comment. Thank you for addressing the comments! Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:27 @@ +26,3 @@ + const auto NotTemplate = unless(hasAncestor( + cxxRecordDecl(::clang::ast_matchers::isTemplateInstantiation(; +

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

manmanren added a comment. Ping :] http://reviews.llvm.org/D18567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r265934 - [clang-format] Walk backwards from end() instead of forwards from rend().

On Mon, Apr 11, 2016 at 5:19 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Mon Apr 11 07:19:19 2016 > New Revision: 265934 > > URL: http://llvm.org/viewvc/llvm-project?rev=265934&view=rev > Log: > [clang-format] Walk backwards from end() instead of

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

pilki added a comment. In http://reviews.llvm.org/D18961#397163, @dblaikie wrote: > I'd consider just making this a compiler warning, perhaps? I honestly don't feel competent right now to write compiler warnings: clang-tidy has a nice, well defined interface. A compiler warning would force me

[PATCH] D18970: Add functions in ctype.h to builtin function database

twoh created this revision. twoh added reviewers: rsmith, aaron.ballman. twoh added a subscriber: cfe-commits. Add functions declared in ctype.h to builtin function database. All functions are annotated with nothrow and const attribute, which enables better optimization. http://reviews.llvm.or

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

alexfh added a comment. In http://reviews.llvm.org/D18961#397163, @dblaikie wrote: > I'd consider just making this a compiler warning, perhaps? I agree that it might be a good idea. However, it doesn't hurt to have this in clang-tidy (at least as a prototype - to figure out details and see how

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

mgehre updated this revision to Diff 53261. mgehre added a comment. Remove unused CFGBuilder::prependLifetimeEndsWithTerminator http://reviews.llvm.org/D15031 Files: include/clang/Analysis/AnalysisContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h

Re: r259734 - Fix predefine for __NSConstantString struct type

On 11/04/16 16:18, Ben Langmuir wrote: On Apr 3, 2016, at 10:57 AM, Yaron Keren > wrote: I look at many AST dumps for small reduced code so it's mostly weird to see this in the AST (and takes a bit of screen real estate) as it's not something that originated in

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

alexfh accepted this revision. alexfh added a comment. Missed this patch somehow: it was in a wrong part of my dashboard =\ LG. Thanks for the fix. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:94 @@ +93,3 @@ + bool Bool{false}; + // CHECK-FIXES: bool

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

pilki updated this revision to Diff 53257. pilki marked 3 inline comments as done. http://reviews.llvm.org/D18961 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/DeletedDefaultCheck.cpp clang-tidy/readability/DeletedDefaultCheck.h clang-tidy/readability/Readability

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D18963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

sbenza added inline comments. Comment at: clang-tidy/readability/RedundantInlineCheck.cpp:59 @@ +58,3 @@ + while (!RawLexer.LexFromRawLexer(Tok)) { +if (Tok.is(tok::semi) || Tok.is(tok::l_brace)) + break; Parsing C++ is hard. Stopping at the first `{` me

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

I'd consider just making this a compiler warning, perhaps? On Mon, Apr 11, 2016 at 5:52 AM, Alex Pilkiewicz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > pilki created this revision. > pilki added a reviewer: alexfh. > pilki added a subscriber: cfe-commits. > > Checks if constructors and

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

pilki marked an inline comment as done. pilki added a comment. http://reviews.llvm.org/D18961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

pilki added inline comments. Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:30 @@ +29,3 @@ + // We should actually use isExplicitlyDefaulted, but it does not exist. + Finder->addMatcher( + cxxConstructorDecl(isDefaultConstructor(), isExplicitlyDefaulted(),

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

sbaranga updated this revision to Diff 53254. sbaranga added a comment. Apply review comments from Renato: - simplify condition for enabling __ARM_FEATURE_FMA - use cortex-a7 instead of cortex-a8 for testing since this is a real use case. http://reviews.llvm.org/D18963 Files: lib/Basic/Targe

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

hfinkel added a comment. In http://reviews.llvm.org/D18823#397122, @rengolin wrote: > In http://reviews.llvm.org/D18823#397112, @hfinkel wrote: > > > However, as an implementation extension, this concern is not relevant. I'm > > in favor of this; I have uses who use this feature in GCC. It is ce

r265952 - [CLANG] [AVX512] [BUILTIN] Adding PSRA{Q|D|QI|DI}{128|256|512} builtin

Author: mzuckerm Date: Mon Apr 11 10:46:39 2016 New Revision: 265952 URL: http://llvm.org/viewvc/llvm-project?rev=265952&view=rev Log: [CLANG] [AVX512] [BUILTIN] Adding PSRA{Q|D|QI|DI}{128|256|512} builtin Differential Revision: http://reviews.llvm.org/D17693 Modified: cfe/trunk/include/cla

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

rengolin added a comment. In http://reviews.llvm.org/D18823#397112, @hfinkel wrote: > However, as an implementation extension, this concern is not relevant. I'm in > favor of this; I have uses who use this feature in GCC. It is certainly true > that most HPC users are using these on PODs, but t

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

hfinkel added a subscriber: hfinkel. hfinkel added a comment. In http://reviews.llvm.org/D18823#397071, @rengolin wrote: > En passant comment: I really wish we wouldn't. > > The C++ standard had some very careful considerations on VLAs and decided > *not* to support. It wasn't for lack of intere

Re: r259734 - Fix predefine for __NSConstantString struct type

Sorry, I didn't mean to imply it’s *only* usable on Darwin. CoreFoundation (or at least a large subset of it) supports other platforms. And in general, these builtins are exposed in all languages and for all platforms, and have been “forever” so there could be other users of this functionality

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

alexfh added inline comments. Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:82 @@ +81,3 @@ + } + if (const auto* copy_assignment = + Result.Nodes.getNodeAs("copy-assignment")) { nit: CopyAssignment http://reviews.llvm.org/D18961 _

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

rengolin added a subscriber: rengolin. rengolin added a comment. En passant comment: I really wish we wouldn't. The C++ standard had some very careful considerations on VLAs and decided *not* to support. It wasn't for lack of interest, it was a well informed decision. Comment

Re: r259734 - Fix predefine for __NSConstantString struct type

If used only for Darwin, could this depend on Target.getTriple().isOSDarwin() ? 2016-04-11 17:18 GMT+03:00 Ben Langmuir : > > On Apr 3, 2016, at 10:57 AM, Yaron Keren wrote: > > I look at many AST dumps for small reduced code so it's mostly weird to > see this in the AST (and takes a bit of scr

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

DmitryPolukhin added inline comments. Comment at: llvm/tools/clang/test/SemaCXX/c99-variable-length-array.cpp:1 @@ -1,1 +1,2 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -Wvla-extension %s +// RUN: %clang_cc1 -fsyntax-only -std=c++98 -DCPP98 -verify -Wvla-extension %s +// RUN: %cl

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

aaron.ballman added reviewers: rsmith, doug.gregor. aaron.ballman added a comment. Adding a few more reviewers. Is there a major use case driving this patch, or is this just for GCC compatibility? Personally, I would prefer to avoid adding VLA support to C++ unless there's a good motivating use

Re: r265201 - [Objective-C] Introduce objc_runtime_visible attribute.

On Fri, Apr 1, 2016 at 7:23 PM, Douglas Gregor via cfe-commits wrote: > Author: dgregor > Date: Fri Apr 1 18:23:52 2016 > New Revision: 265201 Sorry about the long delay before getting you this feedback (been a bit hectic around here). One request: can you add some Sema tests that the attribute

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

DmitryPolukhin added a comment. The patch itself looks good to me but the main question do we want to support VLA in C++ in GNU extension mode. http://reviews.llvm.org/D18823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D15032: [clang-tidy] new checker cppcoreguidelines-pro-lifetime

aaron.ballman added a comment. Thank you for working on this! A few initial nits (I don't have the chance to complete the review yet, but wanted to get you some early feedback). Comment at: clang-tidy/cppcoreguidelines/ProLifetimeCheck.cpp:34-35 @@ +33,4 @@ + + Finder->addMatc

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

sbaranga added inline comments. Comment at: lib/Basic/Targets.cpp:4931 @@ -4931,1 +4930,3 @@ +if (ArchVersion >= 7 && (CPUProfile != "M" || CPUAttr == "7EM") && +(FPU & VFP4FPU)) Builder.defineMacro("__ARM_FEATURE_FMA", "1"); rengolin wrote: > I

Re: r259734 - Fix predefine for __NSConstantString struct type

> On Apr 3, 2016, at 10:57 AM, Yaron Keren wrote: > > I look at many AST dumps for small reduced code so it's mostly weird to see > this in the AST (and takes a bit of screen real estate) as it's not something > that originated in the code. > By now I'm used to ignoring it but would expect NS

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

alexfh added inline comments. Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:26 @@ +25,3 @@ +void DeletedDefaultCheck::registerMatchers(MatchFinder *Finder) { + const auto NotTemplate = unless(hasAncestor( + cxxRecordDecl(::clang::ast_matchers::isTemplateInstant

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:157 @@ +156,3 @@ +// Convenience utility to get a RecordDecl from a QualType. +const RecordDecl *getRecordDecl(const QualType &Type) { + if (const auto *RT = Type.getCanonical

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

rengolin added a reviewer: rengolin. Comment at: lib/Basic/Targets.cpp:4931 @@ -4931,1 +4930,3 @@ +if (ArchVersion >= 7 && (CPUProfile != "M" || CPUAttr == "7EM") && +(FPU & VFP4FPU)) Builder.defineMacro("__ARM_FEATURE_FMA", "1"); I think just t

  1   2   >