pxli168 updated this revision to Diff 51629.
pxli168 added a comment.
Add test for correct case.
http://reviews.llvm.org/D17955
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
Index: test/SemaOpenCL/invalid-pipe-bu
faisalv updated this revision to Diff 51627.
faisalv added a comment.
An updated patch that incorporates Richard's feedback.
Thanks!
http://reviews.llvm.org/D14905
Files:
include/clang/Basic/DiagnosticASTKinds.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Sema/Sema.h
lib/
faisalv marked 8 inline comments as done.
faisalv added a comment.
Thanks for the review - will submit a updated patch with recommended changes,
shortly.
http://reviews.llvm.org/D14905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: rsmith
Date: Thu Mar 24 20:17:43 2016
New Revision: 264377
URL: http://llvm.org/viewvc/llvm-project?rev=264377&view=rev
Log:
[modules] Store a local offset to DeclContext lexical and visible contents.
Saves a few bytes for each primary DeclContext.
Modified:
cfe/trunk/lib/Serializati
jlebar added a comment.
In http://reviews.llvm.org/D18458#383266, @rsmith wrote:
> This makes the "`constexpr` implies `__host__` `__device__`" patch look
> slightly questionable: two translation units defining the same `constexpr`
> function will mangle that function differently depending on w
Author: dexonsmith
Date: Thu Mar 24 19:38:14 2016
New Revision: 264372
URL: http://llvm.org/viewvc/llvm-project?rev=264372&view=rev
Log:
CGLoopInfo: Use the MD_loop metadata kind from r264371, NFC
Besides a small compile-time speedup, there should be no real
functionality change here.
Modified:
rsmith added a comment.
This makes the "`constexpr` implies `__host__` `__device__`" patch look
slightly questionable: two translation units defining the same `constexpr`
function will mangle that function differently depending on whether the
translation unit is built with CUDA support enabled.
Great, thanks!
On Thu, Mar 24, 2016, 5:26 PM Adrian Prantl wrote:
> I added a testcase that demonstrates the problem with this commit in
> r264366.
>
> -- adrian
> > On Feb 23, 2016, at 11:07 AM, Eric Christopher
> wrote:
> >
> > Thanks Adrian!
> >
> > On Tue, Feb 23, 2016 at 9:19 AM Adrian Pra
Author: chapuni
Date: Thu Mar 24 19:24:35 2016
New Revision: 264367
URL: http://llvm.org/viewvc/llvm-project?rev=264367&view=rev
Log:
3rd attempt of fixup with -std=c++11
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-redundant-string-cstr.cpp
Modified:
clang-tools-extra/tru
I added a testcase that demonstrates the problem with this commit in r264366.
-- adrian
> On Feb 23, 2016, at 11:07 AM, Eric Christopher wrote:
>
> Thanks Adrian!
>
> On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote:
> --> r261657.
>
> Author: adrian
> Date: Tue Feb 23 17:13:47 2016 +00
Author: adrian
Date: Thu Mar 24 19:20:35 2016
New Revision: 264366
URL: http://llvm.org/viewvc/llvm-project?rev=264366&view=rev
Log:
Debug Info: Add a testcase for the bug introduced by r259975.
In r259975 we rauw'ed the scope of enum declarations without taking into
account that DIBuilder strips
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D5041
___
cfe-commits mailing list
cfe-commits@l
Author: chapuni
Date: Thu Mar 24 19:16:13 2016
New Revision: 264365
URL: http://llvm.org/viewvc/llvm-project?rev=264365&view=rev
Log:
Fixup -- "-target x86_64-unknown -fno-ms-compatibility" didn't work as expected.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-redundant-strin
Author: rsmith
Date: Thu Mar 24 19:08:53 2016
New Revision: 264363
URL: http://llvm.org/viewvc/llvm-project?rev=264363&view=rev
Log:
Fix nondeterminism in computation of builtin operator overload sets.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
cfe/trunk/test/SemaCXX/diagnostic-order.c
Author: chapuni
Date: Thu Mar 24 19:05:33 2016
New Revision: 264362
URL: http://llvm.org/viewvc/llvm-project?rev=264362&view=rev
Log:
clang-tools-extra/test/clang-tidy/readability-redundant-string-cstr.cpp:
Appease MS targets with -fno-ms-compatibility.
FIXME: Add a test with -fms-compatibility
milianw added a comment.
+1 from my side, but someone else has to approve.
http://reviews.llvm.org/D5041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Mar 24 18:41:14 2016
New Revision: 264359
URL: http://llvm.org/viewvc/llvm-project?rev=264359&view=rev
Log:
[modules] Store offset to LOCAL_REDECLARATIONS record relative to the current
record rather than relative to the start of the bitcode file. Saves a couple of
bytes p
rjmccall added a comment.
Oh, you know, this should really propagate all the dependence bits, not just
instantiation-dependence. It would be safer, at least. You could probably
find a contrived example involving value-dependence.
http://reviews.llvm.org/D18461
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D18461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb updated this revision to Diff 51607.
jfb added a comment.
Herald added a subscriber: jfb.
- Check feature test macro exists
http://reviews.llvm.org/D17951
Files:
include/atomic
test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
Index: test/std/atomics/atomics.lockfree/isalways
Hi Alexey,
It will help to have a reproducer that fail without assertions.
If I remove the assertion, the test failed in clang self-build will pass.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/11281
Thanks,
Amjad
From: Alexey Samsonov [mailto:vonos...@gmail.com]
Sen
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D17951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264342: Attach profile summary information to Module.
(authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D18289?vs=51342&id=51604#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: eraman
Date: Thu Mar 24 16:32:25 2016
New Revision: 264342
URL: http://llvm.org/viewvc/llvm-project?rev=264342&view=rev
Log:
Attach profile summary information to Module.
Differential Revision: http://reviews.llvm.org/D18289
Added:
cfe/trunk/test/Profile/Inputs/profile-summary.prof
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
Please rebase against trunk. I'm surprised that no tests need updating due to
this. Can you add some, please?
Comment at: lib/Basic/Targets.cpp:387
@@ +386,3 @@
+
I've been using no-asserts build, and it led to segfault, so probably it
was required. I see that Reid already proceeded with the revert. I will
still work on a reproducer.
On Thu, Mar 24, 2016 at 1:43 PM, Aboud, Amjad wrote:
> I believe it is safe to disable the assertion.
>
> I added this asse
I believe it is safe to disable the assertion.
I added this assertion...I am trying to figure out why we are hitting it.
I am not convinced that we should do a total revert.
Regards,
Amjad
From: Alexey Samsonov [mailto:vonos...@gmail.com]
Sent: Thursday, March 24, 2016 22:27
To: Aboud, Amjad
Cc
Author: rnk
Date: Thu Mar 24 15:38:43 2016
New Revision: 264333
URL: http://llvm.org/viewvc/llvm-project?rev=264333&view=rev
Log:
Revert "Recommitted r263425 "Supporting all entities declared in lexical scope
in LLVM debug info." After fixing PR26942 (the fix is included in this commit)."
This r
manmanren created this revision.
manmanren added reviewers: rsmith, rjmccall.
manmanren added a subscriber: cfe-commits.
Instantiation dependence were not being handled correctly for OpqaueValueExpr
AST nodes. As a result, if an undeclared identifier was used in a CXXNewExpr
that is assigned to a
fowles updated this revision to Diff 51596.
fowles marked 5 inline comments as done.
fowles added a comment.
- review comments
http://reviews.llvm.org/D18408
Files:
clang-tidy/readability/AvoidConstParamsInDecls.cpp
clang-tidy/readability/AvoidConstParamsInDecls.h
clang-tidy/readability/C
davidxl accepted this revision.
davidxl added a reviewer: davidxl.
davidxl added a comment.
lgtm
http://reviews.llvm.org/D18289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
This lgtm.
IMO we'd get the same coverage if the C file contained `void foo() {}`, but
that's just a nit :). It'd be good to follow up with David about what he thinks
is lacking in `general.proftex
eraman added a comment.
Since test case tests this change - that profile summary is attached to the
module - I think it is sufficient. David and Vedant, does this sound reasonable?
http://reviews.llvm.org/D18289
___
cfe-commits mailing list
cfe-com
Heads-up: I see segmentation faults in Clang following this revision. I
will try to come up with a standalone reproducer and update
https://llvm.org/bugs/show_bug.cgi?id=26942, possibly reverting this change.
On Thu, Mar 24, 2016 at 6:30 AM, Amjad Aboud via cfe-commits <
cfe-commits@lists.llvm.org
Hi Jean-Philippe,
first off, sorry that this is causing you trouble.
I am always happy to reconsider. However, I do think that this is a good
change based on hundreds of examples I have looked at. Obviously, this is
subjective and I won't even start to make an argument on whether this is
wasted o
bruno added a comment.
Ping!
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D18304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar marked an inline comment as done.
jlebar added a comment.
Okay, just one more patch, http://reviews.llvm.org/D18458, then I think we're
good here. (This is split up into two patches in my queue.)
Thanks for your help, Richard.
http://reviews.llvm.org/D18380
_
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added subscribers: tra, cfe-commits.
This is important because in a later patch, we will allow __host__
__device__ functions to be overloaded with __host__ / __device__
functions with the same signature, and we don't want a nami
jlebar marked 2 inline comments as done.
Comment at: include/clang/Basic/LangOptions.def:175
@@ -174,2 +174,3 @@
LANGOPT(CUDAAllowVariadicFunctions, 1, 0, "Allow variadic functions in CUDA
device code")
+LANGOPT(CUDAHostDeviceConstexpr, 1, 1, "Treat unattributed constexpr functi
Author: etienneb
Date: Thu Mar 24 14:42:36 2016
New Revision: 264325
URL: http://llvm.org/viewvc/llvm-project?rev=264325&view=rev
Log:
[clang-tidy] Add support for different char-types for the
readability-redundant-string-cstr checker.
Summary:
The current checker is able to recognize std::strin
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG now. Thanks!
http://reviews.llvm.org/D18412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
etienneb marked an inline comment as done.
etienneb added a comment.
Tests are fine. PTAnL?
Comment at: clang-tidy/readability/RedundantStringCStrCheck.cpp:103
@@ +102,3 @@
+callee(memberExpr().bind("member")),
+callee(cxxMethodDec
etienneb updated this revision to Diff 51585.
etienneb added a comment.
fix hasName.
http://reviews.llvm.org/D18412
Files:
clang-tidy/readability/RedundantStringCStrCheck.cpp
test/clang-tidy/readability-redundant-string-cstr.cpp
Index: test/clang-tidy/readability-redundant-string-cstr.cpp
etienneb updated this revision to Diff 51584.
etienneb added a comment.
update comment.
http://reviews.llvm.org/D18457
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousMissingCommaCheck.cpp
clang-tidy/misc/SuspiciousMissingCommaCheck.h
Author: rsmith
Date: Thu Mar 24 14:12:22 2016
New Revision: 264323
URL: http://llvm.org/viewvc/llvm-project?rev=264323&view=rev
Log:
Change ADL to produce lookup results in a deterministic order. This fixes some
rare issues with nondeterministic diagnostic order, and some very common issues
with n
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This checker is able to detect missing comma in
an array of string literals.
```
const char* A[] = {
"abc",
"def" // missing comma (no compiler warnings)
"ghi",
};
```
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
OK, if you're not blocked on this, let's just wait then.
http://reviews.llvm.org/D17981
___
cfe-commits mailing list
cfe-commits@lists.
pcc updated this revision to Diff 51580.
pcc added a comment.
- Compute a correct byte offset for struct vtable bitsets
http://reviews.llvm.org/D18199
Files:
docs/UsersManual.rst
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CGVTables.h
li
On Thu, Mar 24, 2016 at 11:29 AM, Aaron Ballman wrote:
> On Thu, Mar 24, 2016 at 12:23 PM, David Majnemer
> wrote:
>>
>>
>> On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman
>> wrote:
>>>
>>> On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote:
>>> > On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballma
alexfh added inline comments.
Comment at: clang-tidy/readability/RedundantStringCStrCheck.cpp:103
@@ +102,3 @@
+callee(memberExpr().bind("member")),
+callee(cxxMethodDecl(matchesName(StringCStrMethod
+ .bind("call");
---
Author: etienneb
Date: Thu Mar 24 13:29:24 2016
New Revision: 264315
URL: http://llvm.org/viewvc/llvm-project?rev=264315&view=rev
Log:
Fix a missing comma between two string literals.
Summary:
The two literals are currently appended.
I'm not sure what was broken by this. Please double check care
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, I'd go ahead and land this. I cc'd Matt Arsenault. He works on AMD GPU
stuff.
http://reviews.llvm.org/D18454
___
cfe-commits mailing list
cfe-co
On Thu, Mar 24, 2016 at 12:23 PM, David Majnemer
wrote:
>
>
> On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman
> wrote:
>>
>> On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote:
>> > On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman
>> > wrote:
>> >>
>> >> That was what I meant by "justification"
etienneb created this revision.
etienneb added reviewers: alexfh, rnk.
etienneb added a subscriber: cfe-commits.
The two literals are currently appended.
I'm not sure what was broken by this. Please double check carefully.
Silly bug found by an on-going checker for clang-tidy.
http://reviews.ll
korli added a comment.
Yes, I don't have commit access.
Repository:
rL LLVM
http://reviews.llvm.org/D16797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Do you need someone to commit this for you?
Repository:
rL LLVM
http://reviews.llvm.org/D16797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
The change to allow `__host__ __device__` functions to be overloaded with other
combinations of target attributes appears to be separable from the `constexpr`
change; please split it out and commit it first.
korli updated this revision to Diff 51571.
korli added a comment.
This updated diff fixes the x86-32 Haiku target, which needs the target define
__INTEL__.
This applies directly to today's trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D16797
Files:
lib/Basic/Targets.cpp
lib/Driver/
On Thu, Mar 24, 2016 at 9:23 AM, David Majnemer
wrote:
>
>
> On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman
> wrote:
>>
>> On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote:
>> > On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman
>> > wrote:
>> >>
>> >> That was what I meant by "justification".
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli added a comment.
Hi
Thinking more carefully, I believe you are right - no, it is not. I guess we
would not call at all shouldEmitInlinedTeamsDirective for the case of paralle.
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D18286
_
Hahnfeld added a comment.
In http://reviews.llvm.org/D18286#382698, @carlo.bertolli wrote:
> Hi Jonas
>
> Thanks for your comment. That scheme would not work for #parallel on the gpu
> in case we do not want to inline the parallel region.
> There are patches coming in which that is going to hap
jlebar added a comment.
Richard, are you happy here?
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli added a comment.
Hi Jonas
Thanks for your comment. That scheme would not work for #parallel on the gpu in
case we do not want to inline the parallel region.
There are patches coming in which that is going to happen so I think that we
really need to distinguish between different p
sberg added a comment.
Can you please push this, I do not have commit access. Thanks
http://reviews.llvm.org/D18430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
ping
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman
wrote:
> On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote:
> > On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman
> > wrote:
> >>
> >> That was what I meant by "justification". I would say it has to be
> >> reasonably compelling code (win32 header
On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote:
> On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman
> wrote:
>>
>> That was what I meant by "justification". I would say it has to be
>> reasonably compelling code (win32 headers, boost, some other major
>> library) as that's our usual bar for t
On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman
wrote:
> That was what I meant by "justification". I would say it has to be
> reasonably compelling code (win32 headers, boost, some other major
> library) as that's our usual bar for these sort of bug-for-bug
> compatible things, as I understand it.
Fair enough - 'preciate your perspectives/further details.
On Thu, Mar 24, 2016 at 8:44 AM, Hal Finkel wrote:
>
> --
>
> *From: *"Reid Kleckner via cfe-commits"
> *To: *"David Blaikie"
> *Cc: *"cfe-commits"
> *Sent: *Thursday, March 24, 2016 10:39:18 AM
> *Subject:
- Original Message -
> From: "Reid Kleckner via cfe-commits"
> To: "David Blaikie"
> Cc: "cfe-commits"
> Sent: Thursday, March 24, 2016 10:39:18 AM
> Subject: Re: r264205 - [CUDA] Don't define __NVCC__.
> On Thu, Mar 24, 2016 at 8:30 AM, David Blaikie via cfe-commits <
> cfe-commits@li
On Thu, Mar 24, 2016 at 8:30 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> This seems like a different tradeoff from the one Clang made for GCC
> compatibility (we define all the GCC macros, but then also define others so
> people can detect Clang). If people were just
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D18430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Mar 23, 2016 at 3:42 PM, Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jlebar
> Date: Wed Mar 23 17:42:27 2016
> New Revision: 264205
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264205&view=rev
> Log:
> [CUDA] Don't define __NVCC__.
>
> Summary:
> We deci
etienneb updated this revision to Diff 51559.
etienneb added a comment.
remove dead-code
http://reviews.llvm.org/D18412
Files:
clang-tidy/readability/RedundantStringCStrCheck.cpp
test/clang-tidy/readability-redundant-string-cstr.cpp
Index: test/clang-tidy/readability-redundant-string-cstr.
alexfh added inline comments.
Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:67
@@ -66,3 +66,3 @@
auto UsedByRef = [&] {
return !ast_matchers::match(
decl(hasDescendant(
It looks like the two-parameter ast_matchers::match function w
etienneb updated this revision to Diff 51558.
etienneb added a comment.
Change name/decl matchers to 'basic_string'.
http://reviews.llvm.org/D18412
Files:
clang-tidy/readability/RedundantStringCStrCheck.cpp
test/clang-tidy/readability-redundant-string-cstr.cpp
Index: test/clang-tidy/readab
alexfh added inline comments.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:116
@@ +115,3 @@
+
+ if (RelativeIntSizes.find(First) != RelativeIntSizes.end() &&
+ RelativeIntSizes.find(Second) != RelativeIntSizes.end()) {
This code shouldn't repea
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
I would add the module together with the first check in it, since an empty
module doesn't make sense.
http://reviews.llvm.org/D18274
_
Author: ioeric
Date: Thu Mar 24 09:59:39 2016
New Revision: 264289
URL: http://llvm.org/viewvc/llvm-project?rev=264289&view=rev
Log:
Dsiable FormatStyle::GetStyleOfFile test case for mingw.
Modified:
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/unittests/Format/FormatTest.cp
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you!
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:26
@@ +25,3 @@
+ return (Name.empty() ? llvm::Twine('#') + llvm::Twine(Index + 1)
+
alexfh added a comment.
Looks good in general. A few nits.
Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:22
@@ +21,3 @@
+
+SourceRange GetTypeRange(const ParmVarDecl &Param) {
+ if (Param.getIdentifier() != nullptr)
"Function names ... should b
baloghadamsoftware updated this revision to Diff 51554.
baloghadamsoftware added a comment.
Merged into misc-assign-operator-signature and thus renamed to
misc-assign-operator
http://reviews.llvm.org/D18265
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/misc
etienneb added a comment.
In http://reviews.llvm.org/D17981#382478, @alexfh wrote:
> ... and who is unavailable for the next couple of weeks, unfortunately. To
> unblock you, I'd suggest the following solution for now:
>
> 1. move this code to clang/lib/Tooling
> 2. gate the code and its depende
I am looking into it now.
On Thu, Mar 24, 2016 at 2:39 PM Nico Weber wrote:
> Won't this still be broken in mingw (GCC, but on Windows)?
> On Mar 24, 2016 9:28 AM, "Eric Liu via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ioeric
>> Date: Thu Mar 24 08:22:42 2016
>> New Revisi
Won't this still be broken in mingw (GCC, but on Windows)?
On Mar 24, 2016 9:28 AM, "Eric Liu via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Thu Mar 24 08:22:42 2016
> New Revision: 264277
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264277&view=rev
> Log:
> Add
Author: aaboud
Date: Thu Mar 24 08:30:41 2016
New Revision: 264281
URL: http://llvm.org/viewvc/llvm-project?rev=264281&view=rev
Log:
Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM
debug info."
After fixing PR26942 (the fix is included in this commit).
Differential
Author: ioeric
Date: Thu Mar 24 08:22:28 2016
New Revision: 264275
URL: http://llvm.org/viewvc/llvm-project?rev=264275&view=rev
Log:
Revert "removed redundant comment in format::getStyle."
This reverts commit r264254.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/
Author: ioeric
Date: Thu Mar 24 08:22:42 2016
New Revision: 264277
URL: http://llvm.org/viewvc/llvm-project?rev=264277&view=rev
Log:
Added support for different VFSs in format::getStyle. Disable platform-related
test case for MS compilers to avoid breaking buildbot.
Modified:
cfe/trunk/inclu
Author: ioeric
Date: Thu Mar 24 08:22:37 2016
New Revision: 264276
URL: http://llvm.org/viewvc/llvm-project?rev=264276&view=rev
Log:
Revert "Added support for different VFSs in format::getStyle."
This reverts commit r264253. It is breaking the buildbot
http://lab.llvm.org:8011/builders/llvm-clan
alexfh added a comment.
In http://reviews.llvm.org/D17981#382213, @etienneb wrote:
> In http://reviews.llvm.org/D17981#380350, @alexfh wrote:
>
> > Adding Manuel, who might have better ideas.
>
... and who is unavailable for the next couple of weeks, unfortunately. To
unblock you, I'd suggest
Author: aaronballman
Date: Thu Mar 24 07:34:44 2016
New Revision: 264263
URL: http://llvm.org/viewvc/llvm-project?rev=264263&view=rev
Log:
Fix Sphinx errors with documentation build.
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
http://
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3074-3078
@@ +3073,7 @@
+
+ if (getLangOpts().OpenMPIsDevice && (
+ CGM.getTarget().getTriple().getArch() == llvm::Triple::nvptx ||
+ CGM.getTarget().getTriple().getArch() == llvm::Triple::nvptx64)
Author: ioeric
Date: Thu Mar 24 06:25:28 2016
New Revision: 264257
URL: http://llvm.org/viewvc/llvm-project?rev=264257&view=rev
Log:
Revert "Added support for different VFSs in format::getStyle."
This reverts commit r264253. It is breaking the buildbot
http://lab.llvm.org:8011/builders/llvm-clan
Author: ioeric
Date: Thu Mar 24 06:24:49 2016
New Revision: 264256
URL: http://llvm.org/viewvc/llvm-project?rev=264256&view=rev
Log:
Revert "removed redundant comment in format::getStyle."
This reverts commit r264254.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/
ioeric added a comment.
@Daniel, now that Manuel is on vacation. Could you have a look at the patch?
Comment at: unittests/Tooling/RefactoringTest.cpp:206
@@ -169,3 +205,3 @@
TEST(ShiftedCodePositionTest, FindsNewCodePosition) {
Replacements Replaces;
Replaces.insert(Repl
Author: ioeric
Date: Thu Mar 24 05:50:26 2016
New Revision: 264254
URL: http://llvm.org/viewvc/llvm-project?rev=264254&view=rev
Log:
removed redundant comment in format::getStyle.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http://llvm.org/viewvc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264253: Added support for different VFSs in
format::getStyle. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D18399?vs=51440&id=51534#toc
Repository:
rL LLVM
http://reviews.l
Author: ioeric
Date: Thu Mar 24 05:50:17 2016
New Revision: 264253
URL: http://llvm.org/viewvc/llvm-project?rev=264253&view=rev
Log:
Added support for different VFSs in format::getStyle.
Summary:
Previously, format::getStyle assumes that the given file resides in
the real file system, which preve
1 - 100 of 111 matches
Mail list logo
