pcc updated this revision to Diff 51061.
pcc added a comment.
- Use a vindex of 0 for non-virtuals
http://reviews.llvm.org/D18199
Files:
docs/UsersManual.rst
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CGVTables.h
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/Itani
sfantao added a comment.
Hi Alexey,
I am sorry but I don't think I am following. So in your example:
#pragma omp target map(to: this->A)
[]()->void {++A}();
the map clause is going to make sure the runtime library allocates the section
of `this` that contains A and that is what is used in
rjmccall added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943
@@ +4934,11 @@
+
+ bool HasStableAttr = Record->hasAttr();
+ bool HasUnstableAttr = Record->hasAttr();
+ if (HasStableAttr && HasUnstableAttr) {
+Diag(Record->getLocation(), diag::err_abi_mismatc
2016-03-18 0:35 GMT+06:00 Arthur O'Dwyer :
> I'm not qualified to comment on the implementation, but I'm a bit
> skeptical that this warning is appropriate in the first place. I've often
> declared friend non-template functions, e.g. swap(). I've never intended to
> declare a friend *template spec
jlebar added a comment.
Abandoning this for now -- it is a maze of twisty passages all alike. Some std
math functions are constexpr, and making them host+device affects all our
existing math overloads in fun and exciting ways.
We may need this at some point, but for now I'm going to try someth
EricWF added a comment.
In http://reviews.llvm.org/D17951#376546, @bcraig wrote:
> Visual Studio has a flag, /Zc:wchar_t-, that turns wchar_t into a short.
> This flag is for people that need to maintain ABI compatibility with ancient
> Visual Studios (MSVC6? MSVC5?). It is definitely non-con
joker.eph added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4999
@@ +4998,3 @@
+return;
+ }
+
pcc wrote:
> joker.eph wrote:
> > joker.eph wrote:
> > > Isn't this correct by the loop which starts with `DC =
> > > InnermostExternalDC`?
> > `s/correct
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
I think will be reasonable to merge misc-assign-operator-return and
misc-assign-operator-signature into one check.
http://reviews.llvm.org/D18265
___
cfe-commits mai
rsmith added a comment.
Are you planning on extending this to also cover templated functions?
Comment at: include/clang/Basic/DiagnosticGroups.td:78
@@ -77,2 +77,3 @@
DiagGroup<"gnu-string-literal-operator-template">;
+def UnavailableTemplate : DiagGroup<"unavailable-template
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
sfantao added a comment.
Hi Alexey,
I am afraid I don't understand what you are trying to accomplish with this. I
was unable to compile your patch as is, I think what you intended is something
like this:
// If we are mapping a field of 'this' we attempt to generate a
// OMPCapturedExprDec
> On 2016-Mar-16, at 12:31, Duncan P. N. Exon Smith
> wrote:
>
>>
>> On 2016-Mar-16, at 12:20, Eric Fiselier wrote:
>>
>> EricWF added a comment.
>>
>> Adding inline comments for the implementation. Comments on the tests to
>> follow shortly.
>>
>>
>>
>> Comment at: incl
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: cbertol
Date: Wed Mar 16 14:04:22 2016
New Revision: 263654
URL: http://llvm.org/viewvc/llvm-project?rev=263654&view=rev
Log:
[OPENMP] Support for codegen of private clause of target, host side
This patch adds support for codegen of private clause of target and a
regression test for host
EricWF added a comment.
Adding inline comments for the implementation. Comments on the tests to follow
shortly.
Comment at: include/__hash_table:103
@@ -102,1 +102,3 @@
+template
+struct __extract_key;
Could you make `__extract_key` behave the same way as `_
mspertus updated this revision to Diff 50820.
mspertus added a comment.
Added reference types and a more accurate AttributedType enum. I am working on
additional items for the future (class members, function types, etc.) but those
will take longer, and I think it is worthwhile to get this revisi
aaron.ballman added a comment.
Mostly LGTM with one question about a comment.
Comment at: clang.natvis:77
@@ +76,3 @@
+
+
+
The only hard-wiring I see uses 3 bits, so is this comment still accurate?
http://reviews.llvm.org/D18261
_
pirama added a comment.
Thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D18138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added inline comments.
Comment at: include/atomic:859
@@ +858,3 @@
+template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 ==
ATOMIC_CHAR32_T_LOCK_FREE;
+template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 ==
ATOMIC_WCHAR_T_LOCK_FREE;
+template <> _
flx created this revision.
flx added reviewers: alexfh, JVApen.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
This fixes bug https://llvm.org/bugs/show_bug.cgi?id=26747
Repository:
rL LLVM
http://reviews.llvm.org/D18300
Files:
clang-tidy/cppcoregu
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
This change shows members of `DeclContext` objects in the Visual Studio
debugger. It will also cast a `TagType` like a class or a struct to a
`DeclContext`, so its methods
eraman created this revision.
eraman added a reviewer: vsk.
eraman added subscribers: cfe-commits, davidxl.
This allows optimization passes to make use of detailed profile summary. Once
this is in and the optimization passes are made to use this, the
"MaxFunctionCount" flag will be removed as th
jfb updated this revision to Diff 50903.
jfb added a comment.
- Size is based on __a_ not _Tp
- Check value is consistent with C macros
http://reviews.llvm.org/D17951
Files:
include/atomic
test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
test/std/atomics/atomics.lockfree/lockfr
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
OK, though I'm hoping either there aren't many more of these cases or we can
treat them more generally somehow.
Comment at: lib/Sema/SemaCast.cpp:1771-1782
@@ +1770,14 @@
+
+
pcc added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4999
@@ +4998,3 @@
+return;
+ }
+
joker.eph wrote:
> joker.eph wrote:
> > Isn't this correct by the loop which starts with `DC = InnermostExternalDC`?
> `s/correct/already covered/`
That loop che
LegalizeAdulthood added a subscriber: LegalizeAdulthood.
LegalizeAdulthood added a comment.
There is utility in the definition of a function in saying that an argument is
`const int i` instead of `int i`. The const-ness declares the intent that this
local variable is not going to be modified.
pcc added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1153
@@ -1152,3 +1152,3 @@
unsigned Virtuality = 0;
- unsigned VIndex = 0;
+ unsigned VIndex = -1u;
rsmith wrote:
> Is this what debug info consumers expect for the non-virtual case?
The deb
Author: bruno
Date: Sat Mar 19 21:08:48 2016
New Revision: 263893
URL: http://llvm.org/viewvc/llvm-project?rev=263893&view=rev
Log:
Reapply [2] [VFS] Add 'overlay-relative' field to YAML files
This reapplies r261552 and r263748. Fixed testcase to reapply.
The VFS overlay mapping between virtual
rsmith added a comment.
I would prefer that we solve this problem generically for all files that Clang
tries to open, not just for module map files. (Note, for instance, that PR20468
concerns files referenced by module map files, such as their nominated headers,
not the module map files themsel
pcc added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943
@@ +4934,11 @@
+
+ bool HasStableAttr = Record->hasAttr();
+ bool HasUnstableAttr = Record->hasAttr();
+ if (HasStableAttr && HasUnstableAttr) {
+Diag(Record->getLocation(), diag::err_abi_mismatch) <<
ahatanak added a comment.
I can add another RUN line to test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp
that is identical to the existing RUN line except that it has "-O3
-disable-llvm-optzns". I confirmed that the test still passes without any
changes to the test itself.
Is that what you are lo
carlo.bertolli updated this revision to Diff 50845.
carlo.bertolli added a comment.
Update against trunk as dependence was committed to trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D18203
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGOpenMPRuntime.cpp
lib/Sema/S
etienneb added a subscriber: etienneb.
etienneb added a comment.
drive-by, some comments.
Comment at: clang-tidy/misc/ConstRefBuiltinCheck.cpp:51
@@ +50,3 @@
+ << Parameter->getFunctionScopeIndex()
+ << Function->getName()
+ << Fix;
Function is de
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
Whenever possible, use C++ names for visualizing builtin types. E.g., `long
double` instead of `LongDouble`
Committed as revision 263891 for post-commit review
h
Author: mps
Date: Sat Mar 19 19:32:30 2016
New Revision: 263891
URL: http://llvm.org/viewvc/llvm-project?rev=263891&view=rev
Log:
Better visualization of clang::BuiltinType in VisualStudio
Whenever possible, use C++ names for visualizing builtin types. E.g., "long
double" instead of "LongDouble"
mspertus added a comment.
Based on Aaron's agreement to conducting post-commit reviews, I've committed
this as revision 263890. Please let me know if I should not have done so. (This
change is a lot smaller and simpler than I feared when I commented on my
roadmap in diff http://reviews.llvm.org
Author: mps
Date: Sat Mar 19 19:20:43 2016
New Revision: 263890
URL: http://llvm.org/viewvc/llvm-project?rev=263890&view=rev
Log:
Visual Studio Visualizer for clang::FunctionProtoType
Displays return type and parameters for the Function Protoype object in the
Locals window.
Modified:
cfe/tr
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: alexfh, hokein.
baloghadamsoftware added subscribers: cfe-commits, xazax.hun.
The return value of every assign operator should be Type&, not only for copy
and move assign operators. This check and its test was implement
etienneb added inline comments.
Comment at: ClangTidy.cpp:144
@@ -138,1 +143,3 @@
+
+Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText());
++TotalFixes;
alexfh wrote:
> aaron.ballman wrote:
> > Is there a purpose to emittin
rsmith added a comment.
Once this lands, we should also consider the corresponding case from a
//fold-expression//:
template bool f(T ...t) { return (t < ...); } // warn if
sizeof...(T) != 2 and we use built-in operator <.
bool k = f(1.0, 2.0, 3.0);
http://reviews.llvm.org/D13643
_
ABataev added a comment.
Samuel, I have a patch that improves handling of map clauses with data members.
Unfortunately, I cannot commit it because I can't create tests for it. Please,
apply this patch to your map clause codegen changes. It uses common technique
for handling non-static data memb
rsmith added inline comments.
Comment at: test/clang-tidy/readability-non-const-parameter.cpp:116-134
@@ +115,21 @@
+
+// CHECK-MESSAGES: :[[@LINE+1]]:18: warning: parameter 'p' can be const
+int return1(int *p) {
+ // CHECK-FIXES: {{^}}int return1(const int *p) {{{$}}
+ return
pcc added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8380
@@ +8379,3 @@
+def warn_unused_abi_stability_attr : Warning<
+ "unused C++ ABI stability attribute on non-dynamic class">,
+ InGroup>;
rsmith wrote:
> How valuable is it to wa
Hahnfeld created this revision.
Hahnfeld added reviewers: ABataev, hfinkel, carlo.bertolli, sfantao.
Hahnfeld added a subscriber: cfe-commits.
Pointer dereference is equal to access of first array element which is already
allowed for the `reduction` clause.
While at it also add test for CodeGen
LegalizeAdulthood added inline comments.
Comment at: docs/clang-tidy/checks/list.rst:91
@@ -90,2 +90,3 @@
performance-implicit-cast-in-loop
+ performance-unnecessary-copy-initialization.rst
readability-braces-around-statements
This check was missing from
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 263837.
Repository:
rL LLVM
http://reviews.llvm.org/D18203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
LegalizeAdulthood created this revision.
LegalizeAdulthood added a reviewer: alexfh.
LegalizeAdulthood added a subscriber: cfe-commits.
Add a file for Extra Clang Tools release notes, based on 3.9 release notes file
for Clang.
http://reviews.llvm.org/D18263
Files:
docs/ReleaseNotes.rst
docs
LegalizeAdulthood updated this revision to Diff 51013.
LegalizeAdulthood added a comment.
Sort check names in list
http://reviews.llvm.org/D18263
Files:
docs/ReleaseNotes.rst
docs/clang-tidy/checks/list.rst
docs/index.rst
Index: docs/index.rst
rnk created this revision.
rnk added reviewers: rsmith, rtrieu.
rnk added a subscriber: cfe-commits.
Emit a new warning if such parameters are modified in the body of the
constructor.
Fixes PR16088.
http://reviews.llvm.org/D18271
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/Se
kzhuravl-AMD created this revision.
kzhuravl-AMD added a reviewer: tstellarAMD.
kzhuravl-AMD added a subscriber: cfe-commits.
http://reviews.llvm.org/D18253
Files:
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/amdgpu-toolchain.c
Index: test/Driver/amdgpu-toolchain.c
=
pcc updated this revision to Diff 50905.
pcc added a comment.
- Do not set virtual index in debug info for relative-ABI virtual functions
http://reviews.llvm.org/D18199
Files:
docs/UsersManual.rst
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CGVTables.h
lib/CodeGe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263766: Remove usage of LLVM_PREFIX. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D17784?vs=50993&id=50994#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17784
Files:
pcc added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943
@@ +4934,11 @@
+
+ bool HasStableAttr = Record->hasAttr();
+ bool HasUnstableAttr = Record->hasAttr();
+ if (HasStableAttr && HasUnstableAttr) {
+Diag(Record->getLocation(), diag::err_abi_mismatch) <<
rsmith added a comment.
Can we instead not add the function to the redeclaration chain until it's
instantiated (like we do if it's dependent)?
http://reviews.llvm.org/D16989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: arpith
Date: Fri Mar 18 07:39:40 2016
New Revision: 263784
URL: http://llvm.org/viewvc/llvm-project?rev=263784&view=rev
Log:
Revert r263783 as buildbot failure is being investigated.
Removed:
cfe/trunk/test/OpenMP/nvptx_target_codegen.cpp
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPR
etienneb added a subscriber: etienneb.
etienneb added a comment.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D18231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
Thanks! Some inline comments --
Comment at: lib/CodeGen/CodeGenModule.cpp:399
@@ -398,1 +398,3 @@
getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
+auto *SummaryMD = PGOReader->getSummary().getMD(getModule().getContext());
hintonda added a comment.
Yes, those were mostly in comments. I'd just done a simple find/grep that
didn't take context into account.
I agree that multiple checkins would be best which will make it much easy to
review.
http://reviews.llvm.org/D18217
___
Author: steven_watanabe
Date: Fri Mar 18 16:35:59 2016
New Revision: 263836
URL: http://llvm.org/viewvc/llvm-project?rev=263836&view=rev
Log:
Fix printing of anonymous struct typedefs.
clang -cc1 -ast-print put the struct
definition in the wrong place, like this:
struct {} typedef S;
The reas
EricWF added a comment.
@jfb: Actually I changed my mind about guarding the new tests. Can you move the
new tests (other than the missing additions) to a new test file? Then add `//
UNSUPPORTED: c++98, c++03, c++11, c++14` to the top of it?
http://reviews.llvm.org/D17951
___
Author: djasper
Date: Thu Mar 17 08:03:41 2016
New Revision: 263713
URL: http://llvm.org/viewvc/llvm-project?rev=263713&view=rev
Log:
clang-format: [JS] Make requoting of JavaScript string literals only
change affected ranges.
Modified:
cfe/trunk/lib/Format/Format.cpp
cfe/trunk/unittests/
mclow.lists added a comment.
One idea is to do this in two steps - do the `throw()` stuff in one patch, and
the defaulted fns in a second one.
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
mclow.lists added a comment.
> Okay, but should I fix the 146 cases of " = default;" that were already there?
If there are `= default` in code that can be used from C++03, then they ought
to be fixed.
Note that many of the ones that turn up in a text search are in the synopsis -
not in the cod
a.sidorin updated this revision to Diff 51027.
a.sidorin added a comment.
Serge, thank you for help!
GNUNullExpr was 'long' on my platform. I weakened a matcher to check only if it
has integer type.
ParenListExpr issue was also successfully reproduced with
'fdelayed-template-parsing' and fixed.
Author: gbiv
Date: Sat Mar 19 16:51:45 2016
New Revision: 263888
URL: http://llvm.org/viewvc/llvm-project?rev=263888&view=rev
Log:
[Sema] Make type deduction work with some overloadable functions
Some functions can't have their address taken. If we encounter an
overload set where only one of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263888: [Sema] Make type deduction work with some
overloadable functions (authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D15591?vs=49337&id=51120#toc
Repository:
rL LLVM
http://
Author: cbertol
Date: Fri Mar 18 16:43:32 2016
New Revision: 263837
URL: http://llvm.org/viewvc/llvm-project?rev=263837&view=rev
Log:
[OPENMP] Implementation of codegen for firstprivate clause of target directive
This patch implements the following aspects:
It extends sema to check that a variab
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263887: [Sema] Allow casting of some overloaded functions
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D17701?vs=49334&id=51119#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: gbiv
Date: Sat Mar 19 16:36:10 2016
New Revision: 263887
URL: http://llvm.org/viewvc/llvm-project?rev=263887&view=rev
Log:
[Sema] Allow casting of some overloaded functions
Some functions can't have their address taken. If we encounter an
overload set where only one of the candidates can
george.burgess.iv marked an inline comment as done.
Comment at: lib/Sema/SemaCast.cpp:1771-1782
@@ +1770,14 @@
+
+ DeclAccessPair DAP;
+ FunctionDecl *Found = Self.resolveAddressOfOnlyViableOverloadCandidate(E,
DAP);
+ if (!Found)
+return false;
+
+ Self.CheckAddressOfMem
> On 2016-Mar-16, at 15:41, Eric Fiselier wrote:
>
> EricWF accepted this revision.
> EricWF added a comment.
> This revision is now accepted and ready to land.
>
> LGTM after change in inline comment.
>
>
>
> Comment at: include/__hash_table:114
> @@ +113,3 @@
> +template
>
hintonda added a comment.
Okay, but should I fix the 146 cases of " = default;" that were already there?
That's a lot of churn, so I don't want to step on anyone...
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm
On 3/18/2016 1:50 AM, Joerg Sonnenberger via cfe-commits wrote:
On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits wrote:
C++ atomics are explicitly designed to avoid problems with touching
adjacent bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte
`cmpxchg` then it's
sdowney updated this revision to Diff 50986.
sdowney added a comment.
Add tests with functions generated with MACROS
http://reviews.llvm.org/D18191
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/ConstRefBuiltinCheck.cpp
clang-tidy/misc/ConstRefBuiltinCheck.h
clang-tidy/misc/MiscT
mclow.lists added inline comments.
Comment at: include/__bit_reference:75
@@ -73,1 +74,3 @@
+_LIBCPP_INLINE_VISIBILITY
+__bit_reference(const __bit_reference&) _NOEXCEPT = default;
private:
Sadly, we don't get to say '=default', because we have clients th
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
In particular, this lets device code call most std::complex functions.
http://reviews.llvm.org/D18219
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include/cl
nwilson created this revision.
nwilson added reviewers: rsmith, hubert.reinterpretcast, faisalv, aaron.ballman.
nwilson added a subscriber: cfe-commits.
A program shall not declare an explicit instantiation (14.8.2), an explicit
specialization (14.8.3), or a partial specialization of a concept de
Author: dblaikie
Date: Thu Mar 17 15:45:38 2016
New Revision: 263747
URL: http://llvm.org/viewvc/llvm-project?rev=263747&view=rev
Log:
Re-add (user defined) move ops to UnresolvedSetImpl to allow UnresolvedSet to
be implicitly movable
Modified:
cfe/trunk/include/clang/AST/UnresolvedSet.h
Mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263738: For MS ABI, emit dllexport friend functions defined
inline in class (authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D15267?vs=46227&id=50968#toc
Repository:
rL LLVM
http:
alexfh added a comment.
Looks good with one comment. Thank you, Richard!
Comment at: docs/clang-tidy/checks/list.rst:91
@@ -90,2 +90,3 @@
performance-implicit-cast-in-loop
+ performance-unnecessary-copy-initialization.rst
readability-braces-around-statements
--
jfb added a comment.
In http://reviews.llvm.org/D17950#376965, @jfb wrote:
> In http://reviews.llvm.org/D17950#376349, @jyknight wrote:
>
> > This conflicts with http://reviews.llvm.org/D17933. Most of this change
> > also seems unnecessary.
> >
> > - I think the `is_always_lock_free` function s
jlebar added a comment.
Actually, this isn't enough. It works fine for std::complex, but it screws
with our existing std math business, because some of the host functions that
we're trying to override are constexpr, and now they're treated as constexpr
host-device.
http://reviews.llvm.org/D1
ABataev added a comment.
Samuel, this will be captured. But foo() will use original A. This cannot be
changed.
But Inside the region all reference to this->A will be replaced by the
CapturedDecl A. It will allow proper codegen for inner captured contexts.
For example, such code won't be handled
On Fri, Mar 18, 2016 at 7:30 AM, Craig, Ben via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 3/18/2016 1:50 AM, Joerg Sonnenberger via cfe-commits wrote:
>
>> On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits
>> wrote:
>>
>>> C++ atomics are explicitly designed to avoid
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
Visualizer for clang::FunctionProtoType
Displays return type and parameters for the Function Protoype object in the
Locals window. For example, the prototype `int
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after change in inline comment.
Comment at: include/__hash_table:114
@@ +113,3 @@
+template
+struct __can_extract_key<_Pair, _Key, pair<_First, _Second>>
+: conditio
On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits wrote:
> C++ atomics are explicitly designed to avoid problems with touching
> adjacent bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte
> `cmpxchg` then it's up to the frontend to make sure `sizeof> >= 4`
> (or somethi
sepavloff updated this revision to Diff 51017.
sepavloff added a comment.
Do not emit warning on class methods.
http://reviews.llvm.org/D16579
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/drs/dr3xx.cpp
test/CX
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, kkwli0, Hahnfeld.
carlo.bertolli added subscribers: sfantao, caomhin, arpith-jacob, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
Herald added a subscriber: jholewinski.
This patch adds in
rsmith added a comment.
@echristo, you asked for time to review this; if you still want to, please can
you do so?
@tra, it looks like you're happy with this design (and with moving the CUDA
offloading support in this direction), please let us know if not!
Comment at: include/c
pcc added a comment.
There's a correctness issue with this change that I'll need to resolve before
this goes in; see http://lists.llvm.org/pipermail/cfe-dev/2016-March/048025.html
http://reviews.llvm.org/D18199
___
cfe-commits mailing list
cfe-comm
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, dexonsmith.
Improve invalid format string specifier handling by printing out invalid
specifiers characters with \x, \u and \U. Previously clang would print gargabe
whenever the character is unprint
kzhuravl-AMD created this revision.
kzhuravl-AMD added reviewers: arsenm, tstellarAMD.
kzhuravl-AMD added subscribers: bpurnomo, cfe-commits.
http://reviews.llvm.org/D18272
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/amdgpu-features.c
Index: test/Driver/amdgpu-f
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D13419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
In the `` of `PointerIntPair` , I cast the pointer to the actual
type, so VS can leverage it while visualizing, not unlike the recent change to
`PointerUnion` vis
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
> Note to Reviewers: I will continue to make frequent changes to the MSVC
> visualizers. While these are worthwhile, I don't want to overwhelm the
> reviewers. Is it OK fo
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 263654.
Repository:
rL LLVM
http://reviews.llvm.org/D18105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
nwilson added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7837
@@ -7819,1 +7836,3 @@
+NewFD->setInvalidDecl(true);
+return NewFD;
}
Please let me know if there are thoughts about better error recovery here. I
did this because we don'
ryee88 added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:3803
@@ +3802,3 @@
+
+// Per C++ standard [n3485] 3.4.4 Elaborated type specifiers, section 3:
+// "Cannot introduce an qualified".
aaron.ballman wrote:
> Can drop the N-paper reference, a
Author: arpith
Date: Fri Mar 18 06:47:43 2016
New Revision: 263783
URL: http://llvm.org/viewvc/llvm-project?rev=263783&view=rev
Log:
[OpenMP] Base support for target directive codegen on NVPTX device.
Summary:
Reworked test case after buildbot failure on windows.
This patch adds base support for
1 - 100 of 247 matches
Mail list logo
