rsmith added a comment. @echristo, you asked for time to review this; if you still want to, please can you do so? @tra, it looks like you're happy with this design (and with moving the CUDA offloading support in this direction), please let us know if not!
================ Comment at: include/clang/Driver/Options.td:1617-1618 @@ -1616,2 +1616,4 @@ HelpText<"Write output to <file>">, MetaVarName<"<file>">; +def omptargets_EQ : CommaJoined<["-"], "omptargets=">, Flags<[DriverOption, CC1Option]>, + HelpText<"Specify comma-separated list of triples OpenMP offloading targets to be supported">; def pagezero__size : JoinedOrSeparate<["-"], "pagezero_size">; ---------------- This is an unfortunate flag name; `-oblah` already means something. Is this name chosen for compatibility with some other system, or could we change it to, say, `-fopenmp-targets=`? ================ Comment at: lib/Driver/Tools.cpp:316 @@ +315,3 @@ + // Add commands to embed target binaries. We ensure that each section and + // image s 16-byte aligned. This is not mandatory, but increases the + // likelihood of data to be aligned with a cache block in several main host ---------------- s -> is http://reviews.llvm.org/D9888 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
