r256920 - Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Dimitry Andric via cfe-commits
Author: dim Date: Wed Jan 6 01:42:18 2016 New Revision: 256920 URL: http://llvm.org/viewvc/llvm-project?rev=256920&view=rev Log: Add -fno-movt frontend option, to disable movt/movw on ARM Summary: In rL256641, @davide turned off movt generation by default for FreeBSD. This was because our ld is

r256919 - Change the set of actions built for external gcc tools.

2016-01-05 Thread Eric Christopher via cfe-commits
Author: echristo Date: Wed Jan 6 01:24:45 2016 New Revision: 256919 URL: http://llvm.org/viewvc/llvm-project?rev=256919&view=rev Log: Change the set of actions built for external gcc tools. A gcc tool has an "integrated" assembler (usually gas) that it will call to produce an object. Let it use

Re: [PATCH] D15911: Switch Action and ActionList over to using std::shared_ptr.

2016-01-05 Thread Justin Lebar via cfe-commits
jlebar added a comment. The main reason I want this is for CUDA. The way CUDA compilation will work, once I finish my patch, is: For each GPU arch, we compile device code to assembly (ptx) and then assemble the ptx into an object file (cubin). We then pass the cubins *and* ptx files to nVidia

[PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-05 Thread Xiuli PAN via cfe-commits
pxli168 created this revision. pxli168 added reviewers: pekka.jaaskelainen, Anastasia. pxli168 added subscribers: cfe-commits, bader. Support for the pipe built-in functions. The pipe packet type can be user defined structure, we need to handle this in clang frontend. This version is based on bad

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

2016-01-05 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4282 @@ +4281,3 @@ + EXPECT_TRUE(matches("void f(int i);", functionProtoType())); + EXPECT_TRUE(matches("void f();", functionProtoType(parameterCountIs(0; + EXPECT_TRUE( -

r256907 - [modules] When a tag type that was imported from a module is referenced via an

2016-01-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jan 5 21:52:10 2016 New Revision: 256907 URL: http://llvm.org/viewvc/llvm-project?rev=256907&view=rev Log: [modules] When a tag type that was imported from a module is referenced via an elaborated-type-specifier, create a declaration of it to track that the current module

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

2016-01-05 Thread Richard Smith via cfe-commits
On Tue, Jan 5, 2016 at 1:32 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrot

[PATCH] D15911: Switch Action and ActionList over to using std::shared_ptr.

2016-01-05 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: echristo. jlebar added a subscriber: cfe-commits. jlebar added a dependency: D15910: Make isa, cast, dyn_cast, etc. work with std::unique_ptr and std::shared_ptr.. Herald added a subscriber: klimek. This makes constructing Action graphs which

Re: [PATCH] D15882: Avoid assert failure on some invalid cc1 options.

2016-01-05 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256897: Avoid assert failure on some invalid cc1 options. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D15882?vs=43958&id=44074#toc Repository: rL LLVM http://reviews.llvm.o

r256897 - Avoid assert failure on some invalid cc1 options.

2016-01-05 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Jan 5 19:37:57 2016 New Revision: 256897 URL: http://llvm.org/viewvc/llvm-project?rev=256897&view=rev Log: Avoid assert failure on some invalid cc1 options. Addressing review comment in D13221. Differential Revision: http://reviews.llvm.org/D15882 Modified: cfe/trun

Re: [PATCH] D15596: Add -L/path/to/cuda/lib if any of our inputs are CUDA files.

2016-01-05 Thread Artem Belevich via cfe-commits
tra added inline comments. Comment at: lib/Driver/ToolChains.cpp:4125 @@ +4124,3 @@ + ArgStringList &LDArgs) const { + if (DriverArgs.hasArg(options::OPT_nocudalib) || !CudaInstallation.isValid()) +return; I'd rename -nocudalib to

RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Liao, Michael via cfe-commits
Hi Samuel The issue is not related to capture feature but the order of evaluation which is not specified for arguments in a function call in C/C++. With the side effect in each argument evaluation, it causes the trouble. Thanks - Michael From: Samuel F Antao [mailto:sfan...@us.ibm.com] Sent: T

Re: [PATCH] D15227: [analyzer] Valist checkers.

2016-01-05 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:31 @@ +30,3 @@ +struct VAListAcceptingFunc { + mutable IdentifierInfo *II; + StringRef FuncName; It does not support ObjC methods. I think this is most useful to checker

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

2016-01-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256887: [analyzer] Fix false warning about memory leak for QApplication::postEvent (authored by zaks). Changed prior to commit: http://reviews.llvm.org/D14170?vs=40596&id=44070#toc Repository: rL LLV

r256885 - [analyzer] Don't report null dereferences on address_space annotated memory

2016-01-05 Thread Anna Zaks via cfe-commits
Author: zaks Date: Tue Jan 5 18:32:49 2016 New Revision: 256885 URL: http://llvm.org/viewvc/llvm-project?rev=256885&view=rev Log: [analyzer] Don't report null dereferences on address_space annotated memory Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp cfe/trunk/t

r256887 - [analyzer] Fix false warning about memory leak for QApplication::postEvent

2016-01-05 Thread Anna Zaks via cfe-commits
Author: zaks Date: Tue Jan 5 18:32:56 2016 New Revision: 256887 URL: http://llvm.org/viewvc/llvm-project?rev=256887&view=rev Log: [analyzer] Fix false warning about memory leak for QApplication::postEvent According to Qt documentation Qt takes care of memory allocated for QEvent: http://doc.qt.i

r256886 - [analyzer] Suppress reports coming from std::__independent_bits_engine

2016-01-05 Thread Anna Zaks via cfe-commits
Author: zaks Date: Tue Jan 5 18:32:52 2016 New Revision: 256886 URL: http://llvm.org/viewvc/llvm-project?rev=256886&view=rev Log: [analyzer] Suppress reports coming from std::__independent_bits_engine The analyzer reports a shift by a negative value in the constructor. The bug can be easily trig

RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Samuel F Antao via cfe-commits
Hi Michael, Thanks for the patch! I am not sure I understand why the behavior is unspecified if Idx is captured by reference, but that is good to know that it fixes the problem. I reverted the patch in the meantime given that I am still trying to replicate a problem I get from the ARM bots, but I

Re: [PATCH] D15448: [analyzer] SVal Visitor.

2016-01-05 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/Regions.def:31 @@ +30,3 @@ +// is both instantiated and derived from. +// Additionally, its kind is not its name with "Kind" suffix, +// unlike all other regions. I'd rath

r256874 - Fix a typo in testcase and increase its coverage!

2016-01-05 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Jan 5 17:54:01 2016 New Revision: 256874 URL: http://llvm.org/viewvc/llvm-project?rev=256874&view=rev Log: Fix a typo in testcase and increase its coverage! Modified: cfe/trunk/test/Modules/ModuleDebugInfo.cpp Modified: cfe/trunk/test/Modules/ModuleDebugInfo.cpp URL

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

2016-01-05 Thread Artem Belevich via cfe-commits
tra added a comment. ping. http://reviews.llvm.org/D15305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256873 - [CMake] Support a simple case for bootstrap builds to generate PGO data

2016-01-05 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Tue Jan 5 17:51:42 2016 New Revision: 256873 URL: http://llvm.org/viewvc/llvm-project?rev=256873&view=rev Log: [CMake] Support a simple case for bootstrap builds to generate PGO data Summary: This patch adds support for the clang multi-stage bootstrapping to support PGO

[PATCH] D15907: Allow various function attributes to be specified on Objective-C blocks too.

2016-01-05 Thread Nicholas Allegra via cfe-commits
comex created this revision. comex added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This mostly "just works" by adding Block to the subject list, but there is an issue with warnings in attribute handlers tied to the return type, which for blocks can be inferred. My solution t

Re: [PATCH] D15705: Adding a scripted test for PR25717

2016-01-05 Thread Yunzhong Gao via cfe-commits
ygao added a comment. In llvm/utils/lit/lit/TestRunner.py line#202 inside function executeShCmd(), the test is spawned by subprocess.Popen(command, ..., stdout = subprocess.PIPE, stderr = subprocess.PIPE, ...) And the test passes. I can verify with a small python script doing just a subprocess.

Re: [libcxx] r249798 - Split out of .

2016-01-05 Thread Nico Weber via cfe-commits
On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith wrote: > On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote: > >> One problem with this patch: stdio.h can be used in .c files, and when >> building .c files with -gnu99 -pedantic, >> > > Do you mean -std=gnu89? > > >> clang will complain about // co

RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Liao, Michael via cfe-commits
Hi Samual The change in CL#256842 has undefined behavior according to C++. Attached patch will avoid side-effect code during argument evaluation of a function call. That solves the problem for me on Linux with GCC 4.9. Thanks - Michael From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.o

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Dimitry Andric via cfe-commits
dim updated this revision to Diff 44059. dim added a comment. Rename `-fno-movt` to `-mno-movt`. http://reviews.llvm.org/D15899 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/arm-no-movt.c Index: test/Driver/arm-no-movt.c =

Re: [PATCH] D15596: Add -L/path/to/cuda/lib if any of our inputs are CUDA files.

2016-01-05 Thread Justin Lebar via cfe-commits
jlebar added a comment. I'm sorry I sat on this for so long; I failed at email somehow, and only came back to ping this patch. :) Comment at: lib/Driver/ToolChains.cpp:4125 @@ +4124,3 @@ + ArgStringList &LDArgs) const { + if (DriverArgs.hasArg(opt

Re: [PATCH] D15596: Add -L/path/to/cuda/lib if any of our inputs are CUDA files.

2016-01-05 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 44056. jlebar marked 2 inline comments as done. jlebar added a comment. Address tra's review comments. http://reviews.llvm.org/D15596 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

2016-01-05 Thread Adrian Prantl via cfe-commits
> On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits > wrote: > >> >> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits >> wrote: >> >> Author: rsmith >> Date: Thu Nov 12 16:19:45 2015 >> New Revision: 252960 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

2016-01-05 Thread Justin Bogner via cfe-commits
Chris Bieneman writes: > beanz updated this revision to Diff 43192. > beanz added a comment. > > One more dependency hookup fix, this one makes it so that stage2 > doesn't depend on the stage2-instrumented compiler-rt, and avoids > building it when you invoke the 'stage2' target. Please update th

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Eric Christopher via cfe-commits
On Tue, Jan 5, 2016 at 12:43 PM Ed Maste wrote: > >> Is there a precendent for the option name? It should be -m* and not -f*, > >> since it is not target independent. > > > > Yes, agreed, thanks for the catch Joerg. > > Presumably -ffixed_r9 should become -mfixed_r9 as well? > That's a bit diffe

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Ed Maste via cfe-commits
>> Is there a precendent for the option name? It should be -m* and not -f*, >> since it is not target independent. > > Yes, agreed, thanks for the catch Joerg. Presumably -ffixed_r9 should become -mfixed_r9 as well? ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Eric Christopher via cfe-commits
On Tue, Jan 5, 2016 at 12:29 PM Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Jan 05, 2016 at 08:12:34PM +, Dimitry Andric via cfe-commits > wrote: > > In rL256641, @davide turned off movt generation by default for FreeBSD. > > This was because our ld is ver

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jan 05, 2016 at 08:12:34PM +, Dimitry Andric via cfe-commits wrote: > In rL256641, @davide turned off movt generation by default for FreeBSD. > This was because our ld is very old, and did not support the relocations > for it. However, Ian Lepore added the support very recently, so we

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Davide Italiano via cfe-commits
davide added a comment. In http://reviews.llvm.org/D15899#319918, @dim wrote: > In http://reviews.llvm.org/D15899#319902, @davide wrote: > > > I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 > > if backported) -- what about people running <= 10.2 ? Isn't this a proble

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Dimitry Andric via cfe-commits
dim added a comment. In http://reviews.llvm.org/D15899#319902, @davide wrote: > I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 > if backported) -- what about people running <= 10.2 ? Isn't this a problem > for them? People running ports-provided or hand-built clan

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. Sure. -eric http://reviews.llvm.org/D15899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Ed Maste via cfe-commits
emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This LGTM http://reviews.llvm.org/D15899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Davide Italiano via cfe-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Hmm, probably they can use the new frontend options so it's fine. LGTM. http://reviews.llvm.org/D15899 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Davide Italiano via cfe-commits
davide added a comment. I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 if backported) -- what about people running <= 10.2 ? Isn't this a problem for them? http://reviews.llvm.org/D15899 ___ cfe-commits mailing list cf

[PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Dimitry Andric via cfe-commits
dim created this revision. dim added reviewers: davide, echristo, dexonsmith. dim added subscribers: emaste, ahatanak, cfe-commits, davide. Herald added subscribers: rengolin, aemerson. In rL256641, @davide turned off movt generation by default for FreeBSD. This was because our ld is very old, and

r256865 - [Clang/Support/Windows/Unix] Command lines created by clang may exceed the command length limit set by the OS

2016-01-05 Thread Oleg Ranevskyy via cfe-commits
Author: oleg Date: Tue Jan 5 13:54:39 2016 New Revision: 256865 URL: http://llvm.org/viewvc/llvm-project?rev=256865&view=rev Log: [Clang/Support/Windows/Unix] Command lines created by clang may exceed the command length limit set by the OS Summary: LLVM part of the patch is D15831. When clang

[libcxx] r256864 - Add explicit include directives; the file was getting implicitly included already. NFC

2016-01-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 5 13:53:31 2016 New Revision: 256864 URL: http://llvm.org/viewvc/llvm-project?rev=256864&view=rev Log: Add explicit include directives; the file was getting implicitly included already. NFC Modified: libcxx/trunk/test/std/containers/associative/map/map.modifi

[PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

2016-01-05 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added a subscriber: cfe-commits. This patch fixes a warning that is issued when -Wpadded is on clang's command line. The following warning is from the build log of http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_abi/554/consoleText (note that I see

[libcxx] r256861 - Remove some test scaffolding that I added and then didn't need. No functional change

2016-01-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 5 13:44:58 2016 New Revision: 256861 URL: http://llvm.org/viewvc/llvm-project?rev=256861&view=rev Log: Remove some test scaffolding that I added and then didn't need. No functional change Modified: libcxx/trunk/test/support/MoveOnly.h Modified: libcxx/trunk/t

[libcxx] r256859 - First half of LWG#2354: 'Unnecessary copying when inserting into maps with braced-init syntax'

2016-01-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 5 13:32:41 2016 New Revision: 256859 URL: http://llvm.org/viewvc/llvm-project?rev=256859&view=rev Log: First half of LWG#2354: 'Unnecessary copying when inserting into maps with braced-init syntax' Modified: libcxx/trunk/include/__tree libcxx/trunk/include

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

2016-01-05 Thread Bob Wilson via cfe-commits
bob.wilson accepted this revision. bob.wilson added a reviewer: bob.wilson. bob.wilson added a comment. This revision is now accepted and ready to land. I applied a Darwin-specific change for this to clang in r256026. http://reviews.llvm.org/D15455

Re: [PATCH] D15888: [Analyzer] Change the default SA checkers for PS4

2016-01-05 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Driver/Tools.cpp:3609 @@ -3602,2 +3608,3 @@ // Enable the following experimental checkers for testing. + if (!IsPS4CPU) { These are no longer experimen

Re: [PATCH] D15882: Avoid assert failure on some invalid cc1 options.

2016-01-05 Thread Paul Robinson via cfe-commits
probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D15882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Samuel F Antao via cfe-commits
Hi Art, That only fixed one of the problems. The other one I am having some trouble to replicate. I am trying a few things and hopefully will get a fix soon. Sorry for the trouble, Samuel From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUS Cc: cfe-commits Date: 01/05/2016 0

Re: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Artem Belevich via cfe-commits
Samuel, The tests are still failing: http://lab.llvm.org:8011/builders/clang-bpf-build/builds/5759 On Tue, Jan 5, 2016 at 10:02 AM, Samuel Antao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sfantao > Date: Tue Jan 5 12:02:24 2016 > New Revision: 256854 > > URL: http://llvm.o

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

2016-01-05 Thread Artem Belevich via cfe-commits
tra added a comment. A better description of the problem would help. PR itself is somewhat short on details. If I understand it correctly, the problem is that if we create multiple definitions with the same mangled name, clang does not always report it as an error and only emits one of those in

Re: [PATCH] D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows

2016-01-05 Thread Nathan Slingerland via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256855: [PGO] Enable clang to pass compiler-rt profile support library to linker on… (authored by slingn). Changed prior to commit: http://reviews.llvm.org/D15833?vs=44017&id=44023#toc Repository: rL

r256855 - [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows

2016-01-05 Thread Nathan Slingerland via cfe-commits
Author: slingn Date: Tue Jan 5 12:27:06 2016 New Revision: 256855 URL: http://llvm.org/viewvc/llvm-project?rev=256855&view=rev Log: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows Summary: This change enables clang to automatically link binaries built with t

Re: [PATCH] D12834: add gcc abi_tag support

2016-01-05 Thread Tavian Barnes via cfe-commits
tavianator added a subscriber: tavianator. Comment at: lib/AST/ItaniumMangle.cpp:1120 @@ -880,2 +1119,3 @@ mangleSourceName(qualifier->getAsIdentifier()); +writeAbiTags(qualifier->getAsNamespaceAlias()); break; This looks bogus, should be `writeAbiTa

r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Tue Jan 5 12:02:24 2016 New Revision: 256854 URL: http://llvm.org/viewvc/llvm-project?rev=256854&view=rev Log: [OpenMP] Allow file ID to be signed in the offloading metadata. This fixes a regression introduced by rL256842. Modified: cfe/trunk/test/OpenMP/target_codege

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-01-05 Thread Timon Van Overveldt via cfe-commits
timonvo added a comment. In http://reviews.llvm.org/D15883#319445, @rengolin wrote: > Tests? Sure, I could add some. But is it common practice to test constants? The tests would end up being a duplication of the definition, I'm not sure how valuable that would be. I also couldn't find tests f

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

2016-01-05 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: test/SemaCUDA/kernel-call.cu:27 @@ -26,1 +26,3 @@ + + g1<<>>(42); // expected-error {{use of undeclared identifier 'undeclared'}} } We set four things in setConfig -- does this test fail if any one of them is commented

Re: [PATCH] D15603: [OpenCL] Pipe type support

2016-01-05 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108 @@ +107,3 @@ +PipeTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc); + } pxli168 wrote: > Anastasia wrote: > > Yes

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-01-05 Thread Renato Golin via cfe-commits
rengolin added a comment. Well, I only saw later that these are propositions from another patch... I don't see why this can't be part of the original patch, but I'm ok with no tests if they're used (and tested) on the final patch. I'll defer to Logan to decide. :) http://reviews.llvm.org/D158

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

2016-01-05 Thread Kostya Serebryany via cfe-commits
On Tue, Jan 5, 2016 at 9:01 AM, Alexander Kornienko wrote: > On Mon, Jan 4, 2016 at 7:39 PM, Kostya Serebryany wrote: > >> Nice! >> is a fuzzer for clang-tidy possible/ >> > > Should be no more difficult than clang-fuzzer. > Let's do it then? > > >> desirable? >> > > It might be useful to fin

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

2016-01-05 Thread Bob Wilson via cfe-commits
bob.wilson accepted this revision. bob.wilson added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for working on this! http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

2016-01-05 Thread Alexander Kornienko via cfe-commits
On Mon, Jan 4, 2016 at 7:39 PM, Kostya Serebryany wrote: > Nice! > is a fuzzer for clang-tidy possible/ > Should be no more difficult than clang-fuzzer. > desirable? > It might be useful to find crashes in clang-tidy earlier than we feed a ton of sources to it. Not sure how effective it would

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

2016-01-05 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: docs/clang-tidy/checks/misc-definitions-in-headers.rst:20 @@ +19,3 @@ + const int c = 1; + namespace { + int f = 2; Done. I have also updated my comments here for these cases. Right now it should be ready for revi

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

2016-01-05 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 44013. hokein marked 2 inline comments as done. hokein added a comment. Correct punctuation usage. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCh

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

2016-01-05 Thread Carlo Bertolli via cfe-commits
carlo.bertolli updated this revision to Diff 44012. carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Update to dist_schedule patch, as requested: show whole context and add ast print regression test. Repository: rL LLVM http://reviews.llvm.org/D15220 Files:

Re: [PATCH] D9600: Add scan-build python implementation

2016-01-05 Thread Laszlo Nagy via cfe-commits
rizsotto.mailinglist added a comment. sorry for the delay, hard to get free time these days. ;) Comment at: tools/scan-build-py/libscanbuild/intercept.py:146 @@ +145,3 @@ +}) +elif sys.platform == 'darwin': +logging.debug('intercept gonna preload libear on OS

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

2016-01-05 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 44010. hokein marked 4 inline comments as done. hokein added a comment. Update. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h clang-tidy/

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

2016-01-05 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 44008. hokein added a comment. Update doc and address comments on test file. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h clang-tidy/mis

r256841 - clang-format: Fix corner case in "if it saves columns"-calculation.

2016-01-05 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Jan 5 10:10:39 2016 New Revision: 256841 URL: http://llvm.org/viewvc/llvm-project?rev=256841&view=rev Log: clang-format: Fix corner case in "if it saves columns"-calculation. Before: .( a

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

2016-01-05 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 44006. hokein added a comment. Update doc. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h clang-tidy/misc/MiscTidyModule.cpp docs/clang-

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

2016-01-05 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 44003. hokein added a comment. Add UseHeaderFileExtension option. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h clang-tidy/misc/MiscTidyM

Re: r244070 - [CMake] First pass at adding support for clang bootstrap builds to CMake

2016-01-05 Thread Chris Bieneman via cfe-commits
I think you may be misaligning the if statements. I've only used it when doing full LLVM+clang builds. In fact, some of the more advanced knobs depend on LLVM being built in-tree (which is a bug that I should fix). If you’re having problems making it work, let me know. It is still largely untest

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

2016-01-05 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki updated this revision to Diff 43997. danielmarjamaki marked an inline comment as done. danielmarjamaki added a comment. Refactorings thanks to review comments http://reviews.llvm.org/D13126 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checker

r256838 - [OpenCL] Disallow taking an address of a function.

2016-01-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Jan 5 08:39:27 2016 New Revision: 256838 URL: http://llvm.org/viewvc/llvm-project?rev=256838&view=rev Log: [OpenCL] Disallow taking an address of a function. An undecorated function designator implies taking the address of a function, which is illegal in OpenCL. Impleme

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

2016-01-05 Thread Chad Rosier via cfe-commits
mcrosier added a comment. Ping. http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15664: Teaches clang about Exynos-M1

2016-01-05 Thread MinSeong KIM via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256829: [AArch64] Teaches clang about Samsung Exynos-M1 (authored by MinSeongKIM). Changed prior to commit: http://reviews.llvm.org/D15664?vs=43354&id=43984#toc Repository: rL LLVM http://reviews.ll

r256829 - [AArch64] Teaches clang about Samsung Exynos-M1

2016-01-05 Thread MinSeong Kim via cfe-commits
Author: minseongkim Date: Tue Jan 5 06:53:24 2016 New Revision: 256829 URL: http://llvm.org/viewvc/llvm-project?rev=256829&view=rev Log: [AArch64] Teaches clang about Samsung Exynos-M1 Adds core tuning support for new Samsung Exynos-M1 core (ARMv8-A). Differential Revision: http://reviews.llvm.

[PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-01-05 Thread Timon Van Overveldt via cfe-commits
timonvo created this revision. timonvo added a reviewer: logan. timonvo added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Adds a number of constants, defined in the ARM EHABI spec, to the Clang lib/Headers/unwind.h header. This is prerequisite for landing http://review

Re: [PATCH] D15266: [clang-format] Handle \n the same way as std::endl with stream operator.

2016-01-05 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Submitted as r256832. http://reviews.llvm.org/D15266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256832 - clang-format: Handle \n the same way as std::endl with stream operator.

2016-01-05 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Jan 5 07:06:27 2016 New Revision: 256832 URL: http://llvm.org/viewvc/llvm-project?rev=256832&view=rev Log: clang-format: Handle \n the same way as std::endl with stream operator. clang-format breaks multi-line streams after std::endl. It now also break for '\n', the sug

r256831 - clang-format: Avoid creating hanging indents in call sequences.

2016-01-05 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Jan 5 07:03:59 2016 New Revision: 256831 URL: http://llvm.org/viewvc/llvm-project?rev=256831&view=rev Log: clang-format: Avoid creating hanging indents in call sequences. Before: .aaa( )

r256830 - clang-format: Improve line wrapping behavior in call sequences.

2016-01-05 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Jan 5 07:03:50 2016 New Revision: 256830 URL: http://llvm.org/viewvc/llvm-project?rev=256830&view=rev Log: clang-format: Improve line wrapping behavior in call sequences. r256750 has been leading to an undesired behavior: aa ..aa

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

2016-01-05 Thread Andrey Bokhanko via cfe-commits
andreybokhanko added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:1235-1243 @@ -1235,9 +1234,11 @@ // different type. -// FIXME: Support for variables is not implemented yet. -if (isa(D.getDecl())) - GV = cast(GetAddrOfGlobal(D, /*IsForDefinition=*

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

2016-01-05 Thread Andrey Bokhanko via cfe-commits
andreybokhanko updated this revision to Diff 43982. andreybokhanko marked an inline comment as done. andreybokhanko added a comment. Fixed tra's note. http://reviews.llvm.org/D15686 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h test/CodeGenCXX/duplicate-mangled-name.cpp

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-01-05 Thread Renato Golin via cfe-commits
rengolin added a comment. Tests? http://reviews.llvm.org/D15883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15888: [Analyzer] Change the default SA checkers for PS4

2016-01-05 Thread Sean Eveson via cfe-commits
seaneveson created this revision. seaneveson added reviewers: zaks.anna, dcoughlin. seaneveson added a subscriber: cfe-commits. This patch removes security.*, unix.API and unix.Vfork from the default checkers for PS4. http://reviews.llvm.org/D15888 Files: lib/Driver/Tools.cpp test/Driver/ps

Re: [PATCH] D15603: [OpenCL] Pipe type support

2016-01-05 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108 @@ +107,3 @@ +PipeTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc); + } Anastasia wrote: > Yes, I think we might, o

Re: [PATCH] D15603: [OpenCL] Pipe type support

2016-01-05 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a reviewer: Anastasia. Anastasia added a comment. LGTM! Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108 @@ +107,3 @@ +PipeTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMContext(), "opencl.pipe_t"), Pi

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

2016-01-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256822: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics. (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D15223?vs=43885&id=43969#toc Repository: rL

r256822 - [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

2016-01-05 Thread Alexandros Lamprineas via cfe-commits
Author: alelab01 Date: Tue Jan 5 03:58:29 2016 New Revision: 256822 URL: http://llvm.org/viewvc/llvm-project?rev=256822&view=rev Log: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics. Differential Revision: http://reviews.llvm.org/D15223 Modified: cfe/trunk/test/Code

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

2016-01-05 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 43965. LegalizeAdulthood added a comment. Add more unit tests from comments http://reviews.llvm.org/D8149 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMa

Re: [PATCH] D15603: [OpenCL] Pipe type support

2016-01-05 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 43964. pxli168 added a comment. Fix some unused diagnostic and wrong diagnostic. Add test for these diagnostics. http://reviews.llvm.org/D15603 Files: include/clang/AST/ASTContext.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/Type.h in