r256088 - Revert "[CMake] Support a simple case for bootstrap builds to generate PGO data"

2015-12-18 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Fri Dec 18 23:47:50 2015 New Revision: 256088 URL: http://llvm.org/viewvc/llvm-project?rev=256088&view=rev Log: Revert "[CMake] Support a simple case for bootstrap builds to generate PGO data" This reverts commit r256069, which was an unintentional tag along on another com

r256083 - Test for diagnostic quality improvement in r256049.

2015-12-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 18 21:12:14 2015 New Revision: 256083 URL: http://llvm.org/viewvc/llvm-project?rev=256083&view=rev Log: Test for diagnostic quality improvement in r256049. Modified: cfe/trunk/test/SemaTemplate/class-template-decl.cpp Modified: cfe/trunk/test/SemaTemplate/class-t

r256080 - Fix crash-on-invalid if a :: is followed by two or more open parentheses (and then something else).

2015-12-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 18 20:40:19 2015 New Revision: 256080 URL: http://llvm.org/viewvc/llvm-project?rev=256080&view=rev Log: Fix crash-on-invalid if a :: is followed by two or more open parentheses (and then something else). Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/t

r256078 - Recommit CC1 part of debugger tuning; pass through setting from driver to LLVM.

2015-12-18 Thread Paul Robinson via cfe-commits
Author: probinson Date: Fri Dec 18 20:24:10 2015 New Revision: 256078 URL: http://llvm.org/viewvc/llvm-project?rev=256078&view=rev Log: Recommit CC1 part of debugger tuning; pass through setting from driver to LLVM. Reapplies r256063, except instead of frugally re-using an LLVM enum, we define a

r256076 - Use a command line alias to remove the need to rewrite a subtarget

2015-12-18 Thread Eric Christopher via cfe-commits
Author: echristo Date: Fri Dec 18 19:48:43 2015 New Revision: 256076 URL: http://llvm.org/viewvc/llvm-project?rev=256076&view=rev Log: Use a command line alias to remove the need to rewrite a subtarget feature for command line compatibility. Modified: cfe/trunk/include/clang/Driver/Options.td

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

2015-12-18 Thread Chandler Carruth via cfe-commits
Uh, did you intend to commit this prior to Justin or others giving an LGTM? On Fri, Dec 18, 2015 at 4:59 PM Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL256069: [CMake] Support a s

r256070 - [CMake] Fixing a typo in a flag

2015-12-18 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Fri Dec 18 18:56:12 2015 New Revision: 256070 URL: http://llvm.org/viewvc/llvm-project?rev=256070&view=rev Log: [CMake] Fixing a typo in a flag Turns out cc1's flag has 1 - not 2... Modified: cfe/trunk/utils/perf-training/lit.cfg Modified: cfe/trunk/utils/perf-traini

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

2015-12-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256069: [CMake] Support a simple case for bootstrap builds to generate PGO data (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D15584?vs=43192&id=43285#toc Repository: rL L

r256069 - [CMake] Support a simple case for bootstrap builds to generate PGO data

2015-12-18 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Fri Dec 18 18:56:10 2015 New Revision: 256069 URL: http://llvm.org/viewvc/llvm-project?rev=256069&view=rev Log: [CMake] Support a simple case for bootstrap builds to generate PGO data Summary: This patch adds support for the clang multi-stage bootstrapping to support PGO

r256066 - Revert r256063, it's killing clang-tools-extra

2015-12-18 Thread Paul Robinson via cfe-commits
Author: probinson Date: Fri Dec 18 18:23:11 2015 New Revision: 256066 URL: http://llvm.org/viewvc/llvm-project?rev=256066&view=rev Log: Revert r256063, it's killing clang-tools-extra Modified: cfe/trunk/include/clang/Driver/CC1Options.td cfe/trunk/include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Rafael Espíndola via cfe-commits
>> This introduces a meaning to -ON during the link. That normally show up by >> people passing CFLAGS when linking. > > I'm not sure what you mean? When I build clang with cake the link is driven > by clang, it will accept the O flag by not propagate it to the actual linker. > How would CFLAGS

Re: [PATCH] D15650: CC1 part of debugger tuning; pass through setting from driver to LLVM.

2015-12-18 Thread Paul Robinson via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256063: CC1 part of debugger tuning; pass through setting from driver to LLVM. (authored by probinson). Changed prior to commit: http://reviews.llvm.org/D15650?vs=43257&id=43280#toc Repository: rL LL

r256063 - CC1 part of debugger tuning; pass through setting from driver to LLVM.

2015-12-18 Thread Paul Robinson via cfe-commits
Author: probinson Date: Fri Dec 18 17:41:11 2015 New Revision: 256063 URL: http://llvm.org/viewvc/llvm-project?rev=256063&view=rev Log: CC1 part of debugger tuning; pass through setting from driver to LLVM. Differential Revision: http://reviews.llvm.org/D15650 Modified: cfe/trunk/include/cla

Re: [PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

2015-12-18 Thread Alexey Samsonov via cfe-commits
On Fri, Dec 18, 2015 at 3:20 PM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > On 18 December 2015 at 18:13, Alexey Samsonov wrote: > > samsonov added a comment. > > > > In http://reviews.llvm.org/D15598#314127, @rafael wrote: > > > >> I am not sure what is "expected" is here: > > > > >

Re: [PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

2015-12-18 Thread Rafael Espíndola via cfe-commits
On 18 December 2015 at 18:13, Alexey Samsonov wrote: > samsonov added a comment. > > In http://reviews.llvm.org/D15598#314127, @rafael wrote: > >> I am not sure what is "expected" is here: > > > Interesting. > I was assuming that Clang tends to understand "-lstdc++" as a special > argument that s

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Mehdi Amini via cfe-commits
Sent from my iPhone > On Dec 18, 2015, at 4:06 AM, Rafael Ávila de Espíndola > wrote: > > rafael added a subscriber: rafael. > rafael added a comment. > > This introduces a meaning to -ON during the link. That normally show up by > people passing CFLAGS when linking. I'm not sure what you

Re: [PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

2015-12-18 Thread Alexey Samsonov via cfe-commits
samsonov added a comment. In http://reviews.llvm.org/D15598#314127, @rafael wrote: > I am not sure what is "expected" is here: Interesting. I was assuming that Clang tends to understand "-lstdc++" as a special argument that says "link against C++ standard library", not "link against libstdc++

Re: [PATCH] D12834: add gcc abi_tag support

2015-12-18 Thread Jonathan Roelofs via cfe-commits
jroelofs added a subscriber: jroelofs. jroelofs added a comment. In http://reviews.llvm.org/D12834#305787, @sberg wrote: > I can't figure out how to add code to someone else's Phabricator review, so > sent it to the mailing list > instead: >

r256057 - [CMake] PGO training data

2015-12-18 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Fri Dec 18 17:00:57 2015 New Revision: 256057 URL: http://llvm.org/viewvc/llvm-project?rev=256057&view=rev Log: [CMake] PGO training data Adding in a few more lit substitutions for cc1 and the test exec path. Modified: cfe/trunk/utils/perf-training/lit.cfg Modified:

r256055 - Fix invalid enum comparison.

2015-12-18 Thread Zachary Turner via cfe-commits
Author: zturner Date: Fri Dec 18 16:58:42 2015 New Revision: 256055 URL: http://llvm.org/viewvc/llvm-project?rev=256055&view=rev Log: Fix invalid enum comparison. Modified: cfe/trunk/unittests/Format/FormatTest.cpp Modified: cfe/trunk/unittests/Format/FormatTest.cpp URL: http://llvm.org/vie

Re: [PATCH] D12834: add gcc abi_tag support

2015-12-18 Thread Elizabeth Myers via cfe-commits
elizafox added a comment. In http://reviews.llvm.org/D12834#311890, @foutrelis wrote: > We have received a few reports of clang crashes after applying the abi_tag > support patch to our llvm/clang package in Arch Linux. Why would you put a patch clearly marked as "needs review" into a distrib

r256049 - Split RequireCompleteType into a function that actually requires that the type

2015-12-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 18 16:40:25 2015 New Revision: 256049 URL: http://llvm.org/viewvc/llvm-project?rev=256049&view=rev Log: Split RequireCompleteType into a function that actually requires that the type is complete (with an error produced if not) and a function that merely queries whether

Re: [PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

2015-12-18 Thread Eric Christopher via cfe-commits
echristo added a comment. What's "expected" here? Do we know which of the options are overriding? IIRC shared and the static options aren't necessarily last one wins with gcc. -eric http://reviews.llvm.org/D15598 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

2015-12-18 Thread Rafael Espíndola via cfe-commits
I am not sure what is "expected" is here: $ gcc test.o -o test.so -lstdc++ -shared -static-libstdc++ && ldd test.so | grep libst libstdc++.so.6 => /lib64/libstdc++.so.6 (0x7f848e57d000) $ gcc test.o -o test.so -shared -static-libstdc++ -lstdc++ && ldd test.so | grep libst libstdc++.so.6 => /l

r256046 - Support AlwaysBreakAfterReturnType

2015-12-18 Thread Zachary Turner via cfe-commits
Author: zturner Date: Fri Dec 18 16:20:15 2015 New Revision: 256046 URL: http://llvm.org/viewvc/llvm-project?rev=256046&view=rev Log: Support AlwaysBreakAfterReturnType This changes the behavior of AlwaysBreakAfterDeclarationReturnType so that it supports breaking after declarations, definitions,

r256045 - [modules] Don't try to use the definition of a class if

2015-12-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 18 16:19:11 2015 New Revision: 256045 URL: http://llvm.org/viewvc/llvm-project?rev=256045&view=rev Log: [modules] Don't try to use the definition of a class if RequireCompleteType(..., 0) says we're not permitted to do so. The definition might not be visible, even thou

Re: [PATCH] D15650: CC1 part of debugger tuning; pass through setting from driver to LLVM.

2015-12-18 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sadly, isn't really a way to test this part. Thanks! -eric http://reviews.llvm.org/D15650 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D15651: Driver part of debugger tuning

2015-12-18 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! -eric http://reviews.llvm.org/D15651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r256037 - Wire a SourceLocation into IsDerivedFrom and move the RequireCompleteType call

2015-12-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 18 15:45:41 2015 New Revision: 256037 URL: http://llvm.org/viewvc/llvm-project?rev=256037&view=rev Log: Wire a SourceLocation into IsDerivedFrom and move the RequireCompleteType call for the derived class into it. This is mostly just a cleanup, but could in principle b

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

2015-12-18 Thread Adrian Zgorzałek via cfe-commits
adek05 added reviewers: aaron.ballman, jroelofs. adek05 added a comment. Ping http://reviews.llvm.org/D15443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 12:45:47PM -0800, Bob Wilson via cfe-commits wrote: > > > On Dec 17, 2015, at 10:59 AM, Bob Wilson via cfe-commits > > wrote: > > > > > >> On Dec 17, 2015, at 10:16 AM, Joerg Sonnenberger via cfe-commits > >> wrote: > >> > >> On Wed, Dec 16, 2015 at 11:59:10PM +,

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

2015-12-18 Thread Bob Wilson via cfe-commits
> On Dec 17, 2015, at 10:59 AM, Bob Wilson via cfe-commits > wrote: > > >> On Dec 17, 2015, at 10:16 AM, Joerg Sonnenberger via cfe-commits >> wrote: >> >> On Wed, Dec 16, 2015 at 11:59:10PM +, Bob Wilson via cfe-commits wrote: >>> We can change this to be Darwin-specific if you prefer,

Re: r256023 - Fix an unused variable warning from r256012.

2015-12-18 Thread Adrian Prantl via cfe-commits
Thanks, Chad! -- adrian > On Dec 18, 2015, at 12:08 PM, Chad Rosier via cfe-commits > wrote: > > Author: mcrosier > Date: Fri Dec 18 14:08:40 2015 > New Revision: 256023 > > URL: http://llvm.org/viewvc/llvm-project?rev=256023&view=rev > Log: > Fix an unused variable warning from r256012. > >

r256026 - PIC should not be enabled by default on Darwin with -static.

2015-12-18 Thread Bob Wilson via cfe-commits
Author: bwilson Date: Fri Dec 18 14:37:54 2015 New Revision: 256026 URL: http://llvm.org/viewvc/llvm-project?rev=256026&view=rev Log: PIC should not be enabled by default on Darwin with -static. r245667 changed -static so that it doesn't override an explicit -fPIC option, but -static should still

Re: [PATCH] D15650: CC1 part of debugger tuning; pass through setting from driver to LLVM.

2015-12-18 Thread Paul Robinson via cfe-commits
probinson added a comment. As the only effect is to set a field in the options struct passed down to LLVM, no idea how to test this. http://reviews.llvm.org/D15650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D15651: Driver part of debugger tuning

2015-12-18 Thread Paul Robinson via cfe-commits
probinson created this revision. probinson added reviewers: echristo, dblaikie, aprantl, dougk. probinson added a subscriber: cfe-commits. Adds driver options named -glldb and -gsce to mean -g plus tuning for lldb and SCE debuggers respectively; the existing -ggdb option does the same for gdb. Exi

Re: [PATCH] D8599: Command-line options to set debugger "target"

2015-12-18 Thread Paul Robinson via cfe-commits
probinson abandoned this revision. probinson added a comment. Split into separate CC1 and Driver parts for easier reviewing. http://reviews.llvm.org/D8599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

r256023 - Fix an unused variable warning from r256012.

2015-12-18 Thread Chad Rosier via cfe-commits
Author: mcrosier Date: Fri Dec 18 14:08:40 2015 New Revision: 256023 URL: http://llvm.org/viewvc/llvm-project?rev=256023&view=rev Log: Fix an unused variable warning from r256012. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llv

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

2015-12-18 Thread Alexey Samsonov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256018: [UBSan] Implement runtime suppressions (PR25066). (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D15363?vs=42250&id=43254#toc Repository: rL LLVM http://reviews.llv

r256012 - Add a defensive check for a nullptr.

2015-12-18 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Fri Dec 18 13:44:31 2015 New Revision: 256012 URL: http://llvm.org/viewvc/llvm-project?rev=256012&view=rev Log: Add a defensive check for a nullptr. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/view

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-12-18 Thread Zachary Turner via cfe-commits
zturner added inline comments. Comment at: lib/Format/TokenAnnotator.h:168 @@ -158,1 +167,3 @@ + bool mustBreakForReturnType(const AnnotatedLine &Line, + FormatToken &Token) const; djasper wrote: > Some comment might help. E.g. at t

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-12-18 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Generally looks good. Comment at: include/clang/Format/Format.h:166 @@ +165,3 @@ + enum ReturnTypeBreakingStyle { +/// Break after return type automatically. +/// \

[PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

2015-12-18 Thread Anton Nadolskiy via cfe-commits
anadolskiy created this revision. anadolskiy added a reviewer: rjmccall. anadolskiy added a subscriber: cfe-commits. This patch fixes stack alignments for MCU (should be aligned to 4 bytes) LLVM part: http://reviews.llvm.org/D15646 http://reviews.llvm.org/D15647 Files: tools/clang/lib/AST/AST

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread James Molloy via cfe-commits
Hi, I'll take a look and see what actual codepath is being triggered. That might give us some insight into the current behaviour. Because like you I don't like doing things when we don't exactly know why they're necessary. James On Fri, 18 Dec 2015 at 17:48 Joerg Sonnenberger via cfe-commits < c

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 05:31:45PM +, James Molloy via cfe-commits wrote: > Evidently not, at least not completely. I see codegen differences with this > patch (and at least one significant improvement). I don't mind the patch as is, but it seems to be a move in the wrong direction by hiding t

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread James Molloy via cfe-commits
Evidently not, at least not completely. I see codegen differences with this patch (and at least one significant improvement). James On Fri, 18 Dec 2015 at 16:31, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Dec 18, 2015 at 03:59:03PM +, James Molloy via cf

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

2015-12-18 Thread Asiri Rathnayake via cfe-commits
rmaprath marked an inline comment as done. rmaprath added a comment. http://reviews.llvm.org/D14653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

2015-12-18 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 43237. rmaprath added a comment. Addressing review comments by @mclow.lists: - Introduced `TEST_TRY` and `TEST_CATCH` macros to avoid the non-standard `#define try/catch`. http://reviews.llvm.org/D14653 Files: include/__config include/array test/st

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 03:59:03PM +, James Molloy via cfe-commits wrote: > This is about the standard generic optimizer flags. Currently when using > -flto, the backend behaves always as if "-O2" were passed (because this is > the default codegen optimization level inside the gold plugin and i

[PATCH] D15643: Don't allow newline after uppercase Obj-C block return types

2015-12-18 Thread Kent Sutherland via cfe-commits
ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fixes the following: BOOL (^aaa)(void) = ^BOOL { }; The first BOOL's token was getting set to TT_FunctionAnnotationRParen incorrectly, which was causing

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread James Molloy via cfe-commits
Hi Joerg, This is about the standard generic optimizer flags. Currently when using -flto, the backend behaves always as if "-O2" were passed (because this is the default codegen optimization level inside the gold plugin and it's never overridden!). So CodeGenOpt::Aggressive is never picked, and th

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 01:53:58PM +, James Molloy wrote: > The gold plugin understands -O0..-O3, but these are not currently being > passed to it. Is this about generic optimizer flags in the sense of things that get back to LLVM or about linker-style optimizations? Joerg __

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread James Molloy via cfe-commits
jmolloy added a comment. Hi Rafael, Thanks for the review! > This introduces a meaning to -ON during the link. That normally show up by > people passing CFLAGS when linking. Yes. The rationale is that with -flto, the link is also part of the compile. I think it's more surprising that the com

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Rafael Ávila de Espíndola via cfe-commits
rafael added a subscriber: rafael. rafael added a comment. This introduces a meaning to -ON during the link. That normally show up by people passing CFLAGS when linking. I think that is OK, but would like a second opinion. Comment at: lib/Driver/Tools.cpp:1815 @@ +1814,3 @@ +

[PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread James Molloy via cfe-commits
jmolloy created this revision. jmolloy added a reviewer: joerg. jmolloy added a subscriber: cfe-commits. jmolloy set the repository for this revision to rL LLVM. Herald added a subscriber: joker.eph. The gold plugin understands -O0..-O3, but these are not currently being passed to it. Repository

[PATCH] D15639: [clang-format] Ensure Sort include is stable with negative Priority

2015-12-18 Thread Jean-Philippe Dufraigne via cfe-commits
jeanphilippeD created this revision. jeanphilippeD added a reviewer: djasper. jeanphilippeD added a subscriber: cfe-commits. Herald added a subscriber: klimek. The new sort include with negative priority was not stable when running it again over the updated includes. Extend the test NegativePrio

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

2015-12-18 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki marked 4 inline comments as done. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:41 @@ +40,3 @@ +const Stmt *Parent = PM.getParent(Cast); +if (!Parent) + return; a.sidorin wrote: > Parent should always exist for an impli

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

2015-12-18 Thread Keno Fischer via cfe-commits
loladiro updated this revision to Diff 43218. loladiro added a comment. Rebased http://reviews.llvm.org/D13330 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h include/clang/Sema/Sema.h l

Re: [PATCH] D15410: AnalysisConsumer: use canonical decl for both lookup and store of visited decls

2015-12-18 Thread Aleksei Sidorin via cfe-commits
a.sidorin added a comment. Thank you. I'm not familiar with Objective-C/C++ issues so I missed that. I'll take an another look. BTW, maybe it is better to use definition decl instead of canonical? Repository: rL LLVM http://reviews.llvm.org/D15410

[PATCH] D15636: Reduce false positives in printf/scanf format checker

2015-12-18 Thread Andy Gibbs via cfe-commits
AndyG created this revision. AndyG added a reviewer: cfe-commits. The printf/scanf format checker is a little over-zealous in handling the conditional operator. This patch reduces work by not checking code-paths that are never used and reduces false positives regarding uncovered arguments, for

Re: [PATCH] D15070: [mips] Added support for -Wa, -mips32 and similar.

2015-12-18 Thread Daniel Sanders via cfe-commits
dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. With a couple small changes it will LGTM Comment at: lib/Driver/Tools.cpp:2567-2568 @@ -2547,1 +2566,4 @@ } + StringRef MipsFeatureStringRef = MipsTargetFeature; + if

r255993 - Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry().

2015-12-18 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Fri Dec 18 04:30:12 2015 New Revision: 255993 URL: http://llvm.org/viewvc/llvm-project?rev=255993&view=rev Log: Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry(). Modified: cfe/trunk/lib/Lex/PPDirectives.cpp cfe/trunk/lib/Lex/PPLexerChange.c

Re: [PATCH] D15561: [OpenMP] Remove explicit call for implicit barrier

2015-12-18 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Fixed tests and committed. Thanks! Repository: rL LLVM http://reviews.llvm.org/D15561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r255992 - [OPENMP] Remove explicit call for implicit barrier

2015-12-18 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 18 04:24:53 2015 New Revision: 255992 URL: http://llvm.org/viewvc/llvm-project?rev=255992&view=rev Log: [OPENMP] Remove explicit call for implicit barrier #pragma omp parallel needs an implicit barrier that is currently done by an explicit call to __kmpc_barrier. How

Re: [PATCH] D15561: [OpenMP] Remove explicit call for implicit barrier

2015-12-18 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255992: [OPENMP] Remove explicit call for implicit barrier (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D15561?vs=42984&id=43210#toc Repository: rL LLVM http://reviews.llv

r255990 - [OPENMP] Fix for http://llvm.org/PR25878: Error compiling an OpenMP program

2015-12-18 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 18 01:58:25 2015 New Revision: 255990 URL: http://llvm.org/viewvc/llvm-project?rev=255990&view=rev Log: [OPENMP] Fix for http://llvm.org/PR25878: Error compiling an OpenMP program OpenMP codegen tried to emit the code for its constructs even if it was detected as a d