Re: [PATCH] D14441: [OpenCL] Pipe types support.

bader abandoned this revision. bader added a comment. New version of this patch was uploaded by pxli168 at http://reviews.llvm.org/D15603. http://reviews.llvm.org/D14441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

r255879 - [OPENMP] Fix for http://llvm.org/PR25142: openmp: Assertion failed: DD && "queried property of class with no definition", file AST/DeclCXX.h

Author: abataev Date: Thu Dec 17 00:55:08 2015 New Revision: 255879 URL: http://llvm.org/viewvc/llvm-project?rev=255879&view=rev Log: [OPENMP] Fix for http://llvm.org/PR25142: openmp: Assertion failed: DD && "queried property of class with no definition", file AST/DeclCXX.h Added processing for t

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. In http://reviews.llvm.org/D10599#312135, @rjmccall wrote: > Richard should really be the one to sign off on this, since he's been > managing the review so far. > > I am curious why we decided to handle this separately instead of treating it > as a different attribute s

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman writes: > eraman added a comment. > > Justin, does this patch look ok? Sure. > > Repository: > rL LLVM > > http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

r255875 - Add QualType case to operator< for DynTypedNode.

Author: rtrieu Date: Wed Dec 16 22:46:48 2015 New Revision: 255875 URL: http://llvm.org/viewvc/llvm-project?rev=255875&view=rev Log: Add QualType case to operator< for DynTypedNode. This allows sorting DynTypedNode's which are QualType's since QualType does not have memoization. Modified: cf

[PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. clang crashes when it compiles a member function or a lambda is marked as "naked": struct S { __attribute__((naked)) S() {} } To fix this bug, this patch defines a function that cleans up the naked function removing al

Re: r255848 - [WebAssembly] Initial linking support.

On Wed, Dec 16, 2015 at 5:20 PM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > testcase? > Also, this is passing -target to ld, which is not a valid option. > This patch is mainly setting up some minimal infrastructure. The actual link command-line will need additional changes to be us

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D15363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D15448: [analyzer] SVal Visitor.

zaks.anna added a comment. Are you saying that we need to rename "SymbolValKind" to "SymbolKind"? That would probably be a tiny change. http://reviews.llvm.org/D15448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

samsonov created this revision. samsonov added reviewers: rafael, compnerd. samsonov added a subscriber: cfe-commits. After this change, AddCXXStdlibLibArgs will check the presence of -static-libstdc++ flag and, if necessary, wrap -lc++/-lstdc++ in -Bstatic/-Bdynamic to force static linking of C++

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

eraman added a comment. Justin, does this patch look ok? Repository: rL LLVM http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

eraman updated this revision to Diff 43089. eraman added a comment. Updated the test case. Repository: rL LLVM http://reviews.llvm.org/D15163 Files: lib/CodeGen/CodeGenModule.cpp test/Profile/Inputs/max-function-count.proftext test/Profile/max-function-count.c Index: test/Profile/max-

Re: r255848 - [WebAssembly] Initial linking support.

testcase? Also, this is passing -target to ld, which is not a valid option. Cheers, Rafael On 16 December 2015 at 18:30, Dan Gohman via cfe-commits wrote: > Author: djg > Date: Wed Dec 16 17:30:41 2015 > New Revision: 255848 > > URL: http://llvm.org/viewvc/llvm-project?rev=255848&view=rev > Lo

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Thu Nov 12 16:19:45 2015 > New Revision: 252960 > > URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev > Log: > [modules] Simplify and generalize the existing rule for finding hidden > de

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

samsonov added a comment. Kostya, PTAL. IIRC it was your feature request :) http://reviews.llvm.org/D15363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r255840 - Fix funciton->function typo.

Thanks :-) On Dec 16, 2015 6:13 PM, "Eric Christopher via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: echristo > Date: Wed Dec 16 17:10:46 2015 > New Revision: 255840 > > URL: http://llvm.org/viewvc/llvm-project?rev=255840&view=rev > Log: > Fix funciton->function typo. > > Modified

r255860 - [TLS on Darwin] use CXX_FAST_TLS calling convention for access functions.

Author: mren Date: Wed Dec 16 18:42:36 2015 New Revision: 255860 URL: http://llvm.org/viewvc/llvm-project?rev=255860&view=rev Log: [TLS on Darwin] use CXX_FAST_TLS calling convention for access functions. Also set nounwind attribute. rdar://problem/9001553 Modified: cfe/trunk/lib/CodeGen/It

r255859 - [analyzer] Better detect when C++ object was constructed into existing region.

Author: dcoughlin Date: Wed Dec 16 18:28:33 2015 New Revision: 255859 URL: http://llvm.org/viewvc/llvm-project?rev=255859&view=rev Log: [analyzer] Better detect when C++ object was constructed into existing region. When the analyzer evaluates a CXXConstructExpr, it looks ahead in the CFG for the

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. Thanks for adding `bear_get_environment()` to handle the environment weirdness on Darwin. Comment at: tools/scan-build-py/libscanbuild/intercept.py:146 @@ +145,3 @@ +}) +elif sys.platform == 'darwin': +logging.debug('intercept gonn

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

jroelofs added inline comments. Comment at: test/libcxx/test/config.py:364 @@ +363,3 @@ +deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and +cxx_abi == 'none' and +not use_llvm_unwinder) --

Re: [PATCH] D15596: Add -L/path/to/cuda/lib if any of our inputs are CUDA files.

tra added inline comments. Comment at: lib/Driver/Tools.cpp:259-261 @@ -249,1 +258,5 @@ + // Add -L/path/to/cuda/lib if any of our inputs are .cu files. + if (std::any_of(C.getActions().begin(), C.getActions().end(), isCudaAction)) { +TC.AddCudaLinkerArgs(Args, CmdArgs); +

Re: [PATCH] D15596: Add -L/path/to/cuda/lib if any of our inputs are CUDA files.

tra added a comment. You also need a test case for the changes. http://reviews.llvm.org/D15596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15596: Add -L/path/to/cuda/lib if any of our inputs are CUDA files.

tra added inline comments. Comment at: lib/Driver/ToolChains.cpp:4125 @@ +4124,3 @@ + ArgStringList &LDArgs) const { + if (DriverArgs.hasArg(options::OPT_nocudalib) || !CudaInstallation.isValid()) +return; We may need a new option

Re: [PATCH] D12297: [libcxx] Fix most undefined behavior in

EricWF abandoned this revision. EricWF added a comment. Abandoning for better solution in http://reviews.llvm.org/D12297. http://reviews.llvm.org/D12297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

EricWF updated this revision to Diff 43084. EricWF added a comment. Update diff against ToT. http://reviews.llvm.org/D13796 Files: test/libcxx/compiler.py test/libcxx/test/config.py Index: test/libcxx/test/config.py === --- te

Re: [PATCH] D13750: [libcxx] Fix LWG Issue #2367 - Fixing std::tuple and std::pair's default constructors.

EricWF updated this revision to Diff 43082. EricWF added a comment. Fix merge conflicts. http://reviews.llvm.org/D13750 Files: include/__config include/utility test/std/utilities/utility/pairs/pairs.pair/default.pass.cpp Index: test/std/utilities/utility/pairs/pairs.pair/default.pass.cpp

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

bob.wilson added a subscriber: bob.wilson. bob.wilson added a comment. There has been a long-standing convention in both gcc and clang for Darwin that -static changes the default for PIC. Changing that convention is breaking stuff for us. The commit message for r245667 says "This new behavior al

[libcxx] r255851 - Add CMake option LIBCXX_CONFIGURE_IDE to allow for other IDE's.

Author: ericwf Date: Wed Dec 16 17:41:05 2015 New Revision: 255851 URL: http://llvm.org/viewvc/llvm-project?rev=255851&view=rev Log: Add CMake option LIBCXX_CONFIGURE_IDE to allow for other IDE's. CLion needs similar configuration changes as MSVC_IDE and XCODE. Modified: libcxx/trunk/CMakeLi

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

tra added a comment. Ping. @rsmith -- Richard, can you take a look at this change as well? http://reviews.llvm.org/D15309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

tra added a comment. Ping. @rsmith -- Richard, can you take a look? http://reviews.llvm.org/D15305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15586: [WebAssembly] Initial linking support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL255848: [WebAssembly] Initial linking support. (authored by djg). Changed prior to commit: http://reviews.llvm.org/D15586?vs=43059&id=43075#toc Repository: rL LLVM http://reviews.llvm.org/D15586 Fi

r255848 - [WebAssembly] Initial linking support.

Author: djg Date: Wed Dec 16 17:30:41 2015 New Revision: 255848 URL: http://llvm.org/viewvc/llvm-project?rev=255848&view=rev Log: [WebAssembly] Initial linking support. This begins minimal support for invoking 'ld' from clang for WebAssembly targets. Differential Revision: http://reviews.llvm.or

r255843 - Update for llvm api change.

Author: rafael Date: Wed Dec 16 17:16:37 2015 New Revision: 255843 URL: http://llvm.org/viewvc/llvm-project?rev=255843&view=rev Log: Update for llvm api change. Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp URL: http://llvm.org/viewvc/ll

r255840 - Fix funciton->function typo.

Author: echristo Date: Wed Dec 16 17:10:46 2015 New Revision: 255840 URL: http://llvm.org/viewvc/llvm-project?rev=255840&view=rev Log: Fix funciton->function typo. Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/trunk/lib/AST/MicrosoftMangle.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 43072. nwilson added a comment. - Move IsConcept bit and associated member functions from FunctionDecl to FunctionTemplateDecl. - Set the IsConcept flag using getDescribedFunctionTemplate. http://reviews.llvm.org/D13357 Files: include/clang/AST/DeclTempl

r255838 - Update for llvm API change.

Author: rafael Date: Wed Dec 16 16:59:09 2015 New Revision: 255838 URL: http://llvm.org/viewvc/llvm-project?rev=255838&view=rev Log: Update for llvm API change. Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp Modified: cfe/trunk/lib/Front

[PATCH] D15591: [Bugfix] Make type deduction work more nicely with unaddressable functions

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. Given: ``` void foo(int i) __attribute__((enable_if(i < 0, ""))); void foo(double d); auto fooToCall = foo; ``` ...We currently can't determine the type of `fo

[PATCH] D15589: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf.

timshen created this revision. timshen added a subscriber: cfe-commits. Add long long/double support for vec_cts, vec_ctu and vec_ctf. Similar to this change in GCC: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02653.html http://reviews.llvm.org/D15589 Files: lib/Headers/altivec.h test/Co

[PATCH] D15590: [Bugfix] Disqualify unaddressable overload candidates when a function is directly called indirectly.

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. "directly called indirectly" wasn't a typo; I can't think of a better name for this pattern. :) Currently, Sema treats `foo()` and `(&foo)()` both as direct cal

[libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert calls operator new when no insert occurs". That fix didn't apply to `unordered_map` because unordered_map::value_type gets packed inside: -- union __value_type { pair __nc; // Only C++11 or higher. pair __cc; // Always.

Re: [PATCH] D15585: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf in altivec.h

timshen abandoned this revision. timshen added a comment. Due to unknown reasons, Phabricator is not sending emails to the list. Kill this revision and create another one to see. http://reviews.llvm.org/D15585 ___ cfe-commits mailing list cfe-commi

r255827 - Fix CFI tests in sanitizer-ld.

Author: eugenis Date: Wed Dec 16 16:03:39 2015 New Revision: 255827 URL: http://llvm.org/viewvc/llvm-project?rev=255827&view=rev Log: Fix CFI tests in sanitizer-ld. This test is not testing what it is supposed to test because of a mixup with the CHECK lines. Modified: cfe/trunk/test/Driver/s

[PATCH] D15586: [WebAssembly] Initial linking support.

sunfish created this revision. sunfish added subscribers: cfe-commits, jfb, dschuff. sunfish set the repository for this revision to rL LLVM. This begins minimal support for invoking 'ld' from clang for WebAssembly targets. Repository: rL LLVM http://reviews.llvm.org/D15586 Files: lib/Driv

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM with some tests cases. http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

beanz created this revision. beanz added reviewers: bogner, silvas, chandlerc. beanz added a subscriber: cfe-commits. This patch adds support for the clang multi-stage bootstrapping to support PGO profdata generation, and can build a 2 or 3 stage compiler. With this patch applied you can configu

Re: [PATCH] D15577: [PS4] Fix the unit test to be compatible with clang driver. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL255814: [PS4] Fix the unit test to be compatible with clang driver. NFC (authored by sgundapa). Changed prior to commit: http://reviews.llvm.org/D15577?vs=43038&id=43049#toc Repository: rL LLVM http

r255814 - [PS4] Fix the unit test to be compatible with clang driver. NFC

Author: sgundapa Date: Wed Dec 16 14:18:12 2015 New Revision: 255814 URL: http://llvm.org/viewvc/llvm-project?rev=255814&view=rev Log: [PS4] Fix the unit test to be compatible with clang driver. NFC ".exe" extension is inherently checked by llvm::fs::can_execute() This patch fixes the linker exte

r255813 - [CMake] Name the bootstrap stages stage[0-9]

Author: cbieneman Date: Wed Dec 16 14:17:07 2015 New Revision: 255813 URL: http://llvm.org/viewvc/llvm-project?rev=255813&view=rev Log: [CMake] Name the bootstrap stages stage[0-9] When you start chaining bootstrap stages the CMake-generated targets get unwieldy. This change supports naming the

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. In http://reviews.llvm.org/D15539#312336, @jroelofs wrote: > In http://reviews.llvm.org/D15539#312332, @bcraig wrote: > > > In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > > > > > What does having them be `long double`s give over just multiplying the > > > co

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. In http://reviews.llvm.org/D15539#312336, @jroelofs wrote: > In http://reviews.llvm.org/D15539#312332, @bcraig wrote: > > > In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > > > > > What does having them be `long double`s give over just multiplying the > > >

Re: [patch] Let -Wdelete-non-virtual-dtor mention that making the class final is a good fix too

r255812, thanks! On Mon, Dec 14, 2015 at 6:45 PM, David Blaikie wrote: > LGTM, please commit (if you like, if you want to wait for other feedback > that's OK too) > > On Tue, Dec 15, 2015 at 2:15 AM, Nico Weber wrote: > >> On Sun, Dec 13, 2015 at 6:57 PM, David Blaikie >> wrote: >> >>> (attach

r255812 - Let -Wdelete-non-virtual-dtor mention final.

Author: nico Date: Wed Dec 16 14:07:24 2015 New Revision: 255812 URL: http://llvm.org/viewvc/llvm-project?rev=255812&view=rev Log: Let -Wdelete-non-virtual-dtor mention final. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/test/SemaCXX/destructor.cpp Modified: c

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. In http://reviews.llvm.org/D15539#312332, @bcraig wrote: > In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > > > What does having them be `long double`s give over just multiplying the > > counts by 16 (or however big it is on your platform)? Alignment? > > >

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > What does having them be `long double`s give over just multiplying the counts > by 16 (or however big it is on your platform)? Alignment? > > Seems like it'd be better to start with a prime that's ~16x larger, s

r255809 - Add -fsyntax-only to fix failure in read-only directories.

Author: dnovillo Date: Wed Dec 16 13:52:05 2015 New Revision: 255809 URL: http://llvm.org/viewvc/llvm-project?rev=255809&view=rev Log: Add -fsyntax-only to fix failure in read-only directories. Internally, this test is executed in a read-only directory, which causes it to fail because the driver

Re: [PATCH] D15577: [PS4] Fix the unit test to be compatible with clang driver. NFC

probinson accepted this revision. probinson added a reviewer: probinson. probinson added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. What does having them be `long double`s give over just multiplying the counts by 16 (or however big it is on your platform)? Alignment? Seems like it'd be better to start with a prime that's ~16x larger, say 211, than to have that factor of 16 floating around everywher

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig updated this revision to Diff 43041. bcraig added a comment. Starting primes at 13, and skipping the larger twin in twin prime pairs. Using long double instead of char for padding to help alleviate fears of multiple structs having the same actual size. http://reviews.llvm.org/D15539 F

Re: [PATCH] D15579: Fix the failing windows clang unit tests. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL255804: Fix the failing windows clang unit tests. NFC (authored by sgundapa). Changed prior to commit: http://reviews.llvm.org/D15579?vs=43022&id=43040#toc Repository: rL LLVM http://reviews.llvm.or

r255804 - Fix the failing windows clang unit tests. NFC

Author: sgundapa Date: Wed Dec 16 13:09:51 2015 New Revision: 255804 URL: http://llvm.org/viewvc/llvm-project?rev=255804&view=rev Log: Fix the failing windows clang unit tests. NFC Some tests are missing the {{(.exe)?}} suffix on the exectables which the FileCheck is grepping for. This will ensur

Re: [PATCH] D15577: [PS4] Fix the unit test to be compatible with clang driver. NFC

sgundapa updated this revision to Diff 43038. http://reviews.llvm.org/D15577 Files: lib/Driver/Tools.cpp test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c === --- test/Driver/sanitizer-ld.c +++ test/Driver/sanitizer-l

Re: [PATCH] D15577: [PS4] Fix the unit test to be compatible with clang driver. NFC

sgundapa added a comment. GetProgramPath will take care of the extension. I will change the line to "{{.*}}ld{{(.gold)?(.exe)?}}" as per your suggestion and push a new patch http://reviews.llvm.org/D15577 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D15534: [CUDA] renamed cuda_runtime.h wrapper to __clang_cuda_runtime_wrapper.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL255802: [CUDA] renamed cuda_runtime.h wrapper to __cuda_runtime.h (authored by tra). Changed prior to commit: http://reviews.llvm.org/D15534?vs=43025&id=43034#toc Repository: rL LLVM http://reviews.

r255802 - [CUDA] renamed cuda_runtime.h wrapper to __cuda_runtime.h

Author: tra Date: Wed Dec 16 12:51:59 2015 New Revision: 255802 URL: http://llvm.org/viewvc/llvm-project?rev=255802&view=rev Log: [CUDA] renamed cuda_runtime.h wrapper to __cuda_runtime.h Currently it's easy to break CUDA compilation by passing "-isystem /path/to/cuda/include" to compiler which l

r255801 - [CMake] If you're building compiler-rt, the bootstrap build should depend on it.

Author: cbieneman Date: Wed Dec 16 12:49:12 2015 New Revision: 255801 URL: http://llvm.org/viewvc/llvm-project?rev=255801&view=rev Log: [CMake] If you're building compiler-rt, the bootstrap build should depend on it. Adding optional dependency for the bootstrap targets on compiler-rt. Modified:

Re: [PATCH] D15577: [PS4] Fix the unit test to be compatible with clang driver. NFC

probinson added a subscriber: probinson. probinson added a comment. So, mainly you want calls to GetProgramPath not to provide the .exe extension, even on Windows? Comment at: test/Driver/sanitizer-ld.c:382 @@ -381,3 +381,3 @@ // RUN: | FileCheck --check-prefix=CHECK-UBSAN-P

r255799 - [CMake] Make CLANG_BOOTSTRAP_TARGETS overridable

Author: cbieneman Date: Wed Dec 16 12:45:53 2015 New Revision: 255799 URL: http://llvm.org/viewvc/llvm-project?rev=255799&view=rev Log: [CMake] Make CLANG_BOOTSTRAP_TARGETS overridable This allows exposing a custom list of targets from the next stage build up. Modified: cfe/trunk/CMakeLists.

r255798 - [CMake] ExternalProject for compiler-rt needs to depend on llvm-config and clang

Author: cbieneman Date: Wed Dec 16 12:42:14 2015 New Revision: 255798 URL: http://llvm.org/viewvc/llvm-project?rev=255798&view=rev Log: [CMake] ExternalProject for compiler-rt needs to depend on llvm-config and clang The add_dependencies call on compiler-rt-configure adds llvm-config and clang t

Re: [PATCH] D15579: Fix the failing windows clang unit tests. NFC

yaron.keren added a comment. http://bb.pgr.jp/grid http://reviews.llvm.org/D15579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

rjmccall added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1866 @@ +1865,3 @@ + let Content = [{ +The attribute ``__attribute__((ifunc("resolver")))`` is used to mark a function as an indirect function using the STT_GNU_IFUNC symbol type extension to the ELF st

Re: [PATCH] D15534: [CUDA] renamed cuda_runtime.h wrapper to __clang_cuda_runtime_wrapper.h

tra updated this revision to Diff 43025. tra marked 3 inline comments as done. tra added a comment. Incorporated Chandler's suggestions. Fixed #include_next -> #include. http://reviews.llvm.org/D15534 Files: lib/Driver/ToolChains.cpp lib/Headers/CMakeLists.txt lib/Headers/__clang_cuda_run

Re: [PATCH] D15534: [CUDA] renamed cuda_runtime.h wrapper to __clang_cuda_runtime_wrapper.h

tra added inline comments. Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:95 @@ -78,3 +94,3 @@ #define __CUDACC__ #include_next "cuda_runtime.h" jhen wrote: > Now that the name of this header has been changed, would it be appropriate to > change this

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

rjmccall added a comment. Richard should really be the one to sign off on this, since he's been managing the review so far. I am curious why we decided to handle this separately instead of treating it as a different attribute spelling kind. http://reviews.llvm.org/D10599 __

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

That would destroy the timing information, but no one seems to be paying attention to that anyway. I recommend just picking smaller buffer sizes. But 11 is too small. Small enough to pass on your embedded platform, but not in the range of a typical alignof(max_align_t). Howard On Dec 16, 20

Re: [PATCH] D15579: Fix the failing windows clang unit tests. NFC

sgundapa added a comment. I can not seem to possibly find a windows community bot. It would be nice if some one can point me to that. http://reviews.llvm.org/D15579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D15579: Fix the failing windows clang unit tests. NFC

sgundapa created this revision. sgundapa added reviewers: martell, yaron.keren, dougk, chapuni. sgundapa added a subscriber: cfe-commits. All the tests are missing the {{(.exe)?}} suffix on the exectables which the FileCheck is grepping for. http://reviews.llvm.org/D15579 Files: test/Driver/m

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

rjmccall added a comment. I'm sorry for the delay. It looks fine, thanks. http://reviews.llvm.org/D12614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15577: [PS4] Fix the unit test to be compatible with clang driver. NFC

sgundapa created this revision. sgundapa added reviewers: eugenis, filcab. sgundapa added a subscriber: cfe-commits. ".exe" extension is inherently checked by llvm::fs::can_execute() This patch fixes the linker extension in clang driver and updates the unit test to accommodate the the check string

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

probinson added a comment. In http://reviews.llvm.org/D15222#311896, @MaggieYi wrote: > Could someone commit it for me please (as I do not have commit access)? Thanks Done. Thanks Maggie! Repository: rL LLVM http://reviews.llvm.org/D15222 ___

r255784 - [PS4][Profile] add "--dependent-lib=libclang_rt.profile-x86_64.a" to

Author: probinson Date: Wed Dec 16 11:25:27 2015 New Revision: 255784 URL: http://llvm.org/viewvc/llvm-project?rev=255784&view=rev Log: [PS4][Profile] add "--dependent-lib=libclang_rt.profile-x86_64.a" to the CC1 command line when enabling code coverage. Patch by Ying Yi! Differential Revision:

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

This revision was automatically updated to reflect the committed changes. Closed by commit rL255784: [PS4][Profile] add "--dependent-lib=libclang_rt.profile-x86_64.a" to (authored by probinson). Changed prior to commit: http://reviews.llvm.org/D15222?vs=42874&id=43020#toc Repository: rL LLVM

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

alexfh added a comment. Thank you for explaining. The use case seems to be important enough to support it. And the solution seems to be good for now. A few concerns: 1. `Werrors` isn't a good name for this. The only reason why a similar thing is called `-Werror` in compilers is that they use `-

Re: r254195 - [x86] Exclusion of incorrect include headers paths for MCU target

No problem, stuff happens. :) On Wed, Dec 16, 2015 at 5:32 AM, Andrey Bokhanko wrote: > Correct patch committed in r255766. > > Yours, > Andrey > > On Wed, Dec 16, 2015 at 2:11 PM, Andrey Bokhanko > wrote: > > Reid, Hal, > > > > I'm really sorry for this -- indeed what I committed (by a mistake

r255773 - Make matchers thread compatible, so we can pass them to different threads and run them on multiple translation units in parallel.

Author: klimek Date: Wed Dec 16 09:48:58 2015 New Revision: 255773 URL: http://llvm.org/viewvc/llvm-project?rev=255773&view=rev Log: Make matchers thread compatible, so we can pass them to different threads and run them on multiple translation units in parallel. Modified: cfe/trunk/include/c

[clang-tools-extra] r255772 - [clang-tidy] google-readability-namespace-comments: ignore stray semicolons

Author: alexfh Date: Wed Dec 16 09:44:42 2015 New Revision: 255772 URL: http://llvm.org/viewvc/llvm-project?rev=255772&view=rev Log: [clang-tidy] google-readability-namespace-comments: ignore stray semicolons Modified: clang-tools-extra/trunk/clang-tidy/readability/NamespaceCommentCheck.cpp

[clang-tools-extra] r255770 - [clang-tidy] Add namespace support to add_new_check.py

Author: alexfh Date: Wed Dec 16 09:05:27 2015 New Revision: 255770 URL: http://llvm.org/viewvc/llvm-project?rev=255770&view=rev Log: [clang-tidy] Add namespace support to add_new_check.py Summary: Without namespace you can not create checks with same name in different modules Reviewers: alexfh

Re: [PATCH] D15571: Add namespace support to add_new_check.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL255770: [clang-tidy] Add namespace support to add_new_check.py (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D15571?vs=43007&id=43008#toc Repository: rL LLVM http://reviews.

Re: [PATCH] D15571: Add namespace support to add_new_check.py

congliu marked 2 inline comments as done. congliu added a comment. Replace namespace with module -- Done. Remove extra space after module -- Done. http://reviews.llvm.org/D15571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D15571: Add namespace support to add_new_check.py

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you! I'll commit the patch for you. http://reviews.llvm.org/D15571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D15571: Add namespace support to add_new_check.py

congliu updated this revision to Diff 43007. congliu added a comment. Replaced namespace with module; Removed extra space after module at line 103 http://reviews.llvm.org/D15571 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py

Re: [PATCH] D15571: Add namespace support to add_new_check.py

alexfh added inline comments. Comment at: clang-tidy/add_new_check.py:99 @@ -97,1 +98,3 @@ + 'check_name_dashes': check_name_dashes, + 'namespace': module}) Thinking about this once again, let's replace `namespace` with `module` for consistency. ==

[PATCH] D15571: Add namespace support to add_new_check.py

congliu created this revision. congliu added a reviewer: alexfh. congliu added a subscriber: cfe-commits. Without namespace you can not create checks with same name in different modules http://reviews.llvm.org/D15571 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py ==

RE: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

Hi Pekka, Re-attaching as a full patch again as something went wrong earlier with the diff wrapping in the email. Thanks, Anastasia -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Anastasia Stulova via cfe-commits Sent: 07 December 2015 17:

Re: [PATCH] D12834: add gcc abi_tag support

foutrelis added a comment. We have received a few reports of clang crashes after applying the abi_tag support patch to our llvm/clang package in Arch Linux. Compiling F1182170: test.cc with `clang++ -std=c++14 -c test.cc` should trigger the segmentation fault

Re: [PATCH] D15070: [mips] Added support for -Wa, -mips32 and similar.

dsanders requested changes to this revision. This revision now requires changes to proceed. Comment at: lib/Driver/Tools.cpp:2501-2524 @@ -2500,2 +2500,26 @@ } + +const char *Feature = llvm::StringSwitch(Value) + .Case("-mips1", "+

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi added a comment. Could someone commit it for me please (as I do not have commit access)? Thanks http://reviews.llvm.org/D15222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

As an alternative, would it be acceptable to heap allocate these objects, using the original padding numbers? On 12/15/2015 5:11 PM, Howard Hinnant wrote: On Dec 15, 2015, at 5:30 PM, Jonathan Roelofs wrote: Could these large padding things be related to the fact that the test is used as a

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a subscriber: bcraig. bcraig added a comment. As an alternative, would it be acceptable to heap allocate these objects, using the original padding numbers? http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [Lldb-commits] Buildbot numbers for week of 12/06/2015 - 12/12/2015

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15.12.2015 20:23, Galina Kistanova via lldb-commits wrote: > Hello everyone, > > Below are some buildbot numbers for the last week of 12/06/2015 - > 12/12/2015. > > Thanks > > Galina > > > > Top 10 fastest builders(not docs): > > lldb-amd6

Re: r254195 - [x86] Exclusion of incorrect include headers paths for MCU target

Correct patch committed in r255766. Yours, Andrey On Wed, Dec 16, 2015 at 2:11 PM, Andrey Bokhanko wrote: > Reid, Hal, > > I'm really sorry for this -- indeed what I committed (by a mistake) is > still WIP. > > Yours, > Andrey > > > On Sat, Dec 5, 2015 at 4:56 AM, Reid Kleckner wrote: >> It loo

  1   2   >