r254846 - [AST] Use std::copy and std::fill to simplify some memcpy and memset calls. Also const-correct some methods being used since the std::copy catches the mismatch where memcpy didn't.

Author: ctopper Date: Sat Dec 5 01:41:44 2015 New Revision: 254846 URL: http://llvm.org/viewvc/llvm-project?rev=254846&view=rev Log: [AST] Use std::copy and std::fill to simplify some memcpy and memset calls. Also const-correct some methods being used since the std::copy catches the mismatch wh

r254845 - Use std::copy and std::transform instead of manual loops. NFC

Author: ctopper Date: Sat Dec 5 01:41:42 2015 New Revision: 254845 URL: http://llvm.org/viewvc/llvm-project?rev=254845&view=rev Log: Use std::copy and std::transform instead of manual loops. NFC Modified: cfe/trunk/lib/AST/Stmt.cpp Modified: cfe/trunk/lib/AST/Stmt.cpp URL: http://llvm.org/

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

carlo.bertolli updated this revision to Diff 41983. carlo.bertolli added a comment. Update dist_schedule patch to reflect changes in distribute directive patch. Repository: rL LLVM http://reviews.llvm.org/D15220 Files: include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisito

r254839 - Pass profile version info to name API (NFC)

Author: davidxl Date: Fri Dec 4 23:37:15 2015 New Revision: 254839 URL: http://llvm.org/viewvc/llvm-project?rev=254839&view=rev Log: Pass profile version info to name API (NFC) Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.cpp URL: http://llvm.or

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:460 @@ -449,4 +459,3 @@ DKind == OMPD_single || DKind == OMPD_parallel_for || - DKind == OMPD_parallel_for_simd || - DKind == OMPD_parallel_sections; // TODO add next directives.

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli updated this revision to Diff 41980. carlo.bertolli marked 7 inline comments as done. carlo.bertolli added a comment. This updated patch includes taskloop simd changes form the trunk and it addresses the second round of comments. Repository: rL LLVM http://reviews.llvm.org/D15

[PATCH] D15255: Remove false positive from -Wpessimizing-move and GNU statement expressions

rtrieu created this revision. rtrieu added a subscriber: cfe-commits. Track whether the initialization came from a GNU statement expression. If it does, prevent the -Wpessiming-move warning from being emitted since the suggested fix can cause a compile error. Fix for https://llvm.org/bugs/show

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

hans added inline comments. Comment at: lib/Serialization/ASTReader.cpp:3390 @@ -3393,5 +3389,3 @@ Mod->getExportedModules(Exports); -for (SmallVectorImpl::iterator - I = Exports.begin(), E = Exports.end(); I != E; ++I) { - Module *Exported = *I; +for (

[PATCH] D15254: Fix crash when dumping NamedDecl with NULL getQualifier().

dawn created this revision. dawn added reviewers: rsmith, alexfh. dawn added a subscriber: cfe-commits. dawn set the repository for this revision to rL LLVM. This fixes calls to the dump() routine for cases when the NamedDecl's getQualifier() is NULL. Since ASTDumper is a debugging utility, it s

Re: [clang-tools-extra] r254785 - Added coverage check for extensionless headers, and exclude hidden dot directoryies.

On Fri, Dec 4, 2015 at 6:04 PM, John Thompson < john.thompson.jtsoftw...@gmail.com> wrote: > >Aren't we already rejecting directories in the line `if (type == > sys::fs::file_type::directory_file)` above? Why check the filename? > > The iterator will walk the directories. That statement just keep

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

rjmccall added a comment. Yes, I think that's a reasonable approach. http://reviews.llvm.org/D14980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r254785 - Added coverage check for extensionless headers, and exclude hidden dot directoryies.

>Aren't we already rejecting directories in the line `if (type == sys::fs::file_type::directory_file)` above? Why check the filename? The iterator will walk the directories. That statement just keeps the directories out of the file list. The iterator also give the relative path from the starting

Re: r254195 - [x86] Exclusion of incorrect include headers paths for MCU target

It looks like the wrong patch got committed with the original description of D14954 . I reverted it in r254823. Feel free to commit the header change, it looks fine. On Fri, Nov 27, 2015 at 5:57 AM, Hal Finkel via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

r254823 - Revert "[x86] Exclusion of incorrect include headers paths for MCU target"

Author: rnk Date: Fri Dec 4 19:52:14 2015 New Revision: 254823 URL: http://llvm.org/viewvc/llvm-project?rev=254823&view=rev Log: Revert "[x86] Exclusion of incorrect include headers paths for MCU target" This reverts commit r254195. From the description, I suspect that the wrong patch was commi

r254817 - [WebAssembly] Remove an obsolete TODO comment.

Author: djg Date: Fri Dec 4 19:36:31 2015 New Revision: 254817 URL: http://llvm.org/viewvc/llvm-project?rev=254817&view=rev Log: [WebAssembly] Remove an obsolete TODO comment. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL: http://llvm.org/viewvc/ll

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added a comment. I've been mostly looking at the path sensitive checks. Maybe clang-tidy team would be interested in reviewing the syntactic checks. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Container.h:31 @@ +30,2 @@ + +#endif A

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r254785 - Added coverage check for extensionless headers, and exclude hidden dot directoryies.

On Fri, Dec 4, 2015 at 2:42 PM, John Thompson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jtsoftware > Date: Fri Dec 4 16:42:18 2015 > New Revision: 254785 > > URL: http://llvm.org/viewvc/llvm-project?rev=254785&view=rev > Log: > Added coverage check for extensionless headers,

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. (Feel free to add comments to the existing code!) > So the real question is whether (or rather how) the Store should maintain > correct region liveness information > after comp

[PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-loop-convert. Autos are used for pointer variables assigned via c

r254806 - [analyzer] Fix MemRegion crash casting non-struct to derived struct (PR25426).

Author: dcoughlin Date: Fri Dec 4 18:22:36 2015 New Revision: 254806 URL: http://llvm.org/viewvc/llvm-project?rev=254806&view=rev Log: [analyzer] Fix MemRegion crash casting non-struct to derived struct (PR25426). This commit prevents MemRegion::getAsOffset() from crashing when the analyzed prog

Re: [PATCH] D15208: Patch for inline abort code generation

danielaustin updated this revision to Diff 41957. danielaustin added a comment. Added a flag controlling whether or not the inlining occurs. Tested with ARM 32 bit (shamu) with AOSP. The patched compiler resulted in correct code generation and no stability issues. The flag is probably not ideall

r254798 - [Docs] One more cleanup of -fsanitize= section.

Author: samsonov Date: Fri Dec 4 17:13:14 2015 New Revision: 254798 URL: http://llvm.org/viewvc/llvm-project?rev=254798&view=rev Log: [Docs] One more cleanup of -fsanitize= section. Describe -fsanitize-blacklist flags in separate paragraphs, move notes about importance of clang++ for vptr down t

r254797 - [CMake] Don't build the libclang tests unless you're building libclang

Author: cbieneman Date: Fri Dec 4 17:12:19 2015 New Revision: 254797 URL: http://llvm.org/viewvc/llvm-project?rev=254797&view=rev Log: [CMake] Don't build the libclang tests unless you're building libclang This fixes a build issue reported by users at Apple. Modified: cfe/trunk/unittests/CM

Re: [PATCH] D14938: Fix implicit conversion from _Nullable to _Nonnull warnings in C++

george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D14938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15246: [Docs] Update MSan docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL254788: [Docs] Update MSan docs (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D15246?vs=41941&id=41946#toc Repository: rL LLVM http://reviews.llvm.org/D15246 Files: cfe/

r254788 - [Docs] Update MSan docs

Author: samsonov Date: Fri Dec 4 16:50:44 2015 New Revision: 254788 URL: http://llvm.org/viewvc/llvm-project?rev=254788&view=rev Log: [Docs] Update MSan docs Summary: 1. Move MSan-specific flags and features from user manual to MSan page. 2. Update current status / list of supported platforms.

Re: [PATCH] D15246: [Docs] Update MSan docs

samsonov marked 2 inline comments as done. samsonov added a comment. Addressed, thanks! http://reviews.llvm.org/D15246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

rjmccall added inline comments. Comment at: lib/Sema/SemaPseudoObject.cpp:232 @@ -231,3 +231,3 @@ /// Return true if assignments have a non-void result. -bool CanCaptureValue(Expr *exp) { +bool CanCaptureValue(Expr *exp) const { if (exp->isGLValue()) --

Re: [PATCH] D13731: [Analyzer] Supporting function attributes in .model files.

zaks.anna added a comment. Pierre, Have you seen the post about API Notes? http://llvm.cc/t/cfe-dev-clang-and-swift/331 I believe using API notes would be a better approach for adding annotations. By the time the static analyzer sees the AST, the annotations would already be there. The API Not

[clang-tools-extra] r254785 - Added coverage check for extensionless headers, and exclude hidden dot directoryies.

Author: jtsoftware Date: Fri Dec 4 16:42:18 2015 New Revision: 254785 URL: http://llvm.org/viewvc/llvm-project?rev=254785&view=rev Log: Added coverage check for extensionless headers, and exclude hidden dot directoryies. Added: clang-tools-extra/trunk/test/modularize/Inputs/CoverageNoProbl

Re: [PATCH] D15246: [Docs] Update MSan docs

eugenis accepted this revision. This revision is now accepted and ready to land. Comment at: docs/MemorySanitizer.rst:109 @@ -107,3 +108,3 @@ MemorySanitizer can track origins of unitialized values, similar to Valgrind's --track-origins option. This feature is enabled by -

[PATCH] D15246: [Docs] Update MSan docs

samsonov created this revision. samsonov added reviewers: eugenis, kcc. samsonov added a subscriber: cfe-commits. 1. Move MSan-specific flags and features from user manual to MSan page. 2. Update current status / list of supported platforms. http://reviews.llvm.org/D15246 Files: docs/MemorySan

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added a comment. Bump, is there anything else that's needed here? http://reviews.llvm.org/D13330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson updated this revision to Diff 41935. tejohnson added a comment. - Move ownership of FunctionInfoIndex onto EmitAssemblyHelper http://reviews.llvm.org/D15025 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/clang/Driver/Types.h include/clang/Fr

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254771: [Docs] Move the list of CFI schemes down to CFI doc, and update it. (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D15237?vs=41905&id=41933#toc Repository: rL LLVM

r254771 - [Docs] Move the list of CFI schemes down to CFI doc, and update it.

Author: samsonov Date: Fri Dec 4 15:30:58 2015 New Revision: 254771 URL: http://llvm.org/viewvc/llvm-project?rev=254771&view=rev Log: [Docs] Move the list of CFI schemes down to CFI doc, and update it. Use proper headling levels in CFI doc. Before that, all sections were considered a subsection

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

beanz added a comment. Mostly formatting comments. I think for the most part this is the right way to go, but I don't really feel qualified to approve this. The one thing I'm not sure about on this is, do we really want this to be darwin-only? I kinda think it might be nice if we unified this b

Re: [PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

alexfh added a comment. Sorry for the delay. Missed this patch somehow. A couple of comments in addition to what Aaron wrote. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h:25 @@ +24,3 @@ +class ProBoundsConstantArrayIndexCheck : public ClangTidyChe

Re: [PATCH] D15203: clang-tidy readability identifiers: better diagnostic location

This revision was automatically updated to reflect the committed changes. Closed by commit rL254766: clang-tidy readability identifiers: better diagnostic location (authored by aizatsky). Changed prior to commit: http://reviews.llvm.org/D15203?vs=41794&id=41931#toc Repository: rL LLVM http:

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. Please remove the asm tests here. As I stated in the original review thread there's no reason for them to be here. Thanks. -eric http://reviews.llvm.org/D15223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang-tools-extra] r254766 - clang-tidy readability identifiers: better diagnostic location

Author: aizatsky Date: Fri Dec 4 14:57:03 2015 New Revision: 254766 URL: http://llvm.org/viewvc/llvm-project?rev=254766&view=rev Log: clang-tidy readability identifiers: better diagnostic location Summary: With this change the error reported is on the identifier location itself. It was declarati

Re: [PATCH] D15203: clang-tidy readability identifiers: better diagnostic location

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D15203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson updated this revision to Diff 41926. tejohnson added a comment. - Use new renameModuleForThinLTO helper function from llvm. - Fix tests I have not change the option name yet. Wanted to be sure we have a name that reflects the fact that this is a special compile that changes the compi

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r254756 - Backing out 254635 until I have a good workaround and test case.

Author: jtsoftware Date: Fri Dec 4 13:44:03 2015 New Revision: 254756 URL: http://llvm.org/viewvc/llvm-project?rev=254756&view=rev Log: Backing out 254635 until I have a good workaround and test case. Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp Modified: clang-tools

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

samsonov added inline comments. Comment at: docs/ControlFlowIntegrity.rst:23 @@ -22,6 +22,3 @@ To enable Clang's available CFI schemes, use the flag ``-fsanitize=cfi``. -As currently implemented, all of Clang's CFI schemes (``cfi-vcall``, -``cfi-derived-cast``, ``cfi-unrelated-ca

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

samsonov updated this revision to Diff 41905. samsonov marked 3 inline comments as done. samsonov added a comment. - Address pcc's comments. http://reviews.llvm.org/D15237 Files: docs/ControlFlowIntegrity.rst docs/UsersManual.rst Index: docs/UsersManual.rst

r254754 - Small follow-up to 254750 to get the test added there passing...

Author: nico Date: Fri Dec 4 13:35:45 2015 New Revision: 254754 URL: http://llvm.org/viewvc/llvm-project?rev=254754&view=rev Log: Small follow-up to 254750 to get the test added there passing... Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Re: [clang-tools-extra] r254635 - Fixed header determination logic. Was missing extensionless headers in coverage check.

I think you're right, though I don't understand why I don't see the failure locally. I will fix it or back it out. On Fri, Dec 4, 2015 at 9:52 AM, David Blaikie wrote: > Still missing test coverage? > > And I'm going to go out on a limb and guess this commit might be > responsible for this ong

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

pcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:23 @@ -22,6 +22,3 @@ To enable Clang's available CFI schemes, use the flag ``-fsanitize=cfi``. -As currently implemented, all of Clang's CFI schemes (``cfi-vcall``, -``cfi-derived-cast``, ``cfi-unrelated-cast``,

r254750 - Fix debug info for Objective-C properties from class extensions after r251874

Author: nico Date: Fri Dec 4 13:14:14 2015 New Revision: 254750 URL: http://llvm.org/viewvc/llvm-project?rev=254750&view=rev Log: Fix debug info for Objective-C properties from class extensions after r251874 After r251874, properties from class extensions no longer show up in ObjCInterfaceDecl::

Re: [PATCH] D15158: [PGO] Instrument only base constructors and destructors.

Serge Pavlov writes: > sepavloff updated this revision to Diff 41744. > sepavloff added a comment. > > Changes according to reviewer's notes. LGTM. > > http://reviews.llvm.org/D15158 > > Files: > lib/CodeGen/CGBlocks.cpp > lib/CodeGen/CGObjC.cpp > lib/CodeGen/CGStmt.cpp > lib/CodeGen/CGS

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D14877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

dcoughlin added a subscriber: dcoughlin. dcoughlin added a comment. In http://reviews.llvm.org/D13126#302328, @danielmarjamaki wrote: > When scanning 692 projects with this checker I got 56 warnings. I've triaged > 21 random warnings of these so far and saw 20 TP and 1 FP. > > When I have triage

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. Thanks Laszlo. I'm still not convinced that all the python package stuff is needed because scan-build is distributed with clang (see my question inline). Also, what do you think about renaming intercept-build to "log-build" or some of the other alternatives I propose

[PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

samsonov created this revision. samsonov added reviewers: pcc, kcc. samsonov added a subscriber: cfe-commits. Before that, all sections were considered a subsection of "Introduction". [Docs] Move the list of CFI schemes down to CFI doc, and update it. http://reviews.llvm.org/D15237 Files: doc

Re: [PATCH] D12352: Clang part -- Changing @llvm.objectsize(i8*, i1) to @llvm.objectsize(i8*, i8)

george.burgess.iv abandoned this revision. george.burgess.iv added a comment. Patch is no longer necessary -- clang can handle `objectsize` well enough on its own. http://reviews.llvm.org/D12352 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [clang-tools-extra] r254635 - Fixed header determination logic. Was missing extensionless headers in coverage check.

Still missing test coverage? And I'm going to go out on a limb and guess this commit might be responsible for this ongoing regression: http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/26746 (no other commits in that build seem like likely candidates) On Thu, Dec 3, 2015 at 11:3

r254734 - [Docs] Remove false claim: UBSan can also be combined with TSan/MSan.

Author: samsonov Date: Fri Dec 4 11:35:47 2015 New Revision: 254734 URL: http://llvm.org/viewvc/llvm-project?rev=254734&view=rev Log: [Docs] Remove false claim: UBSan can also be combined with TSan/MSan. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: [PATCH] D15217: Clang documentation for UBSan.

samsonov added a comment. Thanks! Addressed the comments. Repository: rL LLVM http://reviews.llvm.org/D15217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15217: Clang documentation for UBSan.

This revision was automatically updated to reflect the committed changes. samsonov marked 5 inline comments as done. Closed by commit rL254733: Clang documentation for UBSan. (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D15217?vs=41823&id=41891#toc Repository: rL

r254733 - Clang documentation for UBSan.

Author: samsonov Date: Fri Dec 4 11:30:29 2015 New Revision: 254733 URL: http://llvm.org/viewvc/llvm-project?rev=254733&view=rev Log: Clang documentation for UBSan. Summary: Create a separate page describing UBSan tool, move the description of fine-grained checks there, provide extra information

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

rmaprath added a comment. Ping? http://reviews.llvm.org/D14653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:29 @@ +28,3 @@ +ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "GslHeader", GslHeader); +} Why GslHeader but not IncludeStyle?

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

> On Dec 4, 2015, at 9:14 AM, Teresa Johnson wrote: > > tejohnson added inline comments. > > > Comment at: lib/CodeGen/CodeGenAction.cpp:822 > @@ +821,3 @@ > + TheModule = std::move(Combined); > +} > + > > joker.eph wrote: >> tejohnson wrote: >>> joker

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + joker.eph wrote: > tejohnson wrote: > > joker.eph wrote: > > > tejohnson wrote: > > > > joker.eph wrote: > > > > > Could we

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + tejohnson wrote: > joker.eph wrote: > > tejohnson wrote: > > > joker.eph wrote: > > > > Could we refactor this in a helper

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + joker.eph wrote: > tejohnson wrote: > > joker.eph wrote: > > > Could we refactor this in a helper in llvm? > > I can create

Re: [PATCH] D15228: [PATCH] New diagnostic for non-idiomatic copy or move operations

aaron.ballman added a comment. As I wade through a lot of diagnostics from our test suite, I notice a recurring pattern is that this is diagnosing in the presence of idiomatic constructors or assignment operators. e.g., struct S { S(const S&) = delete; S(S&); // We diagnose, and sugge

r254723 - [PS4] Add an additional test for ASan+UBSan

Author: filcab Date: Fri Dec 4 10:18:03 2015 New Revision: 254723 URL: http://llvm.org/viewvc/llvm-project?rev=254723&view=rev Log: [PS4] Add an additional test for ASan+UBSan Modified: cfe/trunk/test/Driver/fsanitize.c Modified: cfe/trunk/test/Driver/fsanitize.c URL: http://llvm.org/viewv

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + tejohnson wrote: > joker.eph wrote: > > Could we refactor this in a helper in llvm? > I can create a new Linker interface t

Re: [PATCH] D15228: [PATCH] New diagnostic for non-idiomatic copy or move operations

aaron.ballman added a comment. I should note for clarity, this is a WIP. There are still a lot of test cases that require updating due to the new diagnostic. I also wanted to get a feel for whether people felt this belongs under -Wall or not. http://reviews.llvm.org/D15228 _

Re: [PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254718: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D15007?vs=41494&id=41876#toc Repository: rL LLVM

r254718 - [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

Author: xazax Date: Fri Dec 4 09:02:30 2015 New Revision: 254718 URL: http://llvm.org/viewvc/llvm-project?rev=254718&view=rev Log: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414. Differential Revision: http://reviews.llvm.org/D15007 Modified: cfe/trunk/lib/StaticAnal

Re: [PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Thanks Gabor! http://reviews.llvm.org/D15007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson added a comment. > Talked with Duncan, we're not convinced about -fthinlto-backend=... for the > option name: the word backend does not seems right here. What about > -fthinlto-index=...? I wanted to express that this was invoking a different pipeline, and distinguish from a normal

[PATCH] D15228: [PATCH] New diagnostic for non-idiomatic copy or move operations

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie. aaron.ballman added a subscriber: cfe-commits. All copy operations were created equal (as far as the core language is concerned), but some copy operations are more equal than others (as far as the library is co

Re: [PATCH] D14441: [OpenCL] Pipe types support.

pekka.jaaskelainen added a comment. Is this still waiting for some updates? http://reviews.llvm.org/D14441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15208: Patch for inline abort code generation

Makes sense, will add that as well. On Thu, Dec 3, 2015 at 4:10 PM Alexey Samsonov wrote: > samsonov added a comment. > > I agree with Richard here. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D15208 > > > > ___ cfe-commits mailing list c

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin updated this revision to Diff 41866. DmitryPolukhin added a comment. Added TODO. http://reviews.llvm.org/D14980 Files: lib/AST/RecordLayoutBuilder.cpp test/Sema/bitfield-layout.c Index: test/Sema/bitfield-layout.c =

[PATCH] D15227: [analyzer] Valist checkers.

xazax.hun created this revision. xazax.hun added reviewers: dcoughlin, zaks.anna, jordan_rose. xazax.hun added subscribers: dkrupp, cfe-commits. This checker was developed by Donat Nagy (m1nag...@gmail.com) and myself. It finds usages of uninitialized va_lists, and also unterminated va_lists.

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki updated this revision to Diff 41858. danielmarjamaki added a comment. Another diff. This time I have stripped the checker to make it simpler to review, triage, etc. It will now only warn about loss of precision in assignments when RHS is a variable. For me, triaging these resul

[PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

labrinea created this revision. labrinea added reviewers: jmolloy, rengolin, echristo, cfe-commits. Herald added subscribers: rengolin, aemerson. Existing tests are currently testing generated backend assembly. We want to test the generated frontend IR as well. As discussed on the list we would l

[PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi created this revision. MaggieYi added reviewers: filcab, probinson, jmagee, phillip.power. MaggieYi added a subscriber: cfe-commits. Dear All, This patch adds “--dependent-lib= libclang_rt.profile-x86_64.a” to the compiler command line when enabling code coverage on the PS4 target. A

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

ABataev updated this revision to Diff 41848. ABataev added a comment. Update after review http://reviews.llvm.org/D15174 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp test/SemaCXX/ms-property-error.cpp test/SemaCXX/ms-property.cpp Index: lib/Sema/SemaPseudoObject

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin added inline comments. Comment at: lib/AST/RecordLayoutBuilder.cpp:1606 @@ +1605,3 @@ +} else if (ExplicitFieldAlign && + Context.getTargetInfo().useBitFieldTypeAlignment()) + FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAl

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

rjmccall added inline comments. Comment at: lib/AST/RecordLayoutBuilder.cpp:1606 @@ +1605,3 @@ +} else if (ExplicitFieldAlign && + Context.getTargetInfo().useBitFieldTypeAlignment()) + FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAlign);

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

John, Actually both, subscripts and references. Ok, got will do. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 04.12.2015 12:00, John McCall пишет: > rjmccall added a comment. > > In http://reviews.llvm.org/D15174#302248, @ABataev wrote: > >> John, >> the resul

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

rjmccall added a comment. In http://reviews.llvm.org/D15174#302248, @ABataev wrote: > John, > the result is always the result of Put operation. For pre-increment we > have to return new value, for the post-increment - previous value > returned by Get (checked it on MSVC). > So, currently po

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

ABataev added inline comments. Comment at: include/clang-c/Index.h:2263-2267 @@ -2262,3 +2262,7 @@ - CXCursor_LastStmt = CXCursor_OMPTaskLoopDirective, + /** \brief OpenMP distribute directive. + */ + CXCursor_OMPDistributeDirective= 259, + +

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

John, the result is always the result of Put operation. For pre-increment we have to return new value, for the post-increment - previous value returned by Get (checked it on MSVC). So, currently postincrement works correctly, pre-increment and assignment not. For pre-increment and assignment we