r253128 - Mark is_destructible/is_nothrow_destructible as implemented

Author: majnemer Date: Sat Nov 14 01:21:35 2015 New Revision: 253128 URL: http://llvm.org/viewvc/llvm-project?rev=253128&view=rev Log: Mark is_destructible/is_nothrow_destructible as implemented These were implemented back in r244564. However, I forgot to update the docs. Modified: cfe/trun

Re: r252834 - Provide a frontend based error for always_inline functions that require

This all sounds a little weird as _mm_mul_ps only requires sse. Can you give me a testcase and command line that you're using to trigger this? Thanks! -eric On Fri, Nov 13, 2015 at 8:28 PM Bruno Cardoso Lopes wrote: > Hi Eric, > > This is very nice! > > After the addition of this feature, LNT

Re: r252834 - Provide a frontend based error for always_inline functions that require

Hi Eric, This is very nice! After the addition of this feature, LNT started crashing on x86_64h: FAIL: SingleSource/UnitTests/Vector/SSE/sse_expandfft.compile_time (3 of 2244) FAIL: SingleSource/UnitTests/Vector/SSE/sse_isamax.compile_time (4 of 2244) FAIL: SingleSource/UnitTests/Vector/SSE/sse_

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Thank you! Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:23 @@ +22,3 @@ + if (const auto *FnTy = Node.getType()->getAs()) { +// If any

Re: [PATCH] Allow "redefinition" of typedef of anon tag from unimported submodule

> On Nov 13, 2015, at 5:32 PM, Ben Langmuir via cfe-commits > wrote: > > >> On Nov 13, 2015, at 4:20 PM, Richard Smith > > wrote: >> >> On Fri, Nov 13, 2015 at 4:03 PM, Ben Langmuir via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> This time sendi

r253123 - [modules] Allow "redefinition" of typedef of anon tag from unimported submodule

Author: benlangmuir Date: Fri Nov 13 21:26:14 2015 New Revision: 253123 URL: http://llvm.org/viewvc/llvm-project?rev=253123&view=rev Log: [modules] Allow "redefinition" of typedef of anon tag from unimported submodule r233345 started being stricter about typedef names for linkage purposes in non-

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Nov 12 23:14:45 2015 > New Revision: 253012 > > URL: http://llvm.org/viewvc/llvm-project?rev=253012&view=rev > Log: > [modules] When a declaration has non-trivial visibi

Re: r252834 - Provide a frontend based error for always_inline functions that require

On Wed, Nov 11, 2015 at 5:38 PM Richard Smith wrote: > On Wed, Nov 11, 2015 at 5:25 PM, Eric Christopher > wrote: > >> On Wed, Nov 11, 2015 at 5:03 PM Richard Smith >> wrote: >> >>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> >>

r253121 - Add support for the always_inline + target feature diagnostic to print

Author: echristo Date: Fri Nov 13 20:38:37 2015 New Revision: 253121 URL: http://llvm.org/viewvc/llvm-project?rev=253121&view=rev Log: Add support for the always_inline + target feature diagnostic to print out the first missing target feature that's required and reword the diagnostic accordingly.

Re: [Diffusion] rL248379: Refactor library decision for -fopenmp support from Darwin into a

tstellarAMD added a project: 3.7.1-merged. Users: joerg (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) rsmith (Auditor) http://reviews.llvm.org/rL248379 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: r252834 - Provide a frontend based error for always_inline functions that require

Hi Akira, I don't think there's currently a good reason we don't perform a diagnostic there, just right now we'd have to say something bland like "unable to inline always_inline function 'foo'" without a reason. We might not have gotten a diagnostic in the past because of compatibility reasons/tra

Re: r252834 - Provide a frontend based error for always_inline functions that require

On Thu, Nov 12, 2015 at 11:55 AM Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Eric Christopher via cfe-commits > > Sent: Wednesday, November 11, 2015 4:44 PM > > T

Re: [Diffusion] rL248424: Push OpenMP linker flags after linker input on Darwin. Don't add any

tstellarAMD added a project: 3.7.1-merged. Users: joerg (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) rsmith (Auditor) http://reviews.llvm.org/rL248424 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [Diffusion] rL248426: Support linking against OpenMP runtime on NetBSD.

tstellarAMD added a project: 3.7.1-merged. Users: joerg (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) rsmith (Auditor) http://reviews.llvm.org/rL248426 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [Diffusion] rL251335: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

tstellarAMD added a project: 3.7.1-merged. Users: ismailp (Author) rsmith (Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) http://reviews.llvm.org/rL251335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

r253119 - Use %select to merge similar diagnostics. NFC

Author: ctopper Date: Fri Nov 13 20:09:55 2015 New Revision: 253119 URL: http://llvm.org/viewvc/llvm-project?rev=253119&view=rev Log: Use %select to merge similar diagnostics. NFC Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td cfe/trunk/lib/Lex/Lexer.cpp cfe/trunk/lib/L

r253117 - Clarify and elaborate the conditions on which we're checking target

Author: echristo Date: Fri Nov 13 19:56:04 2015 New Revision: 253117 URL: http://llvm.org/viewvc/llvm-project?rev=253117&view=rev Log: Clarify and elaborate the conditions on which we're checking target features for calls. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/Co

Re: [PATCH] Allow "redefinition" of typedef of anon tag from unimported submodule

> On Nov 13, 2015, at 4:20 PM, Richard Smith wrote: > > On Fri, Nov 13, 2015 at 4:03 PM, Ben Langmuir via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > This time sending to the right list address. > > Likewise =) > > > On Nov 13, 2015, at 4:00 PM, Ben Langmuir >

Re: r252872 - Update clang regression tests for 'norecurse'

Did some cleaning up in r253114 On Thu, Nov 12, 2015 at 8:18 AM, James Molloy wrote: > Hi David, > > Honestly, I really don't know. I just updated them due to a change in LLVM > - I hadn't considered doing an audit. > > James > > On Thu, 12 Nov 2015 at 16:08 David Blaikie via cfe-commits < > cfe

r253114 - Make some tests LLVM-optimization agnostic and remove some others that were beyond value/repair

Author: dblaikie Date: Fri Nov 13 19:10:38 2015 New Revision: 253114 URL: http://llvm.org/viewvc/llvm-project?rev=253114&view=rev Log: Make some tests LLVM-optimization agnostic and remove some others that were beyond value/repair Several of these tests (the two deleted, and the one removal edit

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL253107: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13973?vs=38359&id=40188#toc Repository: rL LLVM ht

r253107 - CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

Author: mgehre Date: Fri Nov 13 18:36:50 2015 New Revision: 253107 URL: http://llvm.org/viewvc/llvm-project?rev=253107&view=rev Log: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt Summary: VisitReturnStmt would create a new block with including Dtors, so the Dtors created in

Re: [PATCH] D13263: Addition of __attribute__((pass_object_size)) to Clang

george.burgess.iv updated this revision to Diff 40185. george.burgess.iv marked 22 inline comments as done. george.burgess.iv added a comment. - Removed pass_object_size-related information from FunctionType - Unified enable_if/pass_object_size error handling when the address of a function with e

Re: [PATCH] D13263: Addition of __attribute__((pass_object_size)) to Clang

george.burgess.iv added inline comments. Comment at: include/clang/AST/Expr.h:631-634 @@ -630,1 +630,6 @@ + /// tryEvaluateObjectSize - If the current Expr is a pointer, this will try to + /// statically determine how many bytes remain in the object this pointer is + /// poi

Re: [PATCH] Allow "redefinition" of typedef of anon tag from unimported submodule

On Fri, Nov 13, 2015 at 4:03 PM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This time sending to the right list address. Likewise =) > On Nov 13, 2015, at 4:00 PM, Ben Langmuir wrote: > > > > Hey Richard, > > > > After your commit r233345 we started diagnosing “redefin

Re: [PATCH] Allow "redefinition" of typedef of anon tag from unimported submodule

This time sending to the right list address. > On Nov 13, 2015, at 4:00 PM, Ben Langmuir wrote: > > Hey Richard, > > After your commit r233345 we started diagnosing “redefinition” errors for > typedefs of anonymous tags that are *not visible* in case like this: > > module that isn’t imported:

Re: [PATCH] D13834: Produce a better diagnostic for global register variables

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! -eric http://reviews.llvm.org/D13834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r253104 - Revert "[AArch64] Unconditionally pass subtarget feature reserve-x18 on Darwin."

Author: bogner Date: Fri Nov 13 17:07:31 2015 New Revision: 253104 URL: http://llvm.org/viewvc/llvm-project?rev=253104&view=rev Log: Revert "[AArch64] Unconditionally pass subtarget feature reserve-x18 on Darwin." This reverts r243310, which is redundant as of r253102. Conflicts: lib/Dri

r253099 - [CMake] Don't install c-index-test when LLVM_INSTALL_TOOLCHAIN_ONLY=ON.

Author: akirtzidis Date: Fri Nov 13 16:41:14 2015 New Revision: 253099 URL: http://llvm.org/viewvc/llvm-project?rev=253099&view=rev Log: [CMake] Don't install c-index-test when LLVM_INSTALL_TOOLCHAIN_ONLY=ON. Modified: cfe/trunk/tools/c-index-test/CMakeLists.txt Modified: cfe/trunk/tools/c-i

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 updated this revision to Diff 40176. kkwli0 added a comment. Update the patch after the first review. http://reviews.llvm.org/D14134 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/Dia

r253081 - Fix build... again

Author: jroelofs Date: Fri Nov 13 15:04:14 2015 New Revision: 253081 URL: http://llvm.org/viewvc/llvm-project?rev=253081&view=rev Log: Fix build... again Modified: cfe/trunk/tools/scan-build/Makefile Modified: cfe/trunk/tools/scan-build/Makefile URL: http://llvm.org/viewvc/llvm-project/cfe/

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

aaron.ballman added a comment. Aside from one question, LGTM. ~Aaron Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2003 @@ +2002,3 @@ +def err_concept_specified_specialization : Error< + "%'concept' cannot be applied on an " + "%select{explicit instantiation|explicit

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

Sure, r253066. 2015-11-13 19:40 GMT+02:00 Rafael Espíndola : > This needs a testcase. Nothing is checking the linker invocation. > > On 14 July 2015 at 01:23, Yaron Keren wrote: > > Author: yrnkrn > > Date: Tue Jul 14 00:23:34 2015 > > New Revision: 242121 > > > > URL: http://llvm.org/viewvc/ll

r253069 - Relax mingw-useld test to fix bot failures.

Author: yrnkrn Date: Fri Nov 13 14:02:08 2015 New Revision: 253069 URL: http://llvm.org/viewvc/llvm-project?rev=253069&view=rev Log: Relax mingw-useld test to fix bot failures. Modified: cfe/trunk/test/Driver/mingw-useld.c Modified: cfe/trunk/test/Driver/mingw-useld.c URL: http://llvm.org/

r253068 - [scan-build] Move non user-facing utilities to share

Author: jroelofs Date: Fri Nov 13 13:56:07 2015 New Revision: 253068 URL: http://llvm.org/viewvc/llvm-project?rev=253068&view=rev Log: [scan-build] Move non user-facing utilities to share Added: cfe/trunk/tools/scan-view/share/Reporter.py - copied unchanged from r253045, cfe/trunk/tools

r253066 - Add test case for mingw -fuse-ld= support introduced in r242121.

Author: yrnkrn Date: Fri Nov 13 13:46:02 2015 New Revision: 253066 URL: http://llvm.org/viewvc/llvm-project?rev=253066&view=rev Log: Add test case for mingw -fuse-ld= support introduced in r242121. Added: cfe/trunk/test/Driver/mingw-useld.c Added: cfe/trunk/test/Driver/mingw-useld.c URL: h

r253060 - Fix auto-link for text-based dynamic library SDKs.

Author: ributzka Date: Fri Nov 13 13:08:07 2015 New Revision: 253060 URL: http://llvm.org/viewvc/llvm-project?rev=253060&view=rev Log: Fix auto-link for text-based dynamic library SDKs. When linking against text-based dynamic library SDKs the library name of a framework has now more than one poss

Re: [PATCH] D13144: [CUDA] propagate to CUDA sub-compilations target triple of opposite side.

tra updated this revision to Diff 40163. tra added a comment. Added a FIXME note regarding figuring out which compilation pass we're constructing. Undone the change to make getToolchain public as it's no longer accessed from outside of Driver. Converted the if(AuxToolchain) into assert. http:/

Re: [PATCH] D14662: [ARM] Pass architecture to TargetParser defaulting to cope with API change

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM http://reviews.llvm.org/D14662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

This needs a testcase. Nothing is checking the linker invocation. On 14 July 2015 at 01:23, Yaron Keren wrote: > Author: yrnkrn > Date: Tue Jul 14 00:23:34 2015 > New Revision: 242121 > > URL: http://llvm.org/viewvc/llvm-project?rev=242121&view=rev > Log: > Add support for -fuse-ld= in the mingw

[PATCH] D14662: [ARM] Pass architecture to TargetParser defaulting to cope with API change

bsmith created this revision. bsmith added a reviewer: rengolin. bsmith added a subscriber: cfe-commits. bsmith set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. The TargetParser API to get the default FPU and extensions will change in D14661, this is

r253055 - Slacken the norecurse test slightly

Author: jamesm Date: Fri Nov 13 11:29:18 2015 New Revision: 253055 URL: http://llvm.org/viewvc/llvm-project?rev=253055&view=rev Log: Slacken the norecurse test slightly It has been reported that this test currently fails on some Power buildbots due to them adding a "signext" function attribute.

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

srhines added a comment. Aidan did ask me about upstreaming this particular (reworked) patch from our Android repository, so I did consent to submitting it. I can try to put together a test case for our particular differences. Repository: rL LLVM http://reviews.llvm.org/D14639 __

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

On Fri, Nov 13, 2015 at 2:00 AM, Aidan Dodds via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ADodds created this revision. > ADodds added reviewers: asl, rsmith. > ADodds added subscribers: pirama, cfe-commits. > ADodds set the repository for this revision to rL LLVM. > Herald added subscri

r253046 - Deduplicate three identical copies of isExplicitInstantiationOrSpecialization, NFC.

Author: yrnkrn Date: Fri Nov 13 09:39:39 2015 New Revision: 253046 URL: http://llvm.org/viewvc/llvm-project?rev=253046&view=rev Log: Deduplicate three identical copies of isExplicitInstantiationOrSpecialization, NFC. Modified: cfe/trunk/include/clang/AST/DeclTemplate.h cfe/trunk/include

Re: r253016 - scan-build: Fix install.

On 11/12/15 11:48 PM, NAKAMURA Takumi via cfe-commits wrote: Author: chapuni Date: Fri Nov 13 00:48:02 2015 New Revision: 253016 URL: http://llvm.org/viewvc/llvm-project?rev=253016&view=rev Log: scan-build: Fix install. My bad... thanks! Jon Modified: cfe/trunk/tools/scan-build/CMa

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman updated this revision to Diff 40149. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated to address review comments. http://reviews.llvm.org/D14619 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/Thr

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman marked 4 inline comments as done. Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:18 @@ +17,3 @@ +namespace { +AST_MATCHER(CXXConstructorDecl, isNoThrowCopyConstructible) { + if (!Node.isCopyConstructor()) alexfh wrote: > nit: I suggest cha

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

hubert.reinterpretcast added a comment. Comment added inline. Otherwise, LGTM. Comment at: lib/Sema/SemaDecl.cpp:7659 @@ +7658,3 @@ +Diag(D.getDeclSpec().getConceptSpecLoc(), + diag::err_concept_specified_specialization) << 1; + } I don'

[PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

rmaprath created this revision. rmaprath added reviewers: mclow.lists, jroelofs, rengolin. rmaprath added a subscriber: cfe-commits. Summary: r252598 and r252870 added XFAILs to all those tests that are currently failing on the -fno-exceptions libc++ library variant. This patch introduces a mecha

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

On Thu, Nov 12, 2015 at 8:51 PM, Argyrios Kyrtzidis wrote: > I assume you are referring to the install-c-index-test target, this should > not be added to IDEs after r253001. Indeed, it is fixed for me now. Thank you! ~Aaron > >> On Nov 12, 2015, at 7:29 AM, Aaron Ballman wrote: >> >> Is this

Re: [PATCH] D14441: [OpenCL] Pipe types support.

pxli168 added a comment. F1095908: pipelog.txt This is the log of runing clang -cc1 -emit-llvm -cl-std=CL2.0 -o - pipe_types.c Comment at: test/CodeGenOpenCL/pipe_types.cl:7 @@ +6,3 @@ + +void test1(read_only pipe int p) { +// CHECK: define vo

[PATCH] D14639: LLDB JIT needs android vector passing rules.

ADodds created this revision. ADodds added reviewers: asl, rsmith. ADodds added subscribers: pirama, cfe-commits. ADodds set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer, aemerson. Looking into some recent issues with LLDBs expression parse

[PATCH] D14652: [analyzer] Improve modeling of static initializers.

ygribov created this revision. ygribov added reviewers: zaks.anna, dcoughlin, jordan_rose. ygribov added a subscriber: cfe-commits. Conversions between unrelated pointer types (e.g. char * and void *) involve bitcasts which were not properly modeled in case of static initializers. The patch fixe

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

spetrovic set the repository for this revision to rL LLVM. spetrovic updated this revision to Diff 40143. spetrovic marked 2 inline comments as done. spetrovic added a comment. Comments addressed. Repository: rL LLVM http://reviews.llvm.org/D13351 Files: include/clang/Basic/DiagnosticDrive

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

alexfh added a comment. Much better now. A few more comments. Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:18 @@ +17,3 @@ +namespace { +AST_MATCHER(CXXConstructorDecl, isNoThrowCopyConstructible) { + if (!Node.isCopyConstructor()) nit: I suggest cha

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

a.sidorin added a comment. Sorry, I misunderstood your first question. This case is OK because CStringChecker handles invalidation and shouldn't track invalidated regions until their lengths become known. Test strlen_global() (string.c:106) should confirm this. Repository: rL LLVM http://r

[clang-tools-extra] r253036 - [clang-tidy] Remove unused #includes.

Author: alexfh Date: Fri Nov 13 06:16:10 2015 New Revision: 253036 URL: http://llvm.org/viewvc/llvm-project?rev=253036&view=rev Log: [clang-tidy] Remove unused #includes. Summary: Testing Phab with git-svn Reviewers: alexfh Differential Revision: http://reviews.llvm.org/D14649 Modified: cl

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

ayartsev added a comment. In http://reviews.llvm.org/D14629#288478, @jroelofs wrote: > `CommonStuff.pm` (which could stand to have a more descriptive name, > `libscanbuild.pm` maybe?) and `scan-build.cfg` belong in `share`. Got it, I'll rename `CommonStuff.pm` and put it to `share` in the next

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

a.sidorin added a comment. > - What happens when you take a string's length, test it against something, > throw it away, then remeasure the string? In this case we'd be okay because > CStringChecker still hangs on to the symbol in its map until the region is > invalidated. We cannot throw out

RE: r253011 - clang/test/Driver/mips-mti-linux.c: Tweak to match DOSish paths.

Thank you for making this run on win buildbots! - Vasileios From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of NAKAMURA Takumi via cfe-commits [cfe-commits@lists.llvm.org] Sent: 13 November 2015 04:44 To: cfe-commits@lists.llvm.org Subject

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. In http://reviews.llvm.org/D14471#288621, @ahatanak wrote: > In getAArch64TargetCPU, if it finds out the cpu name passed via -mtune or > -mcpu is "native", > > 1. Call llvm::sys::getHostCPUName to get the host CPU name. > 2. Check the host CPU name to see if it is a val