Would citing PR20455 help? It wasn't actually my primary motivation but it's
not too far off. Having the template parameters there lets you know what's
going on in the DWARF, without having to fetch and parse the name string of
every struct you come across. Actually I'm not sure parsing the n
Author: davidxl
Date: Wed Nov 4 23:46:39 2015
New Revision: 252147
URL: http://llvm.org/viewvc/llvm-project?rev=252147&view=rev
Log:
Use profile data template file for covmap func record (NFC)
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMap
nwilson updated this revision to Diff 39314.
nwilson added a comment.
- Cover variadic arguments in check for no params.
- Add tests to cover variadic arguments.
http://reviews.llvm.org/D14352
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/concepts-ts/dcl
michaelwu added inline comments.
Comment at: test/Index/symbol-visibility.c:8
@@ +7,3 @@
+// CHECK: FunctionDecl=foo1:3:47visibility=Default
+// CHECK: FunctionDecl=foo2:4:49visibility=Protected
+// CHECK: FunctionDecl=foo3:5:46visibility=Hidden
skalinichev wrote:
Test case?
On Wed, Nov 4, 2015 at 3:44 PM, Tamas Berghammer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> tberghammer created this revision.
> tberghammer added a reviewer: echristo.
> tberghammer added a subscriber: cfe-commits.
>
> Add new compiler flag to enable the generation of dwar
On Wed, Nov 4, 2015 at 1:07 PM, Richard Smith wrote:
> On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote:
>
>> On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote:
>>
>>> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek
>>> wrote:
>>>
On Tue, Oct 20, 2015 at 10:41 AM Sean Silva
wrote:
On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote:
>
>
> On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote:
>
>> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote:
>>
>>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva
>>> wrote:
>>>
On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek
w
Author: alexfh
Date: Wed Nov 4 20:30:21 2015
New Revision: 252138
URL: http://llvm.org/viewvc/llvm-project?rev=252138&view=rev
Log:
Accommodate interface change in r252134.
Modified:
clang-tools-extra/trunk/modularize/Modularize.cpp
Modified: clang-tools-extra/trunk/modularize/Modularize.cp
tinti marked 2 inline comments as done.
Comment at: lib/Frontend/CompilerInvocation.cpp:459
@@ +458,3 @@
+StringRef Value = A->getValue();
+bool Valid = llvm::StringSwitch(Value)
+ .Case("default", true)
This part of the code does not i
tinti updated this revision to Diff 39304.
tinti added a comment.
Clang format.
Repository:
rL LLVM
http://reviews.llvm.org/D14184
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/Driver/Tools.cpp
lib/Frontend/CompilerIn
Author: alexfh
Date: Wed Nov 4 20:19:53 2015
New Revision: 252134
URL: http://llvm.org/viewvc/llvm-project?rev=252134&view=rev
Log:
Make ArgumentAdjuster aware of the current file being processed.
Summary:
This is needed to handle per-project configurations when adding extra
arguments in clang-t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252134: Make ArgumentAdjuster aware of the current file
being processed. (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D14191?vs=38776&id=39303#toc
http://reviews.llvm.org/D141
eugenis added inline comments.
Comment at: test/SemaCXX/internal_linkage.cpp:23
@@ +22,3 @@
+
+__attribute__((internal_linkage)) void A::f4() {} //
expected-error{{'internal_linkage' attribute does not appear on the first
declaration of 'f4'}}
+
Btw, this trigge
probinson added a comment.
GCC 4.8.4 on Linux doesn't produce these, but DWARF 4 section 5.5.8 says a
class template instantiation is just like the equivalent non-template class
entry, with the exception of the template parameter entries. I read that as
meaning an incomplete description (i.e.
Author: chapuni
Date: Wed Nov 4 19:34:19 2015
New Revision: 252128
URL: http://llvm.org/viewvc/llvm-project?rev=252128&view=rev
Log:
TestModuleFileExtension.cpp: Include explicitly for fprintf(3).
Modified:
cfe/trunk/lib/Frontend/TestModuleFileExtension.cpp
Modified: cfe/trunk/lib/Frontend
Author: rsmith
Date: Wed Nov 4 19:30:19 2015
New Revision: 252125
URL: http://llvm.org/viewvc/llvm-project?rev=252125&view=rev
Log:
[modules] Don't merge an anonymous enum definition into a named enum definition.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/test/Modules/merge-enum
djasper added a subscriber: djasper.
Comment at: clang-tidy/ClangTidy.cpp:46
@@ +45,3 @@
+
+#include "llvm/ADT/StringExtras.h"
+
This doesn't seem to be the right place for this #include.
Comment at: clang-tidy/ClangTidyOptions.h:89-93
@@ -86,1 +
djasper added a subscriber: djasper.
djasper accepted this revision.
djasper added a reviewer: djasper.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D14191
___
cfe-commits mailing list
aprantl added a comment.
Unless this is some kind of optimization that we specifically added to minimize
debug info size (I have never looked at our template support in detail), this
looks totally reasonable. Do other compilers do the same here?
http://reviews.llvm.org/D14358
__
Author: majnemer
Date: Wed Nov 4 19:10:42 2015
New Revision: 252120
URL: http://llvm.org/viewvc/llvm-project?rev=252120&view=rev
Log:
Fix build break
Modified:
cfe/trunk/lib/Lex/PPMacroExpansion.cpp
Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp
URL:
http://llvm.org/viewvc/llvm-project/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252115: [Lex] Add __has_builtin support for
__make_integer_seq (authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D14349?vs=39258&id=39294#toc
Repository:
rL LLVM
http://review
Author: majnemer
Date: Wed Nov 4 19:01:47 2015
New Revision: 252115
URL: http://llvm.org/viewvc/llvm-project?rev=252115&view=rev
Log:
[Lex] Add __has_builtin support for __make_integer_seq
Differential Revision: http://reviews.llvm.org/D14349
Modified:
cfe/trunk/lib/Lex/PPMacroExpansion.cpp
Author: rsmith
Date: Wed Nov 4 18:54:55 2015
New Revision: 252114
URL: http://llvm.org/viewvc/llvm-project?rev=252114&view=rev
Log:
[modules] If we're given a module file, via -fmodule-file=, for a module, but
we can't load that file due to a configuration mismatch, and implicit module
building i
probinson added a comment.
In debug-info-template-member.cpp, some things came out in a different order;
that's the only change there.
http://reviews.llvm.org/D14358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
probinson created this revision.
probinson added reviewers: echristo, dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
We were forgetting the template parameters on the forward declaration of a
template class.
http://reviews.llvm.org/D14358
Files:
lib/CodeGen/CGDebugInfo.cpp
t
Author: rnk
Date: Wed Nov 4 18:24:01 2015
New Revision: 252107
URL: http://llvm.org/viewvc/llvm-project?rev=252107&view=rev
Log:
Fix nullptr crash in -Wthread-safety-beta
Modified:
cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyCommon.h
cfe/trunk/test/SemaCXX/warn-thread-safety-an
klimek marked 2 inline comments as done.
klimek added a comment.
Addressed comments.
http://reviews.llvm.org/D14353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek updated this revision to Diff 39287.
klimek added a comment.
Remove unnecessary if and fix segfault.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: tes
Thanks! Commit in r252104.
~Aaron
On Wed, Nov 4, 2015 at 7:05 PM, Richard Smith wrote:
> LGTM, thanks!
>
> On Wed, Nov 4, 2015 at 4:00 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> On Wed, Nov 4, 2015 at 5:46 PM, Richard Smith
>> wrote:
>> > On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith
>>
rsmith added inline comments.
Comment at: lib/Lex/ModuleMap.cpp:235-237
@@ -234,5 +234,1 @@
return IsPrivateRole &&
- // FIXME: Should we map RequestingModule to its top-level module here
- //too? This check is redundant with the isSubModuleOf check in
-
Author: aaronballman
Date: Wed Nov 4 18:06:05 2015
New Revision: 252104
URL: http://llvm.org/viewvc/llvm-project?rev=252104&view=rev
Log:
The control expression for a _Generic selection expression should have
its type decayed and qualifiers stripped when determining which
selection it matches. Fi
LGTM, thanks!
On Wed, Nov 4, 2015 at 4:00 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Nov 4, 2015 at 5:46 PM, Richard Smith
> wrote:
> > On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith
> wrote:
> >>
> >> It'd be simpler and would more directly match the C spec
On Wed, Nov 4, 2015 at 5:46 PM, Richard Smith wrote:
> On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith wrote:
>>
>> It'd be simpler and would more directly match the C specification (and
>> would handle a few other cases better, such as placeholder types and atomic
>> types) if you instead passed t
tberghammer created this revision.
tberghammer added a reviewer: echristo.
tberghammer added a subscriber: cfe-commits.
Add new compiler flag to enable the generation of dwarf accelerator tables
The dwarf accelerator tables already generated on darwin platforms. This CL
ands a new flag to clang
Dushistov updated this revision to Diff 39264.
Dushistov added a comment.
I reduce testcase to almost minimal variant.
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
test/Analysis/qt_malloc.cpp
Index: test/Analysis/
Dushistov updated this revision to Diff 39265.
Dushistov added a comment.
Fix line length issue
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
test/Analysis/qt_malloc.cpp
Index: test/Analysis/qt_malloc.cpp
=
hubert.reinterpretcast added inline comments.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p5.cpp:7
@@ +6,2 @@
+template
+concept bool fcpi(int i = 0) { return true; } // expected-error {{function
concept cannot have any parameters}}
hubert.
klimek created this revision.
klimek added a reviewer: rsmith.
klimek added a subscriber: cfe-commits.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: test/Modul
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7575
@@ +7574,3 @@
+// following restrictions:
+// — The declaration’s parameter list shall be equivalent to an empty
+// parameter list.
I think the U+2014 s
rnk added a comment.
> ! In http://reviews.llvm.org/D14180#280193, @martell wrote:
>
> > You can then change the mingw headers to use
> > `__has_builtin(_InterlockedCompareExchange)` to provide compatibility with
> > either mode.
>
>
> Yes I could do this but this still won't work with t
ping
On Fri, Oct 16, 2015 at 2:51 PM, Akira Hatanaka wrote:
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> clang doesn't print a very user-friendly message when an invalid register
> is used for a global register variable:
>
> For example, when the following co
berenm marked an inline comment as done.
Comment at: lib/Format/WhitespaceManager.cpp:150-151
@@ -149,109 +149,4 @@
}
-// Walk through all of the changes and find sequences of "=" to align. To do
-// so, keep track of the lines and whether or not an "=" was found on align. If
dim added a subscriber: dim.
dim added auditors: 3.7-release, cfe-commits, tstellarAMD, hfinkel.
dim added a comment.
This got reported again in PR25397, and occurs during compilation of mpich.
Looks like a good candidate for 3.7.1.
Users:
hfinkel (Author, Auditor)
3.7-release (Auditor)
nwilson created this revision.
nwilson added reviewers: rsmith, faisalv, hubert.reinterpretcast, aaron.ballman.
nwilson added a subscriber: cfe-commits.
Diagnose when a function concept declaration has parameter(s)
http://reviews.llvm.org/D14352
Files:
include/clang/Basic/DiagnosticSemaKinds.t
djasper added a comment.
I like it :-)
Comment at: lib/Format/WhitespaceManager.cpp:151
@@ -150,13 +150,3 @@
-// Walk through all of the changes and find sequences of "=" to align. To do
-// so, keep track of the lines and whether or not an "=" was found on align. If
-// a "=
Author: djasper
Date: Wed Nov 4 16:49:32 2015
New Revision: 252089
URL: http://llvm.org/viewvc/llvm-project?rev=252089&view=rev
Log:
clang-format: Turn on wrapping before "else" for WebKit style.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http:
On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith wrote:
> It'd be simpler and would more directly match the C specification (and
> would handle a few other cases better, such as placeholder types and atomic
> types) if you instead passed the operand through DefaultLvalueConversion
>
or rather, Defa
It'd be simpler and would more directly match the C specification (and
would handle a few other cases better, such as placeholder types and atomic
types) if you instead passed the operand through DefaultLvalueConversion
rather than matching against the decayed form of the type.
On Wed, Nov 4, 2015
majnemer created this revision.
majnemer added a reviewer: rsmith.
majnemer added a subscriber: cfe-commits.
http://reviews.llvm.org/D14349
Files:
lib/Lex/PPMacroExpansion.cpp
test/SemaCXX/make_integer_seq.cpp
Index: test/SemaCXX/make_integer_seq.cpp
=
alexfh added a comment.
Ping.
http://reviews.llvm.org/D14192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Ping.
http://reviews.llvm.org/D14191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
In http://reviews.llvm.org/D14345#281475, @xazax.hun wrote:
> Hi!
>
> I think it is great to support this model in these scripts. Do you plan to
> check the list of the project urls in to the repository as well?
The project URLs are implicitly included in the downloa
Author: eugenezelenko
Date: Wed Nov 4 15:37:17 2015
New Revision: 252081
URL: http://llvm.org/viewvc/llvm-project?rev=252081&view=rev
Log:
Fix some Clang-tidy modernize warnings, other minor fixes.
Differential revision: http://reviews.llvm.org/D14311
Modified:
cfe/trunk/lib/AST/ASTContext.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252081: Fix some Clang-tidy modernize warnings, other minor
fixes. (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D14311?vs=39134&id=39252#toc
Repository:
rL LLVM
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252080: [analyzer] Add 'optin' checker package and move
localizability checkers into it. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D14303?vs=39102&id=39251#toc
Repositor
Author: dcoughlin
Date: Wed Nov 4 15:33:41 2015
New Revision: 252080
URL: http://llvm.org/viewvc/llvm-project?rev=252080&view=rev
Log:
[analyzer] Add 'optin' checker package and move localizability checkers into it.
This commit creates a new 'optin' top-level checker package and moves several of
dcoughlin marked an inline comment as done.
dcoughlin added a comment.
http://reviews.llvm.org/D14303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
In http://reviews.llvm.org/D13925#281349, @eugenis wrote:
> Hm, the current implementation allows all of the following:
>
> void f(int a [[clang::internal_linkage]]) { // 1
>
> int b [[clang::internal_linkage]]; // 2
> static int c [[clang::internal_linkage]]; //
eugenis updated this revision to Diff 39249.
Repository:
rL LLVM
http://reviews.llvm.org/D13925
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/Decl.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D14311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote:
> On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote:
>
>> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote:
>>
>>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva
>>> wrote:
>>>
On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek
wrote
eugenis updated this revision to Diff 39245.
Repository:
rL LLVM
http://reviews.llvm.org/D13925
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/Decl.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/
eugenis added a comment.
How do I check if a Var is a local variable?
Comment at: test/CodeGenCXX/attribute_internal_linkage.cpp:35-36
@@ +34,4 @@
+__attribute__((internal_linkage)) void A::f3() {
+}
+
+// Forward declaration w/o an attribute.
OK, done. Still al
ahatanak added a comment.
Thanks, I'll see how the review for the llvm-side patch goes and commit both
patches after it is approved.
http://reviews.llvm.org/D12922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
xazax.hun added a comment.
Hi!
I think it is great to support this model in these scripts. Do you plan to
check the list of the project urls in to the repository as well? I think it
would be great to do so, so one can easily reproduce a buildbot error locally,
or even run the whole testsuit. I
zaks.anna added a comment.
> > What is needed to turn this into a non-alpha checker?
>
>
> I guess that's question for maintainers) We have to consider that vfork is
> used rarely enough.
Please, make this into a non-alpha, turned on by default.
Thank you!
Anna.
http://reviews.llvm.org/
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:376
@@ -375,3 +375,3 @@
/// \brief Parse an expression statement.
StmtResult Parser::ParseExprStatement() {
// If a case keyword is missing, this is where it should be inserted.
> I don'
Author: alexfh
Date: Wed Nov 4 13:42:17 2015
New Revision: 252069
URL: http://llvm.org/viewvc/llvm-project?rev=252069&view=rev
Log:
Fixed a link.
Modified:
cfe/trunk/docs/ClangTools.rst
Modified: cfe/trunk/docs/ClangTools.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ClangToo
Author: alexfh
Date: Wed Nov 4 13:40:05 2015
New Revision: 252068
URL: http://llvm.org/viewvc/llvm-project?rev=252068&view=rev
Log:
Fixed header levels.
Modified:
cfe/trunk/docs/ClangTools.rst
Modified: cfe/trunk/docs/ClangTools.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/C
rnk added a comment.
This is an interesting test case, though:
inline int foo() {
static int __attribute__((internal_linkage)) x;
return x++;
}
If foo gets inlined, those call sites will use and update 'x'. If foo is not
inlined, one definition of foo will win, and every caller will
berenm updated this revision to Diff 39233.
berenm added a comment.
[clang-format] Remove deleted methods declaration.
http://reviews.llvm.org/D14325
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.
On Wed, Nov 4, 2015 at 11:36 AM, James Y Knight via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jyknight added inline comments.
>
> /cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 Looks like GCC's behavior does
> actually follow that spec.
>
> I'm not sure why the library exposes these entry-po
Author: alexfh
Date: Wed Nov 4 13:34:55 2015
New Revision: 252066
URL: http://llvm.org/viewvc/llvm-project?rev=252066&view=rev
Log:
Removed mentions of clang-modernize, added a short description of clang-tidy.
Modified:
cfe/trunk/docs/ClangTools.rst
Modified: cfe/trunk/docs/ClangTools.rst
U
jyknight added inline comments.
/cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 Looks like GCC's behavior does
actually follow that spec.
I'm not sure why the library exposes these entry-points when you're not
supposed to use them. Oop. Sorry that I failed to notice that.
Users:
jyknight (Author
berenm updated this revision to Diff 39232.
berenm added a comment.
[clang-format] Alignment code factorization.
http://reviews.llvm.org/D14325
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, krememek.
dcoughlin added a subscriber: cfe-commits.
Currently the SATestBuild.py and SATestAdd.py buildbot scripts expect project
sources to be checked into the project repository. This patch changes these
scripts to additiona
Author: rsmith
Date: Wed Nov 4 13:26:32 2015
New Revision: 252063
URL: http://llvm.org/viewvc/llvm-project?rev=252063&view=rev
Log:
[modules] Generalize the workaround for multiple ambiguous definitions of
internal linkage entities in different modules from r250884 to apply to all
names, not just
On Wed, Nov 4, 2015 at 2:20 PM, Evgeniy Stepanov wrote:
> eugenis added a comment.
>
> Hm, the current implementation allows all of the following:
>
> void f(int a [[clang::internal_linkage]]) { // 1
>
> int b [[clang::internal_linkage]]; // 2
> static int c [[clang::internal_linkage]]; //
The control expression for a _Generic selection expression should have
its type decayed and qualifiers stripped when determining which
selection it matches. e.g., the following should compile:
_Generic("test", char *: 1);
const int i = 12;
_Generic(i, int: 1);
This patch fixes PR16340.
~Aa
zaks.anna added a comment.
Test cases need to be small and self contained.
You might be having a problem with reproducing with a simple test case, where
you define QCoreApplication::postEvent in the test file because it is not
considered to be in the system header. You can use special pragmas
eugenis added a comment.
Hm, the current implementation allows all of the following:
void f(int a [[clang::internal_linkage]]) { // 1
int b [[clang::internal_linkage]]; // 2
static int c [[clang::internal_linkage]]; // 3
}
I'll fix (1). Is it OK to allow (2) and (3)? The attribute has
rsmith added inline comments.
Comment at: test/CodeGenCXX/attribute_internal_linkage.cpp:34-35
@@ +33,4 @@
+
+__attribute__((internal_linkage)) void A::f3() {
+}
+
We should reject this. We're just causing problems for ourselves if we allow
the linkage to change
rsmith added a subscriber: rsmith.
rsmith raised a concern with this commit.
/cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 According to the GCC documentation
for libatomic:
> for i = __atomic_add_fetch (ptr, j, model) the code generated will be
>
>tmp = __atomic_fetch_add (ptr, j, model);
zaks.anna added a comment.
See the comment below, otherwise, LGTM.
Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:23
@@ +22,3 @@
+
+def OptIn : Package<"optin">;
+
Please, add a comment describing for how this package should be used as you do
in the commit
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
The formatting is wrong, aligned to the right, clang-format the new code.
Can we control getInstalledDir() when running under LIT so this co
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith accepted this commit.
Users:
dim (Author)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
joerg (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL250657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
rsmith accepted this commit.
Users:
ismailp (Author)
rsmith (Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
http://reviews.llvm.org/rL251335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
eugenis added a comment.
Hi Eric,
could you please clarify what exactly you are looking for here?
Repository:
rL LLVM
http://reviews.llvm.org/D10677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252061: [Concepts] Add diagnostics which fall under
[dcl.spec.concept]p1 (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D14316?vs=39151&id=39215#toc
Repository:
rL LLVM
http
Author: nwilson
Date: Wed Nov 4 12:18:35 2015
New Revision: 252061
URL: http://llvm.org/viewvc/llvm-project?rev=252061&view=rev
Log:
[Concepts] Add diagnostics which fall under [dcl.spec.concept]p1
Summary: Diagnose when the 'concept' specifier is used on a typedef or function
parameter.
Revie
craig.topper added a comment.
Does icc have an intrinsic for it?
http://reviews.llvm.org/D11752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/Sema/SemaDecl.cpp:5374
@@ +5373,3 @@
+
+ // Virtual functions cannot be marked as 'notail'.
+ if (auto *Attr = ND.getAttr())
rmaprath added a comment.
In http://reviews.llvm.org/D14293#281183, @rengolin wrote:
> In http://reviews.llvm.org/D14293#281176, @jroelofs wrote:
>
> > I think this ^ is a reasonable solution.
>
>
> I'm fine with that, as long as everyone's happy.
>
> 160 XFAILs are ok (as long as you're fixing t
rengolin added a comment.
In http://reviews.llvm.org/D14293#281176, @jroelofs wrote:
> I think this ^ is a reasonable solution.
I'm fine with that, as long as everyone's happy.
160 XFAILs are ok (as long as you're fixing them), disabling the tests makes no
sense. :)
cheers,
--renato
http:/
jroelofs added a comment.
> Counter proposal, we mark all the currently failing (-fno-exceptions) test
> cases with:
>
> // XFAIL: libcpp-no-exceptions
>
>
> This has the following advantages:
>
> - No need to change buildbots to skip tests
> - The bots will catch any regressions
Author: hans
Date: Wed Nov 4 10:11:56 2015
New Revision: 252056
URL: http://llvm.org/viewvc/llvm-project?rev=252056&view=rev
Log:
clang-cl: Parse the /guard:cf[-] flag (PR25400)
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/
On Fri, Oct 9, 2015 at 10:37 AM, Aaron Ballman wrote:
> On Fri, Oct 9, 2015 at 8:53 AM, Aaron Ballman wrote:
>> On Thu, Oct 8, 2015 at 6:10 PM, Richard Smith wrote:
>>> On Thu, Oct 8, 2015 at 2:59 PM, Adrian Zgorzalek wrote:
Same story:
warning: 'ownership_takes' attribute only
1 - 100 of 123 matches
Mail list logo
