Re: [PATCH] D12736: [PATCH] AST traversal from types to decls

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. This is great, thanks! http://reviews.llvm.org/D12736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko added a comment. Reid, thank you for the review! One last confirmation (see below), and I'll go ahead. Yours, Andrey Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170 @@ -169,3 +169,3 @@ // it has a different calling conversion. - // CHECK4: call void @_ZN

r247389 - [OPENMP] Fix printing of array section with single index.

Author: abataev Date: Thu Sep 10 23:54:28 2015 New Revision: 247389 URL: http://llvm.org/viewvc/llvm-project?rev=247389&view=rev Log: [OPENMP] Fix printing of array section with single index. Modified: cfe/trunk/lib/AST/StmtPrinter.cpp cfe/trunk/test/OpenMP/task_ast_print.cpp Modified: c

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

rjmccall added a comment. LGTM. Comment at: lib/CodeGen/CGClass.cpp:1234 @@ -1233,1 +1233,3 @@ +static bool isInitilierOfDynamicClass(const CXXCtorInitializer *BaseInit) { + const Type *BaseType = BaseInit->getBaseClass(); "Initializer" But I think you can j

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

rjmccall added a comment. Sorry for putting off the final review on this; I was heads-down trying to get the alignment patch done. It's looking good; obviously you'll need to update it to work with Addresses properly, but hopefully that won't be too much of a problem. When you do, maybe you s

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rjmccall added a comment. LGTM, thanks. http://reviews.llvm.org/D12743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D1623: Support __builtin_ms_va_list.

rjmccall added a comment. This is a kindof weird extension conceptually. "Emulate the C ABI that Microsoft would use on the current architecture"? I guess we're lucky that they never support two different C ABIs on the same ISA. But okay, whatever, it's a thing. A couple comments: ===

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin abandoned this revision. mzolotukhin added a comment. We decided to go with an alternative way - with builtins instead of type attributes. The corresponding patch is http://reviews.llvm.org/D12313, and it's already reviewed and committed. http://reviews.llvm.org/D12221 _

Re: [PATCH] D12747: Implement [depr.c.headers]

rsmith added a comment. Each of the foo.h files added here was svn cp'd from the corresponding cfoo file. The listed diffs are against the base file. Likewise, __nullptr was copied from cstddef. (Please disregard the changes to lib/buildit.) Repository: rL LLVM http://reviews.llvm.org/D127

r247384 - [modules] Don't load files specified by -fmodule-file= when modules are

Author: rsmith Date: Thu Sep 10 22:58:07 2015 New Revision: 247384 URL: http://llvm.org/viewvc/llvm-project?rev=247384&view=rev Log: [modules] Don't load files specified by -fmodule-file= when modules are disabled. (We still allow this via -cc1 / -Xclang, primarily for testing.) Modified: cfe

Re: [PATCH] D1623: Support __builtin_ms_va_list.

rsmith added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11664-11672 @@ -11662,1 +11663,11 @@ + + // It might be a __builtin_ms_va_list. + if (!E->isTypeDependent() && Context.getTargetInfo().hasBuiltinMSVaList()) { +QualType MSVaListType = Context.getBuiltinMSVaListT

r247380 - [opaque pointer type] update test cases for explicit pointee types on global aliases

Author: dblaikie Date: Thu Sep 10 22:22:18 2015 New Revision: 247380 URL: http://llvm.org/viewvc/llvm-project?rev=247380&view=rev Log: [opaque pointer type] update test cases for explicit pointee types on global aliases Modified: cfe/trunk/test/CodeGen/alias.c cfe/trunk/test/CodeGen/attr

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

On Thu, Sep 10, 2015 at 7:27 PM John McCall wrote: > On Sep 10, 2015, at 16:09, Chandler Carruth wrote: > > > On Thu, Sep 10, 2015 at 3:26 PM John McCall wrote: > >> On Sep 10, 2015, at 3:22 PM, Chandler Carruth >> wrote: >> >> I've reproduced this with the same technique. >> >> John, let me k

Re: [PATCH] D9924: Ignore report when the argument to malloc is assigned known value

hiraditya added a comment. Hi Anna, I have updated the patch to address the changes you asked for. http://reviews.llvm.org/D9924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9924: Ignore report when the argument to malloc is assigned known value

hiraditya updated this revision to Diff 34525. hiraditya added a comment. Emit warning when numerator is unknown (may overflow). The checker will ignore warning when numerator and denominator are both known. Added test case. Format patch with clang-format. http://reviews.llvm.org/D9924 Files:

r247375 - [modules] Slightly defang an assert that produces false-positives on the selfhost bot.

Author: rsmith Date: Thu Sep 10 21:22:03 2015 New Revision: 247375 URL: http://llvm.org/viewvc/llvm-project?rev=247375&view=rev Log: [modules] Slightly defang an assert that produces false-positives on the selfhost bot. Modified: cfe/trunk/lib/Serialization/ASTWriterDecl.cpp Modified: cfe/t

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin added a comment. Thanks, committed in r247374 with the requested changes! Michael Repository: rL LLVM http://reviews.llvm.org/D12785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247374: Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store. (authored by mzolotukhin). Changed prior to commit: http://reviews.llvm.org/D12785?vs=34521&id=34524#toc Repository:

r247374 - Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

Author: mzolotukhin Date: Thu Sep 10 21:01:15 2015 New Revision: 247374 URL: http://llvm.org/viewvc/llvm-project?rev=247374&view=rev Log: Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store. Summary: In r247104 I added the builtins for generating non-temporal memory operatio

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

jordan_rose added a comment. A few comments coming late… Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is visi

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie wrote: > > > On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Thu Sep 10 20:03:26 2015 >> New Revision: 247369 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=247369

Re: [PATCH] D12767: [Static Analyzer] Properly clean up the dynamic type information for dead regions.

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/DynamicTypeMap.cpp:10 @@ +9,3 @@ +// +// This file defines APIs that are related to track and query dynamic type +// information. This information can be used to devirtualize calls during the "

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: docs/LanguageExtensions.rst:1784 @@ +1783,3 @@ + +Clang provides overloaded builtins allowing to generate non-temporal memory +accesses. to g

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

> On Sep 10, 2015, at 6:29 PM, Richard Smith wrote: > > On Thu, Sep 10, 2015 at 5:57 PM, Michael Zolotukhin > wrote: > mzolotukhin added inline comments. > > > Comment at: docs/LanguageExtensions.rst:1802-1807 > @@ +1801,8 @@ > + > +For example, o

Re: [PATCH] D11279: Initial patch for PS4 toolchain

filcab updated this revision to Diff 34522. filcab marked 12 inline comments as done. filcab added a comment. This revision is now accepted and ready to land. Addressed review comments. http://reviews.llvm.org/D11279 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/Di

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229 @@ -228,2 +228,3 @@ + /// checkers should use generateErrorNode() instead. ExplodedNode *generateSink(ProgramStateRef State = nullptr,

r247373 - [sema] Fix assertion hit when using libclang to index a particular C++ snippet involving templates.

Author: akirtzidis Date: Thu Sep 10 20:44:56 2015 New Revision: 247373 URL: http://llvm.org/viewvc/llvm-project?rev=247373&view=rev Log: [sema] Fix assertion hit when using libclang to index a particular C++ snippet involving templates. Assertion hit was in ClassTemplateSpecializationDecl::getSo

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

jordan_rose added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321 @@ +320,3 @@ +// sink, we assume that a client requesting a transition to a state that is +// the same as the predecessor state has made a mistake. We return

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin updated this revision to Diff 34521. mzolotukhin added a comment. - Remove paragraph about changing program behavior (since we shouldn't change it anyway). http://reviews.llvm.org/D12785 Files: docs/LanguageExtensions.rst Index: docs/LanguageExtensions.rst ==

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu Sep 10 20:03:26 2015 > New Revision: 247369 > > URL: http://llvm.org/viewvc/llvm-project?rev=247369&view=rev > Log: > Module Debugging: Emit forward declarations for typ

Re: r247319 - Add a getDeclContextDescriptor() helper function to CGDebugInfo. (NFC)

On Thu, Sep 10, 2015 at 11:39 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu Sep 10 13:39:45 2015 > New Revision: 247319 > > URL: http://llvm.org/viewvc/llvm-project?rev=247319&view=rev > Log: > Add a getDeclContextDescriptor() helper function t

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 6:26 PM, David Blaikie wrote: > > > On Thu, Sep 10, 2015 at 1:34 PM, Richard Smith > wrote: > >> On Thu, Sep 10, 2015 at 11:46 AM, David Blaikie >> wrote: >> >>> >>> >>> On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith >>> wrote: >>> On Thu, Sep 10, 2015 at 9:13 AM,

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Please, do turn on by default. LGTM http://reviews.llvm.org/D12652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

On Thu, Sep 10, 2015 at 5:57 PM, Michael Zolotukhin wrote: > mzolotukhin added inline comments. > > > Comment at: docs/LanguageExtensions.rst:1802-1807 > @@ +1801,8 @@ > + > +For example, on AArch64 in the following code:: > + > + LDR X1, [X2] > + LDNP X3, X4, [X1] > + > +the `

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 1:34 PM, Richard Smith wrote: > On Thu, Sep 10, 2015 at 11:46 AM, David Blaikie > wrote: > >> >> >> On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith >> wrote: >> >>> On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

filcab abandoned this revision. filcab added a comment. We don't need this anymore, since we're making some internal changes. Thank you for the feedback! Comment at: include/clang/Driver/Options.td:1853-1854 @@ -1853,1 +1852,4 @@ +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, Help

r247369 - Module Debugging: Emit forward declarations for types that are defined in

Author: adrian Date: Thu Sep 10 20:03:26 2015 New Revision: 247369 URL: http://llvm.org/viewvc/llvm-project?rev=247369&view=rev Log: Module Debugging: Emit forward declarations for types that are defined in clang modules, if -dwarf-ext-refs (DebugTypesExtRefs) is specified. Added: cfe/trunk/t

r247368 - Cleanup: Let CGDebugInfo::ModuleRefCache use a TrackingMDNode (NFC).

Author: adrian Date: Thu Sep 10 20:03:19 2015 New Revision: 247368 URL: http://llvm.org/viewvc/llvm-project?rev=247368&view=rev Log: Cleanup: Let CGDebugInfo::ModuleRefCache use a TrackingMDNode (NFC). Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h Mo

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin added inline comments. Comment at: docs/LanguageExtensions.rst:1802-1807 @@ +1801,8 @@ + +For example, on AArch64 in the following code:: + + LDR X1, [X2] + LDNP X3, X4, [X1] + +the ``LDNP`` might be executed before the ``LDR``. In this case the load would +be perfor

r247367 - [MS ABI] Remove another call to RequireCompleteType

Author: majnemer Date: Thu Sep 10 19:53:15 2015 New Revision: 247367 URL: http://llvm.org/viewvc/llvm-project?rev=247367&view=rev Log: [MS ABI] Remove another call to RequireCompleteType I cannot come up with a testcase which would rely on this call to RequireCompleteType, I believe that it is su

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added a comment. I'm going to commit this tomorrow unless someone speaks up. Repository: rL LLVM http://reviews.llvm.org/D12087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D12406: [Analyzer] Add -analyzer-config option for function size the inliner considers as large

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. I will commit. Thanks Sean! http://reviews.llvm.org/D12406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

rsmith added inline comments. Comment at: docs/LanguageExtensions.rst:1802-1807 @@ +1801,8 @@ + +For example, on AArch64 in the following code:: + + LDR X1, [X2] + LDNP X3, X4, [X1] + +the ``LDNP`` might be executed before the ``LDR``. In this case the load would +be performed f

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

This revision was automatically updated to reflect the committed changes. Closed by commit rL247362: [Driver] Use UniversalCRT on Windows if available (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D12695?vs=34475&id=34515#toc Repository: rL LLVM http://reviews.llvm.org

r247362 - [Driver] Use UniversalCRT on Windows if available

Author: rnk Date: Thu Sep 10 19:09:39 2015 New Revision: 247362 URL: http://llvm.org/viewvc/llvm-project?rev=247362&view=rev Log: [Driver] Use UniversalCRT on Windows if available Summary: With Visual Studio 2015 release, a part of runtime library was extracted and now comes with Windows Kits. Th

r247360 - Docs: Add missing new line before a list.

Author: mzolotukhin Date: Thu Sep 10 18:56:10 2015 New Revision: 247360 URL: http://llvm.org/viewvc/llvm-project?rev=247360&view=rev Log: Docs: Add missing new line before a list. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL: http://llv

[PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin created this revision. mzolotukhin added reviewers: hfinkel, rsmith. mzolotukhin added a subscriber: cfe-commits. In r247104 I added the builtins for generating non-temporal memory operations, but now I realized that they lack documentation. This patch adds some. http://reviews.llvm.o

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

eugenis added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1652 @@ +1651,3 @@ + + static void Poison(CodeGenFunction &CGF, llvm::Value *OffsetPtr, +CharUnits::QuantityType PoisonSize); nmusgrave wrote: > eugenis wrote: > > If it's a glo

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave marked 2 inline comments as done. Comment at: lib/CodeGen/CGClass.cpp:1652 @@ +1651,3 @@ + + static void Poison(CodeGenFunction &CGF, llvm::Value *OffsetPtr, +CharUnits::QuantityType PoisonSize); eugenis wrote: > If it's a global func

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

eugenis added a comment. So, this can not be moved to the complete destructor because that would fail to poisons vptrs of the base classes. On the other hand, the current implementation is a bit wasteful, as it can poison the same pointer multiple times when it is shared by the derived class an

Re: [PATCH] D12767: [Static Analyzer] Properly clean up the dynamic type information for dead regions.

xazax.hun updated this revision to Diff 34507. xazax.hun added a comment. - Updated to latest trunk. - Separated the set/getDynamicTypeInfo APIs out from ProgramState Note that it is not advised to put the implementations of set/getDynamicTypeInfo into a checker, because in that case there is a

[PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, krememek. dcoughlin added subscribers: jordan_rose, cfe-commits, xazax.hun. The analyzer trims unnecessary nodes from the exploded graph before reporting path diagnostics. However, in some cases it can trim all nodes (includin

r247351 - Handle '-r' option properly

Author: rnk Date: Thu Sep 10 17:31:45 2015 New Revision: 247351 URL: http://llvm.org/viewvc/llvm-project?rev=247351&view=rev Log: Handle '-r' option properly Summary: This fixs the bug https://llvm.org/bugs/show_bug.cgi?id=12587 Patch by Yunlian Jiang Reviewers: Bigcheese, rnk Differential Rev

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170 @@ -169,3 +169,3 @@ // it has a different calling conversion. - // CHECK4: call void @_ZN5test93barD2Ev + // C

r247350 - Support noreturn in limited contexts on Objective-C message sends.

Author: rjmccall Date: Thu Sep 10 17:27:50 2015 New Revision: 247350 URL: http://llvm.org/viewvc/llvm-project?rev=247350&view=rev Log: Support noreturn in limited contexts on Objective-C message sends. rdar://6198039 Added: cfe/trunk/test/CodeGenObjC/attr-noreturn.m Modified: cfe/trunk/l

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

xazax.hun added a comment. In http://reviews.llvm.org/D12652#243762, @zaks.anna wrote: > Have you tested this on a large codebase that uses lambdas? When do you think > we should turn this on by default? I checked llvm and clang and did not found any failure. There are no obvious limitations

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

+Tom for 3.7.1 On Fri, Aug 21, 2015 at 6:41 PM, Saleem Abdulrasool wrote: > On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg wrote: >> >> On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool >> wrote: >> > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg >> > wrote: >> >> >> >> +Saleem and Renato;

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

xazax.hun updated this revision to Diff 34498. xazax.hun added a comment. - Updated to latest trunk - Added test for the defensive inline check heuristic case - Added test for diagnostic within a lambda body - Added test for path notes http://reviews.llvm.org/D12652 Files: include/clang/Stati

r247349 - [SEH] Use cleanupendpad so that WinEHPrepare gets the coloring right

Author: rnk Date: Thu Sep 10 17:11:13 2015 New Revision: 247349 URL: http://llvm.org/viewvc/llvm-project?rev=247349&view=rev Log: [SEH] Use cleanupendpad so that WinEHPrepare gets the coloring right Cleanupendpad is a lot like catchendpad, so we can reuse the same EHScopeStack type. Modified:

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. It looks good to me. http://reviews.llvm.org/D12769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

zaks.anna added a comment. Have you tested this on a large codebase that uses lambdas? When do you think we should turn this on by default? Please, add test cases that demonstrate what happens when an issue is reported within a lambda and to check if inlined defensive checks work. (As a follow

r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Author: majnemer Date: Thu Sep 10 16:52:00 2015 New Revision: 247346 URL: http://llvm.org/viewvc/llvm-project?rev=247346&view=rev Log: [MS ABI] Make member pointers return true for isIncompleteType The type of a member pointer is incomplete if it has no inheritance model. This lets us reuse more

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12586 @@ -12585,3 +12585,3 @@ if (!FieldTy->isDependentType()) { uint64_t TypeSize = Context.getTypeSize(FieldTy); if (Value.getZExtValue() > TypeSize) { hubert.reinterpretcast wrote: > r

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

On Thu, Sep 10, 2015 at 2:17 PM, Rachel Craik wrote: > rcraik added inline comments. > > > Comment at: lib/Sema/SemaDecl.cpp:12586 > @@ -12585,3 +12585,3 @@ >if (!FieldTy->isDependentType()) { > uint64_t TypeSize = Context.getTypeSize(FieldTy); > if (Value.getZExtVa

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

grosbach added a comment. In http://reviews.llvm.org/D10414#243302, @jmolloy wrote: > In an ideal world, yes. However there's no guarantee that all ARM > implementors will (a) be able to commit to LLVM or (b) use ToT. Perhaps > they're building a project that uses clang, or a specific version o

Re: Preventing several replacements on a macro call.

> On Sep 10, 2015, at 12:22 PM, Angel Garcia via cfe-commits > wrote: > > Hi Argyrios, > > Thank you for your answer. I think that it is pretty clear that we don't > really want to allow changes like the one in your example. But my problem is > almost the opposite. I have something like this

[PATCH] D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.Make sure the output filepath supplied to createUniqueFile() in HTM

dirty created this revision. dirty added reviewers: rsmith, akyrtzi. dirty added a subscriber: cfe-commits. Make sure the output filepath supplied to createUniqueFile() in HTMLDiagnostics::ReportDiag() is absolute. http://reviews.llvm.org/D12774 Files: lib/StaticAnalyzer/Core/HTMLDiagnostics.

Re: [PATCH] D12736: [PATCH] AST traversal from types to decls

aaron.ballman updated this revision to Diff 34486. aaron.ballman added a comment. After speaking with Manuel on IRC about the testability, we decided the best approach would be to add the AST matcher functionality required to actually test out the changes to HasDeclarationMatcher::matchesSpecial

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

aaron.ballman added a comment. This appears to have broken one of the bots: http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/15065 http://reviews.llvm.org/D12759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

jroelofs added a subscriber: jroelofs. jroelofs added a comment. A testcase would be good, regardless of which of the proposed fixes ends up being chosen. http://reviews.llvm.org/D12689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 11:46 AM, David Blaikie wrote: > > > On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith > wrote: > >> On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> >>> On Thu, Sep 10, 2015 at 9:07 AM, Mehdi Amini >>> wrote

r247332 - Revert "Generating assumption loads of vptr after ctor call (fixed)"

Author: prazek Date: Thu Sep 10 15:18:30 2015 New Revision: 247332 URL: http://llvm.org/viewvc/llvm-project?rev=247332&view=rev Log: Revert "Generating assumption loads of vptr after ctor call (fixed)" It seems that there is small bug, and we can't generate assume loads when some virtual function

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ruiu added a comment. I'm sorry about leave http://reviews.llvm.org/D12604 hanging. I didn't notice that it got a new review message. Don't mind my patch -- please just submit when you got LGTM http://reviews.llvm.org/D12695 ___ cfe-commits mailin

r247327 - Move sel-address.mm from test/CodeGenCXX to test/SemaObjCXX, it's not a codegen test.

Author: nico Date: Thu Sep 10 14:35:31 2015 New Revision: 247327 URL: http://llvm.org/viewvc/llvm-project?rev=247327&view=rev Log: Move sel-address.mm from test/CodeGenCXX to test/SemaObjCXX, it's not a codegen test. Added: cfe/trunk/test/SemaObjCXX/sel-address.mm - copied, changed fro

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko updated this revision to Diff 34477. andreybokhanko added a comment. Reid, Sorry for delayed reply. All your comments are fixed (it turned out that usage of DefaultCC instead of ToCC is the root of all evil; after I fixed this, all other problems went away). Patch updated; pleas

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko marked 8 inline comments as done. andreybokhanko added a comment. http://reviews.llvm.org/D12402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin updated this revision to Diff 34475. ikudrin added a comment. - Fixed formatting issues. - Normalized VariableNames. - Reworked the useUniversalCRT method to receive a path of Visual Studio. http://reviews.llvm.org/D12695 Files: lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h

Re: Preventing several replacements on a macro call.

Hi Argyrios, Thank you for your answer. I think that it is pretty clear that we don't really want to allow changes like the one in your example. But my problem is almost the opposite. I have something like this: #define MY_MAC(x,y) doSomething(x, y); which is used in this way: MY_MAC(var1, var1

r247324 - Driver: Support cfi-icall on all OSs when targeting x86/x86_64.

Author: pcc Date: Thu Sep 10 14:18:05 2015 New Revision: 247324 URL: http://llvm.org/viewvc/llvm-project?rev=247324&view=rev Log: Driver: Support cfi-icall on all OSs when targeting x86/x86_64. Modified: cfe/trunk/lib/Driver/ToolChain.cpp cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

ahatanak added a comment. OK, thanks. I'll go ahead and commit this patch and the llvm-side patch. http://reviews.llvm.org/D11815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Preventing several replacements on a macro call.

Hi Angel, This part of the code is conservative because it is not clear if accepting the change in all the different places where the macro argument is expanded is acceptable or not. For a contrived example, let’s say you have this macro definition: #define MY_MAC(x) foo(x) + bar(x) an

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith wrote: > On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Thu, Sep 10, 2015 at 9:07 AM, Mehdi Amini >> wrote: >> >>> >>> On Sep 10, 2015, at 9:02 AM, David Blaikie wrote: >>> >>> >

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

rsmith added a subscriber: rsmith. rsmith added a comment. Can we instead fix this in Clang by ensuring that libc++ is put at the right position in the static link order so that its initializers run first? libc++'s avoidance of running iostreams init code from every translation unit is a signif

r247318 - [SEH] Use catchret in the new EH IR like we do for C++

Author: rnk Date: Thu Sep 10 13:39:41 2015 New Revision: 247318 URL: http://llvm.org/viewvc/llvm-project?rev=247318&view=rev Log: [SEH] Use catchret in the new EH IR like we do for C++ Also add tests for SEH with the new IRGen. Added: cfe/trunk/test/CodeGen/exceptions-seh-new.c - copie

r247319 - Add a getDeclContextDescriptor() helper function to CGDebugInfo. (NFC)

Author: adrian Date: Thu Sep 10 13:39:45 2015 New Revision: 247319 URL: http://llvm.org/viewvc/llvm-project?rev=247319&view=rev Log: Add a getDeclContextDescriptor() helper function to CGDebugInfo. (NFC) Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Thu, Sep 10, 2015 at 9:07 AM, Mehdi Amini > wrote: > >> >> On Sep 10, 2015, at 9:02 AM, David Blaikie wrote: >> >> >> >> On Thu, Sep 10, 2015 at 9:00 AM, Mehdi Amini >> wrote: >> >>> >>>

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin added a comment. In http://reviews.llvm.org/D12695#243552, @rnk wrote: > There's a bunch of whitespace issues that clang-format can resolve. Thanks! I'll reformat it. > We also have the convention that variables are StudlyCaps, which isn't > followed in a few places. I've tried to f

Re: PATCH: Expose the 'file' that is associated with a compile database command

> On Sep 10, 2015, at 1:48 AM, Manuel Klimek wrote: > > @@ -179,11 +185,13 @@ public: >/// \param Directory The base directory used in the > FixedCompilationDatabase. >static FixedCompilationDatabase *loadFromCommandLine(int &Argc, >

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

dcoughlin updated this revision to Diff 34471. dcoughlin added a comment. Pass -cc1 to clang even when SDK path is not found. http://reviews.llvm.org/D12769 Files: utils/analyzer/SATestBuild.py Index: utils/analyzer/SATestBuild.py =

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

dcoughlin added inline comments. Comment at: utils/analyzer/SATestBuild.py:277 @@ +276,3 @@ +# For now, we assume the preprocessed files should be analyzed +# with the OS X SDK. +SDKPath = getSDKPath("macosx") xazax.hun wrote: > dcoughlin wrote: > > xa

r247317 - [CUDA] Postprocess bitcode linked in during device-side CUDA compilation.

Author: tra Date: Thu Sep 10 13:24:23 2015 New Revision: 247317 URL: http://llvm.org/viewvc/llvm-project?rev=247317&view=rev Log: [CUDA] Postprocess bitcode linked in during device-side CUDA compilation. Link in and internalize the symbols we need from supplied bitcode library. Differential Revi

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247317: [CUDA] Postprocess bitcode linked in during device-side CUDA compilation. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D11664?vs=34467&id=34470#toc Repository: rL LLVM

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

xazax.hun added inline comments. Comment at: utils/analyzer/SATestBuild.py:277 @@ +276,3 @@ +# For now, we assume the preprocessed files should be analyzed +# with the OS X SDK. +SDKPath = getSDKPath("macosx") dcoughlin wrote: > xazax.hun wrote: > > I

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

dcoughlin added inline comments. Comment at: utils/analyzer/SATestBuild.py:277 @@ +276,3 @@ +# For now, we assume the preprocessed files should be analyzed +# with the OS X SDK. +SDKPath = getSDKPath("macosx") xazax.hun wrote: > I think it might be bet

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

rnk added a comment. There's a bunch of whitespace issues that clang-format can resolve. We also have the convention that variables are StudlyCaps, which isn't followed in a few places. Do you need someone to commit this for you? If so, I can patch this in, test it manually, and deal with the

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

xazax.hun added a comment. - on other OS-es like linux. http://reviews.llvm.org/D12769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

xazax.hun added inline comments. Comment at: utils/analyzer/SATestBuild.py:277 @@ +276,3 @@ +# For now, we assume the preprocessed files should be analyzed +# with the OS X SDK. +SDKPath = getSDKPath("macosx") I think it might be better to check if the

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

tra updated this revision to Diff 34467. tra added a comment. Removed unneeded #includes. http://reviews.llvm.org/D11664 Files: include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td lib/CodeGen/CodeGenAction.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGenCUDA/Inp

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin marked an inline comment as done. ikudrin added a comment. In http://reviews.llvm.org/D12695#243320, @rnk wrote: > FYI @ruiu is moving this code to LLVM in http://reviews.llvm.org/D12604. Thanks. I think I'll move my changes to the new place when he's finished. http://reviews.llvm.org

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

skalinichev added a comment. AFAIUI the canonical type could never be an elaborated type, but just type could. And yes before we used nested name specifier from the type name as written in the source code (a.k.a. ElaboratedType), now we use nested name specifier of the type that the elaborated

  1   2   >