Yep, looks like two distinct problems. I'm going to revert r245265 as
well and send Piotr the crash repro for the second assertion.
Piotr Padlewski writes:
> Confirm, the assertions are different from the last one.
>
> On Mon, Aug 17, 2015 at 11:45 PM, Justin Bogner via cfe-commits <
> cfe-commit
Confirm, the assertions are different from the last one.
On Mon, Aug 17, 2015 at 11:45 PM, Justin Bogner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Richard Smith writes:
> > Are you sure it was this change and not r245265?
>
> Pretty sure - I ran the crash repro script with tot and i
Author: abataev
Date: Tue Aug 18 01:47:21 2015
New Revision: 245268
URL: http://llvm.org/viewvc/llvm-project?rev=245268&view=rev
Log:
[OPENMP 4.1] Allow variables with reference types in private clauses.
OpenMP 4.1 allows to use variables with reference types in all private clauses
(private, fir
Richard Smith writes:
> Are you sure it was this change and not r245265?
Pretty sure - I ran the crash repro script with tot and it repro'd, then
with r245264 reverted and it didn't. That's when I pushed the revert.
> On Aug 17, 2015 10:41 PM, "Justin Bogner via cfe-commits" <
> cfe-commits@list
Are you sure it was this change and not r245265?
On Aug 17, 2015 10:41 PM, "Justin Bogner via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: bogner
> Date: Tue Aug 18 00:40:20 2015
> New Revision: 245267
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245267&view=rev
> Log:
> Revert
Thanks. I have no idea what happen, but I will fix it tomorrow.
Piotr
On Mon, Aug 17, 2015 at 10:43 PM, Justin Bogner
wrote:
> Piotr Padlewski via cfe-commits writes:
> > Author: prazek
> > Date: Mon Aug 17 22:52:00 2015
> > New Revision: 245264
> >
> > URL: http://llvm.org/viewvc/llvm-projec
Piotr Padlewski via cfe-commits writes:
> Author: prazek
> Date: Mon Aug 17 22:52:00 2015
> New Revision: 245264
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245264&view=rev
> Log:
> Generating assumption loads of vptr after ctor call (fixed)
>
> Generating call assume(icmp %vtable, %global_vt
Author: bogner
Date: Tue Aug 18 00:40:20 2015
New Revision: 245267
URL: http://llvm.org/viewvc/llvm-project?rev=245267&view=rev
Log:
Revert "Generating assumption loads of vptr after ctor call (fixed)"
Bootstrap bots were failing:
http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_bu
On Tue, Aug 18, 2015 at 2:00 AM, Richard Smith wrote:
>
>> > Should this logic for PCH/PTH scanning move out of the driver and into
>> > the frontend?
>
>> gcc also checks if the gch file is a directory and if so finds the first
>> file with matching language / defines etc. It also uses gch files
"Li, Charles" writes:
> Hi Richard,
>
> I have modified the “expected-“ lines as you requested.
>
> Cheers,
>
> Charles
>
> From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith
> Sent: Monday, August 17, 2015 5:41 PM
> To: Li, Charles
> Cc: Justin Bogner; cfe-commits@lists
pcc added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:3677
@@ +3676,3 @@
+llvm::Metadata *CodeGenModule::CreateMetadataIdentifierForType(QualType T) {
+ llvm::Metadata *&InternalId = MetadataIdMap[T.getCanonicalType()];
+ if (InternalId)
Prazek wr
Hans, everything is fine.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
17.08.2015 21:30, Hans Wennborg пишет:
Merged in r245229.
There were merge conflicts in StmtOpenMP.h because we don't have
r244209 on the branch. I think I got it right, but I'd appreciate
Prazek added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:3677
@@ +3676,3 @@
+llvm::Metadata *CodeGenModule::CreateMetadataIdentifierForType(QualType T) {
+ llvm::Metadata *&InternalId = MetadataIdMap[T.getCanonicalType()];
+ if (InternalId)
questi
Author: prazek
Date: Mon Aug 17 22:52:00 2015
New Revision: 245264
URL: http://llvm.org/viewvc/llvm-project?rev=245264&view=rev
Log:
Generating assumption loads of vptr after ctor call (fixed)
Generating call assume(icmp %vtable, %global_vtable) after constructor
call for devirtualization purpose
On Thu, Aug 13, 2015 at 10:50 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> rsmith added a comment.
>
> I would think most Windows users would be surprised if we showed them
> paths with /s instead of \s, but I'm fine with us using / internally if it
> doesn't leak out t
On Wed, Aug 12, 2015 at 6:05 PM, Richard Smith
wrote:
> On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva wrote:
>
>>
>>
>> On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith
>> wrote:
>>
>>> On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva
>>> wrote:
>>>
silvas added a subscriber: silvas.
==
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/CodeGenCXX/vtable-assume-load.cpp:24
@@ +23,3 @@
+// CHECK1-LABEL: define void @_ZN5test14fooAEv()
+// CHECK1: call void @_ZN5test11AC1Ev(%"struct.test1:
On Mon, Aug 17, 2015 at 6:27 PM, Li, Charles <
charles...@playstation.sony.com> wrote:
> Hi Richard,
>
>
>
> I have modified the “expected-“ lines as you requested.
>
+#if (!defined(__cplusplus)) || (__cplusplus <= 199711L) // C or C++03 or
earlier modes
You can simplify that to:
#if __cplusplu
Prazek updated this revision to Diff 32363.
Prazek added a comment.
Fix for the PR24479
http://reviews.llvm.org/D11859
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI
alexr added a subscriber: alexr.
alexr added a comment.
Just to remind everybody, different OSes handle Unicode differently as well.
Think of it as case insensitivity for the different Unicode ways of encoding
the same glyph. For example U+00DC (LATIN CAPITAL LETTER U WITH DIAERESIS) vs
U+0055
Hi Richard,
I have modified the “expected-“ lines as you requested.
Cheers,
Charles
From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith
Sent: Monday, August 17, 2015 5:41 PM
To: Li, Charles
Cc: Justin Bogner; cfe-commits@lists.llvm.org
Subject: Re: Second Lit tests C++
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sure I guess. I'm still not sure why we can't do this in the configure side of
things, but I don't really care that much for now.
http://reviews.llvm.org/D12036
___
On Mon, Aug 17, 2015 at 5:15 PM, Li, Charles via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard and Justin,
>
>
>
>
>
> > What's the upside to this approach? AFAICT it makes the test harder to
> read and errors less informative due to pointing at the wrong lines, but
> (at least in
I reverted this in r245260 as it caused
https://llvm.org/bugs/show_bug.cgi?id=24479
- Hans
On Mon, Aug 17, 2015 at 4:34 PM, Piotr Padlewski via cfe-commits
wrote:
> Author: prazek
> Date: Mon Aug 17 18:33:49 2015
> New Revision: 245257
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245257&vie
Chris Bieneman writes:
> beanz updated this revision to Diff 32349.
> beanz added a comment.
>
> - Adapting to r245255 which exposes a variable in autoconf for which
> compiler you are building with.
> - Updated the CMake to be more CMake-y
>
> Note: This has been tested by running a check on a st
Author: hans
Date: Mon Aug 17 19:17:58 2015
New Revision: 245260
URL: http://llvm.org/viewvc/llvm-project?rev=245260&view=rev
Log:
Revert r245257 "Generating assumption loads of vptr after ctor call"
It caused PR24479
Removed:
cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
Modified:
cf
Eric Christopher writes:
> There is nothing broken about not having the include guards there, it's just
> not helpful. I'm working on the infrastructure for an error if you call a
> function from within an incompatible routine at the moment (without
> duplicating a lot of code it's actually a bit
Hi Richard and Justin,
> What's the upside to this approach? AFAICT it makes the test harder to read
> and errors less informative due to pointing at the wrong lines, but (at least
> in switch-1.c) it doesn't actually reduce any code duplication or anything
> like that. What is this gaining u
> Date: Mon, 17 Aug 2015 21:39:32 +
> To: hiradi...@msn.com; jordan_r...@apple.com; kreme...@apple.com;
> daniel.marjam...@evidente.se; mclow.li...@gmail.com; adasg...@codeaurora.org;
> zaks.a...@gmail.com
> From: zaks.a...@gmail.com
> CC: cfe-commit
On Mon, Aug 17, 2015 at 9:24 AM, Nico Weber wrote:
> thakis added a subscriber: thakis.
>
>
> Comment at: lib/Driver/Tools.cpp:398
> @@ +397,3 @@
> + FoundPTH = !UsePCH;
> +}
> + }
>
> kimgr wrote:
> > kimgr wrote:
> > > kimgr wr
Author: hans
Date: Mon Aug 17 18:38:56 2015
New Revision: 245259
URL: http://llvm.org/viewvc/llvm-project?rev=245259&view=rev
Log:
Doxygen: add build option to use svg instead of png files for graphs
Differential Revision: http://reviews.llvm.org/D11994
Modified:
cfe/trunk/docs/CMakeLists.tx
Author: prazek
Date: Mon Aug 17 18:33:49 2015
New Revision: 245257
URL: http://llvm.org/viewvc/llvm-project?rev=245257&view=rev
Log:
Generating assumption loads of vptr after ctor call
Generating call assume(icmp %vtable, %global_vtable) after constructor
call for devirtualization purposes.
For
Prazek updated this revision to Diff 32355.
Prazek marked 2 inline comments as done.
http://reviews.llvm.org/D11859
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGen/available-
The 3.7 branch does have the include guards; they were re-added in
http://llvm.org/viewvc/llvm-project?rev=243925&view=rev. That happened
after rc2, but it will be in rc3.
Can you double check if you're still running into problems on the 3.7 branch?
- Hans
On Mon, Aug 17, 2015 at 3:04 PM, Dimi
rjmccall added a comment.
Just a couple tweaks and then LGTM.
Comment at: lib/CodeGen/CGClass.cpp:1833
@@ +1832,3 @@
+ // unless we are calling base constructor - we don't want to generating
+ // assumption loads for not completed because vptr may still change.
+ if (CGM.getC
beanz updated this revision to Diff 32349.
beanz added a comment.
- Adapting to r245255 which exposes a variable in autoconf for which compiler
you are building with.
- Updated the CMake to be more CMake-y
Note: This has been tested by running a check on a stage2 clang built with asan
and ubsan
Author: echristo
Date: Mon Aug 17 17:22:28 2015
New Revision: 245251
URL: http://llvm.org/viewvc/llvm-project?rev=245251&view=rev
Log:
Remove dead code, there's no need for an override that just duplicates
the default behavior.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/li
Author: rtrieu
Date: Mon Aug 17 17:18:30 2015
New Revision: 245250
URL: http://llvm.org/viewvc/llvm-project?rev=245250&view=rev
Log:
Make a test less brittle.
Capture line numbers in a variable for FileCheck instead of hardcoding them.
Modified:
cfe/trunk/test/SemaCXX/warn-logical-not-compar
There is nothing broken about not having the include guards there, it's
just not helpful. I'm working on the infrastructure for an error if you
call a function from within an incompatible routine at the moment (without
duplicating a lot of code it's actually a bit annoying), but there's
nothing act
[Re-sending, used the old cfe-commits address by accident]
Where is the other thread? This problem still exists, for both trunk and the
upcoming 3.7.0 RC3. I'll try to submit a patch tomorrow to partially restore
the include guards, so we won't have a broken release.
-Dimitry
> On 03 Aug 201
zaks.anna added a comment.
> Maybe, I should add a check that `a, b, n' are positive.
> So, in this case static analyzer can choose to be strict and reject false
> positives.
What would this buy us? Does the checker warn on underflow?
> If a' might overflow, then in this case we can emit war
On Mon, Aug 17, 2015 at 12:41 PM, Eric Christopher
wrote:
>
>
> On Mon, Aug 17, 2015 at 11:57 AM Akira Hatanaka
> wrote:
>
>> On Thu, Aug 13, 2015 at 5:56 PM, Eric Christopher
>> wrote:
>>
>>>
> Apologies, I'm really resistant to more things being used in
> TargetOptions and I was (pe
Author: marshall
Date: Mon Aug 17 16:14:16 2015
New Revision: 245239
URL: http://llvm.org/viewvc/llvm-project?rev=245239&view=rev
Log:
Make regex and any assert when they should throw an exception _but_ the user
has decreed 'no exceptions'. This matches the behavior of string and vector
Modified
On Mon, Aug 17, 2015 at 1:59 PM, David Blaikie wrote:
>
>
> On Mon, Aug 17, 2015 at 11:07 AM, Evgeniy Stepanov via cfe-commits
> wrote:
>>
>> eugenis created this revision.
>> eugenis added reviewers: chandlerc, rsmith.
>> eugenis added a subscriber: cfe-commits.
>> eugenis set the repository for
Prazek marked 3 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D11859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Aug 17, 2015 at 1:59 PM, David Blaikie wrote:
>
>
> On Mon, Aug 17, 2015 at 11:07 AM, Evgeniy Stepanov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> eugenis created this revision.
>> eugenis added reviewers: chandlerc, rsmith.
>> eugenis added a subscriber: cfe-commits.
>> e
Prazek updated this revision to Diff 32343.
Prazek marked an inline comment as done.
http://reviews.llvm.org/D11859
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGen/available-
xazax.hun added a comment.
The problem here is that, this checker can emit a warning for two cases:
1, Null was bound to a reference which should be reported as a dereference
2, Null was passed to parameter that should be non-null (marked by the
attribute, not the qualifier) which should be repor
Prazek marked 3 inline comments as done.
Comment at: lib/CodeGen/CGClass.cpp:1862
@@ +1861,3 @@
+ for (const VPtr &Vptr : getVTablePointers(ClassDecl))
+if (CGM.getCXXABI().requiresVPtrInitialization(Vptr))
+ EmitVTableAssumptionLoad(Vptr, This);
rjmccal
eugenis added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:513
@@ +512,3 @@
+void CodeGenModule::RewriteAlwaysInlineFunctions() {
+ for (llvm::Function *Fn : AlwaysInlineFunctions)
+RewriteAlwaysInlineFunction(Fn);
Done. Should I make it a "Smal
eugenis updated this revision to Diff 32341.
http://reviews.llvm.org/D12087
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGen/2008-05-19-AlwaysInli
On Mon, Aug 17, 2015 at 11:07 AM, Evgeniy Stepanov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> eugenis created this revision.
> eugenis added reviewers: chandlerc, rsmith.
> eugenis added a subscriber: cfe-commits.
> eugenis set the repository for this revision to rL LLVM.
>
> Currently
rsmith added inline comments.
Comment at: lib/AST/DeclBase.cpp:273
@@ +272,3 @@
+return true;
+ if (const CXXRecordDecl *ClassD = dyn_cast(LDC))
+return ClassD->isLocalClass() && !ClassD->isLambda();;
It's not necessary for this change, but to match its d
rsmith added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:513
@@ +512,3 @@
+void CodeGenModule::RewriteAlwaysInlineFunctions() {
+ for (llvm::Function *Fn : AlwaysInlineFunctions)
+RewriteAlwaysInlineFunction(Fn);
Does it matter that this traver
eugenis marked an inline comment as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:447-448
@@ +446,4 @@
+if (C && !isa(C)) {
+ C->handleOperandChange(GV, IndirectReplacement, &U);
+ continue;
+}
Good catch.
Comment at: lib/Code
eugenis updated this revision to Diff 32338.
http://reviews.llvm.org/D12087
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGen/2008-05-19-AlwaysInli
Author: rsmith
Date: Mon Aug 17 15:24:17 2015
New Revision: 245236
URL: http://llvm.org/viewvc/llvm-project?rev=245236&view=rev
Log:
[modules] When parsing the base specifiers of a parse-merged class, the current
context is the class itself but lookups should be performed starting with the
lookup
rjmccall added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:1862
@@ +1861,3 @@
+ for (const VPtr &Vptr : getVTablePointers(ClassDecl))
+if (CGM.getCXXABI().requiresVPtrInitialization(Vptr))
+ EmitVTableAssumptionLoad(Vptr, This);
No, it only chec
> Date: Mon, 17 Aug 2015 19:29:29 +
> To: hiradi...@msn.com; jordan_r...@apple.com; kreme...@apple.com;
> daniel.marjam...@evidente.se; mclow.li...@gmail.com; adasg...@codeaurora.org;
> zaks.a...@gmail.com
> From: zaks.a...@gmail.com
> CC: cfe-commit
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with one more testcase :)
Comment at: lib/AST/ExprConstant.cpp:6243-6245
@@ +6242,5 @@
+ } else if (End.Designator.IsOnePastTheEnd) {
+
george.burgess.iv added inline comments.
Comment at: lib/AST/ExprConstant.cpp:6221-6223
@@ +6220,5 @@
+ //
+ // extern struct X { char buff[32]; int a, b, c; } *p;
+ // int a = __builtin_object_size(p->buff + 4, 3); // returns 28
+ // int b = __builtin_object_size(p->buf
george.burgess.iv updated the summary for this revision.
george.burgess.iv updated this revision to Diff 32333.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
Addressed feedback.
http://reviews.llvm.org/D12000
Files:
lib/AST/ExprConstant.cpp
test/Code
On Mon, Aug 17, 2015 at 9:56 AM, Li, Charles via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Clang developers,
>
>
>
> We here at Sony are continuing to update the Lit tests for C++ dialects
> compatibility.
>
> Attached is the second patch. (As a reference, here is the link to the
> dis
probinson added a subscriber: probinson.
Comment at: lib/CodeGen/CodeGenModule.cpp:496
@@ +495,3 @@
+ llvm::ReturnInst::Create(Ctx, CI, BB);
+ }
+
What does the debug info look like for the wrapper?
http://reviews.llvm.org/D12087
___
On Mon, Aug 17, 2015 at 11:57 AM Akira Hatanaka wrote:
> On Thu, Aug 13, 2015 at 5:56 PM, Eric Christopher
> wrote:
>
>>
>>> > Apologies, I'm really resistant to more things being used in
>>> > TargetOptions and I was (perhaps mistakenly) under the impression
>>> > that you wanted to move it to
zaks.anna added a comment.
> x = a/b; where n < b
> malloc (x*n); Then x*n will not overflow
I am not convinced that the new rule is strong enough. 'a' can be any
expression. For example, maybe you have (b-1)*a/b and the denominator cancels
out something unrelated to 'n' in the numerator? Ma
eugenis removed rL LLVM as the repository for this revision.
eugenis updated this revision to Diff 32330.
http://reviews.llvm.org/D12087
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGen/2008-05-19-AlwaysInl
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
I believe we saw a regression in diagnostics with this modification. Gabor, do
you recall what it was?
http://reviews.llvm.org/D11433
__
On Thu, Aug 13, 2015 at 5:56 PM, Eric Christopher
wrote:
>
>> > Apologies, I'm really resistant to more things being used in
>> > TargetOptions and I was (perhaps mistakenly) under the impression
>> > that you wanted to move it to TargetOptions without an IR
>> > serialization. We need all option
chandlerc added a comment.
FYI, we should send an RFC to llvm-dev about the design change of always_inline
and make sure folks generally like the IR-level direction as well. We can point
at this review as an example.
I'm happy to write that up and send it if that's useful?
Repository:
rL LL
On Sun, Aug 16, 2015 at 3:05 AM Simon Pilgrim
wrote:
> RKSimon added a comment.
>
> Yes using that uninitialized value has worried me as well. I originally
> set it to zero (and considered using __ LINE __ or __ COUNTER __) but both
> introduce defined behaviour that I could see causing all sorts
Merged in r245229.
There were merge conflicts in StmtOpenMP.h because we don't have
r244209 on the branch. I think I got it right, but I'd appreciate if
someone could double check
http://llvm.org/viewvc/llvm-project?rev=245229&view=rev
Thanks,
Hans
On Sun, Aug 16, 2015 at 8:55 PM, Bataev, Alexey
rsmith added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:447-448
@@ +446,4 @@
+ C->handleOperandChange(GV, IndirectReplacement, &U);
+} else if (!isa(U.getUser()) &&
+ !isa(U.getUser())) {
+ U.set(IndirectReplacement);
Do
eugenis created this revision.
eugenis added reviewers: chandlerc, rsmith.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Currently always_inline definitions are emitted as (in most cases) an
available_externally llvm function with an alwaysinlin
"Li, Charles via cfe-commits" writes:
> Hi Clang developers,
>
> We here at Sony are continuing to update the Lit tests for C++ dialects
> compatibility.
>
> Attached is the second patch. (As a reference, here is the link to the
> discussion on the previous Lit patch. http://lists.cs.uiuc.edu/pipe
sfantao added a comment.
Alexey,
Thanks for the review! Find my comments inlined.
Thanks again!
Samuel
Comment at: lib/CodeGen/CGExpr.cpp:1969
@@ -1945,3 +1968,3 @@
else
- return EmitCapturedFieldLValue(*this, CapturedStmtInfo->lookup(VD),
-
sfantao updated this revision to Diff 32322.
sfantao added a comment.
Adress reviewers concerns.
Also fix issue with target regions with no arguments and in the VLA size
computation I found in the meantime.
http://reviews.llvm.org/D11361
Files:
include/clang/AST/Decl.h
include/clang/AST/S
Hi Clang developers,
We here at Sony are continuing to update the Lit tests for C++ dialects
compatibility.
Attached is the second patch. (As a reference, here is the link to the
discussion on the previous Lit patch.
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134667.htm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245228: [modules] PR20507: Avoid silent textual inclusion.
(authored by silvas).
Changed prior to commit:
http://reviews.llvm.org/D10423?vs=30196&id=32317#toc
Repository:
rL LLVM
http://reviews.llvm
Author: silvas
Date: Mon Aug 17 11:39:30 2015
New Revision: 245228
URL: http://llvm.org/viewvc/llvm-project?rev=245228&view=rev
Log:
[modules] PR20507: Avoid silent textual inclusion.
Summary:
If a module was unavailable (either a missing requirement on the module
being imported, or a missing fil
thakis added a subscriber: thakis.
Comment at: lib/Driver/Tools.cpp:398
@@ +397,3 @@
+ FoundPTH = !UsePCH;
+}
+ }
kimgr wrote:
> kimgr wrote:
> > kimgr wrote:
> > > kimgr wrote:
> > > > Add a `break;` here so we don't continue sea
angelgarcia updated this revision to Diff 32311.
angelgarcia marked 9 inline comments as done.
angelgarcia added a comment.
Comments fixed.
http://reviews.llvm.org/D12081
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNullpt
sepavloff updated this revision to Diff 32310.
sepavloff added a comment.
Updated method isLexicallyWithinFunctionOrMethod according to Richard's notes.
http://reviews.llvm.org/D11194
Files:
include/clang/AST/DeclBase.h
lib/AST/DeclBase.cpp
lib/Sema/SemaTemplateInstantiate.cpp
lib/Sema/
berenm updated this revision to Diff 32304.
berenm added a comment.
Alright!
Here is the latest revision then, with FIXMEs comments mentioning this missing
feature. I will work on implementing it and come back to you when i've got
something working.
Thanks for your time and your advices!
htt
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:16
@@ +15,3 @@
+
+using namespace clang::ast_matchers;
+using namespace clang;
nit: The list should be sorted.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp
angelgarcia updated this revision to Diff 32303.
angelgarcia added a comment.
Previous diff was not the newest one.
http://reviews.llvm.org/D12081
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNullptrCheck.cpp
clang-tidy/
alexfh added a comment.
In http://reviews.llvm.org/D10933#225696, @berenm wrote:
> Indeed, I probably don't have rights on Clang/LLVM repositories.
>
> I have updated the patch with stricter tests - and found a missing break
> statement (`clang-tidy/readability/IdentifierNamingCheck.cpp:201`).
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
Move UseNullptr from clang-modernize to modernize module
berenm updated this revision to Diff 32294.
berenm added a comment.
Indeed, I probably don't have rights on Clang/LLVM repositories.
I have updated the patch with stricter tests - and found a missing break
statement (`clang-tidy/readability/IdentifierNamingCheck.cpp:201`).
I also realized that
a.sidorin updated this revision to Diff 32293.
a.sidorin added a comment.
- Fix review notes
- Add some more tests
- Add a fix and a test for incorrect pruning of trivially unreachable case
statements in CFG for SwitchStmt (accidentially found while writing a test).
http://reviews.llvm.org/D510
alexfh added a comment.
In http://reviews.llvm.org/D10933#225678, @berenm wrote:
> In http://reviews.llvm.org/D10933#225671, @alexfh wrote:
>
> > Looks good with a couple of comments. Tell me if you need me to submit the
> > patch for you, once you address the comments.
>
>
> If you tell me how
Agreed, let’s get that right first.
The attached patch causes the program to trap for all optimizations levels,
except when optimizing for size.
Sjoerd.
From: dosr...@gmail.com [mailto:dosr...@gmail.com] On Behalf Of Gabriel Dos Reis
Sent: 13 August 2015 21:51
To: Richard Smith
Cc: Sjoerd Meijer
ismail accepted this revision.
ismail added a reviewer: ismail.
ismail added a comment.
This revision is now accepted and ready to land.
Great work. Tested fine on Windows. Next step would be mapping /openmp flag to
-fopenmp but I guess thats for another bug.
http://reviews.llvm.org/D11932
_
berenm added a comment.
In http://reviews.llvm.org/D10933#225671, @alexfh wrote:
> Looks good with a couple of comments. Tell me if you need me to submit the
> patch for you, once you address the comments.
If you tell me how I should proceed, I can maybe do it myself (do I just have
to send t
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a couple of comments. Tell me if you need me to submit the
patch for you, once you address the comments.
Thank you for the awesome new check!
Comment at: cla
Author: alexfh
Date: Mon Aug 17 06:27:11 2015
New Revision: 245215
URL: http://llvm.org/viewvc/llvm-project?rev=245215&view=rev
Log:
[clang-tidy] Fix a use-after-free.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangT
alexfh added a comment.
Some initial comments. I'll need a bit more time to review this thoroughly.
Comment at: test/clang-tidy/modernize-loop-convert.cpp:149
@@ +148,3 @@
+arr[i] = 0;
+ // CHECK-MESSAGES-NOT: :[[@LINE-2]]:3: warning: use range-based for loop
instead
+ //
Hi,
Attached you will find the fix for a crash on invalid code in clang 3.7
It crashes on this code:
void fn2() {
f(THIS_IS_AN_ERROR, afunction(afunction_));
}
The problem is that the arguments are of TheCall are reset later to the ones
in Args. Some TypoExpr that have already been diagno
Author: alexfh
Date: Mon Aug 17 05:03:27 2015
New Revision: 245205
URL: http://llvm.org/viewvc/llvm-project?rev=245205&view=rev
Log:
[clang-tidy] Allow use of -list-checks option without need to pass source files.
Initialize CommonOptionsParser with ZeroOrOne NumOccurrenceFlag so callers can
pass
Author: alexfh
Date: Mon Aug 17 05:01:42 2015
New Revision: 245204
URL: http://llvm.org/viewvc/llvm-project?rev=245204&view=rev
Log:
[clang-tidy] Make NumOccurrenceFlag for SourcePaths configurable.
Added an additional ctor that takes a NumOccurrenceFlag parameter for the
SourcePaths option. This
1 - 100 of 106 matches
Mail list logo
