zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thank you! LGTM.
I'll commit this tomorrow.
http://reviews.llvm.org/D11572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
I think it is on by default for clang builds
# Turn off missing field initializer warnings for gcc to avoid noise
from
# false positives with empty {}. Turn them on otherwise (they're off by
# default for clang).
check_cxx_compiler_flag("-Wmissing-field-initializers"
CXX_SUPPORTS_M
Ah thanks Craig. Perhaps we should turn that one on by default?
On Thu, Aug 6, 2015, 10:17 PM Craig Topper wrote:
> This was causing -Wmissing-field-initializers to fire due to Features not
> being assigned in BUILTIN or LIBBUILTIN macro expansions. Fixed it in
> r244307.
>
> On Thu, Aug 6, 2015
This was causing -Wmissing-field-initializers to fire due to Features not
being assigned in BUILTIN or LIBBUILTIN macro expansions. Fixed it in
r244307.
On Thu, Aug 6, 2015 at 3:11 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Thu Aug 6 17:1
Author: ctopper
Date: Fri Aug 7 00:14:44 2015
New Revision: 244307
URL: http://llvm.org/viewvc/llvm-project?rev=244307&view=rev
Log:
Make sure the Features field of the Builtin Info struct is always initialized.
Silences -Wmissing-field-initializers.
While there convert 0 in the BUILTIN macros
benlangmuir closed this revision.
benlangmuir added a comment.
r244306
Repository:
rL LLVM
http://reviews.llvm.org/D11824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1262
@@ -1260,1 +1261,3 @@
+/// \brief The end location of the exception specifier, if any.
+unsigned ExceptionSpecLocEnd;
Please let me know if there is still an issue with the wor
nwilson added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7454-7456
@@ +7453,5 @@
+ PDiag(diag::err_function_concept_exception_spec);
+ if (Range.isValid()) {
+PD << FixItHint::CreateRemoval(Range);
+ }
+ Diag(NewFD->getLo
Author: benlangmuir
Date: Thu Aug 6 20:59:56 2015
New Revision: 244306
URL: http://llvm.org/viewvc/llvm-project?rev=244306&view=rev
Log:
Make 'arm' cover both 32 and 64 bit architecutres
... and add aarch32 to specifically refer to the 32-bit ones.
Previously, 'arm' meant only 32-bit architectu
On Thu, Aug 6, 2015 at 4:49 PM, Ben Langmuir wrote:
> benlangmuir added inline comments.
>
>
> Comment at: lib/Basic/Targets.cpp:4552
> @@ -4551,2 +4551,3 @@
> .Case("arm", true)
> +.Case("aarch32", true)
> .Case("softfloat", SoftFloat)
> ---
benlangmuir added inline comments.
Comment at: lib/Basic/Targets.cpp:4552
@@ -4551,2 +4551,3 @@
.Case("arm", true)
+.Case("aarch32", true)
.Case("softfloat", SoftFloat)
rsmith wrote:
> Should we also recognize "arm32" to better mirror the
espositofulvio added inline comments.
Comment at: include/__mutex_base:246
@@ -266,3 +245,3 @@
-class _LIBCPP_TYPE_VIS condition_variable
+class _LIBCPP_TYPE_VIS condition_variable : private
__libcxx_support::condition_variable
{
theraven wrote:
> espositofulv
espositofulvio added inline comments.
Comment at: include/__mutex_base:19
@@ +18,3 @@
+#ifndef _WIN32
+#include
+#endif
jroelofs wrote:
> I think it might make sense to create a file: `` where the
> contents are just:
>
> ```
> #ifndef _WIN32
> #include
> #end
Author: tbrethou
Date: Thu Aug 6 18:31:37 2015
New Revision: 244297
URL: http://llvm.org/viewvc/llvm-project?rev=244297&view=rev
Log:
Revert test commit.
Modified:
libunwind/trunk/CMakeLists.txt
Modified: libunwind/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/libunwind/tru
Author: tbrethou
Date: Thu Aug 6 18:30:28 2015
New Revision: 244296
URL: http://llvm.org/viewvc/llvm-project?rev=244296&view=rev
Log:
Test commit
Modified:
libunwind/trunk/CMakeLists.txt
Modified: libunwind/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/libunwind/trunk/CMake
rsmith added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1262
@@ +1261,3 @@
+
+/// \brief The end location of the keyword introducing the spec, if any.
+unsigned ExceptionSpecLocEnd;
Drop bogus "keyword introducing the" here, and drop either
benlangmuir created this revision.
benlangmuir added a reviewer: rsmith.
benlangmuir added a subscriber: cfe-commits.
benlangmuir set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
... and add aarch32 to specifically refer to the 32-bit ones.
chh added a comment.
Reid, thanks a lot for fixing my hacks!
I tried your new diff 31457 and it worked for Android libm and all my other
tests.
I am still waiting for some review of the back end changes in
http://reviews.llvm.org/D11438.
This patch can be submitted now or later with http://revi
nwilson updated this revision to Diff 31488.
nwilson added a comment.
Updated Patch based on comments; fix diagnostic spacing and phrasing, add
getExceptionSpecRange, check FunctionTypeInfo exists, use PartialDiagnostic,
add static_assert test for function concept being treated as noexcept(true)
kulpreet added a comment.
Updated diff to include Anna's suggestions.
http://reviews.llvm.org/D11572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kulpreet updated this revision to Diff 31481.
kulpreet marked an inline comment as done.
kulpreet added a comment.
- By default (non-aggressive mode) the UnlocalizedStringChecker will ignore
strings that are less than two characters long to avoid false positives such as
@"-"
- Added UIAlertView
Author: dougk
Date: Thu Aug 6 17:36:24 2015
New Revision: 244290
URL: http://llvm.org/viewvc/llvm-project?rev=244290&view=rev
Log:
Range-forify a loop, delete trailing whitespace. NFC
Modified:
cfe/trunk/lib/Driver/ToolChain.cpp
Modified: cfe/trunk/lib/Driver/ToolChain.cpp
URL:
http://llvm
Author: rsmith
Date: Thu Aug 6 17:14:35 2015
New Revision: 244289
URL: http://llvm.org/viewvc/llvm-project?rev=244289&view=rev
Log:
[modules] Remove unused ModuleManager::visitDepthFirst function.
Modified:
cfe/trunk/include/clang/Serialization/ModuleManager.h
cfe/trunk/lib/Serialization
Author: rsmith
Date: Thu Aug 6 17:14:12 2015
New Revision: 244288
URL: http://llvm.org/viewvc/llvm-project?rev=244288&view=rev
Log:
[modules] Fix use-after-iterator-invalidation bug.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
URL:
Author: echristo
Date: Thu Aug 6 17:11:54 2015
New Revision: 244286
URL: http://llvm.org/viewvc/llvm-project?rev=244286&view=rev
Log:
Continue the work from r243908 by adding a Features field to Builtin::Info
so that we can populate it on a per-target basis with required features.
Future commits
rcraik marked 2 inline comments as done.
rcraik added a comment.
http://reviews.llvm.org/D10018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LGTM
On Thursday, August 6, 2015, Artem Belevich wrote:
> tra added a comment.
>
> Ping.
>
>
> http://reviews.llvm.org/D11666
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
Ping.
http://reviews.llvm.org/D11666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: majnemer
Date: Thu Aug 6 15:56:55 2015
New Revision: 244266
URL: http://llvm.org/viewvc/llvm-project?rev=244266&view=rev
Log:
[ItaniumCXXABI] Don't import RTTI data for classes with key functions
MinGW has some pretty strange behvaior around RTTI and
dllimport/dllexport:
- RTTI data is n
jyknight marked 2 inline comments as done.
Comment at: lib/AST/Decl.cpp:3122
@@ +3121,3 @@
+ void *Buffer = Context.Allocate(
+ totalSizeToAlloc(
+ TArgs.size(), Ts.size()));
rsmith wrote:
> OK, I guessed that might be the reason. Seems like a reaso
Hi,This patch extends the patches in 'Late evaluation of vectorization requirements’ (still in review). This makes the num runtime pointer checks test into a late diagnostic so we can give the user a better diagnostic message. Clang appends the diagnostic with options for getting the loop vectorize
I’ve updated the patches a bit. I am going post another pair of patches to add another late diagnostic soon as well.Please review,Tyler
LLVM-Late-evaluation-of-vectorization-requirements.patch
Description: Binary data
LLVM-Removed-unused-and-incorrectly-implemented-classof-o.patch
Description: B
ahatanak created this revision.
ahatanak added reviewers: echristo, dexonsmith.
ahatanak added a subscriber: cfe-commits.
This patch makes changes to pass subtarget feature "force-align-stack" instead
of passing a backend-option when users provide "-mstackrealign" on the command
line.
The llvm-
Author: dblaikie
Date: Thu Aug 6 13:29:32 2015
New Revision: 244241
URL: http://llvm.org/viewvc/llvm-project?rev=244241&view=rev
Log:
Fix memory ownership in the NeonEmitter by using values instead of pointers
(smart or otherwise)
Improvement to the memory leak fix in 244196.
Address validity
On Thu, Aug 6, 2015 at 11:29 AM, Richard Smith wrote:
> On Aug 6, 2015 11:01 AM, "David Blaikie" wrote:
> >
> >
> >
> > On Wed, Aug 5, 2015 at 9:23 PM, Richard Smith <
> richard-l...@metafoo.co.uk> wrote:
> >>
> >> Author: rsmith
> >> Date: Wed Aug 5 23:23:48 2015
> >> New Revision: 244192
> >>
martell created this revision.
martell added a reviewer: yaron.keren.
martell added a subscriber: cfe-commits.
When gcc is not installed we fail to set the correct include and lib directory.
In some cases base is set and we might want to use clang without gcc being
installed
http://reviews.llvm.
davide added a comment.
Hi Richard, do you have any comments on the new patch?
http://reviews.llvm.org/D11658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
Thanks! See the comments inline.
Comment at: lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp:182
@@ +181,3 @@
+ if (rhs->isEvaluatable(Context))
+eraseAssign = true;
+ // Erase if the multiplicand was assigned a value,
-
rnk updated this revision to Diff 31457.
rnk updated the summary for this revision.
rnk added a comment.
- Update classify and GetByteVectorType
http://reviews.llvm.org/D11437
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/x86_64-fp128.c
Index: test/CodeGen/x86_64-fp128.c
=
rnk commandeered this revision.
rnk added a reviewer: chh.
rnk added a comment.
Comandeering so I can upload my diff.
http://reviews.llvm.org/D11437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
rnk added a comment.
In http://reviews.llvm.org/D11437#211165, @chh wrote:
> I tried to make X86_64ABIInfo::classify to return (Lo=SSE, Hi=NoClass) for
> fp128 long double type, or (Lo=SSE, Hi=SSEUp). That is not enough, although
> making fp128 Complex type to "Memory" worked.
>
> X86_64ABIInfo
> Ah, you were referring to
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134471.html
Yes, that is correct :)
> Sorry, email is hard to keep up with sometimes :-)
No worries, I do understand ;)
--
AlexDenisov
Software Engineer, http://lowlevelbits.org
> On 06 Aug 2015, a
jordan_rose added a comment.
I guess the regular pings didn't work, so it was worth trying the gentle one?
Sorry!
This seems mostly ready to me, but I still have a few comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1646-1650
@@ -1644,2 +1645,7 @@
DefinedOrUnkn
Ah, you were referring to
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134471.html
Sorry, email is hard to keep up with sometimes :-)
On Thu, Aug 6, 2015 at 9:15 AM, Hans Wennborg wrote:
> Hi Alex,
>
> What crash is that? I don't see any PR number in the commit.
>
> Richar
theraven added inline comments.
Comment at: include/__mutex_base:246
@@ -266,3 +245,3 @@
-class _LIBCPP_TYPE_VIS condition_variable
+class _LIBCPP_TYPE_VIS condition_variable : private
__libcxx_support::condition_variable
{
espositofulvio wrote:
> theraven wro
berenm updated this revision to Diff 31447.
berenm added a comment.
Here is an updated version with some style fixes, and function splits.
The styles are still selected the same way as before (no split between finding
the best type style and falling back to available style), but there is only th
alexfh added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:178
@@ +177,3 @@
+if (NamingStyles[Typedef].isSet()) {
+ KindName = "typedef";
+ Style = NamingStyles[Typedef];
berenm wrote:
> alexfh wrote:
> > berenm wrote:
theraven added inline comments.
Comment at: include/__mutex_base:246
@@ -266,3 +245,3 @@
-class _LIBCPP_TYPE_VIS condition_variable
+class _LIBCPP_TYPE_VIS condition_variable : private
__libcxx_support::condition_variable
{
Does this change the ABI for a mutex
Author: abataev
Date: Thu Aug 6 07:30:57 2015
New Revision: 244209
URL: http://llvm.org/viewvc/llvm-project?rev=244209&view=rev
Log:
[OPENMP 4.1] Allow references in init expression for loop-based constructs.
OpenMP 4.1 allows to use variables with reference types in private clauses and,
theref
Author: aaronballman
Date: Thu Aug 6 07:15:47 2015
New Revision: 244208
URL: http://llvm.org/viewvc/llvm-project?rev=244208&view=rev
Log:
Correcting and adding tests for r244206.
Modified:
clang-tools-extra/trunk/unittests/clang-query/QueryParserTest.cpp
Modified: clang-tools-extra/trunk/un
aaron.ballman closed this revision.
aaron.ballman added a comment.
In http://reviews.llvm.org/D11761#218178, @pcc wrote:
> You'd have had to look at the documentation (i.e. the "help" message) anyway
> to determine the right way to terminate the program. We can document
> Ctrl-{D,Z} there inste
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244207: Mark calls in thunk functions as tail-call
optimization candidates (authored by mkuper).
Changed prior to commit:
http://reviews.llvm.org/D11476?vs=31341&id=31440#toc
Repository:
rL LLVM
htt
Author: mkuper
Date: Thu Aug 6 03:24:38 2015
New Revision: 244201
URL: http://llvm.org/viewvc/llvm-project?rev=244201&view=rev
Log:
[X86] Add support for _MM_ALIGN16
Differential Revision: http://reviews.llvm.org/D11753
Added:
cfe/trunk/test/CodeGen/ms-mm-align.c
Modified:
cfe/trunk/lib
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244201: [X86] Add support for _MM_ALIGN16 (authored by
mkuper).
Changed prior to commit:
http://reviews.llvm.org/D11753?vs=31317&id=31430#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11753
File
Author: yrnkrn
Date: Thu Aug 6 02:28:36 2015
New Revision: 244196
URL: http://llvm.org/viewvc/llvm-project?rev=244196&view=rev
Log:
Plug a memory leak in NeonEmitter: Intrinsics allocated were never released.
Modified:
cfe/trunk/utils/TableGen/NeonEmitter.cpp
Modified: cfe/trunk/utils/Tabl
55 matches
Mail list logo
