Re: Cleaning up the paint API of KoShape

2011-01-23 Thread jaham
On Sunday 23 January 2011 15:36:15 Inge Wallin wrote: > There is a big wart on the KoShape API and that is the one for painting. > Currently we have these two functions: > > virtual void paint(QPainter &painter, const KoViewConverter &converter) = > 0; virtual void paintDecorations(QPainter &pain

Re: Qt 4.7 as minimal requirement ?

2011-01-31 Thread jaham
On Monday 31 January 2011 17:57:17 Cyrille Berger Skott wrote: > Hi, > > I am asking the question since right now there is a compilation error for > Qt 4.6 and the connectiontool: > > /home/cyrille/src/calligra/plugins/defaultTools/connectionTool/ConnectionTo > ol.cpp: In member function ‘virtual

Re: Git policy: git merge or git cherry-pick

2011-01-31 Thread jaham
On Monday 31 January 2011 14:27:50 Lukast dev wrote: > Hello, > > I would like to have your opinion about the preferable and consistent way > of merging of the code from the features branches we have into master. > > There are more ways: > 1. git cherry-picking > a) cherrypick single commits > b)

Re: Single Canvas Presentation Feature in Karbon

2011-03-21 Thread jaham
On Monday 21 March 2011 23:17:09 Aakriti Gupta wrote: > Hi, > I am interested in the following idea of implementing a single canvas > presentation view (like Prezi, Zippl or JessyInk)as a GSoC project for this > year. > http://community.kde.org/GSoC/2011/Ideas#Project:_Single-canvas_Presentatio > n

Re: Review Request: Share handle radius and grab sensitivity via the document resource

2011-03-24 Thread jaham
On Thursday 24 March 2011 10:01:37 Boudewijn Rempt wrote: > On Wednesday 23 March 2011 Mar, Jan Hambrecht wrote: > > This patch changes the scope of the handle radius and grab sensitivity > > settings from the canvas resource to the document resource. I also added > > some convenience functions to

Re: Review Request: Share handle radius and grab sensitivity via the document resource

2011-03-26 Thread jaham
On Friday 25 March 2011 11:48:15 Boudewijn Rempt wrote: > On Thursday 24 March 2011 Mar, ja...@gmx.net wrote: > > On Thursday 24 March 2011 10:01:37 Boudewijn Rempt wrote: > > > On Wednesday 23 March 2011 Mar, Jan Hambrecht wrote: > > > > This patch changes the scope of the handle radius and grab >

Re: Review Request: Share handle radius and grab sensitivity via the document resource

2011-03-26 Thread jaham
On Saturday 26 March 2011 12:20:34 Boudewijn Rempt wrote: > On Saturday 26 March 2011 Mar, ja...@gmx.net wrote: > > On Friday 25 March 2011 11:48:15 Boudewijn Rempt wrote: > > > On Thursday 24 March 2011 Mar, ja...@gmx.net wrote: > > > > On Thursday 24 March 2011 10:01:37 Boudewijn Rempt wrote: > >

Re: Idea for solving shadow overlap issue

2011-04-19 Thread jaham
On Tuesday 19 April 2011 10:55:24 Yue Liu wrote: > Hello, > > To solve the shadow-overlap-other-shapes issue, I got an idea but not sure > whether it is done right. > The problem currently is, if we add shadow to a stencil(which is a shape > group), shadows to the child shape would overlap each ot

Re: deleting children of KoShapeContainer

2011-04-20 Thread jaham
On Wednesday 20 April 2011 14:27:53 Boudewijn Rempt wrote: > On Wednesday 20 April 2011 Apr, C. Boemann wrote: > > Hi > > > > I believe it's important for the KoShapeContainer to delete it's > > children. > > Well, we should have a clear idea on how to handle memory management for > shapes. Until

Re: Idea for solving shadow overlap issue

2011-04-20 Thread jaham
On Wednesday 20 April 2011 06:49:30 Yue Liu wrote: > > If that is not allowed in the odf specification you can't use the draw > > namespace. > > > > I think the biggest obstacle (as often) is to work around the odf > > specification. > > > > > > I haven't found out where it says which kind of st

Re: Questions about shape group

2011-05-02 Thread jaham
On Thursday 28 April 2011 16:52:17 you wrote: > Hello Jan, > > Should group be redesigned to be a shape (actually I still don't understand > why group inherits shape container and shape container inherits koShape but > group is not a shape) ? Well you already found the correct answer. :-) KoShap

Re: Questions about shape group

2011-05-02 Thread jaham
On Thursday 28 April 2011 18:02:34 you wrote: > Also, I noticed that shadow.Insets is considered when calculating the > boundingRect to a shape, is it needed to include the shadow into the > boundingRect? And besides calculating boundingRect, where is shadow.Insets > being used? Yes the shadow ins

Re: Questions about shape group

2011-05-03 Thread jaham
On Tuesday 03 May 2011 07:21:50 Yue Liu wrote: > Hello, > > Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() to > KoCommand, which now becomes > KoShapeGroupCommandPrivate::containerBoundingRect(). I think now it's ok to > move it back to KoShapeGroup, what do you think? >

Re: Proposal for new modifiers/shortcuts system

2011-06-13 Thread jaham
On Sunday 12 June 2011 11:13:59 Dmitry Kazakov wrote: > Hi! > > As we discussed at the last Krita sprint, Krita needs some common system to > manage keyboard shortcuts and modifiers. The problem is, different keyboard > keys should switch tools temporarily and restore the tool when the key is > re

Re: Proposal for new modifiers/shortcuts system

2011-06-14 Thread jaham
On Tuesday 14 June 2011 12:12:34 Dmitry Kazakov wrote: > > If I have understood correctly there two types of shortcuts needed. > > 1. Global shortcuts to change tools > > 2. Local shortcuts to change a tools state > > > > What I think is that the global shortcuts should be handled by the > > toolm

Re: Switching shapes and tools: is it broken?

2011-06-20 Thread jaham
On Monday 20 June 2011 15:31:28 Dag Andersen wrote: > Mandag 20 juni 2011 15:20:27 skrev du: > > On 20.06.2011 13:02, Dag Andersen wrote: > > > Mandag 20 juni 2011 11:37:13 skrev du: > > >> On 20.06.2011 10:34, Dag Andersen wrote: > > >>> Before the weekend I fixed a crash in ArtisticTextShape and,

Proposal: Promote svg support

2011-06-25 Thread jaham
Hi folks... I want to make a proposal to move the svg supporting classes now residing in calligra/filters/karbon/svg to a lib in calligra/libs/svg. You may ask why I want to do that. The following are some reasons: 1. Make it possible to have support for loading and saving embedded svg document

Re: Proposal: Promote svg support

2011-06-26 Thread jaham
On Sunday 26 June 2011 05:10:27 Thorsten Zachmann wrote: > On Saturday, June 25, 2011 19:45:17 ja...@gmx.net wrote: > > Hi folks... > > > > Before starting on this project I wanted to get some opinions from you if > > that is something to attempt or if that is utter bullshit. > > I'm all for it.

Re: Proposal: Promote svg support

2011-06-26 Thread jaham
On Sunday 26 June 2011 02:35:17 Aakriti Gupta wrote: > On Sun, Jun 26, 2011 at 5:02 AM, C. Boemann wrote: > > On Saturday 25 June 2011 19:45:17 ja...@gmx.net wrote: > > > Hi folks... > > > > > > I want to make a proposal to move the svg supporting classes now > > > residing in calligra/filters/ka

Re: Proposal: Promote svg support

2011-06-27 Thread jaham
On Monday 27 June 2011 17:25:37 Thorsten Zachmann wrote: > On Sunday, June 26, 2011 18:25:56 ja...@gmx.net wrote: > > I thought to have a separate lib similar to our odf lib containing the > > classes used for loading/saving svg. One of these classes would be an > > interface which shapes can impl

Re: Proposal: Promote svg support

2011-06-28 Thread jaham
On Tuesday 28 June 2011 06:00:43 Thorsten Zachmann wrote: > On Monday, June 27, 2011 22:07:28 ja...@gmx.net wrote: > > On Monday 27 June 2011 17:25:37 Thorsten Zachmann wrote: > > > On Sunday, June 26, 2011 18:25:56 ja...@gmx.net wrote: > > > > I thought to have a separate lib similar to our odf li

Re: Proposal: Promote svg support

2011-06-30 Thread jaham
On Wednesday 29 June 2011 08:24:45 Jaroslaw Staniek wrote: > On 25 June 2011 19:45, wrote: > > Hi folks... > > > > I want to make a proposal to move the svg supporting classes now residing > > in calligra/filters/karbon/svg to a lib in calligra/libs/svg. > > Hi, > Just 'wondering', would it be

Re: Proposal: Promote svg support

2011-06-30 Thread jaham
On Wednesday 29 June 2011 13:22:12 Inge Wallin wrote: > On Saturday, June 25, 2011 19:45:17 ja...@gmx.net wrote: > > Hi folks... > > > > I want to make a proposal to move the svg supporting classes now residing > > in calligra/filters/karbon/svg to a lib in calligra/libs/svg. > > You may ask why I

Re: Cleaning your remote branch list

2011-06-30 Thread jaham
y contains the active one. > > We do have a lot of branches, don't forget to tell Boudewijn or me when you > are finished with a branch so that we kill it from the server. Please remove remotes/origin/flake-clipping-jaham Thanks! Ciao Jan _

Re: [calligra/libs-svg-support-jaham] /: let rectangle and ellipse shape save themselves

2011-07-08 Thread jaham
On Thursday 07 July 2011 06:50:05 Thorsten Zachmann wrote: > Hello Jan, > > On Wednesday, July 06, 2011 20:19:29 Jan Hambrecht wrote: > > +class RectangleShape : public KoParameterShape, public SvgSerializable > > I realy think we should avoid using multiple inheritance in each shape that > makes

Re: How to use a shape without using its tools?

2011-07-09 Thread jaham
On Thursday 07 July 2011 09:34:55 Inge Wallin wrote: > I have just added a patch to the reviewboard: > http://git.reviewboard.kde.org/r/101871/ This mail is about an issue with > this patch. > > Here is the description of (one of) the issues that it solves: > > 1. It fixes a serious issue with lo

Re: [calligra] /: basic support for group shadow and shadow after filter effect

2011-08-21 Thread jaham
On Sunday 21 August 2011 14:09:56 you wrote: > On Sunday 21 August 2011 13:16:37 you wrote: > > On Sunday 21 August 2011 10:34:02 Yue Liu wrote: > > > Git commit 8cfdbbd52503fcdacc38becd746c9e8d421fb639 by Yue Liu. > > > Committed on 20/04/2011 at 17:01. > > > Pushed by liu into branch 'master'. >

Re: Karbon or Karbon14?

2012-02-23 Thread jaham
On Thursday 23 February 2012 15:37:59 Friedrich W. H. Kossebau wrote: > Hi, > > IIRC the official name of Karbon14 is now (Calligra) Karbon. But in the > sources (including the .desktop files) the name is still Karbon14. Something > inside me wants to fix this :) > > Okay if I provide a patch to

Re: Karbon or Karbon14?

2012-02-26 Thread jaham
On Saturday 25 February 2012 13:32:34 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 23. Februar 2012, 23:22:46 schrieb ja...@gmx.net: > > On Thursday 23 February 2012 15:37:59 Friedrich W. H. Kossebau wrote: > > > Hi, > > > > > > IIRC the official name of Karbon14 is now (Calligra) Karbon. But

Re: Input for ODF plugfest/TC call

2012-04-19 Thread jaham
On Thursday 19 April 2012 13:48:52 Friedrich W. H. Kossebau wrote: > Hi, > > so here my list of issues that I have had with ODF so far. Please consider > putting them on the table for the plugfest as well as for the TC call :) > > > A) no official test suite > B) spec vs. reality: how to handle

Re: RR to remove filters/karbon/{applixgraphics,eps/EpsExport}

2013-01-03 Thread jaham
On Sunday 30 December 2012 19:20:23 Boudewijn Rempt wrote: > On Sunday 30 December 2012 Dec, Friedrich W. H. Kossebau wrote: > > Hi, > > > > some filters escaped the Great Filter Cleanup (tm) but now catched my > > attention while grepping for Q3* classes. Having looked at them I propose > > to mo