Re: Merge request of text layout restructuring

2011-01-05 Thread Sebastian Sauer
C. Boemann wrote: > Last week I worked on the text layout, and I'm now requesting a merge of > the branch I worked in: > > text-layoutrestructure-boemann > > What I've done is moving the text runaround properties from the KWFrame > class to KoShape > > Secondly I moved the runaround code from KW

Don't show template selection ui any longer

2011-01-13 Thread Sebastian Sauer
Hi, please find attached a patch that disables the templates-dialog per default for Calligra words and tables. Stage is not changed since imho the default empty template doesn't really make sense for presentations. What do you think? Good idea or not? diff --git a/tables/tablesrc b/tables/table

Re: How should calligra apps start by default? Was: Re: Don't show template selection ui any longer

2011-01-14 Thread Sebastian Sauer
Boudewijn Rempt wrote: > The current template dialog is said to be the result of usability work, > though I've never seen the report nor the interaction design. I do believe it's a bad idea to display suich a dialog and seems at least Microsoft Office and OpenOffice.org do not do something like t

In Calligra Words switch to raster graphicssystem per default

2011-01-17 Thread Sebastian Sauer
Hi, please find attached a patch that makes sure Calligra Words uses the raster graphicssystem per default rather then the native one. This provides way better performance while dealing with documents compared to the native XRender backend cause of http://bugreports.qt.nokia.com/browse/QTBUG-16

Re: Combined startup view and file menu

2011-01-19 Thread Sebastian Sauer
On Wednesday 19 January 2011 20:40:30 Jaroslaw Staniek wrote: > Another mockup. > Variant of the 3.1 mockup: "Words" button's frame has been completely > removed, so the button looks and feels like other menu items. > > http://community.kde.org/Calligra/Usability_and_UX/Common/Startup/Startup_v >

Re: Combined startup view and file menu

2011-01-19 Thread Sebastian Sauer
On Wednesday 19 January 2011 22:14:25 Sebastian Sauer wrote: > On Wednesday 19 January 2011 20:40:30 Jaroslaw Staniek wrote: > > Another mockup. > > Variant of the 3.1 mockup: "Words" button's frame has been completely > > removed, so the button looks and feels

Re: Review Request 114439: Support QT_NO_PRINTER and QT_NO_NETWORKINTERFACE

2014-10-15 Thread Sebastian Sauer
/KWPrintingDialog.cpp 82b450f Diff: https://git.reviewboard.kde.org/r/114439/diff/ Testing --- Thanks, Sebastian Sauer ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

review-request: Calligra Words performance work

2011-01-31 Thread Sebastian Sauer
* Copyright (C) 2006, 2011 Sebastian Sauer * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Library General Public @@ -139,7 +140,7 @@ public: /// return the list of shapes that will be used to run all the text into. virtu

Re: "Post-it" area + notes as a GSOC?

2011-02-26 Thread Sebastian Sauer
On Saturday 26 February 2011 12:38:40 Pierre Stirnweiss wrote: > Do you think that the following would be a good GSOC subject? > > - implement the "post-it" area. inspiration: > http://wiki.services.openoffice.org/wiki/Notes2 > - implement the notes/change tracking info as "post-tis" > > The post

Re: next mentor meeting

2011-04-12 Thread Sebastian Sauer
Thorsten Zachmann wrote: > Hello all, > > On Monday, April 11, 2011 16:41:44 Boudewijn Rempt wrote: >> We need to have the final ranking done by the 16th, so I propose we have >> another IRC meeting with all mentors on #calligra-gsoc. I suggest >> Wednesday evening, 21:00 to discuss the final ran

Review-request: Fix shapes are not deleted in KPresenter

2011-04-20 Thread Sebastian Sauer
Please see attached patch which fixes Crash is observed while opening the attached ppt file https://bugs.kde.org/show_bug.cgi?id=270960 and is the followup to the "deleting children of KoShapeContainer" thread. ok to commit? diff --git a/kpresenter/part/KPrPicturesImport.cpp b/kpresenter/part/KPrP

Re: Review-request: Fix shapes are not deleted in KPresenter

2011-04-21 Thread Sebastian Sauer
Boudewijn Rempt wrote: > On Wednesday 20 April 2011 Apr, Sebastian Sauer wrote: >> Please see attached patch which fixes >> Crash is observed while opening the attached ppt file >> https://bugs.kde.org/show_bug.cgi?id=270960 >> and is the followup to the "delet

Re: KoTableColumnAndRowStyleManager Question.

2011-04-27 Thread Sebastian Sauer
On Monday 28 February 2011 10:08:53 Ganesh Paramasivam wrote: > Yes, you are right. I missed looking at this declaration > QExplicitlySharedDataPointer d; But imho it would still be great to change it to a reference so it's easier to understand the code without looking at the private implementati

Re: KoTableColumnAndRowStyleManager Question.

2011-04-27 Thread Sebastian Sauer
On Thursday 28 April 2011 02:07:32 Sebastian Sauer wrote: > On Monday 28 February 2011 10:08:53 Ganesh Paramasivam wrote: > > Yes, you are right. I missed looking at this declaration > > QExplicitlySharedDataPointer d; > > But imho it would still be great to change it t

Re: Testing document loading/painting

2011-04-29 Thread Sebastian Sauer
; www.odfauthors.org%2Fopenoffice.org%2Fenglish%2Fuserguide3%2Fimpress3%2F3%30_published%2F%305%308IG3- > SlidesNotesAndHandouts.odt Cannot reproduce any longer. Fixed too? -- Best regards Sebastian Sauer | sebastian.sa...@kdab.com | Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Gro

The state of Calligra Words (a call for testing)

2011-05-03 Thread Sebastian Sauer
When we merged end of last week the textlayout-branch to master things where in a pretty bad state. I was surprised how much problems did show up within last days. I was even more surprised to see how fast they got fixed. Special thanks here goes to Casper and Thorsten. Today we are in a state

Re: The state of Calligra Words (a call for testing)

2011-05-06 Thread Sebastian Sauer
Cyrille Berger Skott wrote: > I did not tag yesterday, because I lost the release script :( > > But after seeing this on IRC, I am not sure if we shouldn't wait a little: > > 08:26 < Zagge> words is totally broken :-( > 08:27 < Zagge> boemann: sebsauer: if you type text and come to the bottom >

Do KoCanvasControllerWidget::updateDocumentSize only if size changed (fixes loop)

2011-05-15 Thread Sebastian Sauer
Hi, please see following patch for libs/flake/KoCanvasControllerWidget.cpp to prevent doing anything on KoCanvasControllerWidget::updateDocumentSize. This fixes the infinite loop with the http://www.zagge.de/anchor/110407/wiki.documentfoundation.org%252Fcgi_img_auth.php%252Fe%252Fe9%252F%25301%

In KoTextDocumentLayout::documentChanged update only following pages (fixes loop)

2011-05-15 Thread Sebastian Sauer
Hi, please see following patch for libs/textlayout/KoTextDocumentLayout.cpp to prevent doing full relayouts just cause we update the page-variable. This fixes the infinite loop with the http://www.zagge.de/anchor/110407/wiki.services.openoffice.org%252Fw%252Fimages%252F9%252F91%252F%25305%25308

Infinite loop fix that disables the experitmenal iterative mode in KoTextDocumentLayout::positionAnchoredObstructions

2011-05-15 Thread Sebastian Sauer
Following patch fixes infinite loops with http://www.zagge.de/anchor/110407/www.coe.unt.edu%252Fsystem%252Ffiles%252F433%252F833%252FTEKS%2520A2%2520B%2520Cab%2520Ride.docx http://www.zagge.de/anchor/110407/www.colfinder.net%252Fmaterials%252FMalaria_Course%252Fodt%252FUNIT_6.odt http://www.zagge.

Re: Infinite loop fix that disables the experitmenal iterative mode in KoTextDocumentLayout::positionAnchoredObstructions

2011-05-15 Thread Sebastian Sauer
On Sunday 15 May 2011 21:53:34 C. Boemann wrote: > On Sunday 15 May 2011 21:40:45 Sebastian Sauer wrote: > > Following patch fixes infinite loops with > > http://www.zagge.de/anchor/110407/www.coe.unt.edu%252Fsystem%252Ffiles%252F > > > 433%252F833%252FTEKS%2520A2%252

Re: In KoTextDocumentLayout::documentChanged update only following pages (fixes loop)

2011-05-15 Thread Sebastian Sauer
On Sunday 15 May 2011 21:52:07 C. Boemann wrote: > On Sunday 15 May 2011 21:36:48 Sebastian Sauer wrote: > > Hi, > > > > please see following patch for libs/textlayout/KoTextDocumentLayout.cpp > > to prevent doing full relayouts just cause we update the page-variab

Review-request: Fix copy+paste sections (bug 271029)

2011-05-25 Thread Sebastian Sauer
The problem is that on copy+paste text in Words we create ODF ouf of a fragment. That fragment can contains SectionEnd's without SectionStart's (or the other way around which would probably produce invalid XML? That case is not handled with this patch :-/ ). That results then in an assert. See b

Remove Zoom-submenu from mainmenu?

2011-05-25 Thread Sebastian Sauer
Hi, please see attached patch which removes the zoom-submenu from all Calligra applications. The reason is that it's redundant with the zoom-menu we have in the statusbar. Good idea or not? diff --git a/braindump/data/braindumpview.rc b/braindump/data/braindumpview.rc index 999c949..2f6f59c 100

Review-request: Fix infinite loop caused by variable-refresh

2011-06-03 Thread Sebastian Sauer
Hi, attached patch fixes the infinite loop with the document attached to comment #3 in https://bugs.kde.org/show_bug.cgi?id=260219 . The idea is to not include the previous and next root-areas and mark them dirty if charsAdded and charsRemoved ==0 what means no characters where changed. In suc

Re: Review-request: Fix infinite loop caused by variable-refresh

2011-06-03 Thread Sebastian Sauer
C. Boemann wrote: > On Friday 03 June 2011 21:13:59 Sebastian Sauer wrote: >> Hi, >> >> attached patch fixes the infinite loop with the document attached to >> comment #3 in https://bugs.kde.org/show_bug.cgi?id=260219 . >> >> The idea is to not include th

Re: Review Request: GSoC: improve selection, drag&drop of Stage Slides Sorter

2011-06-05 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101501/#review3685 --- Great patch and blog ( http://paulm-byte.blogspot.com/2011/05/g

Re: Update from the ODF TC

2011-06-06 Thread Sebastian Sauer
Jos van den Oever wrote: > Hello Calligra-ers, > > As you may or may not know, I represent KDE in the committee that > specifies the OpenDocument Format. We have a weekly telephone call for the > core TC in which I and Thorsten Zachmann participate. In addition there is > a weekly call for the wor

Re: [calligra] libs/textlayout: Fix crash on editing.

2011-06-06 Thread Sebastian Sauer
C. Boemann wrote: > Actually this may be due to the document containing foot or endnotes > > I have some trick in mind to prevent this, so are there anyway you can > mark or move this to a workaround branch for now I don't think that's a good idea. It's crashing just because of painting, the com

Re: Review Request: Anchored shape positioning fix

2011-06-07 Thread Sebastian Sauer
- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101532/ > ------- > > (Updated June 7, 2011, 12:49 p.m.) > > > Review request for Calligra, Casper Boemann and Sebastian Sauer. >

Re: Review Request: Anchored shape positioning fix

2011-06-07 Thread Sebastian Sauer
eviewboard.kde.org/r/101532/ > --- > > (Updated June 7, 2011, 12:49 p.m.) > > > Review request for Calligra, Casper Boemann and Sebastian Sauer. > > > Summary > --- > > This is reimplementation of the old layout ancho

review-request: Fix objects are displayed if they should be hidden

2011-06-07 Thread Sebastian Sauer
This is related to bug https://bugs.kde.org/show_bug.cgi?id=274905 or to be more exact to the objects displayed at the top of the first page which should not be displayed. The problem: The anchored objects are anchored to a header/footer which is never created and displayed cause no page with s

review-request: Fix invalid data-pointer in the msword-filter

2011-06-08 Thread Sebastian Sauer
Please find attached a patch that fixes bug 275204. The reason for the bug was that we where ending with random values cause what could work but sometimes didn't. The values where random cause we dealed with mem past the allocated number of U8-bytes. diff --git a/filters/words/msword-odf/wv2/src

Re: review-request: Fix invalid data-pointer in the msword-filter (2)

2011-06-09 Thread Sebastian Sauer
On Wednesday 08 June 2011 22:37:13 Sebastian Sauer wrote: > Please find attached a patch that fixes bug 275204. The reason for the bug > was that we where ending with random values cause what could work but > sometimes didn't. The values where random cause we dealed with mem past &

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Sebastian Sauer
Thorsten Zachmann wrote: > Hello, > > On Friday, June 10, 2011 08:22:04 Jos van den Oever wrote: >> Here is an idea to improve code quality in Calligra. >> >> Currently, we use KoXmlWriter to write ODF XML. For this, functions like >> startElement, endElement, addAttribute are used. >> >> By usi

Re: Announcement for snapshot 2

2011-06-13 Thread Sebastian Sauer
On Saturday 11 June 2011 23:30:33 Inge Wallin wrote: > As far as I know, Cyrille has tagged snapshot 2 now. At least he updated > the version to 2.3.72. > > This means that the release is imminent, and it's time for me to write a > new announcement. So I'd like to get a grasp of what has happene

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
Dag Andersen wrote: > I'm looking into a crash which happens when textshapes is edited and the > shape is not on page 1. This is a general case of header/footer crash > reported in: https://bugs.kde.org/show_bug.cgi?id=273945 > > AFAICS the problem is in KWRootAreaProvider::provide(). > It seems

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
52:22 Sebastian Sauer wrote: > Dag Andersen wrote: > > I'm looking into a crash which happens when textshapes is edited and the > > shape is not on page 1. This is a general case of header/footer crash > > reported in: https://bugs.kde.org/show_bug.cgi?id=273945 &g

Review Request: Proper handle break-after="page"

2011-06-15 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/ --- Review request for Calligra. Summary --- The problem is that incremen

Re: Review Request: Proper handle break-after="page"

2011-06-15 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/ --- (Updated June 15, 2011, 4:15 p.m.) Review request for Calligra. Summary

Re: Review Request: Proper handle break-after="page"

2011-06-15 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/ --- (Updated June 15, 2011, 4:16 p.m.) Review request for Calligra. Summary

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
On Wednesday 15 June 2011 15:16:44 Dag Andersen wrote: > Onsdag 15 juni 2011 15:00:33 skrev Sebastian Sauer: > > Seems meanwhile I found the reason why it crashes thanks to your hint :) > > The fix is at http://pastebin.com/fsNFBwqY and the reason was that even > > when th

Re: Double^W Quadruple speed parsing of binary MS Office files

2011-06-15 Thread Sebastian Sauer
On Tuesday 14 June 2011 09:19:20 Jos van den Oever wrote: > On Monday, June 13, 2011 19:02:09 PM Jos van den Oever wrote: > > When run on a set of 600 ppt files from a.o. kofficetests, this is the > > output from valgrind: > > simpletest: (normal run time: 5.7 seconds) > > ==28930== total heap us

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
On Thursday 16 June 2011 02:19:04 C. Boemann wrote: > On Thursday 16 June 2011 01:58:42 Sebastian Sauer wrote: > > On Wednesday 15 June 2011 15:16:44 Dag Andersen wrote: > > > Onsdag 15 juni 2011 15:00:33 skrev Sebastian Sauer: > > > > Seems meanwhile I found the r

Re: words: strange code KWFrame dtor

2011-06-17 Thread Sebastian Sauer
Dag Andersen wrote: > The code indicates that the last frame should delete its frameset. This > never happens though, as when the frame removes itself from the frameset, > the frames framset pointer is reset. The detaching only happens if the frameset still knows about the frame so it seems... >

Re: Bugs with patches (remove close toolbar-button)

2011-06-20 Thread Sebastian Sauer
On Sunday 19 June 2011 10:54:37 Boudewijn Rempt wrote: > We don't have many bugs with patches, but some of them are quite old and > others haven't had any attention yet. > > 260564wis NOR calligra-bugs-n...@kde.org NEW > calligra usabilit > Linuk

Re: Bugs with patches (remove close toolbar-button)

2011-06-20 Thread Sebastian Sauer
On Monday 20 June 2011 22:29:15 Sven Langkamp wrote: > On Mon, Jun 20, 2011 at 9:20 PM, Sebastian Sauer wrote: > > On Sunday 19 June 2011 10:54:37 Boudewijn Rempt wrote: > > > We don't have many bugs with patches, but some of them are quite old > > > and othe

Re: Bugs with patches (remove close toolbar-button)

2011-06-20 Thread Sebastian Sauer
On Tuesday 21 June 2011 00:01:22 Sebastian Sauer wrote: > On Monday 20 June 2011 22:29:15 Sven Langkamp wrote: > > On Mon, Jun 20, 2011 at 9:20 PM, Sebastian Sauer wrote: > > > On Sunday 19 June 2011 10:54:37 Boudewijn Rempt wrote: > > > > We don't have many

Re: cursor keys broken in words

2011-06-21 Thread Sebastian Sauer
> >> > I'm bisecting it -- but it could indeed be that long ago. June 1st > >> >> > it was still allright, though. > >> >> > >> >> Alright. It was a wild guess as it seemed to touch some > >> >> cursor/editor-ish stuff. > >>

Re: Bugs with patches (remove close toolbar-button)

2011-06-21 Thread Sebastian Sauer
On Tuesday 21 June 2011 14:32:50 Arjen Hiemstra wrote: > On Tuesday 21 June 2011 09:55:15 Boudewijn Rempt wrote: > > I like the idea of a view lock; especially if it would also lock the > > height/width/position of the dockers. If it just removes the close > > button, I don't see much value for it,

Re: Bugs with patches (remove close toolbar-button)

2011-06-21 Thread Sebastian Sauer
On Tuesday 21 June 2011 11:47:57 Cyrille Berger Skott wrote: > On Tuesday 21 June 2011, Boudewijn Rempt wrote: > > I like the idea of a view lock; especially if it would also lock the > > height/width/position of the dockers. If it just removes the close > > button, I don't see much value for it, a

Re: Review Request: some small performance improvements in plugins

2011-06-23 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101736/#review4110 --- Ship it! Looks good .Thanks! - Sebastian On June 23, 2011, 7

Re: Cleaning your remote branch list

2011-06-29 Thread Sebastian Sauer
On Wednesday 29 June 2011 10:39:25 Cyrille Berger Skott wrote: > Hi, > > We just realized that git does not auto-clean the list of remote branches > from your local clone. To do that, the best is to run "git remote prune > origin", so that the list of branches only contains the active one. > > We

Re: Review Request: Some dead code I do not know how to handle

2011-06-29 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4267 --- The kotext-part looks great. - Sebastian On June 29, 2011, 8:

Re: Review Request: add const qualifier to methods that do not modify the object status

2011-07-03 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101839/#review4342 --- Ship it! - Sebastian On July 3, 2011, 8:04 a.m., Jaime Torres

Re: Review Request: more methods made const

2011-07-03 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101843/#review4358 --- - bool operator==(BaseIterator it) + bool operator==(BaseIterato

Re: Review Request: more methods made const

2011-07-04 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101843/#review4369 --- Ship it! Ha, I see. Thank you for the clarification and all the

Re: [calligra] libs/main: Show the current working directory by default when starting without args

2011-07-04 Thread Sebastian Sauer
On Monday 04 July 2011 15:29:10 Cyrille Berger Skott wrote: > On Monday 04 July 2011, Boudewijn Rempt wrote: > > On Monday 04 July 2011 Jul, Marijn Kruisselbrink wrote: > > > Why would you want the "current" working directory to be shown when you > > > start an app from the kde menu and/or krunner

Re: Review Request: Do not loose DDE text

2011-07-05 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101855/#review4412 --- Ship it! - Sebastian On July 5, 2011, 1:48 p.m., Dag Andersen

Re: [calligra] libs/main: Show the current working directory by default when starting without args

2011-07-05 Thread Sebastian Sauer
On Tuesday 05 July 2011 10:03:44 Boudewijn Rempt wrote: > On Monday 04 July 2011 Jul, Sebastian Sauer wrote: > > just an additional idea; > > > > How about allowing to define a directory as argument and not only a file? > > Then somebody could do "calligrawords .&

Review Request: QTextLine positioning on right-to-left

2011-07-06 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101867/ --- Review request for Calligra and Casper Boemann. Summary --- Attached

Re: Review Request: QTextLine positioning on right-to-left

2011-07-06 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101867/ --- (Updated July 6, 2011, 3:04 p.m.) Review request for Calligra and Casper B

Re: Review Request: QTextLine positioning on right-to-left

2011-07-07 Thread Sebastian Sauer
viewboard.kde.org/r/101867/#review4471 --- On July 6, 2011, 3:04 p.m., Sebastian Sauer wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request: Fix hyperlink-activation in Tables

2011-07-07 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101872/ --- Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus. Sum

Re: Questions about Words

2011-07-08 Thread Sebastian Sauer
Aloha Steven, Steven Kakoczky wrote: > I'm trying to understand how words is put together so I can add a Notes > feature to it and was wondering if someone could explain to me what I need > to know about the way the KWView, KWDocument, KWPage, and KWCanvas, or any > related objects, work together

Progress-update for shapes (in this case emf-parser in the vectorshape)

2011-07-09 Thread Sebastian Sauer
Hi, please find attached a patch that introduces the possibility to provide progress updates for shapes so they are able to give feedback on long running tasks. The patch also extends the vectorshape to use the functionality during parsing an EMF file. What you think? diff --git a/libs/flake/

Re: Progress-update for shapes (in this case emf-parser in the vectorshape)

2011-07-09 Thread Sebastian Sauer
On Saturday 09 July 2011 18:20:35 Sebastian Sauer wrote: > Hi, > > please find attached a patch that introduces the possibility to provide > progress updates for shapes so they are able to give feedback on long > running tasks. > > The patch also extends the vectorshape to

Re: Position of elements TOCs

2011-07-11 Thread Sebastian Sauer
that breaks it is > > 3eff92c01f932f5a6aed520431248fce8cef3dcb is the first bad commit > commit 3eff92c01f932f5a6aed520431248fce8cef3dcb > Author: Sebastian Sauer > Date: Thu Jul 7 20:44:19 2011 +0200 > > Fix letters are sometimes only visible after a relayout. > > So it

Re: [calligra] libs/kotext/styles: Fix saving line-height to ODF. Just because the property exists doesn't mean it's valid.

2011-07-12 Thread Sebastian Sauer
Pierre wrote: > On Friday 08 July 2011 18:51:17 Sebastian Sauer wrote: >> Git commit 9f017cf21d343c1408214499bd878b987d8daf6f by Sebastian Sauer. >> Committed on 08/07/2011 at 18:43. >> Pushed by sebsauer into branch 'master'. >> >> Fix saving line-heig

Regressions || Huston we have a problem

2011-07-15 Thread Sebastian Sauer
Aloha, yesterday at the ODF plugfest 2011 ( http://www.opendocsociety.org/news/2011- berlin-plugfest/ ) we had two interoperability tests and failed on both of them. It seems both where working at some point but cause of regressions didn't any longer at the event. That is a problem. Let me add

Re: Regressions || Huston we have a problem

2011-07-17 Thread Sebastian Sauer
On Saturday 16 July 2011 15:44:52 Pierre wrote: > On Friday 15 July 2011 12:30:01 Sebastian Sauer wrote: > > Aloha, > > > > yesterday at the ODF plugfest 2011 ( > > http://www.opendocsociety.org/news/2011- berlin-plugfest/ ) we had two > > interoperability tes

Re: Regressions || Huston we have a problem

2011-07-17 Thread Sebastian Sauer
On Friday 15 July 2011 16:27:00 Thorsten Zachmann wrote: > On Friday, July 15, 2011 13:52:26 Cyrille Berger Skott wrote: > > On Friday 15 July 2011, Boudewijn Rempt wrote: > > > On Friday 15 July 2011 Jul, Sebastian Sauer wrote: > > > > Aloha, > > > >

Review Request: Fix table-borders are sometimes not visible

2011-07-19 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102007/ --- Review request for Calligra. Summary --- Attached patch fixes the cas

Re: Review Request: unused-but-set-variable-warning

2011-07-21 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101911/#review4933 --- Ship it! - Sebastian On July 10, 2011, 9:10 p.m., Sune Vuorel

Review Request: Make parsing and drawing of the vectorshape threaded

2011-07-21 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102028/ --- Review request for Calligra. Summary --- Attachd patch makes the prob

Re: Review Request: Make parsing and drawing of the vectorshape threaded

2011-07-21 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102028/ --- (Updated July 21, 2011, 9:05 p.m.) Review request for Calligra. Summary

Review Request: Make parsing and drawing of the vectorshape threaded (2th try)

2011-07-26 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102093/ --- Review request for Calligra. Summary --- Attachd patch makes the prob

Review Request: Prevent infinite layout-loop

2011-07-27 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102097/ --- Review request for Calligra and Casper Boemann. Summary --- Attached

Re: Review Request: Prevent infinite layout-loop

2011-07-27 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102097/ --- (Updated July 27, 2011, 2:04 p.m.) Review request for Calligra and Casper

Review Request: Fix text clipping

2011-07-27 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102100/ --- Review request for Calligra and Casper Boemann. Summary --- A while a

Review Request: Fix clipping of cosmetic pen table-borders drawn for user convenience when on screen (accuBlankBorders)

2011-07-28 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102107/ --- Review request for Calligra and Casper Boemann. Summary --- The probl

Re: Regressions

2011-08-01 Thread Sebastian Sauer
Thanks for discovering. Thorsten Zachmann wrote: > 2. Problems with shape positions introduced in > commit 4104ab4dc622b2390b22072dcc49d9c3596f23f1 > Author: Sebastian Sauer > Date: Thu Jul 28 12:04:21 2011 +0200 > > Fix infinite layout-loop > see http://git.

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5440 --- 1. Please test loading with ODT/ODS/ODP files produced with Word

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Sebastian Sauer
> On Aug. 6, 2011, 4:35 p.m., Sebastian Sauer wrote: > > 1. Please test loading with ODT/ODS/ODP files produced with > > Words/Tables/Stage. OO.org does save all the content in one line and > > therefore has no additional spaces in front. For me it looks like those &

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5443 --- Thinking a bit more in my opinion we should not change how white

Re: Review Request: Fix for Words crashes on picking "Blank Document" in template dialog with one document already open.

2011-08-08 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102242/#review5494 --- Ship it! Just fantastic :-) - Sebastian On Aug. 7, 2011, 10:

Re: Review Request: Fix layout of CellToolOptionWidget

2011-08-09 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102244/#review5535 --- Ship it! yay :) - Sebastian On Aug. 7, 2011, 2:15 p.m., Pet

Re: Review Request: Add support for relative minimum line height

2011-08-12 Thread Sebastian Sauer
. 12, 2011, 10:53 a.m.) > > > Review request for Calligra and Sebastian Sauer. > > > Summary > --- > > style:line-height-at-least can be relative. This patch implements this > behaviour, but I'm not sure what it is relative to... > > > Diffs > - &

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-16 Thread Sebastian Sauer
> On Aug. 6, 2011, 5:04 p.m., Sebastian Sauer wrote: > > Thinking a bit more in my opinion we should not change how whitespaces are > > handled atm if there is no good reason for it (like a performance-boost or > > ...). The "2.10 White Space Handling" section

Re: Review Request: Tables: Fix Bug 266223 - Cannot reliably sort rows with some empty cells

2011-08-23 Thread Sebastian Sauer
- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102411/ > --- > > (Updated Aug. 22, 2011, 6:41 p.m.) > > > Review request for Calligra, Marijn Kru

Re: Review Request: Tables: Fix Bug 266223 - Cannot reliably sort rows with some empty cells

2011-08-23 Thread Sebastian Sauer
eply, visit: > http://git.reviewboard.kde.org/r/102411/ > --- > > (Updated Aug. 22, 2011, 6:41 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer. > > > Summary > --- > > Calligra Tabl

Re: Review Request: Tables: Fix Bug 266223 - Cannot reliably sort rows with some empty cells

2011-08-24 Thread Sebastian Sauer
> On Aug. 23, 2011, 8:12 a.m., Sebastian Sauer wrote: > > Boemann provided the answer; "in excel at least you can choose format even > > if the value is empty" > > So, yes, makes absolutely sense :-) > > > > Juan Aquino wrote: > I have no git

Re: Review Request: Fix some odf saving/loading for charts

2011-08-30 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102488/#review6169 --- plugins/chartshape/ChartShape.cpp

Re: Review Request: Fix some odf saving/loading for charts

2011-08-30 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102488/#review6170 --- Ship it! - Sebastian On Aug. 30, 2011, 7 a.m., Thorsten Zachm

Re: Review Request: Some small fixes for latex exports

2011-09-01 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102467/#review6213 --- Ship it! - Sebastian On Aug. 28, 2011, 11:23 a.m., Jaime Torr

Review Request: Fix wrong position calculations in AbstractSelectionStrategy, SelectionStrategy and DragAndDropStrategy

2011-09-02 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102517/ --- Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus. Sum

Review Request: Fix crashes in the DOC filter

2011-09-02 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102520/ --- Review request for Calligra and Matus Uzak. Summary --- Attached patc

Re: Review Request: IndexGeneratorManager

2011-09-05 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102508/#review6270 --- Ship it! - Sebastian On Sept. 1, 2011, 4:37 p.m., Casper Boem

Re: [calligra] libs/textlayout: Reworked anchor logic.

2011-09-06 Thread Sebastian Sauer
;tab=buildResultsDiv&buildTypeId=bt7 Will look. On Monday 05 September 2011, Sebastian Sauer wrote: Git commit 644f8d91b3944ea46ee467d981cae12a7440e1c7 by Sebastian Sauer. Committed on 05/09/2011 at 15:12. Pushed by sebsauer into branch 'master'. Reworked anchor logic. A coperate bo

Re: Review Request: Fix crashes in the DOC filter

2011-09-06 Thread Sebastian Sauer
de.org/r/102520/#review6310 --- On Sept. 2, 2011, 11:50 a.m., Sebastian Sauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

  1   2   3   >