> On Sept. 6, 2011, 6:04 p.m., Matus Uzak wrote: > > There are two different issues in bug 281112 and bug 281164. An invalid > > Header document, to be specific header/footer stories are missing. And > > Header documents of Word6 files have to be validated in a different way. I > > already have a fix for both. Going to commit tomorrow.
Great, thanks :) - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102520/#review6310 ----------------------------------------------------------- On Sept. 2, 2011, 11:50 a.m., Sebastian Sauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102520/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2011, 11:50 a.m.) > > > Review request for Calligra and Matus Uzak. > > > Summary > ------- > > Attached patch fixes the both crash bugs > https://bugs.kde.org/show_bug.cgi?id=281112 and > https://bugs.kde.org/show_bug.cgi?id=281164 . > > I know it is a rather dirty way (see comments I added to bug 281112 for more > details) but then > 1) it fixes the crashes > 2) it doesn't reopen the original problem that code tried to fix > 3) it makes it more easy to understand the code (I seriously have no idea > what that new code is supposed to do - hint: a comment explaining what it > does for what reason would be *veryyyyyyyyyyy* useful here) > > > Diffs > ----- > > filters/words/msword-odf/wv2/src/headers.cpp 877f557 > > Diff: http://git.reviewboard.kde.org/r/102520/diff > > > Testing > ------- > > > Thanks, > > Sebastian > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
