D19759: Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY Resulted warning "QGraphicsWidget::setAttribute: unsupported attribute 14". Don't think this has ever worked as in

D19760: Support Qt <5.7 on KoShape flag usage

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY Currently Qt 5.3 is defined as minimum version in root CMakeLists.txt, but setFlag() was introduced in Qt 5.7. Add

D19761: Remove obsolete syncX() workaround

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY On Qt5 qApp->syncX() is a deprecated no-op method. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.

D19884: Avoid deprecated QAbstractItemModel::reset()

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19884 AFFECTED FILES plugins/textshape/TextDocumentStructur

D19759: Remove unsupported attributes from QGraphicsWidgets

pvuorela updated this revision to Diff 54325. pvuorela retitled this revision from "Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets" to "Remove unsupported attributes from QGraphicsWidgets". pvuorela edited the summary of this revision. pvuorela added a comment. Updated to re

D19885: Implement logging category for excel plugins

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY Previous std::cout/printf as debug output, std::cerr/stderr as warning output. Not 100% the same output, but shou

D19885: Implement logging category for excel plugins

pvuorela updated this revision to Diff 54337. pvuorela added a comment. Eliminated one unintended #ifdef SWINDER_XLS2RAW removal from the patch. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19885?vs=54323&id=54337 REVISION DETAIL https://phabricator.kde

D19884: Avoid deprecated QAbstractItemModel::reset()

pvuorela added inline comments. INLINE COMMENTS > dcaliste wrote in TextDocumentStructureModel.cpp:308 > I did the same changes in https://phabricator.kde.org/D15102 at another place > and I put the begin and end at the start and end of the routine, like you > did. But I remember that I got rev

D19912: Implement logging category for rtf-qt

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY To be noted that indentation looks a bit off, rtf-qt has a mixed bag of hard tabs and spaces, used only spaces here

D19912: Implement logging category for rtf-qt

pvuorela added a comment. In D19912#435058 , @danders wrote: > Strange indents, could you fix it? That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same f

D19938: Avoid deprecated QRegion::subtract()

pvuorela created this revision. pvuorela added a reviewer: Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19938 AFFECTED FILE

D19941: Avoid deprecated setSupportedDragActions

pvuorela created this revision. pvuorela added a reviewer: Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19941 AFFECTED FILE

D19943: Small cleanups for qml components

pvuorela created this revision. pvuorela added a reviewer: leinir. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY - Delete doesn't need null protection - Removed some non-functional texteditor

D19944: Migrate away from deprecated interfaces in gemini dropbox parts

pvuorela created this revision. pvuorela added a reviewer: leinir. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY Having trouble getting Gemini Dropbox working here, but should be simple enough

D19973: MsooXmlCommonRead: protect member for double free

pvuorela created this revision. pvuorela added a reviewer: Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19973 AFFECTED FILE

D19943: Small cleanups for qml components

pvuorela added inline comments. INLINE COMMENTS > leinir wrote in Document.cpp:221 > What happens to this signal now? Nothing, but that's how it used to be. The intention might have been different, but effectively it's two disconnects without actual connection appearing anywhere as far as I ca

D19759: Remove unsupported attributes from QGraphicsWidgets

pvuorela added a comment. Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute(). REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19759 To: pvuorela, boemann Cc: Cal

D19943: Small cleanups for qml components

This revision was automatically updated to reflect the committed changes. Closed by commit R8:35ec7cff51c2: Small cleanups for qml components (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19943?vs=54489&id=55405 REVISION DETAIL https

D19944: Migrate away from deprecated interfaces in gemini dropbox parts

This revision was automatically updated to reflect the committed changes. Closed by commit R8:cfdd5d860b2a: Migrate away from deprecated interfaces in gemini dropbox parts (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19944?vs=54490&id=

D19759: Remove unsupported attributes from QGraphicsWidgets

pvuorela added a comment. Second ping for this. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19759 To: pvuorela, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D23492: Correct anchor detection in QML components.

pvuorela added a comment. Indeed that doesn't look like a good loop, if triggered once, nothing affecting the break out condition inside of it. But isn't the same thing happening also at the beginning of this method, and actually same kind of construct being there in spreadsheet and presenta

D23492: Correct anchor detection in QML components.

pvuorela accepted this revision. pvuorela added a comment. Having a bit strange rendering for TextDocumentImpl.cpp changes here, but the raw diff looks good now. Trust all good :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23492 To: dcaliste, leinir, pvuorela, d

D23492: Correct anchor detection in QML components.

pvuorela added a comment. And even rendering now better, no idea what happened. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23492 To: dcaliste, leinir, pvuorela, danders, boemann Cc: Calligra-Devel-list, #calligra:_3.0, dcaliste, cochise, vandenoever

D24831: Migrate csv plugins from kdebug to qdebug

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY Introduce logging categories both for import and export. Also while at it, migrated cursor overrides from QApplica

D24831: Migrate csv plugins from kdebug to qdebug

pvuorela added reviewers: dcaliste, leinir. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24831 To: pvuorela, dcaliste, leinir Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D24830: Add support for strikeout text in RTF documents

pvuorela added inline comments. INLINE COMMENTS > DocumentDestination.cpp:121 > + } else if ( controlWord == "strike" ) { > + m_output->setFontStrikeout(true); > } else if ( ( controlWord == "u" ) && hasValue ) { Value should be like bold and underline, i.e. something like "! h

D24830: Add support for strikeout text in RTF documents

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Looking good to me. REVISION DETAIL https://phabricator.kde.org/D24830 To: akomakhin, pvuorela, #calligra:_3.0 Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24830: Add support for strikeout text in RTF documents

This revision was automatically updated to reflect the committed changes. Closed by commit R8:11b3b7718796: Add support for strikeout text in RTF documents (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24830?vs=68442&id=68516 REVISION

D24761: Asign correct column width when importing XLS file

pvuorela added a comment. Seems it was indeed the only physicalDpi, though not too many logical either. Not trivial to follow, but seems sane and the screenshots are thorough. I'll approve if no-one objects shortly. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D247

D24943: Better charset, unicode and image support for RTF files

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY Combining work from Andrew den Exter and Mikhail Filippov. Supports better different encodings, images and unicode

D19759: Remove unsupported attributes from QGraphicsWidgets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:0e9d73d8ce1e: Remove unsupported attributes from QGraphicsWidgets (authored by pvuorela). REPOSITORY R8 Calligra CHAN

D24761: Asign correct column width when importing XLS file

pvuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24761 To: davidllewellynjones, #calligra:_3.0, pvuorela Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24831: Migrate csv plugins from kdebug to qdebug

This revision was automatically updated to reflect the committed changes. Closed by commit R8:b17f993c3b20: Migrate csv plugins from kdebug to qdebug (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24831?vs=68438&id=68884 REVISION DETAIL

D24943: Better charset, unicode and image support for RTF files

pvuorela added inline comments. INLINE COMMENTS > davidllewellynjones wrote in DocumentDestination.cpp:125 > A minor issue, but the spacing around the brackets here doesn't match the > surrounding code. Sure. > davidllewellynjones wrote in PictDestination.cpp:46 > The spec mentions `\wbitmap`

D24943: Better charset, unicode and image support for RTF files

pvuorela updated this revision to Diff 6. pvuorela added a comment. Whitespace adjustments REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24943?vs=68746&id=6 BRANCH unicode REVISION DETAIL https://phabricator.kde.org/D24943 AFFECTED FILES fi

D24943: Better charset, unicode and image support for RTF files

pvuorela marked an inline comment as done. pvuorela added inline comments. INLINE COMMENTS > davidllewellynjones wrote in PictDestination.cpp:101 > The logic is confusing me here I'm afraid. If there's no `\picwgoal` control > word, then `m_goalWidth` will default to 0 and the code above will be

D24943: Better charset, unicode and image support for RTF files

pvuorela updated this revision to Diff 68972. pvuorela added a comment. Update image size reading conditions REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24943?vs=6&id=68972 BRANCH unicode REVISION DETAIL https://phabricator.kde.org/D24943 AFFEC

D24943: Better charset, unicode and image support for RTF files

This revision was automatically updated to reflect the committed changes. Closed by commit R8:1b17db1a98ec: Better charset, unicode and image support for RTF files (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24943?vs=68972&id=69026 R

D24761: Asign correct column width when importing XLS file

This revision was automatically updated to reflect the committed changes. Closed by commit R8:e80856e8eb6a: Asign correct column width when importing XLS file (authored by davidllewellynjones, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D25035: Fix incorrect conditional styling of spreadsheet cells.

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25035 To: denexter, pvuorela Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D25037: Don't drop number styling information from xlsx cell formats which start with a currency symbol.

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Seems good. REVISION DETAIL https://phabricator.kde.org/D25037 To: denexter, pvuorela Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D25036: Don't double format spreadsheet currency values with custom format strings.

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Seems good. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25036 To: denexter, pvuorela Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D25031: Don't allow an unrecognized child element to block loading of a shape plugin.

pvuorela added a comment. Seems sensible to me. I'll approve and merge shortly if no-one objects. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25031 To: denexter, pvuorela Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D25032: Read xlsx drawing dimensions from the xdr:ext element if available.

pvuorela added a comment. Seems sensical for what I can tell. I'll do some test round and (likely) approve later if no objections pop up. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25032 To: denexter, pvuorela Cc: Calligra-Devel-list, dcaliste, cochise, vandenoe

D25033: Extract images from excel files which omit the FtCF entry.

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Minor comment, but overall looks good to me. INLINE COMMENTS > excel.cpp:1421 > +if (ft2 == 0x0008) { > +Q_ASSERT(ft2 == 0x0008); Q_UNUSED(ft2); > +const

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

pvuorela added a comment. Is there something in the spec encoding the microsoft fonts or just some kind of practice? Seems a little scary just stripping bits. If the main issue is the whole string disappearing, those text.clear() calls below looks suspicious. Unicode string could contain

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

pvuorela added a reviewer: mkruisselbrink. pvuorela added a comment. But would those characters work without encoding adjustments if the used MS font was present? Not sure how it gets rendered now without the font, but if it's anything like the "J" exchange email smiley I'm not sure which is

D25031: Don't allow an unrecognized child element to block loading of a shape plugin.

pvuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25031 To: denexter, pvuorela Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25032: Read xlsx drawing dimensions from the xdr:ext element if available.

pvuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25032 To: denexter, pvuorela Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25036: Don't double format spreadsheet currency values with custom format strings.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:44e297458950: Don't double format spreadsheet currency values with custom format strings. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://pha

D25037: Don't drop number styling information from xlsx cell formats which start with a currency symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:d0b2c2f9afdf: Don't drop number styling information from xlsx cell formats which start with a… (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https:

D25031: Don't allow an unrecognized child element to block loading of a shape plugin.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:cec1e93bb7d5: Don't allow an unrecognized child element to block loading of a shape plugin. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://p

D25035: Fix incorrect conditional styling of spreadsheet cells.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:345f970a6deb: Fix incorrect conditional styling of spreadsheet cells. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D250

D25032: Read xlsx drawing dimensions from the xdr:ext element if available.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:66ea04a230d7: Read xlsx drawing dimensions from the xdr:ext element if available. (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.

D25033: Extract images from excel files which omit the FtCF entry.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:b253bef8dc85: Extract images from excel files which omit the FtCF entry. (authored by denexter, committed by pvuorela). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25033?vs=68943&id=69569#toc

D25285: Mark \shp and \shpinst as supported control words on rtf reader

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY The destination don't get specific handling at the moment, but might contain images etc. Suppose it's lesser bad t

D25285: Mark \shp and \shpinst as supported control words on rtf reader

pvuorela added reviewers: denexter, davidllewellynjones. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25285 To: pvuorela, denexter, davidllewellynjones Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25288: Fix build on newish gcc with qreal as float

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REPOSITORY R8 Calligra BRANCH fix_qreal_float REVISION DETAIL https://phabricator.kde.org/D25288 AFFECTED FILES libs/flake/K

D25288: Fix build on newish gcc with qreal as float

pvuorela added reviewers: leinir, denexter. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25288 To: pvuorela, leinir, denexter Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25285: Mark \shp and \shpinst as supported control words on rtf reader

This revision was automatically updated to reflect the committed changes. Closed by commit R8:845a1ffb3204: Mark \shp and \shpinst as supported control words on rtf reader (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25285?vs=69672&id=

D25288: Fix build on newish gcc with qreal as float

This revision was automatically updated to reflect the committed changes. Closed by commit R8:6f183e8ae93e: Fix build on newish gcc with qreal as float (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25288?vs=69679&id=69734 REVISION DETA

D25256: Allow non-conforming LibreOffice PPT files to be imported

pvuorela added a comment. Seems reasonable to me. Wonder what to do with that .jar. So phabricator didn't allow to be included in this PR? Manually include when merging? INLINE COMMENTS > simpleParser.h:2 > /* This code was generated by msoscheme (http://gitorious.org/msoscheme) */ > -

D25256: Relax TextPFRun validation to allow LibreOffice PPT import

pvuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH allow-libreoffice-ppt-validation (branched from master) REVISION DETAIL https://phabricator.kde.org/D25256 To: davidllewellynjones, pvuorela, dcaliste Cc: Calligra-Devel-list, d

D25256: Relax TextPFRun validation to allow LibreOffice PPT import

This revision was automatically updated to reflect the committed changes. Closed by commit R8:26c957c77e64: Relax TextPFRun validation to allow LibreOffice PPT import (authored by davidllewellynjones, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricato

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

pvuorela added a comment. A bit mixed feelings for this. In a way nice to avoid unnecessary work, but then again it seems effectively a compilation option if xlsx support is for read-write or view-only. On main level CMake it's also a bit random detail compared to others. Could be nice

D25541: Display figure brackets in plain text

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Or in other words: support for escaped brackets \{ \} REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25541 To: mphilippov, pvuorela, denexter, dcaliste, davidl

D25541: Display figure brackets in plain text

This revision was automatically updated to reflect the committed changes. Closed by commit R8:206fdf01eaac: Display figure brackets in plain text (authored by mphilippov, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25541?vs=70333&id=7

D25715: Use RTF default color as default Qt format

pvuorela created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. pvuorela requested review of this revision. REVISION SUMMARY RTF spec says a color entry without anything defined is a "default color", but doesn't specify more what that is.

D25715: Use RTF default color as default Qt format

pvuorela added reviewers: davidllewellynjones, dcaliste. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25715 To: pvuorela, davidllewellynjones, dcaliste Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25715: Use RTF default color as default Qt format

pvuorela added inline comments. INLINE COMMENTS > dcaliste wrote in ColorTableDestination.h:45 > I'm wondering, if we could use the invalid status of QColor as this flag ? > > See later… Should work, but I'm not sure would it be much better. Saves one boolean instance during loading a file, bu

D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

pvuorela added a reviewer: leinir. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25779 To: denexter, pvuorela, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

pvuorela added inline comments. INLINE COMMENTS > Document.cpp:57 > QString lastError; > +bool readOnly; > }; Looks like this is on top of Sailfish patched Calligra, upstream doesn't have lastError. Could otherwise resolve that conflict myself, but the arc tool doesn't seem to play a

D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Seems to work and big impact indeed. Approving already. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25779 To: denexter, pvuorela, leinir Cc: Calligra-Devel-

D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:bcda431ed438: Add a readOnly property to the QtQuick2 Document type which disables the… (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabri

D25715: Use RTF default color as default Qt format

pvuorela added inline comments. INLINE COMMENTS > davidllewellynjones wrote in ColorTableDestination.cpp:44 > It looks like there may be a distinction to be made between an empty control > word and an unhandled control word. In the case of an unhandled control word, > clearing the colour seems

D25715: Use RTF default color as default Qt format

pvuorela added inline comments. INLINE COMMENTS > pvuorela wrote in ColorTableDestination.cpp:44 > Empty control word? Don't think that should be happening? Or well, the code might return such, but think the file in that case is broken and as such ok to complain about on debug. Also a bit separ

D25715: Use RTF default color as default Qt format

This revision was automatically updated to reflect the committed changes. Closed by commit R8:959027525581: Use RTF default color as default Qt format (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25715?vs=70828&id=72487 REVISION DETAI

D24852: Remove list style from headings

pvuorela added a comment. Actually seems to now revert that one line as it was before commit fc7b878f206fb / https://bugs.kde.org/show_bug.cgi?id=306141 But the rationale sounds good to me, fixes the issue and no

D25423: Fill table cells with color for ODS and XLSX files

pvuorela added a comment. Not sure about all the details but two things look suspicious here: 1. Above this there's handling for transparent and now the handling isn't symmetric for background brush. 2. There's some handling on the file for KoXmlNs::draw / style-name & KoXmlNs::calligr

D25422: Handle custom-shapes to display text in ODP files

pvuorela added a comment. Don't know this shape stuff that well, but text shape plugin handling custom-shape feels suspicious. INLINE COMMENTS > TextShape.cpp:368 > +answer = loadOdfFrameElement(element, context); > +} > m_textShapeData->document()->setUndoRedoEnabled(true);

D25423: Fill table cells with color for ODS and XLSX files

pvuorela added a comment. > loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned. I'm talking about handling in that particular method. It will already set background brush in

D25423: Fill table cells with color for ODS and XLSX files

pvuorela added a comment. > Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what? The main question was how should the three attributes play together. But another qu

D27694: Don't recreate ImageDataItem texture unless needed

pvuorela accepted this revision. pvuorela added a comment. Looking good. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D27694 To: davidllewellynjones, #calligra:_3.0, leinir, danders, pvuorela Cc: pvuorela, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb,

D27694: Don't recreate ImageDataItem texture unless needed

This revision was automatically updated to reflect the committed changes. Closed by commit R8:5a5f98658e7f: Don't recreate ImageDataItem texture unless needed (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27694?vs=76520&id=76544 REVISI