pvuorela added inline comments. INLINE COMMENTS
> davidllewellynjones wrote in DocumentDestination.cpp:125 > A minor issue, but the spacing around the brackets here doesn't match the > surrounding code. Sure. > davidllewellynjones wrote in PictDestination.cpp:46 > The spec mentions `\wbitmap` is also a Windows device-dependent bitmap. Could > that be sent through this branch too? > > (see: http://latex2rtf.sourceforge.net/rtfspec_7.html#rtfspec_24) I'd maybe add new keywords in separate commits later based on needs. > davidllewellynjones wrote in PictDestination.cpp:54 > The `\picw` and `\pich` keywords are now ignored; is this intentional? It > looks like they're mandatory, whereas the `\picwgoal`, `\pichgoal`, > `\picscalex` and `\picscaley` which seem to be used now instead, are optional. > > (see: http://latex2rtf.sourceforge.net/rtfspec_7.html#rtfspec_24) Was Andrew's part, but I think file itself should contain the geometry and goals are handled here as optional, i.e. if not set will be read from the file. > davidllewellynjones wrote in PictDestination.cpp:110 > Lines 87-110 seem to use different spacing around the brackets than elsewhere. Yea, could change these too. Though have been pondering of just feeding the whole rtf-qt through astyle to get consistent formatting and whitespace. > davidllewellynjones wrote in TextDocumentRtfOutput.cpp:68 > The tabs/spaces are all over the place in this file already, but it probably > makes sense to stick to one or the other nevertheless (spaces by the looks of > it). Yea, the whole module here is a mess regarding whitespace. Now using the same formatting as surrounding code. REPOSITORY R8 Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D24943 To: pvuorela, davidllewellynjones Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever
