Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129512/#review101106 --- Ship it! Ship It! - Dag Andersen On Nov. 21, 2016, 4

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

ix: > https://cgit.kde.org/calligra.git/commit/?id=a8fd10d8b0a24e581eeb4754b458ba98ddbf0167) > > René J.V. Bertin wrote: > Sheets works nicely too! > > Anthony Fieroni wrote: > I response for only Karbon, wait for Camilla and Dag Andersen. > > René J.V. Berti

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

ix: > https://cgit.kde.org/calligra.git/commit/?id=a8fd10d8b0a24e581eeb4754b458ba98ddbf0167) > > René J.V. Bertin wrote: > Sheets works nicely too! > > Anthony Fieroni wrote: > I response for only Karbon, wait for Camilla and Dag Andersen. > > René J.V. Berti

D8310: Port Calligra Gemini for 3.x

danders added a comment. I'm clueless on qtquick, but unless somebody else has comments I'd say ship it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D8310 To: leinir, Calligra-Devel-list Cc: danders, vandenoever

D8310: Port Calligra Gemini for 3.x

danders added a comment. Dan Leinir Turthra Jensen skrev den 2017-10-30 12:06: I hope ppl have just taken an extended summer vacation ;) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D8310 To: leinir, Calligra-Devel-list Cc: danders, vandenoever

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

danders added a comment. The background was it failed for one case in Plan, and I found a possible failure in KoMainWindow (I think it was), but that was a "if all else fails" case and I doubt the code will ever be executed. Also, I have seen that not all places uses KoResourcePaths so a ca

D9253: Make Plan build on Windows

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Surprised it was *that* easy... REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9253 To: leinir, #calligra:_3.0, danders Cc: Calligra-Devel-list, cochise, vandeno

D11505: Plan: fix build with Qt 5.6

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Hmm, it should have been i18n'ed also. I'll fix that later, just land it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11505 To: wbauer, danders Cc: Calligra-D

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

danders added a comment. Yeah :) Seems a unit test needs adjustments, could you have a look? https://build.kde.org/view/Calligra/job/Calligra%20calligra%20kf5-qt5%20FreeBSDQt5.10/lastCompletedBuild/testReport/(root)/TestSuite/libs_kotextlayout_TestBlockLayout/ REPOSITORY R8 Calligra RE

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY There is a couple of failing tests now marked as XFAIL. I am afrai

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

danders marked an inline comment as done. danders added a comment. What to change depends on what the number means ;) Well in general all numbers that depends on fontsize should be changed, the rest should stay the same, but yes it is a puzzle. REPOSITORY R8 Calligra REVISION DETAIL ht

D14916: [ArtisticTextShape] Merge text ranges with same style

danders added a comment. The change in appendText(const QString &text): The original appended to an existing range while you add a new range. I would think you could just leave the old code untouched, no? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To:

D14916: [ArtisticTextShape] Merge text ranges with same style

danders added a comment. Hmm, I assumed it only got in here when appending a text to a) an empty shape (no need for merging), b) at the end of an existing text, in which case using the the existing formatting of the last range should ok. I just can't see why using a defaultfont in this ca

D14916: [ArtisticTextShape] Merge text ranges with same style

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

danders added a comment. I'm not 100% sure of stackChanged() change. Probably ok, but the original would call both begin and end before calling the selection model. To get exactly the same behaviour you could do the same. It depends on how the selction model handles reset and setCurrentI

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

danders accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D14975 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15056: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Haven't tested, but sounds sane :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15056 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-l

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

danders added a reviewer: leinir. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15102 To: dcaliste, #calligra:_3.0, leinir Cc: Calligra-Devel-list, cochise, vandenoever

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

danders added a comment. Ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14901 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, cochise, vandenoever

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

This revision was automatically updated to reflect the committed changes. Closed by commit R8:705d0ae50923: Fix blocklayout unittest after percentage lineheight was fixed in D9537 (authored by danders). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14901?vs=39919&id=40803#toc REPOSITORY

D15403: {Style] Default sheets to white background

danders added a comment. Hmm, imo styling odf apps content area should be considdered a bug :=) Because: All info pertaining to presentation of content is stored in odf file and is controllable by user, so styling it would often create strange resullts. (And it would not be much wysiwyg ab

D15403: {Style] Default sheets to white background

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15412: [filters] Extend table lifetime

danders added a comment. Sorry, don't have any qualified opinons, I don't quite understand the original code either, so... Imo if you think it is good, land it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3

D15549: Words: Save anchor info also for page-anchored shapes

danders created this revision. danders added a reviewer: boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY LO needs anchor info to position shapes correctly. REPOSITORY R8 Calligra BRANC

D15549: Words: Save anchor info also for page-anchored shapes

danders added a comment. After reading the fine print, see: http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1420028_253892949 it seems to me a shape can be anchored to a page in different ways. Note this: "If the attribute value is not from-left and

D15567: Words: Do not popup contextmenu twice

danders created this revision. danders added a reviewer: boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Popup menu was called from mousePressEvent. No need as it is handled in contextMe

D15549: Words: Save anchor info also for page-anchored shapes

This revision was automatically updated to reflect the committed changes. Closed by commit R8:02f34b05723a: Words: Save anchor info also for page-anchored shapes (authored by danders). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15549?vs=41737&id=41811#toc REPOSITORY R8 Calligra CH

D15622: Upgrade intersect() to intersected() calls

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15622 To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15620 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15619: Remove use of kglobal.h in sheets

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15619 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15567: Words: Do not popup contextmenu twice

This revision was automatically updated to reflect the committed changes. Closed by commit R8:7bd9b921826e: Words: Do not popup contextmenu twice (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15567?vs=41797&id=42052 REVISION DETAIL ht

D15775: Make the item background color and page cache properties available from View component

danders added inline comments. INLINE COMMENTS > View.h:118 > + */ > +bool pageCache() const; > +/** Could you rename pageCache() to pageCacheEnabled() and d:o setPageChache() REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, dande

D15053: Consistently use qreal in libs/pigment

danders accepted this revision as: danders. danders added a comment. This revision is now accepted and ready to land. Fine with me. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calligr

D16127: Annotation: Block adding comment to an annotation shape

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY To reproduce crash: 1. Add a text shape 2. Add an annotation

D16127: Annotation: Block adding comment to an annotation shape

danders marked an inline comment as done. danders added a comment. No, it should not be possible to activate a tool without a shape. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise,

D16127: Annotation: Block adding comment to an annotation shape

danders updated this revision to Diff 43721. danders added a comment. - DefaultTool: Do not considder parent flags when checking Move-/ResizeAllowd - DefaultTool: MoveStrategy: Check if shape is movable - DefaultTool: ResizeStrategy: Check if shape is resizeable - DefaultTool: ShareStrate

D16127: Annotation: Block adding comment to an annotation shape

danders added a comment. Arghh, accidentally propt a new diff on top of this, howto undo this? (arc is fine, but do not do anything wrong) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, c

D16127: Annotation: Block adding comment to an annotation shape

danders abandoned this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16127: Annotation: Block adding comment to an annotation shape

danders updated this revision to Diff 43724. danders added a comment. - If no textshape is editied, select the first found text shape REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16127?vs=43721&id=43724 BRANCH danders_annotation_crash REVISION DETAIL

D16127: Annotation: Block adding comment to an annotation shape

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:d4744090e8c6: Annotation: Block adding comment to an annotation shape (authored by danders). REPOSITORY R8 Calligra C

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REPOSITORY R8 Calligra BRANCH karbon_danders REVISION DETAIL https://phabricator.kde.or

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

This revision was automatically updated to reflect the committed changes. Closed by commit R8:99527b565f59: Karbon: Add Anthony as maintainer and remove unmaintained (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16289?vs=43840&id=43844

D16367: EnhancedPathShape: Shape is moved/resized on save/load

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Remove all code that uses viewbox to affect position and size.

D16367: EnhancedPathShape: Shape is moved/resized on save/load

danders added a comment. I have tested with LO: Create with flow, Open in LO, Save in LO, Open in flow. And it seems to work, so there must be some special case? The only workaround I've seen is for ellipses. No chance for a testdoc I guess... REPOSITORY R8 Calligra REVISION D

D16367: EnhancedPathShape: Shape is moved/resized on save/load

danders added a comment. Yes, found it: https://bugs.kde.org/show_bug.cgi?id=289646 Afaics this affects only callout shapes where OO/LO breaks the intention of the odf spec by using the shape size and position as text area. This is ok (sort of) when text area and shape area overlap but n

D16367: EnhancedPathShape: Shape is moved/resized on save/load

danders abandoned this revision. danders added a comment. Ok, after some more investigation, I've found a number of problems around these things. This was really just a bug in the stencil database.odg file. The callout stuff is the big one, because it abuses odf so needs special treatment

D16679: Words: Fix interop problem with LO/OO

danders created this revision. danders added a reviewer: boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Words creates pagestyles with name "Standard" and displayname "Default". Afaics t

D16679: Words: Fix interop problem with LO/OO

This revision was automatically updated to reflect the committed changes. Closed by commit R8:caffa566d8d2: Words: Fix interop problem with LO/OO (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16679?vs=44892&id=44896 REVISION DETAIL ht

D16756: CalloutShape: Add a new shape to handle callouts

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY This is the start of a dedicated callout shape. It uses draw:type

D16756: CalloutShape: Add a new shape to handle callouts

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:2e1aaae999f3: CalloutShape: Add a new shape to handle callouts (authored by danders). REPOSITORY R8 Calligra CHANGES

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Would it be possible to make a unit test? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Had a closer look at this. Afaics we get an infinit loop when a table is 'totally misfit', Can't say I understand the table layout logic, but my assumption is that if a row is a total misfit it can't just be ignored, so breaking off the row layout loop in this cas

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Ok, think I'm on to something. Testing with the 1.doc in bug 381341. It seems it fails on the table in approx page 222 (open in LO) with text in 0,0: Экономический субъект Stepping through the KoTextLayoutTableArea::layoutRow(), it seems *all* columns in row 0 (

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. I ended up in the same spot as you: Since all columns in row 0 spans rows, totalMisFit will always be set to true and the whole table is layed out on next page, and next page again and again ... I'm not 100% certain just adding noCellsFitted to the condition cov

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378420 , @anthonyfieroni wrote: > Yep, it's look like same approach to mine, did you try mine or it's not correct in all cases? Mine tries to take into account the case where the first row after header

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378422 , @boemann wrote: > Dan I like your diff better - I don't think it's completely there but it's a better starting point > > On a more conceptual level, what should happen if the design of table is suc

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. In D15428#378432 , @boemann wrote: > No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words Ahhh. It's a guard against loop/crash in extreme

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Fidled a little more with this, and found several problems when table with merged cells is split over pages, like unmerged cell painted on both pages (empty on first page), caret not shown in selected cell and sometimes shown in prev cell. Tried to recreate pro

D18095: Add new table layout unit tests

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds multiple areas capabilities and tests with merged cells REPOSI

D18095: Add new table layout unit tests

danders added a comment. Not trivial (for me) to get data out of layout so it is hard to create robust tests. I don't think I have been able to create a test to simulate the loop excactly. Also, uncertain wether the MockRootAreaProvider is sufficient. Any ideas/comments wellcome. REPOSI

D18095: Add new table layout unit tests

danders added a comment. No, all do not pass, generally when the first row is merged, layout fails. (I am trying to provoke problems similar to bug 381341 that we have tried to fix in D15428 .) REPOSITORY R8 Calligra REVISION DETAIL https://phabricat

D18095: Add new table layout unit tests

danders updated this revision to Diff 49141. danders added a comment. Add a test that trigger a loop in the table layout REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18095?vs=48957&id=49141 BRANCH table_unittest_danders REVISION DETAIL https://phabri

D18095: Add new table layout unit tests

danders added a comment. Even if they do not all pass, I think they should be commited if the tests/methods are ok and the reason for not passing are genuin bugs, no? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Calli

D18095: Add new table layout unit tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:666ae5b484cc: Add new table layout unit tests (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Ran this patch against new unit tests and it fixes all the expected ones, namely those where all cells in first row is merged with cells in second row. Test results without patch: https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5.10/lastCompleted

D18448: Replaced "distraction free" with "fullscreen" - BUG:378527

danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18448 To: niccolove, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

danders added a comment. I think the problem is that slotFilePrint() is called (in KoApplication::start()) before the document is actually loaded. Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead. And to be safe, we also need to handle loadCa

D18466: Fixed calligra crashing when opening remote document

danders added a comment. In D18466#400507 , @niccolove wrote: > I'm not sure on how to do that, do you have any tip? > openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When i

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Well, unit tests has been added that fails without this patch and passes with this patch. If there are more test cases needed, please add them so that we can get this patch committed soon... REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D1

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Regarding the completed slot, the doc says: --print Only print and exit --export-pdf Only export to PDF and exit To exit, you need to know when all jobs have finished, so if some failed you need to track that. Also, the

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Yeah, well there are some half done designs in here :( The benchmark just does not work with remote files. Don't know if it should or if it should be blocked. Let's leave it for now. If you do not specify a pdf filename, it will use the same name as in the l

D18466: Fixed calligra crashing when opening remote document

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Yes, close. When export to pdf, the mainwindow is not shown and since we don't exit, the app will hang. You need to invert the check in KoApplication line 460 so the window is shown.

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Ok, it's accepted so please commit/push/land REPOSITORY R8 Calligra BRANCH print-remote-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D18466 To: niccolove, danders Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise,

D18841: StencilBoxDocker: Make the docker collapsed by default

danders created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY WIP REPOSITORY R8 Calligra BRANCH activate_stencils_danders REVISION DETAIL https://phabricator.kde.org/D1884

D18841: StencilBoxDocker: Make the docker collapsed by default

danders abandoned this revision. danders added a comment. mistake REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18841 To: danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18843: Activate stencils docker in all apps

danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY The docker now loads in separate thread and is hidden by default,

D18866: Use check_symbol_exists instead of check_function_exists

danders added a comment. What about the other ​check_function_exists, should they also be changed? Also, do you know when ​check_symbol_exists was introduced? We still use cmake 2.8.12. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker Cc: dand

D18866: Use check_symbol_exists instead of check_function_exists

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker, danders Cc: pino, danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

danders added a comment. In D18466#411248 , @boemann wrote: > Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email Yes, I have, and just answered again in case something went wrong f

D18963: Improve KoModeBox display in horizontal Mode

danders added a comment. Please remove trailing whitespace. REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, co

D18843: Activate stencils docker in all apps

This revision was automatically updated to reflect the committed changes. Closed by commit R8:d11e63457aab: Activate stencils docker in all apps (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18843?vs=51158&id=51575 REVISION DETAIL htt

D18466: Fixed calligra crashing when opening remote document

danders added a comment. Thanks, I'm checking it out now... Just a couple of things: Keywords needs to be on a separate line to have effect, see https://community.kde.org/Infrastructure/Git/Hooks Also FIXED-IN is nice to add. I've updated and closed the bug, so no problem. REPOSITO

D19132: Update libs/widgets to c++11

danders added a reviewer: leinir. danders added a comment. Hmmm. wasn't it somethng with ms windows and for loops, leinir? Also, I think there may be detachment issues with them, clazy can tell. There is a qAsConst() solution but that is not supported in the qt version we need to support.

D19132: Update libs/widgets to c++11

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Ok, I can't say I have scrutinized every change, but... Could you give a heads up when you continue with other parts or else there may be merge problems. I'm working on karbon and page

D19132: Update libs/widgets to c++11

danders added a comment. > Thanks for the review, I will work next on libs/{pigment,version,widgetutils}. Hmm, maybe wait with pigment, according to rempt, only krita actually used it. I haven't looked into it, but if that is the case probably we should dump it. REPOSITORY R8 Calligr

D19216: Karbon: Enable multi page capability

danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support

D19216: Karbon: Enable multi page capability

danders added a comment. In D19216#417288 , @rjvbb wrote: > This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would jus

D19216: Karbon: Enable multi page capability

danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > I want to discuss comments in the review, i don't want to have in. why we > remove this? Recent file & docker font: Why does karbon need these, none of the other apps have it. Personal

D19216: Karbon: Enable multi page capability

danders added a comment. In D19216#417502 , @rjvbb wrote: > > Canvas color: > > I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed. > > A custom canvas colour feat

D19216: Karbon: Enable multi page capability

danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > We can remove "number of recent files" since other apps does not have it. but > for other 2 i don't see why we remove them, someone can found useful > (somehow). About me, i want them

D19216: Karbon: Enable multi page capability

danders marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: danders, anthonyfieroni Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

danders added a comment. Can we get a conclussion to this? @Camilla Have you come up with any more unit tests? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vand

D19327: Karbon: Enable multi page capability

danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. Ported to use pageapp classes. K

D19216: Karbon: Enable multi page capability

danders added a comment. In D19216#421689 , @rjvbb wrote: > > That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown. > > Heh, I've had the opportunity to work closely with professional infograp

D19761: Remove obsolete syncX() workaround

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19761 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19760: Support Qt <5.7 on KoShape flag usage

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19760 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19759: Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets

danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19759 To: pvuorela, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19885: Implement logging category for excel plugins

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19885 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

danders added inline comments. INLINE COMMENTS > dcaliste wrote in TextDocumentStructureModel.cpp:308 > I did the same changes in https://phabricator.kde.org/D15102 at another place > and I put the begin and end at the start and end of the routine, like you > did. But I remember that I got revi

D19912: Implement logging category for rtf-qt

danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Strange indents, could you fix it? Otherwise ok. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19912 To: pvuorela, danders Cc: danders, Calligra-Devel-list, d

  1   2   3   >