danders added inline comments.

INLINE COMMENTS

> dcaliste wrote in TextDocumentStructureModel.cpp:308
> I did the same changes in https://phabricator.kde.org/D15102 at another place 
> and I put the begin and end at the start and end of the routine, like you 
> did. But I remember that I got review asking not to risk to change signal 
> order emission, in case, and put the begin/end just around the m_textDocument 
> assignment.
> 
> I'm not completely sure that I remember correctly and I cannot find it in 
> Phabricator anymore...

Hmmm, cannot find the diff either, but I *think* it was about an emit, wasn' it?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19884

To: pvuorela
Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandenoever

Reply via email to