Re: Review Request 114890: Fix calculation of the shape's insets when it has Miter joining

2014-01-06 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114890/#review46933 --- Ship it! Ship It! - Camilla Boemann On Jan. 6, 2014, 9:01

Re: Review Request 115352: Fix the Stroke and Shape Id of the Pencil Tool

2014-01-28 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115352/#review48464 --- Ship it! Ship It! - Camilla Boemann On Jan. 28, 2014, 1

Re: Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

2014-05-21 Thread Camilla Boemann
rther improvement. That said i'll say ship it but please check that text input widget (like font selector in text tool) still works - Camilla Boemann On May 20, 2014, 11:42 p.m., Marijn Kruisselbrink wrote: > > --- > This is an automa

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-04 Thread Camilla Boemann
sections surely don't belong in production code But all in all you show a nice understanding of how everything works but no ok just yet libs/kotext/KoSection.h <https://git.reviewboard.kde.org/r/118532/#comment41242> we normally don't use getXxx() for getter but just xxx() - Ca

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-04 Thread Camilla Boemann
rg/r/118532/#comment41256> == PasteMode - Camilla Boemann On June 4, 2014, 7:51 p.m., Denis Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

2016-01-18 Thread boemann (Camilla Boemann)
boemann added a subscriber: boemann. boemann added a comment. I fully support this - but I was tol long ago that it actually isn't so easy to do as it will depend on where things are installed or so - but perhabs now that we use json it has become easier. One thing tohugh - it shouldn't be an e

[Differential] [Accepted] D2058: Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages

2016-07-01 Thread boemann (Camilla Boemann)
boemann accepted this revision. boemann added a reviewer: boemann. boemann added a comment. This revision is now accepted and ready to land. Was my idea on how to fix too so i agree REPOSITORY rCALLIGRA Calligra BRANCH fixTestXmlReaderTestingTranslatedErrorMessages REVISION DETAIL http

[Differential] [Accepted] D128: Restore loading of defaultstyles.xml

2015-06-28 Thread boemann (Camilla Boemann)
boemann added a subscriber: boemann. boemann accepted this revision. boemann added a reviewer: boemann. boemann added a comment. it looks okay to me too REPOSITORY rCALLIGRA Calligra BRANCH fixFindingDefaultStylesXml REVISION DETAIL https://phabricator.kde.org/D128 EMAIL PREFERENCES h

[Differential] [Accepted] D269: Replace KoToolButton with KoToolAction

2015-08-26 Thread boemann (Camilla Boemann)
boemann accepted this revision. REPOSITORY rCALLIGRA Calligra BRANCH improveToolBoxes REVISION DETAIL https://phabricator.kde.org/D269 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, abrahams, rempt, boemann Cc: Calligra-Devel-list _

<    1   2   3