----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118232/#review58220 -----------------------------------------------------------
Ship it! I think it's safe enough to commit this, however in the text tool every botton emits an i_am_done signal which we use to return focus to the canvas. Some widgets will keep the focus (and we would want them to be navigatable by keyboard for accessability) and without this signal it wont work just some inspiration for testing and further improvement. That said i'll say ship it but please check that text input widget (like font selector in text tool) still works - Camilla Boemann On May 20, 2014, 11:42 p.m., Marijn Kruisselbrink wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118232/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 11:42 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Currently everytime you click a button to change formatting of a cell in > sheets the scrollarea gets keyboard focus, making further editing very > annoying. This fixes that behavior. > I'm not sure if any other code/UI depends on this scroll area being focusable > though? > (two years ago I made the same change in > 5e2cc2ee27a50806b0c2eb16724ad704a6450d9f for KoToolDocker) > > > Diffs > ----- > > libs/main/KoModeBox.cpp 91f71e2 > > Diff: https://git.reviewboard.kde.org/r/118232/diff/ > > > Testing > ------- > > > Thanks, > > Marijn Kruisselbrink > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
