Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7

/KoDockWidgetTitleBar.cpp 4d0d1aa plugins/textshape/dialogs/StylesCombo.cpp 9ca044b plugins/textshape/dialogs/StylesDelegate.cpp faa90fb Diff: https://git.reviewboard.kde.org/r/129420/diff/ Testing --- Build with Karbon. Thanks, Anthony Fieroni

Re: Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7

marked as submitted. Review request for Calligra and Friedrich W. H. Kossebau. Changes --- Submitted with commit 821f1048d5ff74d996dbb7cdcfca5405f5ab5b57 by Anthony Fieroni to branch master. Repository: calligra Description --- ^^ Diffs - braindump/plugins/stateshape

Review Request 129421: [karbon] Returning of Karbon as maintained product

cmake 965e9d8 karbon/CMakeLists.txt ba775ad karbon/main.cpp 2fa3f4d karbon/ui/KarbonAboutData.h aa96ee1 Diff: https://git.reviewboard.kde.org/r/129421/diff/ Testing --- Builds. Thanks, Anthony Fieroni

Review Request 129435: [shapefiltereffects] Update ConvolveMatrixEffect kernel accordingly to order

://git.reviewboard.kde.org/r/129435/diff/ Testing --- Build and run with Karbon Thanks, Anthony Fieroni

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

mail. To reply, visit: https://git.reviewboard.kde.org/r/129421/#review100920 ----------- On Ноев. 17, 2016, 10:09 след обяд, Anthony Fieroni wrote: > > --- > This is an autom

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

bugs. Diffs (updated) - CalligraProducts.cmake 965e9d8 Diff: https://git.reviewboard.kde.org/r/129421/diff/ Testing --- Builds. Thanks, Anthony Fieroni

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

emphazise it would be really great to see you work on karbon - > > it deserves to come to full glory! > > Anthony Fieroni wrote: > So you want to return warn message on non-Release builds? > > Camilla Boemann wrote: > I'm sorry I don't understand what you me

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

emphazise it would be really great to see you work on karbon - > > it deserves to come to full glory! > > Anthony Fieroni wrote: > So you want to return warn message on non-Release builds? > > Camilla Boemann wrote: > I'm sorry I don't understand what you me

Re: Review Request 129435: [shapefiltereffects] Update ConvolveMatrixEffect kernel accordingly to order

marked as submitted. Review request for Calligra, Camilla Boemann, Friedrich W. H. Kossebau, and Yue Liu. Changes --- Submitted with commit 9d8146e05b96ba8245816a06e087f1cc88af2a2e by Anthony Fieroni to branch master. Bugs: 353816 http://bugs.kde.org/show_bug.cgi?id=353816

Review Request 129437: [widgets] Make sure destination xml file path exist

run with Karbon. Thanks, Anthony Fieroni

Review Request 129438: [karbon] Correct usage of KPageDialog in KarbonConfigureDialog.cpp

Description --- Now config dialog saves changes correct, it's a porting script bug Diffs - karbon/ui/dialogs/KarbonConfigureDialog.cpp 0ba166d Diff: https://git.reviewboard.kde.org/r/129438/diff/ Testing --- Build and run with Karbon. Thanks, Anthony Fieroni

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

emphazise it would be really great to see you work on karbon - > > it deserves to come to full glory! > > Anthony Fieroni wrote: > So you want to return warn message on non-Release builds? > > Camilla Boemann wrote: > I'm sorry I don't understand what you me

Re: Review Request 129438: [karbon] Correct usage of KPageDialog in KarbonConfigureDialog.cpp

marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 64c64378f1eb2cfaf6ba51c18387af099583396d by Anthony Fieroni to branch master. Repository: calligra Description --- Now config dialog saves changes correct, it's a porting s

Re: Review Request 129437: [widgets] Make sure destination xml file path exist

marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 6657dac8e5f14e89586790e2f51a5c858432b05b by Anthony Fieroni to branch master. Repository: calligra Description --- Otherwise it shown warning message ""Cannot

Review Request 129512: [stencil] Follow system color for stencilsdocker icons

://git.reviewboard.kde.org/media/uploaded/files/2016/11/20/b96331ae-db38-455f-a715-50101c30a3d0__Screenshot_20161120_213613.png Thanks, Anthony Fieroni

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

-a082-9c5e3e072999__Screenshot_20161120_213518.png Black theme https://git.reviewboard.kde.org/media/uploaded/files/2016/11/20/b96331ae-db38-455f-a715-50101c30a3d0__Screenshot_20161120_213613.png Thanks, Anthony Fieroni

Review Request 129514: [connectionTool] Check dynamic_cast return type

iff: https://git.reviewboard.kde.org/r/129514/diff/ Testing --- PS: I manage to work on 2 wishlist, Px (pixels) if can be enabled from settings (i still don't know why it's disabled) and export arrow line in SVG. Other bus looks really outdated. Thanks, Anthony Fieroni

Review Request 129531: [flake] Serialize / deserialize svg canonicalGradient

Description --- Enable write / parse canonicalGradient Diffs - libs/flake/svg/SvgParser.cpp 943c448 libs/flake/svg/SvgStyleWriter.cpp b949dd5 Diff: https://git.reviewboard.kde.org/r/129531/diff/ Testing --- Build and run with Karbon Thanks, Anthony Fieroni

Re: Review Request 129531: [flake] Serialize / deserialize svg canonicalGradient

/ Testing --- Build and run with Karbon Thanks, Anthony Fieroni

Review Request 129532: [shortcuts] Undo / Redo shortkeys

/ Testing --- Build and run with Karbon Thanks, Anthony Fieroni

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

libs/main/KoMainWindow.cpp 828d789 libs/main/KoView.cpp f3b6fd9 Diff: https://git.reviewboard.kde.org/r/129532/diff/ Testing --- Build and run with Karbon Thanks, Anthony Fieroni

Re: Review Request 129531: [flake] Serialize / deserialize svg conicalGradient

libs/flake/svg/SvgStyleWriter.cpp b949dd5 Diff: https://git.reviewboard.kde.org/r/129531/diff/ Testing --- Build and run with Karbon Thanks, Anthony Fieroni

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 4fb2711afc1125efdcc009d9e20ca05a4405b735 by Anthony Fieroni to branch master. Repository: calligra Description --- + fullscreen action provide warning on runtime &quo

Re: Review Request 129531: [flake] Serialize / deserialize svg conicalGradient

marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 823fed356b2ca0052428a5aa98240f318e586268 by Anthony Fieroni to branch master. Repository: calligra Description --- Enable write / parse conicalGradient Diffs - libs

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129512/#review101102 --- Ping, is it has a problem? - Anthony Fieroni On Ноев. 21

Re: Review Request 129514: [connectionTool] Check dynamic_cast return type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129514/#review101103 --- This can go, just in any case, no? - Anthony Fieroni On

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit d5c8f3d4690f4e7223b11442bf1e4ef3b1f0d10a by Anthony Fieroni to branch master. Repository: calligra Description --- Still has icons who are drown incorrect, i blame factory, but

Re: Review Request 129514: [connectionTool] Check dynamic_cast return type

marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit f3f26b78c7b792e9f5de480d2fd00c98a48d8ba2 by Anthony Fieroni to branch master. Bugs: 326258 http://bugs.kde.org/show_bug.cgi?id=326258 Repository: calligra Description

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

ector graphics software but i will try to help and fixing bugs. Diffs - CalligraProducts.cmake 965e9d8 Diff: https://git.reviewboard.kde.org/r/129421/diff/ Testing --- Builds. Thanks, Anthony Fieroni

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

tps://git.reviewboard.kde.org/r/129800/#comment68176> Correct is #elif http://en.cppreference.com/w/cpp/preprocessor - Anthony Fieroni On Ян. 10, 2017, 6:34 след обяд, René J.V. Bertin wrote: > > --- > This is an automatically g

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

s are they worked as well as Karbon? - Anthony Fieroni On Ян. 10, 2017, 6:34 след обяд, René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Windows too)

tps://git.reviewboard.kde.org/r/129804/#comment68188> Why only for Apple, it's needed some other changes ? - Anthony Fieroni On Jan. 11, 2017, 5:30 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

> On Ян. 10, 2017, 10:28 след обяд, Anthony Fieroni wrote: > > So when Karbon works, i'm +1, please try words / sheets are they worked as > > well as Karbon? > > René J.V. Bertin wrote: > I cannot tell yet, but I'm not expecting any issues because of thi

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

anthonyfieroni added a comment. This revision now requires changes to proceed. This review is more than an years old, is it still related? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D2577 To: danders, #calligra:_3.0, staniek, Calligra-Devel-list Cc: anthonyfieroni

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. Restricted Application added a subscriber: Calligra-Devel-list. Ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. I investigate couple of days, last year, in rendering and i think problem isn't there. So probably table, but i don't get suspicious code, so text layout can be. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni,

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. Test documents -> https://europass.cedefop.europa.eu/documents/curriculum-vitae/templates-instructions REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, v

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni updated this revision to Diff 35423. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9537?vs=24438&id=35423 REVISION DETAIL https://phabricator.kde.org/D9537 AFFECTED FILES libs/textlayout/KoTextLayoutArea.cpp To: anthonyfieroni, danders, me

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. In D9537#270932 , @boemann wrote: > And finally the code you already wrote can be simplyfied by by not having an else but always multiplying You mean to not percentage and multiply always 1.16? REPOSITORY

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. I don't understand what you mean. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. Ping, let put in this fix, what should be done? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. This -> https://phabricator.kde.org/source/calligra/browse/master/plugins/textshape/dialogs/ParagraphIndentSpacing.cpp$124-132 ? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Call

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni updated this revision to Diff 38205. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9537?vs=35423&id=38205 REVISION DETAIL https://phabricator.kde.org/D9537 AFFECTED FILES libs/textlayout/KoTextLayoutArea.cpp plugins/textshape/dialogs/Para

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni updated this revision to Diff 38209. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9537?vs=38205&id=38209 REVISION DETAIL https://phabricator.kde.org/D9537 AFFECTED FILES libs/textlayout/KoTextLayoutArea.cpp plugins/textshape/dialogs/Para

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni closed this revision. anthonyfieroni added a comment. https://cgit.kde.org/calligra.git/commit/?id=805df22766026fac22154ae89b64dad532a6cbb4 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-De

D11971: Use same keyword separator for read and write

anthonyfieroni added a comment. Restricted Application added a subscriber: Calligra-Devel-list. It looks good +1 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11971 To: michaelh, #calligra:_3.0, leinir, danders Cc: Calligra-Devel-list, anthonyfieroni, cochise, vande

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. Values like 14.4, 28.8, 28.0-12.0, should be correct, how are they results? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9537 To: anthonyfieroni, danders, mecir, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

anthonyfieroni added a comment. In D9537#300367 , @boemann wrote: > given that we no multiply with1.16 the values should be: 12*1.16, 24*1.16, no It looks like - no > Actual (blockLayout->lineAt(1).y()): 120.875 > Expected (0.0

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

anthonyfieroni added a comment. Thanks, i really don't know how to change predefined values like 28.0 etc. i see you changed them i still not clear to me what are the new vales :) INLINE COMMENTS > TestBlockLayout.cpp:497 > int lastLineNum = block1Layout->lineCount() - 1; > -const q

D14916: [ArtisticTextShape] Merge text ranges with same style

anthonyfieroni created this revision. anthonyfieroni added reviewers: boemann, danders, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabri

D14916: [ArtisticTextShape] Merge text ranges with same style

anthonyfieroni added a comment. Basically we want to be unchanged, but when it merged, now, it does not have guaranteed that appending to last will be nor same behavior nor correct. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To: anthonyfieroni, boemann, da

D14916: [ArtisticTextShape] Merge text ranges with same style

anthonyfieroni added a comment. You are right, when i see docs > /// Appends plain text to the last text range > void appendText(const QString &plainText); REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To: anthonyfieroni, boemann, danders, #calligra:_3

D14916: [ArtisticTextShape] Merge text ranges with same style

anthonyfieroni updated this revision to Diff 40031. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14916?vs=39955&id=40031 REVISION DETAIL https://phabricator.kde.org/D14916 AFFECTED FILES plugins/artistictextshape/ArtisticTextShape.cpp To: anthonyfieroni

D14916: [ArtisticTextShape] Merge text ranges with same style

This revision was automatically updated to reflect the committed changes. Closed by commit R8:f5a88ba9040e: [ArtisticTextShape] Merge text ranges with same style (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14916?vs=40031&id=4014

D14975: Don't use obsolete QRectF functions

anthonyfieroni added a comment. You can make them at once, if there is no functionality changes. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14975 To: dcaliste, leinir Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF functions

anthonyfieroni added reviewers: danders, Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14975 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a comment. You use it on Pinebook or similar ARM based laptop? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a comment. I'm OK with the patch, can you try Karbon as well? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15056: [EnhancedPathShape] Keep correct aspect ratio of odf files

anthonyfieroni created this revision. anthonyfieroni added reviewers: Calligra: 3.0, danders, boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY View bound has same aspect ratio as con

D15056: [EnhancedPathShape] Keep correct aspect ratio of odf files

anthonyfieroni updated this revision to Diff 40363. anthonyfieroni added a comment. Fix wrong diff REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15056?vs=40362&id=40363 REVISION DETAIL https://phabricator.kde.org/D15056 AFFECTED FILES plugins/pathshap

D15056: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files

anthonyfieroni retitled this revision from "[EnhancedPathShape] Keep correct aspect ratio of odf files" to "[EnhancedPathShape] Keep correct aspect ratio of shapes in odf files". anthonyfieroni edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricato

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a comment. In D15053#314717 , @dcaliste wrote: > I cannot test easily on arm because karbon depends on KF5kdelibs4support, which is not available. I will investigate to remove it as depend. REPOSITORY R8 Calligra

D15056: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files

anthonyfieroni added a comment. Any objections to this? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15056 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

anthonyfieroni created this revision. anthonyfieroni added reviewers: boemann, danders, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY CCBUG: 312739 REPOSITORY R8 Calligra

D15111: [KoUnit] Let's show pixel units

anthonyfieroni updated this revision to Diff 40536. anthonyfieroni added a comment. Fix Tests as well. Notable change is that i made to always use round functions toXXX, do we need precision as offer qreal ? REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. That's purely abstract, i think to add DPI spinbox next to pixel setting. I'm not a designer, but it looks like they want to work on *real* pixels that should look on the target device, that's maybe DPI config will be relevant. REPOSITORY R8 Calligra REVISI

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. I agree with that, but in some situations like targeting embedded device with especially knowing resolution :) I really don't know what can they'll see in pixels, but defined resolution is possible case. REPOSITORY R8 Calligra REVISION DETAIL https://phab

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. Agree, maybe that's why it's vector graphics not nixes graphics. I really don't know what and how other vector graphics software offers these pixels :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15111 To: anthonyfieroni, boemann,

D15056: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files

This revision was automatically updated to reflect the committed changes. Closed by commit R8:da40d525d2c0: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15056?v

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. We'll rethink of being this option or i should discard as unwanted? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15111 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. @staniek did you want a DPI config spinbox? Can try this patch over master to approve it can be useful in Karbon? I keep in mind to make markers for SVG to have ability to save arrows, we have a bug report for that too. Maybe a little help will be needed :) R

D15111: [KoUnit] Let's show pixel units

anthonyfieroni updated this revision to Diff 41190. anthonyfieroni added a comment. Complete remove of hide pixel. This review can stay open till someone find out it as useful, then it can reviewed. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15111?

D15403: {Style] Default sheets to white background

anthonyfieroni created this revision. anthonyfieroni added reviewers: danders, boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY Other applications does not respect palette for backgr

D15403: {Style] Default sheets to white background

anthonyfieroni edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15403: {Style] Default sheets to white background

anthonyfieroni added a comment. It's inspired in forum discussion, it has predominately advice that other Calligra apps has a white background despite palette but sheets. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: C

D15412: [filters] Extend table lifetime

anthonyfieroni created this revision. anthonyfieroni added reviewers: danders, boemann, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY CCBUG: 379255 REPOSITORY R8 Calligra

D15412: [filters] Extend table lifetime

anthonyfieroni updated this revision to Diff 41377. anthonyfieroni edited the test plan for this revision. anthonyfieroni added a comment. Aggressive refactor, it makes m_table a shared pointer, presetTables is one time initialized. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https:

D15428: [textlayout] Don't enter infinite loop when table are misfit

anthonyfieroni created this revision. anthonyfieroni added reviewers: Calligra: 3.0, danders, boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY Also QTextLine can crash due to its val

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni retitled this revision from "[textlayout] Don't enter infinite loop when table are misfit" to "[textlayout] Don't enter infinite loop when table is misfit". REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders,

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni updated this revision to Diff 41418. anthonyfieroni added a comment. Initialize labelYOffset even layout line is not valid REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15428?vs=41409&id=41418 REVISION DETAIL https://phabricator.kde.org/D1

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added inline comments. INLINE COMMENTS > boemann wrote in KoTextLayoutTableArea.cpp:464 > nah this is too aggressive. > There are definitely cases where setting to 0 is the correct thing to do. > There might be some times we enter an infinite loop yes, but we need to catch > this

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. In D15428#324451 , @boemann wrote: > One reason why this might fail is if virginpage becomes false when we add the table headerrow (if we can fix this and that doesn't have other ill effect then I would prefer suc

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. It does not work, as you can see it overriding here https://phabricator.kde.org/source/calligra/browse/master/libs/textlayout/KoTextLayoutArea.cpp$571 so that's why i want to set it true before loop. REPOSITORY R8 Calligra REVISION DETAIL https://phabrica

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Something as if (d->headerRows) { cursor->row = 0; } REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15412: [filters] Extend table lifetime

anthonyfieroni added a comment. Ping on this, did you try it? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15412: [filters] Extend table lifetime

anthonyfieroni added a comment. It can be allocated only in read_tbl but as you can see in bug report, use-after-free is very common to happen. INLINE COMMENTS > staniek wrote in MsooXmlDrawingReaderTableMethods.h:40 > This is declaration-only header, so better no, otherwise allocation of a

D15412: [filters] Extend table lifetime

anthonyfieroni updated this revision to Diff 41552. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15412?vs=41377&id=41552 REVISION DETAIL https://phabricator.kde.org/D15412 AFFECTED FILES filters/libmsooxml/MsooXmlDrawingReaderTableImpl.h filters/libmso

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni updated this revision to Diff 41564. anthonyfieroni added a comment. Another try: Don't mark table as misfit when it does not have header rows REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15428?vs=41418&id=41564 REVISION DETAIL https://

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Any other ideas for special handling of headerRows == 0? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D12839: Get Calligra to compile with Qt 5.11

anthonyfieroni closed this revision. anthonyfieroni added a comment. It was merged. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D12839 To: nerdopolist, Calligra-Devel-list, #calligra:_3.0, staniek Cc: anthonyfieroni, #calligra:_3.0, dcaliste, cochise, vandenoever

D15403: {Style] Default sheets to white background

This revision was automatically updated to reflect the committed changes. Closed by commit R8:e5fc394f4a54: [Style] Default sheets to white background (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15403?vs=41338&id=41840 REVISION

D15412: [filters] Extend table lifetime

This revision was automatically updated to reflect the committed changes. Closed by commit R8:cb7ff65d2e7c: Extend table lifetime (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15412?vs=41552&id=41841 REVISION DETAIL https://pha

D15617: Move away from kdebug and kdelibs4 in filter/sheets

anthonyfieroni added a comment. This is old practice, please make a logging category -> https://doc.qt.io/qt-5/qloggingcategory.html REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15617 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel

D15775: Make the item background color and page cache properties available from View component

anthonyfieroni added a comment. Also can you add parentheses over single line code and if you know better way to get impl() without duplicate calls will be great :) INLINE COMMENTS > View.cpp:160 > canvas->setGeometry(0, 0, q->width(), q->height()); > + > static_cast(docume

D15053: Consistently use qreal in libs/pigment

anthonyfieroni added a subscriber: boemann. anthonyfieroni added a comment. I'm OK with it +1, @danders or @boemann should accept it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calli

D16127: Annotation: Block adding comment to an annotation shape

anthonyfieroni added inline comments. INLINE COMMENTS > TextTool.cpp:2036 > +} > +m_textShape = textShape; > +} If it has more than one shape that not satisfy above condition (2032) m_textShape will point to last one, not to first as current behavior. So maybe

D15428: [textlayout] Don't enter infinite loop when table is misfit

anthonyfieroni added a comment. Let's make some fix about that. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16127: Annotation: Block adding comment to an annotation shape

anthonyfieroni added a comment. Looks good to me +1 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH karbon_danders REVISION DETAIL https://phabricator.kde.org/D16289 To: danders, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

  1   2   >