anthonyfieroni added inline comments.
INLINE COMMENTS
> TextTool.cpp:2036
> + }
> + m_textShape = textShape;
> + }
If it has more than one shape that not satisfy above condition (2032)
m_textShape will point to last one, not to first as current behavior. So maybe
if (!m_textShape) {
m_textShape = textShape;
}
It will point to first when it does not have exactly match.
> TextTool.cpp:3121
> + // but just disabling the insert_annotation action somehow does not work.
> + if (m_textShape->shapeId() == AnnotationShape_SHAPEID) {
> + return;
Can m_textShape be a nullptr ?
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D16127
To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
