Re: Proposal: standardized (subdir) names for 3rdparty/generated code

On 6 March 2015 at 01:16, Friedrich W. H. Kossebau wrote: > Hi, > > so I spent quite some time scanning the sources, below is what I found as > TODO. > > So the idea still is: put 3rd-party code into a subdir "3rdparty" and put > generated and committed code into a subdir "generated", either loca

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-06 8:25 GMT+01:00 Dmitry Kazakov : > Hi! > > I looked through the patch and updated the google docs: > > https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit# > > The changes which I believe we must fix before applying it to master: > > 1) Inlined functions.

Re: Review Request 121541: Qt5/KF5-port assistance by product set system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121541/ --- (Updated March 6, 2015, 10:22 a.m.) Status -- This change has been m

Re: Review Request 122698: Kexi maps choosing Map Theme Id.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122698/#review77097 --- Minor things. But one isn't minor: I cannot spot the theme "th

Re: Does it ever load?

On Thu, 05 Mar 2015 22:41:32 +0100 "C. Boemann" wrote: > I got the document and it loaded in 3 seconds - > so don't really know what it was about > > > On Thursday 05 March 2015 22:29:48 matus uzak > wrote: > > Hey, anything special about the document? Or > > a deadlock in the layout engine?

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

Am Freitag, 6. März 2015, 08:07:07 schrieb Elvis Stansvik: > 2015-03-06 1:16 GMT+01:00 Friedrich W. H. Kossebau : > > Hi, > > > > so I spent quite some time scanning the sources, below is what I found as > > TODO. > > > > So the idea still is: put 3rd-party code into a subdir "3rdparty" and put >

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

Am Freitag, 6. März 2015, 07:50:34 schrieb C. Boemann: > > filters/words/msword-odf/wv2 > > from what I heard this can be considered a fork already. > > but for now I would still treat it as 3rdparty lib, > > until the further fate of this lib has been discussed > > -> filters/words/msword-odf/3rdp

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-06 20:05 GMT+01:00 Friedrich W. H. Kossebau : > Am Freitag, 6. März 2015, 08:07:07 schrieb Elvis Stansvik: > > 2015-03-06 1:16 GMT+01:00 Friedrich W. H. Kossebau : > > > Hi, > > > > > > so I spent quite some time scanning the sources, below is what I found > as > > > TODO. > > > > > > So t

Re: Review Request 122698: Kexi maps choosing Map Theme Id.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122698/ --- (Updated Mar 6, 2015, 9:22 po południu) Review request for Calligra, Andr

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122783/#review77123 --- How about adding some user documentation? - Adam Pigg On Ma

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122783/#review77124 --- libs/db/expression.cpp

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122783/#review77126 --- libs/db/expression.cpp

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

> On March 6, 2015, 9:25 p.m., Adam Pigg wrote: > > How about adding some user documentation? Planned at http://userbase.kde.org/Kexi/Handbook for all the functions. Our plan is serious as can be seen at https://community.kde.org/Kexi/Plugins/Queries/SQL_Functions. - Jarosław -

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

> On March 6, 2015, 9:28 p.m., Adam Pigg wrote: > > libs/db/expression.cpp, line 306 > > > > > > Is it ok to change strings for minor version? It's not, as I said in the above description: "For 2.9 the i18n() ch

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

> On March 6, 2015, 9:33 p.m., Adam Pigg wrote: > > libs/db/expression.cpp, line 1048 > > > > > > how about seperating this out into a seperate function, validateSubstr? > > by the time we implement more functi

Re: Review Request 122698: Kexi maps choosing Map Theme Id.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122698/#review77130 --- plugins/reporting/maps/KoReportItemMaps.cpp

Re: Review Request 122698: Kexi maps choosing Map Theme Id.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122698/#review77131 --- Ship it! After fixing on details please - ship to 2.9 - cher

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122783/#review77132 --- Ship it! Answers seem fine! - Adam Pigg On March 3, 2015,

Re: Review Request 122783: Kexi queries/parser: make SUBSTR(X, Y [, Z]) built-in SQL function work

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122783/ --- (Updated March 6, 2015, 9:22 p.m.) Status -- This change has been ma