----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122698/#review77097 -----------------------------------------------------------
Minor things. But one isn't minor: I cannot spot the theme "theme" property in the property editor: http://i.imgur.com/vXYvPyv.png. plugins/reporting/maps/KoReportDesignerItemMaps.cpp <https://git.reviewboard.kde.org/r/122698/#comment52978> BTW, please remove this, blurs the output plugins/reporting/maps/KoReportItemMaps.cpp <https://git.reviewboard.kde.org/r/122698/#comment52977> Can it be an empty list? If so, crash. plugins/reporting/maps/KoReportItemMaps.cpp <https://git.reviewboard.kde.org/r/122698/#comment52980> btw, remove plugins/reporting/maps/KoReportItemMaps.h <https://git.reviewboard.kde.org/r/122698/#comment52981> coding style - Jarosław Staniek On March 4, 2015, 11:44 p.m., Radosław Wicik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122698/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 11:44 p.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam > Pigg, Jarosław Staniek, Dimitrios Tanis, and Tomasz Olszak. > > > Repository: calligra > > > Description > ------- > > Kexi maps choosing Map Theme Id in reports. > > > Diffs > ----- > > plugins/reporting/maps/KoReportItemMaps.h > 62eb15db4ef89502a1edbba6ee49cf85dd6521e9 > plugins/reporting/maps/KoReportItemMaps.cpp > c29c0c51d17db8ce3f0c7e672e4d098e40a78f59 > plugins/reporting/maps/MapRenderer.cpp > 687179c7fe4b1ae70fc31ab0566eab33fe6f7630 > plugins/reporting/maps/KoReportDesignerItemMaps.cpp > d76b259720955304de9dd1f7819f9d2b0f630f2c > > Diff: https://git.reviewboard.kde.org/r/122698/diff/ > > > Testing > ------- > > Maunual testing > > > Thanks, > > Radosław Wicik > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
