Re: Review Request 108708: fix possibly broken rect size calculation in Krita blur filters

2013-02-03 Thread Boudewijn Rempt
> On Feb. 2, 2013, 9:44 p.m., Boudewijn Rempt wrote: > > Yeah... If msvc warns about it, but I do think it's silly :-). Anyway, I > > still need to test, but I'm sure it's fine, it doesn't alter what we meant > > with the code. > > Friedrich W. H. Kossebau wrote: > I was surprised as well,

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108725/#review26568 --- Ship it! Okay, I've now tested in words, stage and sheets with

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/ --- (Updated Feb. 3, 2013, 11:18 a.m.) Review request for Calligra. Changes

2.6.0 tag is set on...

2013-02-03 Thread Cyrille Berger Skott
97fec182466ace56fd7fb71fdb113b1f88271b8f http://quickgit.kde.org/?p=calligra.git&a=commit&h=97fec182466ace56fd7fb71fdb113b1f88271b8f -- Cyrille Berger Skott ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/ca

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26570 --- lots of if () without {} libs/basicflakes/tools/KoPencilTool

Re: Review Request 108709: in KisPlainColorSource equally distribute mix factor between values [0..255]

2013-02-03 Thread Cyrille Berger Skott
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108709/#review26572 --- Ship it! sounds fine to me - Cyrille Berger Skott On Feb. 3

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108725/#review26573 --- This review has been submitted with commit d59175f802b17379de9

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-03 Thread Sven Langkamp
> On Feb. 3, 2013, 10:20 a.m., C. Boemann wrote: > > Okay, I've now tested in words, stage and sheets with all the combinations > > I can think which might have problems with this. > > > > Not finding, and I like you solution as well, although the manual tweaks > > needed for modebox and krita

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-03 Thread C. Boemann
> On Feb. 3, 2013, 10:20 a.m., C. Boemann wrote: > > Okay, I've now tested in words, stage and sheets with all the combinations > > I can think which might have problems with this. > > > > Not finding, and I like you solution as well, although the manual tweaks > > needed for modebox and krita

Re: Review Request 108726: Fix width of Words statistics docker after opening a document

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108726/#review26577 --- This review has been submitted with commit dbac221139137a99c93

Re: Review Request 108587: Don't interpret selection by tablet as move

2013-02-03 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108587/#review26578 --- Has been a week since this was submitted. Any problems or can t

Re: Review Request 108587: Don't interpret selection by tablet as move

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108587/#review26579 --- Ship it! Ship It! - C. Boemann On Jan. 25, 2013, 11:42 p.m.

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26580 --- Ship it! Okay so with my last issues fixed in git, I think it'

Re: Review Request 108587: Don't interpret selection by tablet as move

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108587/#review26581 --- This review has been submitted with commit c678789df64ebea4a22

Re: Review Request 108708: fix possibly broken rect size calculation in Krita blur filters

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108708/#review26583 --- This review has been submitted with commit 64408ec4e912432f1da

Re: Review Request 108709: in KisPlainColorSource equally distribute mix factor between values [0..255]

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108709/#review26584 --- This review has been submitted with commit 780fe134176171a032b

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108569/#review26586 --- This review has been submitted with commit af0a52787676c8ff705

Re: 2.6.0 tag is set on...

2013-02-03 Thread Inge Wallin
On Sunday, February 03, 2013 12:32:36 Cyrille Berger Skott wrote: > 97fec182466ace56fd7fb71fdb113b1f88271b8f > > http://quickgit.kde.org/?p=calligra.git&a=commit&h=97fec182466ace56fd7fb71f > db113b1f88271b8f Could we please reset it to 5d8d95ae6dd29e1d03718e7b9579b78e80fdb78c? If not, Calligra A

Re: Review Request 108379: Fix merging style to caret

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108379/#review26593 --- This review has been submitted with commit 97c2d333435486f319d

Re: Review Request 108379: Fix merging style to caret

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108379/#review26594 --- This review has been submitted with commit f63718a89e24abad7a8

Re: Review Request 108532: Fix crash in krita master on style combo

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108532/#review26595 --- This review has been submitted with commit 980f34c7b2ed24496b1

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-03 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review26556 --- kexi/kexiutils/KexiPushButton.cpp

Re: Review Request 108096: Pimp KoReport section editor dialogs

2013-02-03 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108096/#review26596 --- Good work, please look at the minor issues (I am sorry for chan

Review Request 108767: Added icon only mode for the modebox

2013-02-03 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108767/ --- Review request for Calligra. Description --- Patch adds a new mode to

Re: Review Request 108767: Added icon only mode for the modebox

2013-02-03 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108767/ --- (Updated Feb. 3, 2013, 11:22 p.m.) Review request for Calligra. Changes

Re: Review Request 108767: Added icon only mode for the modebox

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108767/#review26597 --- Ship it! Looks very good - thanks a lot - C. Boemann On Feb

Re: Review Request 108767: Added icon only mode for the modebox

2013-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108767/#review26598 --- This review has been submitted with commit 91f265f2425eb60b523