-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108569/#review26586
-----------------------------------------------------------


This review has been submitted with commit 
af0a52787676c8ff7056693b012d36fcfa8cdb79 by C. Boemann to branch master.

- Commit Hook


On Feb. 3, 2013, 11:18 a.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108569/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 11:18 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch totally changes the design of the tools config widget use. This 
> new way of doing had been discussed with several people (boemann and a UI 
> designer worked 8 hours at the aKademy, and this part is one of the main 
> thing to do. The manipulation of shapes on pages and slides is way easier 
> now. The good widgets appear to you when you select a tool, and you know 
> directly have what you need and want to manipulate the shapes!
> 
> - If you select a tool, it will open the config widgets associated.
> - As you can see on the screenshots, all the tools needs their own widgets.
> - Stroke, Fill and Shadow config widgets are the main one.
> - A same config widget can be used with several tools.
> - Snap Settings had been removed from config widgets and added as a Docker -- 
> the opposite way that the StrokeDocker for instance.
> 
> 
> Diffs
> -----
> 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.h 
> 1c07423 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.h 7de7a14 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 4833d86 
>   karbon/ui/widgets/KarbonGradientEditWidget.cpp e0cb9ff 
>   krita/CMakeLists.txt 835f90d 
>   libs/basicflakes/CMakeLists.txt de004d7 
>   libs/basicflakes/tools/KoCreatePathTool.cpp 043ec2e 
>   libs/basicflakes/tools/KoPencilTool.h 85172bf 
>   libs/basicflakes/tools/KoPencilTool.cpp a56b988 
>   libs/flake/tools/KoPathTool.cpp 9dd8caf 
>   libs/main/KoModeBox.cpp 1c81fa2 
>   libs/textlayout/KoTextLayoutRootAreaProvider.cpp f21b5c4 
>   libs/widgets/CMakeLists.txt 61df2d6 
>   libs/widgets/KoColorPopupAction.h 87f6ae1 
>   libs/widgets/KoColorPopupAction.cpp d47634e 
>   libs/widgets/KoColorPopupButton.h PRE-CREATION 
>   libs/widgets/KoColorPopupButton.cpp PRE-CREATION 
>   libs/widgets/KoFillConfigWidget.h PRE-CREATION 
>   libs/widgets/KoFillConfigWidget.cpp PRE-CREATION 
>   libs/widgets/KoOpacityConfigWidget.h PRE-CREATION 
>   libs/widgets/KoOpacityConfigWidget.cpp PRE-CREATION 
>   libs/widgets/KoResourcePopupAction.h PRE-CREATION 
>   libs/widgets/KoResourcePopupAction.cpp PRE-CREATION 
>   libs/widgets/KoShadowConfigWidget.h 332e97a 
>   libs/widgets/KoShadowConfigWidget.cpp e9e9502 
>   libs/widgets/KoShadowConfigWidget.ui 4378813 
>   libs/widgets/KoStrokeConfigWidget.h 559c65f 
>   libs/widgets/KoStrokeConfigWidget.cpp d0a8eb9 
>   plugins/defaultTools/connectionTool/ConnectionTool.cpp eec40fc 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp db7c489 
>   plugins/dockers/CMakeLists.txt ddb4695 
>   plugins/dockers/Plugin.cpp 09394f9 
>   plugins/dockers/shadowdocker/ShadowDocker.h a26b2b4 
>   plugins/dockers/shadowdocker/ShadowDocker.cpp 010673d 
>   plugins/dockers/strokedocker/StrokeDocker.h 776a675 
>   plugins/dockers/strokedocker/StrokeDocker.cpp 991756e 
>   plugins/dockers/strokedocker/StrokeDockerFactory.h d8ef237 
>   plugins/dockers/strokedocker/StrokeDockerFactory.cpp d761851 
>   plugins/dockers/strokedocker/pics/CMakeLists.txt f3e737e 
>   plugins/dockers/strokedocker/pics/hi16-action-cap_butt.png 6c8dbad 
>   plugins/dockers/strokedocker/pics/hi16-action-cap_round.png 72423c0 
>   plugins/dockers/strokedocker/pics/hi16-action-cap_square.png e2204ae 
>   plugins/dockers/strokedocker/pics/hi16-action-join_bevel.png 8ddfb27 
>   plugins/dockers/strokedocker/pics/hi16-action-join_miter.png b6dfa00 
>   plugins/dockers/strokedocker/pics/hi16-action-join_round.png 756db8c 
>   plugins/dockers/styledocker/StrokeFillWidget.h b6b5b73 
> 
> Diff: http://git.reviewboard.kde.org/r/108569/diff/
> 
> 
> Testing
> -------
> 
> Tested in the flake-configwidgets-boemann branch, on words and stage, with 
> several documents, and different kind of shapes.
> 
> 
> File Attachments
> ----------------
> 
> Default Tools config widgets
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/DefaultTools.jpg
> New docker list
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/NewDockersList.jpg
> Freehand path drawing tool config widgets
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/PathDrawingTool.jpg
> Snap Settings Docker
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/23/SnapSettings.jpg
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to