Review Request: [GCI] Adding d-pointers to kexi/widget

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107673/ --- Review request for Calligra and Jarosław Staniek. Description --- Pat

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Jarosław Staniek
> On Dec. 10, 2012, 9 p.m., Jarosław Staniek wrote: > > kexi/formeditor/objecttree.cpp, line 149 > > > > > > change to const QString &set please fix this - Jarosław ---

Re: Review Request: [GCI] Adding d-pointers to kexi/main

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107648/#review23343 --- Thanks for the effort but please revert unused code removal fro

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 12, 2012, 8:37 a.m.) Review request for Calligra and Jarosła

Re: Calligra Spring Sprint

2012-12-12 Thread Mani N C
+1 Great Idea. On Wed, Dec 12, 2012 at 11:19 AM, sujith h wrote: > > > On Tue, Dec 11, 2012 at 11:20 PM, Shantanu Tushar Jha > wrote: > >> >> On Tue, Dec 11, 2012 at 10:39 PM, Inge Wallin wrote: >> >>> On Wednesday, December 05, 2012 18:35:59 Shantanu Tushar Jha wrote: >>> > Hi, >>> > >>> >

Proposed 2.6 Final Schedule

2012-12-12 Thread Cyrille Berger
Hi, Here is a proposal for a final schedule for 2.6: December 15th, RC2 tag December 19th, RC2 Release January 5th, 2.6.0 tag January 9th, 2.6.0 Release And 2.6.1 two weeks after. -- Cyrille Berger Skott ___ calligra-devel mailing list calligra-deve

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-12 Thread Jarosław Staniek
> On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/core/KexiView.h, line 165 > > > > > > Please use 'const QString &iconName' not fixed > On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/c

Re: Proposed 2.6 Final Schedule

2012-12-12 Thread Jaroslaw Staniek
On 12 December 2012 10:05, Cyrille Berger wrote: > Hi, > > Here is a proposal for a final schedule for 2.6: > > December 15th, RC2 tag > December 19th, RC2 Release Yes Sir, and how about per new habit not announcing RC on calligra.org but just on kde-announce? > January 5th, 2.6.0 tag > January

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 12, 2012, 9:56 a.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 12, 2012, 10:03 a.m.) Review request for Calligra and Jarosł

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107610/#review23348 --- kexi/widget/dataviewcommon/KexiTableViewColumn.cpp

Re: Review Request: [GCI] Adding d-pointers (part #1)

2012-12-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107610/#review23349 --- This review has been submitted with commit 900640e6df1f25583f5

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-12 Thread Jarosław Staniek
> On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/core/kexidataiteminterface.h, line 181 > > > > > > Never use meaningless names such as 'x'; > > > > x -> set not fixed > On Dec. 9, 2012, 8:

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review23351 --- kexi/core/kexidataiteminterface.h

Re: Review Request: [GCI] Adding d-pointers to kexi/widget

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107673/#review23353 --- Ship it! Good job. I'll commit it for you, when https://git.r

Re: Proposed 2.6 Final Schedule

2012-12-12 Thread Boudewijn Rempt
On Wednesday 12 December 2012 Dec, Cyrille Berger wrote: > Hi, > > Here is a proposal for a final schedule for 2.6: > > December 15th, RC2 tag > December 19th, RC2 Release > > January 5th, 2.6.0 tag > January 9th, 2.6.0 Release > > And 2.6.1 two weeks after. Fine with me -- that gives me part

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/ --- (Updated Dec. 12, 2012, 1:44 p.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers to kexi/main

2012-12-12 Thread Andrey Inishev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107648/ --- (Updated Dec. 12, 2012, 1:45 p.m.) Review request for Calligra and Jarosła

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review23355 --- Ship it! Thanks. I'll commit with other patches. - Jarosław S

Review Request: honor the suffix of the filename the user selected when exporting from odt to (x)html

2012-12-12 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107676/ --- Review request for Calligra, Inge Wallin and mojtaba shahi. Description --

Re: Review Request: honor the suffix of the filename the user selected when exporting from odt to (x)html

2012-12-12 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107676/#review23358 --- Ship it! Patch looks ok, and you can commit to both master and

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23359 --- kexi/formeditor/widgetwithsubpropertiesinterface.cpp

Re: Review Request: [GCI] Adding d-pointers to kexi/kexiutils

2012-12-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107649/#review23360 --- kexi/kexiutils/FlowLayout.cpp

Re: Calligra Spring Sprint

2012-12-12 Thread Thorsten Zachmann
Hello, > > What do you guys think? > > I think this is an excellent idea! > > But I have little chance of helping to organize that so I guess it's up to > somebody actually within India to do it. > > -Inge > > PS. I CC'ed claudia as well since she or the board would have to ack this. I

Re: Review Request: honor the suffix of the filename the user selected when exporting from odt to (x)html

2012-12-12 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107676/#review23368 --- Ship it! Ship It! - mojtaba shahi On Dec. 12, 2012, 2:49 p.

Re: Review Request: honor the suffix of the filename the user selected when exporting from odt to (x)html

2012-12-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107676/#review23370 --- This review has been submitted with commit 51a831034330c157da4

Re: Review Request: honor the suffix of the filename the user selected when exporting from odt to (x)html

2012-12-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107676/#review23371 --- This review has been submitted with commit c65038bbb791230c7ba

Re: PierreSt's style sorting code in 2.6?

2012-12-12 Thread Thorsten Zachmann
On Wednesday 12 December 2012 06:26:44 Burkhard Lück wrote: > Am Mittwoch, 12. Dezember 2012, 04:37:37 schrieb Thorsten Zachmann: > > Hello, > > > > On Sunday 09 December 2012 20:08:50 C. Boemann wrote: > > > Styles in use > > > > > > Standard > > > Head 1 > > > > > > --- > >

Re: Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

2012-12-12 Thread Thorsten Zachmann
> On Dec. 11, 2012, 10:35 p.m., C. Boemann wrote: > > plugins/defaultTools/createPathTool/KoCreatePathTool.cpp, line 373 > > > > > > To possible other reviewers. > > > > I said this was okay, we are going t