> On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/core/KexiView.h, line 165 > > <http://git.reviewboard.kde.org/r/107515/diff/5/?file=97495#file97495line165> > > > > Please use 'const QString &iconName'
not fixed > On Dec. 9, 2012, 8:56 p.m., Jarosław Staniek wrote: > > kexi/core/KexiView.cpp, line 703 > > <http://git.reviewboard.kde.org/r/107515/diff/5/?file=97496#file97496line703> > > > > Please use 'const QString &iconName' not fixed; Please carefully look at all issues and fix, ok? - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review23221 ----------------------------------------------------------- On Dec. 10, 2012, 9:46 a.m., Andrey Inishev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107515/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 9:46 a.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > Patch for kexi/core, > http://www.google-melange.com/gci/task/view/google/gci2012/8009216 > > > Diffs > ----- > > kexi/core/KexiView.h ae0376e > kexi/core/KexiView.cpp a59c904 > kexi/core/KexiWindow.cpp 9136fde > kexi/core/kexidataiteminterface.h 4258451 > kexi/core/kexidataiteminterface.cpp a5ad759 > kexi/core/kexiinternalpart.h 08178ed > kexi/core/kexiinternalpart.cpp 253e77d > kexi/core/kexipartmanager.h 9cb2356 > kexi/core/kexipartmanager.cpp cf17f3a > kexi/core/kexiprojectconnectiondata.h b88a1f9 > kexi/core/kexiprojectconnectiondata.cpp 0df2793 > kexi/core/kexistartupdata.h 2147465 > kexi/core/kexistartupdata.cpp 45fdd71 > kexi/core/kexitextmsghandler.h 29adc64 > kexi/core/kexitextmsghandler.cpp 71011c9 > > Diff: http://git.reviewboard.kde.org/r/107515/diff/ > > > Testing > ------- > > > Thanks, > > Andrey Inishev > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
