---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105654/#review16196
---
Ship it!
Ship It!
- Yue Liu
On July 22, 2012, 1:09 a.m., Fr
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105654/#review16202
---
This review has been submitted with commit
69f542cd6ac9749cb16
> On July 22, 2012, 4:41 a.m., Thorsten Zachmann wrote:
> > Looks good. Good work. Please commit.
> > Should we ask an aartist to come up with the icons?
> > If you continue to work on it I thing that widget is a bit to wide for my
> > taste. Not sure why that is.
Looking at the ui file a lit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105650/#review16204
---
This review has been submitted with commit
5c98d8f8d841718a70c
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105654/#review16205
---
This review has been submitted with commit
349162107dab6a8c58a
Hi Dag,
seems that in ReportDesignDialog the icon used should be always "window-new"
for the "Save To View" button, also in case of constructor
"ReportDesignDialog( ReportView *, QWidget *)", right?
Currently there it is "window" (which is non-existing).
So okay to commit attached patch and bac
Am Samstag, 7. Juli 2012, 15:08:50 schrieb Timothée Giet:
> Git commit e11539e16a15f968574eeb496c9fa63c803d5954 by Timothée Giet.
> Committed on 07/07/2012 at 15:05.
> Pushed by timotheegiet into branch 'master'.
>
> New templates for film workflow
>
> Added templates from Simon Legrand (dslr, fi
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105660/
---
Review request for Calligra and Boudewijn Rempt.
Description
---
Whil
Am Sonntag, 22. Juli 2012, 16:38:56 schrieb Timothée Giet:
> Thanks Friedrich for your feedback,
>
> Actually I already edited the icons before to commit, first to change
> resolution, then modified them so that at least they have a white/empty
> border (with original icons they were all stuck tog
Thanks Friedrich for your feedback,
Actually I already edited the icons before to commit, first to change
resolution, then modified them so that at least they have a white/empty
border (with original icons they were all stuck together, very bad…)
Now at least they are separated, but I see what you
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105669/
---
Review request for Calligra and Boudewijn Rempt.
Description
---
Ther
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105669/#review16207
---
if I may: isn't it better to actually add the file rather than
Am Sonntag, 22. Juli 2012, 17:50:48 schrieb Timothée Giet:
> Here are some screenshots showing the issue I'm talking about.
> (I could easily reproduce as, I don't know exactly why, it keeps showing
> those "1st version" icons on my main install…)
>
> As you can see at first I did use all the spac
> On July 22, 2012, 3:55 p.m., C. Boemann wrote:
> > if I may: isn't it better to actually add the file rather than reusing
> > another icon - mixing the semantic meaning.
> >
> > it can still be just a copy of that very icon
Yes, also a solution (but costs more in terms of storage on disk and
On Sunday 22 July 2012 17:50:48 Timothée Giet wrote:
> Here are some screenshots showing the issue I'm talking about.
> (I could easily reproduce as, I don't know exactly why, it keeps showing
> those "1st version" icons on my main install…)
because of icon cache
just remove it:
rm -rf /var/tmp/k
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105671/
---
Review request for Calligra and Jan Hambrecht.
Description
---
fix by
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105672/
---
Review request for Calligra and Cyrille Berger Skott.
Description
---
Am Dienstag, 10. Juli 2012, 12:04:32 schrieb Friedrich W. H. Kossebau:
> Hi Marijn,
>
> pushing for icon completeness, I found the music shape misses the following
> icons in the repository:
>
> music-clef-trebble
> plugins/musicshape/actions/SetClefAction.cpp:41
> music-clef
> plugin
Hi,
so after another review of the missing icons, where I managed to find
solutions for some (see e.g. today's small patch flood :) ), this email now
might have the final list of icons which are definitely missing for Calligra
(2.5 and surely also master).
Missing icons can be grouped into:
a)
On 22 July 2012 21:05, Friedrich W. H. Kossebau wrote:
> Hi,
>
> so after another review of the missing icons, where I managed to find
> solutions for some (see e.g. today's small patch flood :) ), this email now
> might have the final list of icons which are definitely missing for Calligra
> (2.5
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105671/#review16238
---
Ship it!
I am ok with backporting too.
- Jan Hambrecht
On J
> On July 22, 2012, 9:27 p.m., Jan Hambrecht wrote:
> > I am ok with backporting too.
Thanks, committed (and forgot to add REVIEW keyword, too late today already)
- Friedrich W. H.
---
This is an automatically generated e-mail. To reply
Søndag den 22. juli 2012 15:27:58 Friedrich W. H. Kossebau skrev:
> Hi Dag,
>
> seems that in ReportDesignDialog the icon used should be always "window-new"
> for the "Save To View" button, also in case of constructor
> "ReportDesignDialog( ReportView *, QWidget *)", right?
> Currently there it is
23 matches
Mail list logo
