> On July 22, 2012, 3:55 p.m., C. Boemann wrote: > > if I may: isn't it better to actually add the file rather than reusing > > another icon - mixing the semantic meaning. > > > > it can still be just a copy of that very icon
Yes, also a solution (but costs more in terms of storage on disk and at runtime :P ) At least a TODO/FIXME should be added to this patch, right. Let's see what the Krita people say :) - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105669/#review16207 ----------------------------------------------------------- On July 22, 2012, 3:48 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105669/ > ----------------------------------------------------------- > > (Updated July 22, 2012, 3:48 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > There is no "krita_paintop_icon" icon. > From the existing icons "krita_tool_freehand" might come closest, so > proposing to use that as substitute in this patch, arguing that the usual > preset icon/preview is also some sketched freehand lines, so this icon can > serve as a working symbol. > > Okay to backport to 2.5? > > > Diffs > ----- > > krita/ui/widgets/kis_paintop_presets_popup.cpp 38e5d8a > > Diff: http://git.reviewboard.kde.org/r/105669/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
