marked as submitted.
Review request for Calligra and Friedrich W. H. Kossebau.
Bugs: 321290
http://bugs.kde.org/show_bug.cgi?id=321290
Repository: calligra
Description
---
This is a split from the patch in review 111413 to apply specifically to 3rd
party lib kdgantt.
It fixes week
>
> Repository: calligra
>
>
> Description
> ---
>
> This is a split from the patch in review 111413 to apply specifically to 3rd
> party lib kdgantt.
>
> It fixes week numbering when using ISO week numbering method.
>
>
> Diffs
> -
>
>
/kdgantt/kdganttdatetimegrid.cpp also
as a separate patch file to 3rdparty/kdganttpatches/ in this commit.
See 3rdparty/kdganttpatches/README for the reason.
- Friedrich W. H. Kossebau
On Nov. 24, 2013, 6:23 p.m., Alvaro Soliverez wrote
http://bugs.kde.org/show_bug.cgi?id=321290
Repository: calligra
Description
---
This is a split from the patch in review 111413 to apply specifically to 3rd
party lib kdgantt.
It fixes week numbering when using ISO week numbering method.
Diffs
-
3rdparty/kdgantt/CMakeLists.txt
approve as far as i'm
concerned.
I have one little question/nitpick
3rdparty/kdgantt/CMakeLists.txt
<http://git.reviewboard.kde.org/r/108019/#comment18557>
uhm i don't get why we can't remove it already.
- C. Boemann
On Dec. 30, 2012, 5:21 a.
is an adaption of the same patch for 2.6.
This patch needs to be tested on Windows, which I hope stuart can do.
Diffs
-
3rdparty/kdgantt/CMakeLists.txt 4a75084
3rdparty/kdgantt/kdganttconstraintmodel.h bc1ed5c
3rdparty/kdgantt/kdganttview.cpp a09edf1
CMakeLists.txt 09d98be
Andersen.
Changes
---
Hmm, that didn't work. It removed it from my eye too...
Description
---
This patch moves the kdgantt library that was previously in the top directory
into a subdirectory called 3rdparty/. This was suggested in a discussion on IRC
as a way to keep 3rdparty li
pdated Nov. 21, 2012, 7:37 p.m.)
>
>
> Review request for Calligra and Dag Andersen.
>
>
> Description
> ---
>
> This patch moves the kdgantt library that was previously in the top directory
> into a subdirectory called 3rdparty/. This was suggested in
12, 9:23 a.m., Dag Andersen wrote:
> > > > > > Ship It!
> > > > >
> > > > > Dag Andersen wrote:
> > > > > One thing:
> > > > > The reason it was statically linked, is that there are other
> > > > >
12, 9:23 a.m., Dag Andersen wrote:
>> > > > > Ship It!
>> > > >
>> > > > Dag Andersen wrote:
>> > > > One thing:
>> > > > The reason it was statically linked, is that there are other
>> > > > variants
> > > >
> > > > Dag Andersen wrote:
> > > > One thing:
> > > > The reason it was statically linked, is that there are other
> > > > variants of kdgantt out there (like in korganizer). So to avoid
> > > >
; > > The reason it was statically linked, is that there are other variants
> > > of kdgantt out there (like in korganizer). So to avoid any potential
> > > clash I think the lib should be renamed e.g. calligrakdgantt.
> >
> > Fixed.
> >
> &g
On Thursday, November 22, 2012 19:20:08 Inge Wallin wrote:
> > On Nov. 22, 2012, 9:23 a.m., Dag Andersen wrote:
> > > Ship It!
> >
> > Dag Andersen wrote:
> > One thing:
> > The reason it was statically linked, is that there are other variant
> On Nov. 22, 2012, 9:23 a.m., Dag Andersen wrote:
> > Ship It!
>
> Dag Andersen wrote:
> One thing:
> The reason it was statically linked, is that there are other variants of
> kdgantt out there (like in korganizer).
> So to avoid any potential clas
> On Nov. 22, 2012, 9:23 a.m., Dag Andersen wrote:
> > Ship It!
One thing:
The reason it was statically linked, is that there are other variants of
kdgantt out there (like in korganizer).
So to avoid any potential clash I think the lib should be renamed e.g.
calligrakdgantt
v. 21, 2012, 7:37 p.m.)
>
>
> Review request for Calligra and Dag Andersen.
>
>
> Description
> ---
>
> This patch moves the kdgantt library that was previously in the top directory
> into a subdirectory called 3rdparty/. This was suggested in a discussion on
> I
<http://git.reviewboard.kde.org/r/107410/#comment17154>
Shouldn't here be added ${CMAKE_BINARY_DIR}/3rdparty/kdgantt too? Plan uses
it that way.
CMakeLists.txt
<http://git.reviewboard.kde.org/r/107410/#comment17156>
We have no plan->no kdgantt rule, now how about a
patch moves the kdgantt library that was previously in the top directory
into a subdirectory called 3rdparty/. This was suggested in a discussion on IRC
as a way to keep 3rdparty library sources collected in one place.
More importantly it also creates a real dynamically loaded library from it and
On Wednesday, 2012-11-14, Dag wrote:
> There are problems with kdgantt. There are modifications that has not been
> pushed back to KDAB (and they might not want to include all of them anyway,
> I suspect). My mails suddenly was not answered, probably the maintainer
> was put on so
ny
> > > KDAB
> > > developer still involved in Calligra, is there?
> >
> > No release, just downloading the tarball from kdab ftp and puting it on
> > KDE's ftp, as far as I understood, the problem with KDAB server is that
> > they require peope to login before
just downloading the tarball from kdab ftp and puting it on
> KDE's ftp, as far as I understood, the problem with KDAB server is that
> they require peope to login before downloading.
There are problems with kdgantt. There are modifications that has not been
pushed back to KDAB (and they might no
On 2012-11-14 10:11, Boudewijn Rempt wrote:
On Wed, 14 Nov 2012, Cyrille Berger wrote:
Unfortunately KDAB makes it very difficult to download them (maybe
we could host a mirror on a KDE server).
I wouldn't mind that, but it would be almost a fork, since we would
have to do releases. I'm wonder
On Wed, 14 Nov 2012, Cyrille Berger wrote:
On 2012-11-13 13:04, Boudewijn Rempt wrote:
It would be better to have calligra/3rdparty/kdchart and
calligra/3rdparty/kdchart, but not in calligra/libs.
Especially since libs/ is LGPL, while kdchart and kdgantt are not. And
ideally, we should stop
On 2012-11-13 13:04, Boudewijn Rempt wrote:
It would be better to have calligra/3rdparty/kdchart and
calligra/3rdparty/kdchart, but not in calligra/libs.
Especially since libs/ is LGPL, while kdchart and kdgantt are not. And
ideally, we should stop shipping them and use them as external
nge Wallin wrote:
>
>> While I was helping Stuart with some library work I noticed that kdgantt,
>> a
>> library to create Gantt charts, is located in / rather than /libs/ within
>> Calligra. Is there any specific reason for this?
>>
>> Shouldn't it be moved t
On Tue, 13 Nov 2012, Inge Wallin wrote:
While I was helping Stuart with some library work I noticed that kdgantt, a
library to create Gantt charts, is located in / rather than /libs/ within
Calligra. Is there any specific reason for this?
Shouldn't it be moved to libs/, perhaps together
While I was helping Stuart with some library work I noticed that kdgantt, a
library to create Gantt charts, is located in / rather than /libs/ within
Calligra. Is there any specific reason for this?
Shouldn't it be moved to libs/, perhaps together with kdchart which is now
located in pl
27 matches
Mail list logo
