----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114088/#review44337 -----------------------------------------------------------
Ship it! Looks good. But please add the diff against 3rdparty/kdgantt/kdganttdatetimegrid.cpp also as a separate patch file to 3rdparty/kdganttpatches/ in this commit. See 3rdparty/kdganttpatches/README for the reason. - Friedrich W. H. Kossebau On Nov. 24, 2013, 6:23 p.m., Alvaro Soliverez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114088/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2013, 6:23 p.m.) > > > Review request for Calligra and Friedrich W. H. Kossebau. > > > Bugs: 321290 > http://bugs.kde.org/show_bug.cgi?id=321290 > > > Repository: calligra > > > Description > ------- > > This is a split from the patch in review 111413 to apply specifically to 3rd > party lib kdgantt. > > It fixes week numbering when using ISO week numbering method. > > > Diffs > ----- > > 3rdparty/kdgantt/CMakeLists.txt 2108158 > 3rdparty/kdgantt/kdganttdatetimegrid.cpp 79c405c > > Diff: http://git.reviewboard.kde.org/r/114088/diff/ > > > Testing > ------- > > > Thanks, > > Alvaro Soliverez > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
