Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Thorsten Zachmann
On Friday, June 10, 2011 17:06:15 Jos van den Oever wrote: > On Friday, June 10, 2011 08:22:04 AM Jos van den Oever wrote: > > Here is an idea to improve code quality in Calligra. > > Here is a version that works fine with a small example use: > > #include "odf.h" > #include > #include > > int

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Thorsten Zachmann
On Friday, June 10, 2011 20:54:48 Jos van den Oever wrote: > On Friday, June 10, 2011 20:36:36 PM Pierre wrote: > > Also, another question about your proposal : would it be strict regarding > > the content types ? > > I mean : a positiveInteger attribute for a given node must remain a > > positiveI

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Thorsten Zachmann
On Friday, June 10, 2011 08:43:39 Jos van den Oever wrote: > On Friday, June 10, 2011 08:30:36 AM Pierre Stirnweiss wrote: > > I like the idea. > > On the headerWriter example you give, the end-element is written when the > > Writer gets out of scope. We'd need to verify that all our start/end > >

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Sebastian Sauer
Thorsten Zachmann wrote: > Hello, > > On Friday, June 10, 2011 08:22:04 Jos van den Oever wrote: >> Here is an idea to improve code quality in Calligra. >> >> Currently, we use KoXmlWriter to write ODF XML. For this, functions like >> startElement, endElement, addAttribute are used. >> >> By usi

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Jos van den Oever
On Friday, June 10, 2011 20:43:38 PM Pierre wrote: > BTW, what RNG parser do you use to generate this .h file ? > So far, we have a terrible one in a test case (yeah, I write ugly code > sometimes, sorry about that, but this one was gonnabe too complex > otherwise...) I wrote a Relax NG parser and

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Jos van den Oever
On Friday, June 10, 2011 20:36:36 PM Pierre wrote: > Also, another question about your proposal : would it be strict regarding > the content types ? > I mean : a positiveInteger attribute for a given node must remain a > positiveInteger, and that could even be checked at compilation time... Yes, th

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Pierre
On Friday 10 June 2011 20:28:55 Jos van den Oever wrote: > On Friday, June 10, 2011 20:24:08 PM Pierre wrote: > > On Friday 10 June 2011 12:49:18 Jos van den Oever wrote: > > > On Friday, June 10, 2011 08:22:04 AM Jos van den Oever wrote: > > > > Can you think of a reason why this would not work? >

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Pierre
On Friday 10 June 2011 08:56:06 Jos van den Oever wrote: > On Friday, June 10, 2011 08:43:58 AM Pierre wrote: > > That is a really interesting solution. The biggest trick would be not to > > forget to delete the objects at the right time if the endElement stays in > > the destructor. > > But I'm no

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Jos van den Oever
On Friday, June 10, 2011 20:24:08 PM Pierre wrote: > On Friday 10 June 2011 12:49:18 Jos van den Oever wrote: > > On Friday, June 10, 2011 08:22:04 AM Jos van den Oever wrote: > > > Can you think of a reason why this would not work? > > > > I can now. The circular nature of element nesting make is

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Pierre
On Friday 10 June 2011 12:49:18 Jos van den Oever wrote: > On Friday, June 10, 2011 08:22:04 AM Jos van den Oever wrote: > > Can you think of a reason why this would not work? > > I can now. The circular nature of element nesting make is harder to create > these classes. E.g. office:document can h

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Jos van den Oever
On Friday, June 10, 2011 08:22:04 AM Jos van den Oever wrote: > Here is an idea to improve code quality in Calligra. Here is a version that works fine with a small example use: #include "odf.h" #include #include int main() { QFile out; out.open(stdout, QIODevice::WriteOnly); KoXmlW

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-10 Thread Jos van den Oever
On Friday, June 10, 2011 08:22:04 AM Jos van den Oever wrote: > Can you think of a reason why this would not work? I can now. The circular nature of element nesting make is harder to create these classes. E.g. office:document can have (at some depth) a "office:image" which can have an "office:do

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
On Friday, June 10, 2011 08:43:58 AM Pierre wrote: > That is a really interesting solution. The biggest trick would be not to > forget to delete the objects at the right time if the endElement stays in > the destructor. > But I'm not sure how it would interact with the change tracking code, > unles

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
On Friday, June 10, 2011 08:42:46 AM Thorsten Zachmann wrote: > Hello, > > On Friday, June 10, 2011 08:22:04 Jos van den Oever wrote: > > Here is an idea to improve code quality in Calligra. > > > > Currently, we use KoXmlWriter to write ODF XML. For this, functions like > > startElement, endElem

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
On Friday, June 10, 2011 08:30:36 AM Pierre Stirnweiss wrote: > I like the idea. > On the headerWriter example you give, the end-element is written when the > Writer gets out of scope. We'd need to verify that all our start/end > element couples are within the same scope however. Yes, i did this o

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Thorsten Zachmann
Hello, On Friday, June 10, 2011 08:22:04 Jos van den Oever wrote: > Here is an idea to improve code quality in Calligra. > > Currently, we use KoXmlWriter to write ODF XML. For this, functions like > startElement, endElement, addAttribute are used. > > By using the Relax NG schema, we could gene

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Pierre
On Friday 10 June 2011 08:22:04 Jos van den Oever wrote: > Here is an idea to improve code quality in Calligra. > > Currently, we use KoXmlWriter to write ODF XML. For this, functions like > startElement, endElement, addAttribute are used. > > By using the Relax NG schema, we could generate a wra

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Pierre Stirnweiss
I like the idea. On the headerWriter example you give, the end-element is written when the Writer gets out of scope. We'd need to verify that all our start/end element couples are within the same scope however. Pierre On Fri, Jun 10, 2011 at 8:22 AM, Jos van den Oever < jos.van.den.oe...@kogmbh.

Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
Here is an idea to improve code quality in Calligra. Currently, we use KoXmlWriter to write ODF XML. For this, functions like startElement, endElement, addAttribute are used. By using the Relax NG schema, we could generate a wrapper around this class which would give us functions like TextPWr