Re: Review Request 125485: Unselect text when the text tool is deactivated.

2016-02-28 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/#review92851 --- I'd prefer if this doesn't go in In words at least it's on pu

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2016-02-28 Thread David Faure
> On Oct. 3, 2015, 10:02 a.m., Camilla Boemann wrote: > > ahh - well i still think the solution is wrong and i am in berlin for the > > qt world summit so no near my home computer, but will take a look when I > > get a chance Ping? This issue is still there. - David ---

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2015-10-03 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/#review86285 --- ahh - well i still think the solution is wrong and i am in ber

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2015-10-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/ --- (Updated Oct. 3, 2015, 9:56 a.m.) Review request for Calligra and Thorste

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2015-10-03 Thread David Faure
> On Oct. 3, 2015, 9:17 a.m., Camilla Boemann wrote: > > This change would go against a lot of special code that ensures the > > selection stays so I would not like this to go in - what i am not getting > > is why this is a problem - when the textshape is no longer selected the > > text is not

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2015-10-03 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/#review86281 --- This change would go against a lot of special code that ensure

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2015-10-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/#review86277 --- don't forget this one :) - David Faure On Oct. 2, 2015, 8:5

Review Request 125485: Unselect text when the text tool is deactivated.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra