Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- (Updated Nov. 22, 2014, 9:42 p.m.) Status -- This change has been ma

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review70026 --- Ship it! The changes on the kopageapp part and flake looks se

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Nov. 7, 2014, 12:13 p.m., Friedrich W. H. Kossebau wrote: > > Zagge and Boemann, your turn again :) At least I guess everyone is looking > > at you to give this a "Ship it", given it touches (and extends) mainly > > Words and Stage. Thorsten, I have no problem with words part - so if you

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69981 --- Zagge and Boemann, your turn again :) At least I guess everyon

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- (Updated Nov. 4, 2014, 3:51 p.m.) Review request for Calligra. Changes

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Nov. 4, 2014, 11:33 a.m., Friedrich W. H. Kossebau wrote: > > qtquick/CMakeLists.txt, line 3 > > > > > > Please add a comment why this is included and why CMAKE_INSTALL_LIBDIR > > is used, not LIB_INSTALL_DIR

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69795 --- qtquick/CMakeLists.txt

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- (Updated Nov. 3, 2014, 10:33 a.m.) Review request for Calligra. Changes

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Nov. 1, 2014, 8:28 p.m., Friedrich W. H. Kossebau wrote: > > And another round of mostly code-style nitpicks. > > > > From my little testing of the branch, there were not visible regressions, > > and Calligra Gemini at least for the Words part seemed usable. For the 2.9 > > release perhap

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69655 --- And another round of mostly code-style nitpicks. >From my lit

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- (Updated Nov. 1, 2014, 5:48 p.m.) Review request for Calligra. Changes

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Nov. 1, 2014, 2:30 p.m., Arjen Hiemstra wrote: > > Please do note that the QtQuick components here are a proof of concept and > > never really got much further than that. There are also Qt5 components > > which have a much better API and overall work much better. I intend to > > merge tho

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Nov. 1, 2014, 6:03 a.m., Thorsten Zachmann wrote: > > qtquick/CQCanvasControllerItem.cpp, line 210 > > > > > > Shouldn't it test that the maximum zoom is bigger then the minimum zoom? it should - and vice v

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69646 --- Please do note that the QtQuick components here are a proof of

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Oct. 29, 2014, 6:49 p.m., Friedrich W. H. Kossebau wrote: > > words/part/frames/KWCopyShape.cpp, line 170 > > > > > > Hm, I prefer the parameter names being written and marked with > > Q_UNUSED. Here both s

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Nov. 1, 2014, 6:03 a.m., Thorsten Zachmann wrote: > > libs/flake/KoCanvasController.h, line 141 > > > > > > Please move implementation to cpp file. I'd put it there to ensure it was explicit, but of course

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69629 --- libs/flake/KoCanvasController.h

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- (Updated Oct. 31, 2014, 11:36 a.m.) Review request for Calligra. Change

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Oct. 30, 2014, 7:45 p.m., Friedrich W. H. Kossebau wrote: > > CalligraProducts.cmake, line 136 > > > > > > Hm, PLUGIN_QTQUICK defined after being referenced before by APP_GEMINI > > is not supported (no laz

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Oct. 29, 2014, 6:49 p.m., Friedrich W. H. Kossebau wrote: > > qtquick/CQTextDocumentNotesModel.cpp, line 53 > > > > > > .insert(role, string) would be mini-opt here > > Dan Leinir Turthra Jensen wrote: >

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Oct. 29, 2014, 4:41 p.m., Camilla Boemann wrote: > > words/part/dockers/KWStatisticsWidget.cpp, line 295 > > > > > > a bit uneasy about this - but at least it's in gui this time > > Dan Leinir Turthra Jense

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69553 --- qtquick/CQImageProvider.cpp

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Okt. 29, 2014, 6:49 nachm., Friedrich W. H. Kossebau wrote: > > qtquick/CQTextDocumentNotesModel.cpp, line 53 > > > > > > .insert(role, string) would be mini-opt here > > Dan Leinir Turthra Jensen wrote: >

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69542 --- And another round of rather code-style level review. Given no

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- (Updated Oct. 30, 2014, 2:54 p.m.) Review request for Calligra. Changes

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Oct. 29, 2014, 4:41 p.m., Camilla Boemann wrote: > > words/part/dockers/KWStatisticsWidget.cpp, line 295 > > > > > > a bit uneasy about this - but at least it's in gui this time The reason for this is that

Re: Review Request 120890: Supporting changes for Calligra Gemini

> On Oct. 29, 2014, 6:49 p.m., Friedrich W. H. Kossebau wrote: > > qtquick/CQTextDocumentNotesModel.cpp, line 53 > > > > > > .insert(role, string) would be mini-opt here Is this a code style issue, is it done thi

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69471 --- Here some code nitpicks from some quick code browsing. In gene

Re: Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/#review69470 --- libs/textlayout/KoTextDocumentLayout.cpp

Review Request 120890: Supporting changes for Calligra Gemini

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120890/ --- Review request for Calligra. Repository: calligra Description ---