Re: Review Request 119579: In docx import filter handle outline level of paragraphs

> On Aug. 10, 2014, 10:18 vorm., Inge Wallin wrote: > > filters/words/docx/import/DocxXmlDocumentReader.cpp, line 3792 > > > > > > While this is correct (according to the comment, didn't read the spec), > > wou

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119579/ --- (Updated Aug. 10, 2014, 1:54 p.m.) Status -- This change has been ma

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119579/#review64146 --- Ship it! Looks good. I commented on a trivial readability is

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

> On Aug. 3, 2014, 6:50 vorm., Lassi Nieminen wrote: > > Looks good to me. > > > > Not sure what spec says but if spec allows paragraph style in the document > > file to define outlineLvl > > then potentially isHeading should check also the existence of the property > > from current m_currentP

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119579/ --- (Updated Aug. 3, 2014, 10:34 nachm.) Review request for Calligra, Inge Wa