Re: Review Request 109651: Refactor style manager

2013-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/#review29977 --- This review has been submitted with commit d91e0681b7d43eb3c91

Re: Review Request 109651: Refactor style manager

2013-03-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/ --- (Updated March 26, 2013, 5:40 p.m.) Status -- This change has been ma

Re: Review Request 109651: Refactor style manager

2013-03-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/#review29902 --- This review has been submitted with commit 4a46fc511efd200c113

Re: Review Request 109651: Refactor style manager

2013-03-26 Thread Pierre Stirnweiss
Sorry not to get back to you, I had to reinstall my box and am still not completely operational. As Thorsten said, we decided (on the phone) that his patch was a welcomed fix for a crash. What i am working on is way more intrusive. All I have left to do on my box is to set back my development envi

Re: Review Request 109651: Refactor style manager

2013-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/#review29841 --- Ship it! I have only a small issue. After that you are free to

Re: Review Request 109651: Refactor style manager

2013-03-24 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/ --- (Updated March 25, 2013, 5:28 a.m.) Review request for Calligra and Pierre

Re: Review Request 109651: Refactor style manager

2013-03-24 Thread Thorsten Zachmann
> On March 24, 2013, 12:12 p.m., Elvis Stansvik wrote: > > I've now tested the branch a bit. No crashes anymore, but I noticed two > > things: > > > > 1) Try this in the Style Manager: > > > > 1) Click "New" in the "Paragraph" tab. > >(A new paragraph style called "New Style" is cr

Re: Review Request 109651: Refactor style manager

2013-03-24 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/#review29793 --- I've now tested the branch a bit. No crashes anymore, but I not

Re: Review Request 109651: Refactor style manager

2013-03-23 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/ --- (Updated March 24, 2013, 6:35 a.m.) Review request for Calligra and Pierre

Re: Review Request 109651: Refactor style manager

2013-03-23 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/#review29753 --- Just a couple of small stuff. plugins/textshape/dialogs/Style

Review Request 109651: Refactor style manager

2013-03-21 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/ --- Review request for Calligra and Pierre Stirnweiss. Description --- Th