Re: Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-05 Thread Jarosław Staniek
> On Dec. 4, 2012, 9:48 p.m., Jarosław Staniek wrote: > > kexi/widget/kexicharencodingcombobox.cpp, line 120 > > > > > > Please always put implementation of Private right after declaration, in > > this case in line

Re: Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-05 Thread Shou Ya
> On Dec. 4, 2012, 9:48 p.m., Jarosław Staniek wrote: > > kexi/widget/kexicharencodingcombobox.cpp, line 120 > > > > > > Please always put implementation of Private right after declaration, in > > this case in line

Re: Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-04 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107578/#review22995 --- Ship it! Good work. Just one thing to fix, then I'll commit.

Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-04 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107578/ --- Review request for Calligra and Jarosław Staniek. Description --- Jus