Re: Review Request: Table of content for words

2011-01-28 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100421/#review1101 --- Ship it! If a heading has no text and no number, i Don't think

Re: Review Request: Table of content for words

2011-01-25 Thread Lukáš Tvrdý
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100421/ --- (Updated Jan. 25, 2011, 1:22 p.m.) Review request for Calligra, Thorsten Z

Re: Review Request: Table of content for words

2011-01-25 Thread Thorsten Zachmann
> On Jan. 24, 2011, 3:16 p.m., Thorsten Zachmann wrote: > > libs/kotext/KoTableOfContentsGeneratorInfo.cpp, line 132 > > > > > > can there be only one index-source-style? If so KoXml::namedItemNS can > > be used to g

Re: Review Request: Table of content for words

2011-01-25 Thread Lukáš Tvrdý
> On Jan. 24, 2011, 3:16 p.m., Thorsten Zachmann wrote: > > I have added some stuff I have seen while looking through the patch. I have > > not tested the patch. I'm going to fix all the issues I did not comment to.. Otherwise I objected somehow. Thank you for the review! > On Jan. 24, 2011,

Re: Review Request: Table of content for words

2011-01-24 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100421/#review1048 --- I have added some stuff I have seen while looking through the pa

Re: Review Request: Table of content for words

2011-01-24 Thread Lukáš Tvrdý
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100421/ --- (Updated Jan. 24, 2011, 1:44 p.m.) Review request for Calligra, Thorsten Z

Re: Review Request: Table of content for words

2011-01-18 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100421/#review979 --- The code looks really nice to me, especially the differences betw

Review Request: Table of content for words

2011-01-18 Thread Lukáš Tvrdý
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100421/ --- Review request for Calligra, Thorsten Zachmann and Casper Boemann. Summary