----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100421/#review979 -----------------------------------------------------------
The code looks really nice to me, especially the differences between ToC and ToC datas. You should maybe remove the useless end lines spaces. I haven't tested the code yet, only read it. Thank you for the work guys. - Jean-Nicolas On Jan. 18, 2011, 1:40 p.m., Lukáš Tvrdý wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100421/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2011, 1:40 p.m.) > > > Review request for Calligra, Thorsten Zachmann and Casper Boemann. > > > Summary > ------- > > This patch implements the loading of the part of the ODF that says how should > be the > table of content generated (table-of-content-source element with children). > > Full loading is done, generation of the links is solved, navigation of the > links works. > > There are still some TODO's marked in the code. > I think the development can continue in master as the solid ground is done. > > This bug was closed as invalid through the development of this feature: > https://bugs.kde.org/show_bug.cgi?id=260542 > > Work done by Pavol Korinek and Lukas Tvrdy. > > > Diffs > ----- > > libs/kotext/CMakeLists.txt 115966e > libs/kotext/KoTableOfContentsGeneratorInfo.h PRE-CREATION > libs/kotext/KoTableOfContentsGeneratorInfo.cpp PRE-CREATION > libs/kotext/KoText.h 6bfb176 > libs/kotext/opendocument/KoTextLoader.h 024d8b5 > libs/kotext/opendocument/KoTextLoader.cpp 6c0a4d7 > plugins/textshape/ToCGenerator.h 84747f1 > plugins/textshape/ToCGenerator.cpp 3aa6a10 > > Diff: http://git.reviewboard.kde.org/r/100421/diff > > > Testing > ------- > > > Thanks, > > Lukáš > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
