Re: Review Request: Refactor out the pseudo-private blocking property in KoPrintingDialog

2012-06-19 Thread Boudewijn Rempt
> On Dec. 23, 2011, 7:57 a.m., Thorsten Zachmann wrote: > > stage/part/KPrPdfPrintJob.cpp, line 41 > > > > > > A general question. Should the print job not always blocking to avoid > > in consistencies when doing pr

Re: Review Request: Refactor out the pseudo-private blocking property in KoPrintingDialog

2012-06-19 Thread Boudewijn Rempt
> On Dec. 23, 2011, 7:57 a.m., Thorsten Zachmann wrote: > > libs/main/KoMainWindow.cpp, line 1290 > > > > > > Does this not give problems as the parent might get deleted before the > > printPreviewJob is finsihed?

Re: Review Request: Refactor out the pseudo-private blocking property in KoPrintingDialog

2011-12-22 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103476/#review9191 --- libs/main/KoMainWindow.cpp

Review Request: Refactor out the pseudo-private blocking property in KoPrintingDialog

2011-12-19 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103476/ --- Review request for Calligra. Description --- Refactor out the pseudo-