----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103476/ -----------------------------------------------------------
Review request for Calligra. Description ------- Refactor out the pseudo-private blocking property in KoPrintingDialog This is done by implementing a new flag for KoPrintJobs, which will allow the user to decide whether to block the call, and whether or not to show the progress dialog, making the logic inside the startPrintJob function clearer. Diffs ----- krita/ui/kis_print_job.h 387d64b krita/ui/kis_print_job.cpp 4f33472 libs/kopageapp/KoPAPrintJob.h 057bb46 libs/kopageapp/KoPAPrintJob.cpp ba069c7 libs/main/KoMainWindow.h 499b186 libs/main/KoMainWindow.cpp e1c3217 libs/main/KoPrintJob.h bcbe894 libs/main/KoPrintJob.cpp ff51adb libs/main/KoPrintingDialog.h f486620 libs/main/KoPrintingDialog.cpp 3ed83bd plan/libs/ui/kptganttview.h 293d54a plan/libs/ui/kptganttview.cpp 720111b plan/libs/ui/kptviewbase.h d3dc51b plan/libs/ui/kptviewbase.cpp 95cda67 stage/part/KPrPdfPrintJob.h b53e272 stage/part/KPrPdfPrintJob.cpp 39bdaf9 tables/part/PrintJob.h 93ba0f1 tables/part/PrintJob.cpp 1c6e710 Diff: http://git.reviewboard.kde.org/r/103476/diff/diff Testing ------- - Tried to print preview (the original reason for the pseudo-private property) - Tried to print various documents to PDF - Tried using adapted version of calligraconverter (which will be uploaded separately) which optionally hides the progress dialog in batch mode (have no printer at my current location so could not test physical printing) Thanks, Dan Leinir Turthra Jensen
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
