Re: Review Request: Move plans odt export into libs/koreport.

2012-09-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review18369 --- This review has been submitted with commit 3adb5dd1b8962e6000d

Re: Review Request: Move plans odt export into libs/koreport.

2012-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review17385 --- This review has been submitted with commit 54fb21b448d977dac7c

Re: Review Request: Move plans odt export into libs/koreport.

2012-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review17382 --- This review has been submitted with commit e6446b1457fca77f83a

Re: Review Request: Move plans odt export into libs/koreport.

2012-08-07 Thread Adam Pigg
> On Aug. 7, 2012, 6:49 p.m., Adam Pigg wrote: > > Ship It! Once it is in koreport, i will port Kexi to use it - Adam --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review17066 -

Re: Review Request: Move plans odt export into libs/koreport.

2012-08-07 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review17066 --- Ship it! Ship It! - Adam Pigg On April 30, 2012, 4:31 p.m.,

Re: Review Request: Move plans odt export into libs/koreport.

2012-08-05 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review16884 --- Ship it! Ship It! - Jarosław Staniek On April 30, 2012, 4:3

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-16 Thread Dag Andersen
> On May 7, 2012, 8:50 p.m., Jarosław Staniek wrote: > > Dag, good work, we're closer to the final. Here's my proposal for naming. > > This is huge change I know but you can rename the classes using KDevelop or > > Creator quite easily. > > > > General concept: Calligra libs use static polymor

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-09 Thread Jarosław Staniek
> On May 7, 2012, 8:50 p.m., Jarosław Staniek wrote: > > Dag, good work, we're closer to the final. Here's my proposal for naming. > > This is huge change I know but you can rename the classes using KDevelop or > > Creator quite easily. > > > > General concept: Calligra libs use static polymor

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-09 Thread Adam Pigg
> On May 7, 2012, 8:50 p.m., Jarosław Staniek wrote: > > Dag, good work, we're closer to the final. Here's my proposal for naming. > > This is huge change I know but you can rename the classes using KDevelop or > > Creator quite easily. > > > > General concept: Calligra libs use static polymor

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-09 Thread Jarosław Staniek
> On May 7, 2012, 8:50 p.m., Jarosław Staniek wrote: > > Dag, good work, we're closer to the final. Here's my proposal for naming. > > This is huge change I know but you can rename the classes using KDevelop or > > Creator quite easily. > > > > General concept: Calligra libs use static polymor

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-08 Thread Dag Andersen
> On May 7, 2012, 8:50 p.m., Jarosław Staniek wrote: > > Dag, good work, we're closer to the final. Here's my proposal for naming. > > This is huge change I know but you can rename the classes using KDevelop or > > Creator quite easily. > > > > General concept: Calligra libs use static polymor

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-08 Thread Dag Andersen
> On May 7, 2012, 8:53 p.m., Adam Pigg wrote: > > libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp, line 108 > > > > > > Are there any objects in ODT that could be used as radio/check boxes > > instead of renderi

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review13561 --- libs/koreport/renderer/KoReportODTRenderer2.h

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review13562 --- Dag, good work, we're closer to the final. Here's my proposal f

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Dag Andersen
> On May 6, 2012, 9:10 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp, line 160 > > > > > > how about using kWarning()? there are more such cases... > > Dag Andersen wrote: >

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review13536 --- I am still looking for a meaningful name. Microsoftish KoReport

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Jarosław Staniek
> On May 6, 2012, 9:10 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp, line 160 > > > > > > how about using kWarning()? there are more such cases... > > Dag Andersen wrote: >

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Dag Andersen
> On May 6, 2012, 9:10 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp, line 60 > > > > > > Is't 0.0pt enough? > > Dag Andersen wrote: > I'm not sure, but: > This is the

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Dag Andersen
> On May 6, 2012, 9:10 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp, line 52 > > > > > > Let's keep such notes as @note in the header's doxygen comments for > > this method.

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread C. Boemann
> On May 6, 2012, 9:10 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp, line 60 > > > > > > Is't 0.0pt enough? > > Dag Andersen wrote: > I'm not sure, but: > This is the

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-07 Thread Dag Andersen
> On May 6, 2012, 9:10 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/KoReportRendererBase.cpp, line 64 > > > > > > Since it's a new code, I propose to get the habit of using > > QString::compare(..., ...,

Re: Review Request: Move plans odt export into libs/koreport.

2012-05-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review13520 --- libs/koreport/renderer/KoReportRendererBase.cpp

Review Request: Move plans odt export into libs/koreport.

2012-04-30 Thread Dag Andersen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/ --- Review request for Calligra, Jarosław Staniek and Adam Pigg. Description -