> On May 6, 2012, 9:10 p.m., Jarosław Staniek wrote: > > libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp, line 160 > > <http://git.reviewboard.kde.org/r/104797/diff/1/?file=59663#file59663line160> > > > > how about using kWarning()? there are more such cases... > > Dag Andersen wrote: > Removed the (useless) kDebug with Q_ASSERT. > (This situation should never happen...) > > AFAICS the other case(s) is not in this patch. > > Jarosław Staniek wrote: > I still suggest to use kWarnings everywhere. Q_ASSERT is for > implementation error, so not for this case. API design suggest that calling > function with any arguments should not cause to program failure.
Ok, fixed - Dag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104797/#review13520 ----------------------------------------------------------- On April 30, 2012, 4:31 p.m., Dag Andersen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104797/ > ----------------------------------------------------------- > > (Updated April 30, 2012, 4:31 p.m.) > > > Review request for Calligra, Jarosław Staniek and Adam Pigg. > > > Description > ------- > > Changes is in branch: report_odt_danders > > Move plans odt export into libs/koreport. > > Retains the current odt export in koreport (as odttables) and > adds the new as odtframes. > > Patch includes modifications to Plan to enable use of both formats. > > > Diffs > ----- > > libs/koreport/CMakeLists.txt d0737c9 > libs/koreport/renderer/KoReportODTRenderer2.h PRE-CREATION > libs/koreport/renderer/KoReportODTRenderer2.cpp PRE-CREATION > libs/koreport/renderer/KoReportRendererBase.cpp 497177d > libs/koreport/renderer/odt/KoSimpleOdtCheckBox.h PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtDocument.h PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtImage.h PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtImage.cpp PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtLine.h PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtLine.cpp PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtPicture.h PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtPicture.cpp PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtPrimitive.h PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtTextBox.h PRE-CREATION > libs/koreport/renderer/odt/KoSimpleOdtTextBox.cpp PRE-CREATION > libs/koreport/renderer/odt/ReportODTRenderer.h PRE-CREATION > plan/libs/ui/CMakeLists.txt 4948bd3 > plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.h 94123e2 > plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.cpp 9a94f5b > plan/libs/ui/reports/odt/KoSimpleOdtDocument.h 65bbbee > plan/libs/ui/reports/odt/KoSimpleOdtDocument.cpp 7d917ef > plan/libs/ui/reports/odt/KoSimpleOdtImage.h 3c40922 > plan/libs/ui/reports/odt/KoSimpleOdtImage.cpp 1061664 > plan/libs/ui/reports/odt/KoSimpleOdtLine.h 6ea097b > plan/libs/ui/reports/odt/KoSimpleOdtLine.cpp 2347117 > plan/libs/ui/reports/odt/KoSimpleOdtPicture.h 10c3b85 > plan/libs/ui/reports/odt/KoSimpleOdtPicture.cpp e0df27f > plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.h 7cff1c7 > plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.cpp ddea498 > plan/libs/ui/reports/odt/KoSimpleOdtTextBox.h 428dff7 > plan/libs/ui/reports/odt/KoSimpleOdtTextBox.cpp d775689 > plan/libs/ui/reports/odt/ReportODTRenderer.h 3c9f149 > plan/libs/ui/reports/odt/ReportODTRenderer.cpp 2c95ed2 > plan/libs/ui/reports/report.h 8cef5be > plan/libs/ui/reports/reportexportpanel.cpp 973078d > plan/libs/ui/reports/reportview.h 265080a > plan/libs/ui/reports/reportview.cpp dea21a6 > > Diff: http://git.reviewboard.kde.org/r/104797/diff/ > > > Testing > ------- > > Tested with Plan, resulting files opened with Words. > > > Thanks, > > Dag Andersen > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
