Re: Review Request: Move creation of print dialog to KoView

2012-06-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105225/#review14756 --- This review has been submitted with commit 1e08c220a1c15f6e1a1

Re: Review Request: Move creation of print dialog to KoView

2012-06-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105225/#review14715 --- Ship it! okay i don't hear anyone else object or have good cou

Re: Review Request: Move creation of print dialog to KoView

2012-06-12 Thread Dag Andersen
> On June 12, 2012, 10:14 a.m., C. Boemann wrote: > > Uhm how does this play in to the KoPrintDialog. > > > > I'm not trying to prevent your usecase, but on the other hand I don't think > > we should make our API even more complicated, than it unfortunately already > > is. so I just want to be

Re: Review Request: Move creation of print dialog to KoView

2012-06-12 Thread C. Boemann
> On June 12, 2012, 10:14 a.m., C. Boemann wrote: > > Uhm how does this play in to the KoPrintDialog. > > > > I'm not trying to prevent your usecase, but on the other hand I don't think > > we should make our API even more complicated, than it unfortunately already > > is. so I just want to be

Re: Review Request: Move creation of print dialog to KoView

2012-06-12 Thread Dag Andersen
> On June 12, 2012, 10:14 a.m., C. Boemann wrote: > > Uhm how does this play in to the KoPrintDialog. > > > > I'm not trying to prevent your usecase, but on the other hand I don't think > > we should make our API even more complicated, than it unfortunately already > > is. so I just want to be

Re: Review Request: Move creation of print dialog to KoView

2012-06-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105225/#review14647 --- Uhm how does this play in to the KoPrintDialog. I'm not trying

Review Request: Move creation of print dialog to KoView

2012-06-12 Thread Dag Andersen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105225/ --- Review request for Calligra. Description --- View centric apps (plan,